Commit graph

27221 commits

Author SHA1 Message Date
bors-servo
03450ee8e1 Auto merge of #17556 - jyc:inline-metrics-of-block, r=emilio
layout: Clean up inline_metrics_of_block a little.

Previously the variable names were a little confusing (ascent was used
for the space_above_baseline in one branch and the and ascent field in
another branch, and was not really the ascent in one). Also add a
small diagram.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because they just refactor existing code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17556)
<!-- Reviewable:end -->
2017-07-05 17:35:49 -07:00
bors-servo
dd11ee1257 Auto merge of #17613 - birtles:zero-length-lists, r=hiro
Handle zero length lists when interpolating

These are the Servo side changes for [Gecko bug 1377053](https://bugzilla.mozilla.org/show_bug.cgi?id=1377053).

These patches have been reviewed by @hiikezoe.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17613)
<!-- Reviewable:end -->
2017-07-05 16:47:36 -07:00
bors-servo
4f0f2fb13e Auto merge of #17587 - canaltinova:webkit-gradient, r=nox
Fix color stop sorting in -webkit-gradient

This was causing a reftest failure in gecko side(layout/reftests/webkit-gradient/webkit-gradient-linear-2.html). Basically, it was sorting exactly opposite if two color stops have the same percentage.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17587)
<!-- Reviewable:end -->
2017-07-05 15:46:01 -07:00
Brian Birtles
4b36f1e9c4 Use the value of the progress through the keyframe interval when falling back to 50% flip behavior 2017-07-06 06:38:57 +09:00
Brian Birtles
59a3142200 Handle zero-length lists in add_weighted 2017-07-06 06:38:17 +09:00
Jonathan Chan
7a7dfe44ed layout: Clean up inline_metrics_of_block a little.
Previously the variable names were a little confusing (ascent was used
for the space_above_baseline in one branch and the and ascent field in
another branch, and was not really the ascent in one). Also add a
small diagram.
2017-07-05 11:13:09 -07:00
bors-servo
296a215e54 Auto merge of #17603 - servo:derive-all-the-things, r=SimonSapin
Clean up vector_longhand a bit

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17603)
<!-- Reviewable:end -->
2017-07-05 07:33:13 -07:00
bors-servo
5baea7b732 Auto merge of #17605 - servo:maybereverse, r=nox
Replace remaining usage of deprecated Range::step_by

… which is being removed in rust-lang/rust#43012

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17605)
<!-- Reviewable:end -->
2017-07-05 06:08:29 -07:00
Simon Sapin
7e0254b530 Drive-by fix "unused import" warning. 2017-07-05 13:58:06 +02:00
Simon Sapin
86293c3b39 Replace remaining usage of deprecated Range::step_by
… which is being removed in https://github.com/rust-lang/rust/pull/43012
2017-07-05 13:54:40 +02:00
Anthony Ramine
4a2ede9b3a Kill delegate_animate from vector_longhand
The impl is now always generated if animation_value_type is ComputedValue.
2017-07-05 11:22:00 +02:00
Anthony Ramine
6c7c00f4c8 Kill gecko_only from vector_longhand 2017-07-05 11:21:59 +02:00
bors-servo
42e551f606 Auto merge of #17544 - dadaa:bug1371115, r=<try>
Support discrete animations for more Gecko things

<!-- Please describe your changes on the following line: -->
This PR fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1371115

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes. Add some tests into dom/animation/test/ of m-c in patch 14. Also, remove test fail annotation from meta in wpt as patch 15.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17544)
<!-- Reviewable:end -->
2017-07-04 22:16:46 -07:00
Daisuke Akatsuka
1b28d5e009 update auto generated files 2017-07-05 13:21:08 +09:00
Daisuke Akatsuka
d8dcc52c9a implements nsStyleImageRequest type properties animatable 2017-07-05 13:11:58 +09:00
Daisuke Akatsuka
d885747a18 implements nsStyleImage type properties animatable 2017-07-05 13:10:58 +09:00
Daisuke Akatsuka
4924a4832f implements URLValue type properties animatable 2017-07-05 13:08:12 +09:00
Daisuke Akatsuka
b3def4a84e implements u8 and array type properties animatable 2017-07-05 13:07:22 +09:00
Daisuke Akatsuka
0107b3e019 rename macro from impl_gecko_keyword_from_trait to impl_gecko_keyword_conversions 2017-07-05 13:07:21 +09:00
Daisuke Akatsuka
961bdee6a3 implements nsFont type properties animatable 2017-07-05 13:07:20 +09:00
Daisuke Akatsuka
699ec02e8b implements nsStyleBorder type properties animatable 2017-07-05 13:07:08 +09:00
Daisuke Akatsuka
0555977c66 implements nsStyleQuoteValues type properties animatable 2017-07-05 13:00:02 +09:00
Daisuke Akatsuka
7d1374e019 implements nsStyleTextOverflow type properties animatable 2017-07-05 12:59:12 +09:00
Daisuke Akatsuka
6316b7aeb8 implements nsStyleCounterData type properties animatable 2017-07-05 12:58:10 +09:00
Daisuke Akatsuka
a155a6341d implements nsStyleSides type properties animatable 2017-07-05 12:57:30 +09:00
Daisuke Akatsuka
34980689a7 implements nsStyleGridLine type properties animatable 2017-07-05 12:55:51 +09:00
Daisuke Akatsuka
983361eb0f implements nsStyleCoord type properties animatable 2017-07-05 12:54:45 +09:00
bors-servo
006037f798 Auto merge of #17602 - bholley:rule_tree_custom_gc, r=emilio
Use GC machinery rather than recursion for post-rule-tree-teardown node dropping

https://bugzilla.mozilla.org/show_bug.cgi?id=1378005
2017-07-04 13:44:52 -07:00
Bobby Holley
c742ed31da Use GC machinery rather than recursion for post-rule-tree-teardown node dropping.
MozReview-Commit-ID: BPC6u4sBNPR
2017-07-04 13:43:41 -07:00
bors-servo
c44b5993eb Auto merge of #17601 - ferjm:bug1370502.selector.matches.element, r=emilio
stylo: Implement ServoStyleRule::SelectorMatchesElement

from https://bugzilla.mozilla.org/show_bug.cgi?id=1370502

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17601)
<!-- Reviewable:end -->
2017-07-04 05:08:03 -07:00
Fernando Jiménez Moreno
fc8d0eeae0 stylo: Implement ServoStyleRule::SelectorMatchesElement 2017-07-04 13:13:48 +02:00
bors-servo
f380d1cfc1 Auto merge of #17600 - Manishearth:revert-cv, r=heycam
Revert "style: Cleanup duplicated code in the definition of ComputedValues."

This reverts commit 1c2fcb16ca.

We're completely redoing the ComputedValues stuff on the gecko side, this makes it easier to deal with

cc @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17600)
<!-- Reviewable:end -->
2017-07-03 22:50:42 -07:00
bors-servo
d52a08a5c5 Auto merge of #17568 - upsuper:user-select, r=Manishearth
Handle prefixed value of -moz-user-select properly

This is supposed to fix [bug 1374996](https://bugzilla.mozilla.org/show_bug.cgi?id=1374996).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17568)
<!-- Reviewable:end -->
2017-07-03 21:56:19 -07:00
Manish Goregaokar
6c94ace6e5 Revert "style: Cleanup duplicated code in the definition of ComputedValues."
This reverts commit 1c2fcb16ca.
2017-07-03 21:48:12 -07:00
bors-servo
b55b9dc78e Auto merge of #17548 - sadmansk:cef-update, r=paulrouget
Fix cef to follow new Browser::new() interface

Changes the call to `Browser::new()` in cef to contain the target_url.

cc @paulrouget
<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17273.

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17548)
<!-- Reviewable:end -->
2017-07-03 19:25:35 -07:00
bors-servo
fe666eb724 Auto merge of #17599 - asajeffrey:script-worklets-wpt-tests, r=jdm
Copied w3c css-paint-api wpt test suite into tests/wpt/mozilla

<!-- Please describe your changes on the following line: -->

As a stop-gap until #17416 lands, copy the css-paint-api wpt tests into the mozilla directory.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17599)
<!-- Reviewable:end -->
2017-07-03 18:11:31 -07:00
bors-servo
7a71035793 Auto merge of #17268 - servo:grid, r=wafflespeanut,canaltinova
Add support for subgrids and fix some other grid properties

This covers the `subgrid <line-name-lists>?` for `grid-template` (for gecko, and hence, stylo).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17268)
<!-- Reviewable:end -->
2017-07-03 17:10:25 -07:00
Nazım Can Altınova
3e49a8c80a Fix serialization of grid-template
If both columns and rows are 'none', shorthand should serialize it as 'none / none'
instead of just 'none'.
2017-07-03 17:08:14 -07:00
Nazım Can Altınova
ba6641de58 Fix parsing of 'subgrid' and 'none' keywords in grid-template 2017-07-03 17:08:12 -07:00
Nazım Can Altınova
f7aac8d225 Fix parsing logic of grid-template property
Fist line names are parsed on the top of the function already and it shouldn't be parsed again.
2017-07-03 17:08:11 -07:00
Nazım Can Altınova
8827cb1440 Fix 'grid' shorthand serialization 2017-07-03 17:08:09 -07:00
Nazım Can Altınova
af96e09c7f Fix parsing of grid-template shorthand
It should accept 'grid-template-rows / grid-template-columns values' values not
'grid-template-rows grid-template-columns values'.
2017-07-03 17:08:08 -07:00
Nazım Can Altınova
fd3b99027a Prevent parsing 'none' keyword in grid-template's columns part 2017-07-03 17:08:06 -07:00
Nazım Can Altınova
f4eccdae3f Fall back to an older version of the spec in TrackRepeat for the parity with gecko 2017-07-03 17:08:05 -07:00
Nazım Can Altınova
5eb33bac8f Fix the serialization of TrackRepeat
It was printing `repeat(n, <line-names>)` for number TrackRepeat.
But it should just print n times <line-names> instead.

MozReview-Commit-ID: FEmL8O2osVb
2017-07-03 17:08:02 -07:00
Ravi Shankar
9d9d99ec25 Switch to GridTemplateComponent for subgrid line names 2017-07-03 17:08:00 -07:00
Ravi Shankar
8af912200c Add support for subgrid line name lists 2017-07-03 14:57:17 -07:00
Alan Jeffrey
fc6c1bfc9d Copied w3c css-paint-api wpt test suite into tests/wpt/mozilla. 2017-07-03 16:43:47 -05:00
bors-servo
c17134ce48 Auto merge of #17593 - emilio:pseudo-replaced, r=heycam
stylo: properly handle ::before/::after rules applying to replaced elements

Bug: 1376352
Reviewed-By: heycam
MozReview-Commit-ID: FO0TyWsPPG7

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17593)
<!-- Reviewable:end -->
2017-07-03 04:04:44 -07:00
Emilio Cobos Álvarez
e2bf7d037a
stylo: properly handle ::before/::after rules applying to replaced elements.
Bug: 1376352
Reviewed-By: heycam
MozReview-Commit-ID: FO0TyWsPPG7
2017-07-03 13:03:24 +02:00