Commit graph

35259 commits

Author SHA1 Message Date
Pyfisch
0e4c4971be Use GradientBuilder::into_stops
Avoid cloning gradient stops.
2018-11-10 12:43:18 +01:00
bors-servo
b60006ae11
Auto merge of #22156 - jdm:wr-scroll, r=pcwalton
Add a transparent hit-testing rectangle for scrollable block content.

This implements the strategy described at https://github.com/servo/webrender/issues/3261#issuecomment-435106998 and which Gecko uses as well. Adding a transparent rectangle below the content and above the background ensures that hit testing correctly associates the background area with the right scrolling node.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22073
- [x] These changes do not require tests because the affected codepath requires user input, and we don't support webdriver tests yet.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22156)
<!-- Reviewable:end -->
2018-11-09 20:27:22 -05:00
bors-servo
fa56fec21b
Auto merge of #22150 - asajeffrey:magicleap-fix-ci-build, r=jdm
Fix the magicleap CI build

<!-- Please describe your changes on the following line: -->

This is a WIP PR to diagnose and fix the magicleap build in CI.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it's fixing the build

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22150)
<!-- Reviewable:end -->
2018-11-09 17:53:53 -05:00
Alan Jeffrey
08270f07fc Get the magicleap build to work in CI 2018-11-09 16:24:09 -06:00
bors-servo
ed0e6e1bb2
Auto merge of #22098 - Eijebong:uuidup, r=jdm
Update uuid

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22098)
<!-- Reviewable:end -->
2018-11-09 15:22:27 -05:00
Bastien Orivel
36c4208f22 Update uuid 2018-11-09 21:04:31 +01:00
Josh Matthews
1eee3c73eb Add a transparent hit-testing rectangle for scrollable block content. 2018-11-09 14:08:46 -05:00
bors-servo
9a41af68a4
Auto merge of #22155 - atouchet:tidy, r=jdm
Update servo-tidy.toml

<!-- Please describe your changes on the following line: -->
I forgot to add this in #22151.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22155)
<!-- Reviewable:end -->
2018-11-09 03:01:22 -05:00
bors-servo
290cee57e2
Auto merge of #22153 - servo-wpt-sync:wpt_update_08-11-2018, r=jdm
Sync WPT with upstream (08-11-2018)

Automated downstream sync of changes from upstream as of 08-11-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22153)
<!-- Reviewable:end -->
2018-11-09 01:55:53 -05:00
bors-servo
c0aa4ada60
Auto merge of #22095 - asajeffrey:magicleap-icon, r=jdm
Add icon for launching Magic Leap Servo

<!-- Please describe your changes on the following line: -->

Add an icon for launching Magic Leap Servo.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't test ML

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22095)
<!-- Reviewable:end -->
2018-11-09 00:37:59 -05:00
Alex Touchet
740c30aae8
Update servo-tidy.toml 2018-11-08 20:45:47 -08:00
WPT Sync Bot
463b6d3b60 Update web-platform-tests to revision d5be80a86d4f938250c075ac12414ad47516969c 2018-11-08 22:33:32 -05:00
bors-servo
d910273bc1
Auto merge of #22151 - atouchet:rayon-core, r=emilio
Update rayon-core

<!-- Please describe your changes on the following line: -->
Update rayon-core to get rid of a rand dependency.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22151)
<!-- Reviewable:end -->
2018-11-08 20:09:12 -05:00
Alex Touchet
929f17a36e
Update rayon-core 2018-11-08 15:50:38 -08:00
Jim Berlage
1f99bf4631 Fixes panic on DOMString::strip_leading_and_trailing_ascii_whitespace 2018-11-08 16:16:28 -06:00
bors-servo
bb2c5e387f
Auto merge of #22143 - emilio:gecko-sync, r=jdm
style: Sync changes from mozilla-central.

See each individual commit for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22143)
<!-- Reviewable:end -->
2018-11-08 16:17:09 -05:00
Emilio Cobos Álvarez
c96df0f810
Update test expectations. 2018-11-08 15:22:44 +01:00
Emilio Cobos Álvarez
8cb5b149eb
style: Some minor formatting nits. 2018-11-08 15:22:31 +01:00
Emilio Cobos Álvarez
2ea4af1171
Fix Servo build. 2018-11-08 15:22:30 +01:00
Emilio Cobos Álvarez
175e594652
style: Format recent patches. 2018-11-08 15:22:29 +01:00
Emilio Cobos Álvarez
efa54a876a
style: Fix code style of a recent commit. 2018-11-08 15:22:29 +01:00
Boris Chiou
23f2e99e99
style: Fix the default behavior of scale:<number>{1}.
The current spec says: "If only the X value is given, the Y value
defaults to the same value.", so we should update the behavior.

Besides, we also update the serialization, so we serialization both
specified and computed value by servo. We enable the preference
for all the css-transforms, so some of them are passed now.

Differential Revision: https://phabricator.services.mozilla.com/D10638
2018-11-08 15:22:28 +01:00
Emilio Cobos Álvarez
264a679c50
style: followup post-review nit. 2018-11-08 15:22:27 +01:00
Cameron McCormack
de5584c1f6
style: Store the Rust QuotePair slice as the computed quotes value in Gecko style structs.
Depends on D10651

Differential Revision: https://phabricator.services.mozilla.com/D10652
2018-11-08 15:22:26 +01:00
Cameron McCormack
acf7b65f36
style: Make quotes property representation allocate less.
Differential Revision: https://phabricator.services.mozilla.com/D10650
2018-11-08 15:22:26 +01:00
Cameron McCormack
56fd3b786f
style: Serialize background-size: auto auto as "auto".
With this change, all of Chrome, Edge, Firefox, and Safari serialize
background-size by omitting the second "auto" if the value is "auto
auto".  Other keywords are still repeated.

Differential Revision: https://phabricator.services.mozilla.com/D10446
2018-11-08 15:22:25 +01:00
Ting-Yu Lin
68f4ad9557
style: Remove preference "layout.css.shape-outside.enabled".
shape-outside, shape-margin, shape-image-threshold have been shipped in Firefox
62. We can remove the preference.

The change in devtools/shared/css/generated/properties-db.js is generated by
"./mach devtools-css-db"

The actual shape-image CORS mode tests in file_shape_outside_CORS.html are
moved into test_shape_outside_CORS.html because we don't need the <iframe>
trick to enable the feature.

Differential Revision: https://phabricator.services.mozilla.com/D10804
2018-11-08 15:22:24 +01:00
bors-servo
dd5e5e9294
Auto merge of #22144 - Eijebong:hyperfix, r=jdm
Fix downloading huge files (broken since hyperup)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22144)
<!-- Reviewable:end -->
2018-11-08 08:47:10 -05:00
bors-servo
0a11e10a0f
Auto merge of #22146 - servo-wpt-sync:wpt_update_07-11-2018, r=jdm
Sync WPT with upstream (07-11-2018)

Automated downstream sync of changes from upstream as of 07-11-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22146)
<!-- Reviewable:end -->
2018-11-08 07:22:18 -05:00
Bastien Orivel
85c6eff94a Use chunk.as_ref() instead of &chunk.into_bytes() 2018-11-08 12:37:50 +01:00
bors-servo
f220a63a0f
Auto merge of #22133 - servo:extern-crate, r=SimonSapin
Use 2018-edition idioms in crates that use that edition

The first commit is almost entirely mechanical, created by running `cargo fix --edition-idioms` and relevant crates. I undid the change of adding an anonymous lifetime parameter in types that have implicit lifetimes parameters, for example replacing `&mut Formatter` with `&mut Formatter<'_>`, because I don’t like it. The remaining changes are, in many places:

* Add `dyn` to trait object types, for example `Rc<gl::Gl>` to `Rc<dyn gl::Gl>`. This change also works in the 2015 edition.
* Remove `extern crate` where is it made unneeded by changes to the import/module system.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22133)
<!-- Reviewable:end -->
2018-11-08 05:11:11 -05:00
Simon Sapin
9f977c5287 Remove useless use crate_name; imports.
A `crate_name::foo` path always works in 2018
2018-11-08 09:29:52 +01:00
Simon Sapin
50c840fe42 Revert "Disable unused-extern-crates warnings for now"
This reverts commit 32462cd909a7c28d0d86664291bdcb0043c0bb45.
2018-11-08 09:28:00 +01:00
Simon Sapin
2012be4a8b cargo fix --edition-idioms 2018-11-08 09:28:00 +01:00
WPT Sync Bot
4443426308 Update web-platform-tests to revision cd44958a002b1ad494168e0290554644de84526e 2018-11-07 22:27:51 -05:00
bors-servo
b1fd6237d1
Auto merge of #22141 - pyfisch:add-note-fmt, r=SimonSapin
Hint ./mach fmt

Just thought that a note how to fix if rustfmt fails would be nice.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22141)
<!-- Reviewable:end -->
2018-11-07 20:57:56 -05:00
Bastien Orivel
dcbe7d36ae Continue decompressing chunks even after hyper is done downloading the body
If hyper reads compressed enough data, we were decompressing 32k by 32k
but we were throwing away the end of the body because we would end up
having lots of backed up data in the cursor when hyper was done.
2018-11-08 02:40:22 +01:00
Bastien Orivel
e30440c9cc Don't reset the buffers for each chunk we download
Sometimes hyper sends data that can't completely decompressed, resetting
the buffer means we're losing some data and thus breaking the body
2018-11-08 02:40:21 +01:00
bors-servo
44b75ed588
Auto merge of #22136 - pyfisch:fix-select-all, r=jdm
Correct select all

Fixes assertion failure.
Set selection direction forward on select all.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22136)
<!-- Reviewable:end -->
2018-11-07 19:40:18 -05:00
bors-servo
2ed23ce4c9
Auto merge of #22131 - servo-wpt-sync:wpt_update_06-11-2018, r=jdm
Sync WPT with upstream (06-11-2018)

Automated downstream sync of changes from upstream as of 06-11-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22131)
<!-- Reviewable:end -->
2018-11-07 17:25:34 -05:00
bors-servo
741bd8e739
Auto merge of #22087 - Eijebong:rust_serialize, r=jdm
Remove rustc-serialize from the dependencies

Closes #12410.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22087)
<!-- Reviewable:end -->
2018-11-07 16:07:38 -05:00
Pyfisch
694991ad7e Hint ./mach fmt 2018-11-07 20:32:22 +01:00
Pyfisch
7db13e93b7 Correct select all
Fixes assertion failure.
Set selection direction forward on select all.
2018-11-07 18:58:51 +01:00
bors-servo
b93d4b2ac6
Auto merge of #22129 - ferjm:media.task.source, r=Manishearth
HTMLMediaElement - use media element instead of dom manipulation task…

… source

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22129)
<!-- Reviewable:end -->
2018-11-07 12:16:58 -05:00
Bastien Orivel
221199d277 Remove rustc-serialize from the dependencies 2018-11-07 17:33:23 +01:00
bors-servo
9c7efd9151
Auto merge of #22127 - Darkspirit:https_intermittent_tracker, r=jdm
Connect to intermittent trackers via https

This is the last part of #22088.
Each https url returns the same with curl as its previous http variant, so it should be a safe change.
And https has already been used at this place in the past: 38474f8671

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22127)
<!-- Reviewable:end -->
2018-11-07 10:13:36 -05:00
bors-servo
da2d9b2228
Auto merge of #22126 - pyfisch:autoformat, r=jdm
Enforce rustfmt on CI

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22126)
<!-- Reviewable:end -->
2018-11-07 08:47:57 -05:00
Pyfisch
1855c88d61 Fix test-tidy self test
Install rustup on first Travis job.
Only use rustfmt::skip as an outer attribute.
2018-11-07 09:37:55 +01:00
bors-servo
618a790050
Auto merge of #22074 - jdm:wrup, r=nox
Update webrender.

Fixes #22114.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22074)
<!-- Reviewable:end -->
2018-11-07 00:40:42 -05:00
WPT Sync Bot
0aa76d7524 Update web-platform-tests to revision 615bb572c95add74ca4fb9fed4af5269a49cf4ef 2018-11-06 22:43:16 -05:00