Commit graph

35259 commits

Author SHA1 Message Date
bors-servo
62d726369f
Auto merge of #22125 - Darkspirit:https_dl_buildbot_timings, r=jdm
Download buildbot metadata via https

https://build.servo.org/json works.

https://www.hardenize.com/report/build.servo.org#www_tls
Likely ECDHE-RSA-AES128-GCM-SHA256 will be used by any modern client to download the file.

-----
https://docs.python.org/2/library/urllib.html
> For Python versions earlier than 2.7.9, urllib does not attempt to validate the server certificates of HTTPS URIs. Use at your own risk!

python3 is used to run the script: 535ea9674f/etc/ci/buildbot_steps.yml (L170)

-----
https://docs.python.org/3.1/howto/urllib2.html
> Currently urllib.request does not support fetching of https locations through a proxy. However, this can be enabled by extending urllib.request as shown in the recipe [7].

I don't think this will be downloaded through a proxy.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22125)
<!-- Reviewable:end -->
2018-11-06 20:26:28 -05:00
bors-servo
8667cb327d
Auto merge of #22123 - Darkspirit:https_taskcluster_windows, r=jdm
Ensuring https for Windows Taskcluster

This should be a safe change as there're already some https downloads on Windows Taskcluster. Examples:
* with `$client.DownloadFile()`: 78327fcba5/etc/taskcluster/windows/bootstrap.ps1 (L43)
* with `Expand-ZIPFile`: e217672c1a/etc/taskcluster/windows/bootstrap.ps1 (L40)

Modern TLS is supported:
https://www.hardenize.com/report/download.tuxfamily.org#www_tls
https://www.hardenize.com/report/nssm.cc#www_tls

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22123)
<!-- Reviewable:end -->
2018-11-06 19:13:20 -05:00
bors-servo
b628b6ef8e
Auto merge of #22119 - atouchet:ua, r=paulrouget
Update Firefox version in user agent string

<!-- Please describe your changes on the following line: -->
GitHub is again limiting functionality in Servo due to using an outdated Firefox version in the user agent string. Updating this should get rid of the warning.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22119)
<!-- Reviewable:end -->
2018-11-06 17:47:09 -05:00
Josh Matthews
1c5e4b3067 Update webrender to 790b76f1547453615262c3037e1fb04bda22fbc8. 2018-11-06 16:51:58 -05:00
Pyfisch
9e92eb205a Reorder imports 2018-11-06 22:35:07 +01:00
Pyfisch
4a947dd719 Remove import order check from test-tidy
Fix leaking file descriptor.
2018-11-06 22:30:31 +01:00
Pyfisch
095d446ccd Manually format remaining problems
Use line comments instead of block comments
as block comments contain trailing whitespace
after formatting with rustfmt.

Skip tests for malloc_size_of and script_plugins
with rustfmt as they have many block comments.
2018-11-06 22:30:31 +01:00
Pyfisch
cb07debcb6 Format remaining files 2018-11-06 22:30:31 +01:00
Pyfisch
bf47f90da6 Run rustfmt on test-tidy
Add ./mach fmt command.
Mach installs rustfmt if needed.
2018-11-06 22:28:29 +01:00
Fernando Jiménez Moreno
ebe6c3fac3 HTMLMediaElement - use media element instead of dom manipulation task source 2018-11-06 20:15:14 +01:00
bors-servo
6878dbbbea
Auto merge of #22086 - servo:2018-without-stylo, r=SimonSapin
Switch some crates to the 2018 edition

This is the subset of https://github.com/servo/servo/pull/22083 that doesn’t affect Gecko at all, so it isn’t blocked.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22086)
<!-- Reviewable:end -->
2018-11-06 13:38:52 -05:00
bors-servo
8df38f5e29
Auto merge of #22122 - Darkspirit:httpsdeps, r=jdm
Consistent servo-deps download URL

This PR ensures consistent https:// downloads for Servo dependencies.

It should be fine because
* https://servo-deps.s3.amazonaws.com is already used for MSVC deps:
e217672c1a/python/servo/bootstrap.py (L286)

* .travis.yml already downloads from [another https url](e217672c1a/.travis.yml (L28)) (https://sh.rustup.rs).
* In #22088 I saw the gstreamer dependency being download via https.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22122)
<!-- Reviewable:end -->
2018-11-06 11:30:26 -05:00
Jan Andre Ikenmeyer
860422d1dc
Optional Windows Taskcluster dependency should be able to use TLS 1.2 2018-11-06 17:29:43 +01:00
Jan Andre Ikenmeyer
d1b5ece9aa
Connect to intermittent trackers via https 2018-11-06 17:02:41 +01:00
Keith Yeung
8757cf5bc0 Use question mark operator instead of try macro with a raw identifier
Co-Authored-By: SimonSapin <simon.sapin@exyr.org>
2018-11-06 16:12:04 +01:00
Simon Sapin
99cd7ba3d4 Disable unused-extern-crates warnings for now
There are *many* new ones in rust 2018!
2018-11-06 16:12:04 +01:00
Simon Sapin
9f9bf8f6bc Switch most crates to the 2018 edition 2018-11-06 16:12:04 +01:00
Simon Sapin
76e59a46d3 Sort use statements 2018-11-06 15:26:02 +01:00
Simon Sapin
45f7199eee cargo fix --edition 2018-11-06 15:26:02 +01:00
Simon Sapin
86f148fb97 Use 2018-style paths in code generated by proc-macro derives 2018-11-06 15:26:02 +01:00
Simon Sapin
acabd50f03 Use 2018-style paths in generated DOM bindings 2018-11-06 15:14:17 +01:00
Simon Sapin
86f0431f16 Rename mozjs to js in script through Cargo rather than extern crate 2018-11-06 15:14:17 +01:00
Jan Andre Ikenmeyer
0ac730a38d
Download buildbot metadata via https 2018-11-06 14:27:05 +01:00
bors-servo
32d97d695e
Auto merge of #22120 - Darkspirit:httpsdocs, r=jdm
Replace http with https in docs

This PR only changes markdown files and one Rust comment.
Background: [bug 1482947](https://bugzilla.mozilla.org/show_bug.cgi?id=1482947) enabled HSTS for servo.org and its subdomains.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22120)
<!-- Reviewable:end -->
2018-11-06 08:13:04 -05:00
Jan Andre Ikenmeyer
82bd1e51c7
Ensuring https for Windows Taskcluster 2018-11-06 13:00:47 +01:00
Jan Andre Ikenmeyer
357f23fae1
Consistent servo-deps download URLs 2018-11-06 12:20:10 +01:00
Jan Andre Ikenmeyer
1097d3fe00
Replace http with https in docs 2018-11-06 11:39:09 +01:00
bors-servo
535ea9674f
Auto merge of #22117 - asajeffrey:magicleap-ci, r=jdm
Add magicleap builder

<!-- Please describe your changes on the following line: -->

Add a magicleap builder to `etc/ci/buildbot_steps.yml` to gate releases on building the magicleap library. This doesn't yet check for building the magicleap app, or add a nightly release. That'll be a later PR.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's adding a build test

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22117)
<!-- Reviewable:end -->
2018-11-06 04:01:34 -05:00
bors-servo
e217672c1a
Auto merge of #22092 - paulrouget:thread_count, r=manishearth
Count threads at shutdown, warn if not all finished and optionally block

On Desktop, after servo shutdown, the process exits, killing all the still-running threads.
On mobile, the process doesn't necessarily shutdown, and we are left with multiple threads failing to use channels, printing warning and panicking.

In the future, we'd like to do a clean shutdown, as in, shutdown only once all the threads have properly finished.

For now, I'm printing a warning if all the threads are not finished, and also add an option to only exit if all the threads have finished.

This only works on MacOS for now, in C, as I haven't found a Rust/multiplatform way to count running threads.

I recommend trying to run servo with `--clean-shutdown` option. Interesting to see how long it takes for other threads to shutdown, and see which threads start panicking.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22092)
<!-- Reviewable:end -->
2018-11-06 02:26:39 -05:00
Paul Rouget
2718675191 Count threads at shutdown and warn if not all finished 2018-11-06 07:50:04 +01:00
Alex Touchet
b145f0c547
Bump Firefox version in user agent string 2018-11-05 22:15:42 -08:00
bors-servo
e265fcfc3c
Auto merge of #22094 - asajeffrey:magicleap-shutdown, r=paulrouget
Shut down Servo when the ML app quits

<!-- Please describe your changes on the following line: -->

Shut down servo when shutting down the magic leap app.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't test ML

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22094)
<!-- Reviewable:end -->
2018-11-06 01:08:07 -05:00
bors-servo
7a3daac613
Auto merge of #22112 - servo:webgl, r=jdm
Implement WEBGL_color_buffer_float and EXT_color_buffer_half_float

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22112)
<!-- Reviewable:end -->
2018-11-06 00:04:43 -05:00
bors-servo
c86b183d5d
Auto merge of #22103 - Eijebong:formdata, r=jdm
Use a BTreeMap to store formdata

I'm really unsure about the MallocSizeOf of BTreeMap as I took the same
code as for HashMap.

Fixes #13105
Fixes #21381

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22103)
<!-- Reviewable:end -->
2018-11-05 22:50:40 -05:00
bors-servo
58b9969b09
Auto merge of #22116 - jdm:gleamup, r=nox
Update gleam.

This allows running the three.js examples on Pixel 1 devices.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22082
- [x] These changes do not require tests because no real android test coverage.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22116)
<!-- Reviewable:end -->
2018-11-05 21:03:14 -05:00
bors-servo
b00ee41ac1
Auto merge of #22099 - pyfisch:net-fmt, r=jdm
Format net and net_traits crates

Manually formatted the fetch_scheme file portion to limit right drift.

Part of #21373

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22099)
<!-- Reviewable:end -->
2018-11-05 16:03:58 -05:00
Alan Jeffrey
e57859fe49 Add magicleap builder 2018-11-05 12:48:17 -06:00
bors-servo
ddc85098af
Auto merge of #22051 - mandreyel:track-focused-bc-of-each-tlbc, r=cbrewster
Update Constellation to track each browser's focused browsing context

Since there may be multiple browsers (top-level browsing contexts), each has a focused browsing context. However, we were not keeping track of each browser's focused browsing context, so e.g when switching tabs the `Constellation::focused_browsing_context_id` would not be set to the switched-to browser's focused browsing context.

This PR introduces a `browser_ids` `HashMap` in constellation, that maps each of the top-level browsing context's ids to their currently focused browsing context's id, so that when the active browser is changed with the `SelectBrowser` message, we can look up and restore the selected browser's focused browsing context.

This is a wip. For one, I'm not a fan of adding another hash map to constellation, and since there already is a hash map for keeping track of a browser's joint session history, we could introduce some `Browser` struct to hold data for a browser like its session history and focused browsing context (and possibly more later). But wanted to implement the bare-bones logic to first ensure correctness and will refactor later. Also, we may need new tests but I'm not sure.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #17401 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22051)
<!-- Reviewable:end -->
2018-11-05 13:23:30 -05:00
Josh Matthews
cd9495fd19 Update gleam. 2018-11-05 11:29:39 -05:00
Alan Jeffrey
6088ade746 Argh tabs vs spaces 2018-11-05 10:00:08 -06:00
Alan Jeffrey
747122fb63 Responding to review comments 2018-11-05 09:57:26 -06:00
bors-servo
5e52992c6b
Auto merge of #22097 - fabrizio8:unused_scroll, r=emilio
Unused scroll

Combined on_scroll_window_event with on_scroll_start_window_event and on_scroll_end_window_event

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22075  (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes:
- Ran unit-test, test-tidy with no errors,  and tested scrolling on webpages
- [ ] These changes do not require tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22097)
<!-- Reviewable:end -->
2018-11-05 10:47:50 -05:00
bors-servo
8205575488
Auto merge of #21864 - ferjm:android.gst.binaries.update, r=SimonSapin
Update GStreamer binaries for Android. Include required codecs

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

This should finally work for both armv7 and x86. I moved the binaries from Github to S3.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21864)
<!-- Reviewable:end -->
2018-11-05 09:11:15 -05:00
Josh Matthews
e31462c37c Implement WEBGL_color_buffer_float and EXT_color_buffer_half_float (fixes #22113) 2018-11-05 14:13:46 +01:00
bors-servo
ff7c6953c8
Auto merge of #22111 - emilio:gecko-sync, r=emilio
style: Sync changes from mozilla-central.

See each individual commit for details.

https://bugzilla.mozilla.org/show_bug.cgi?id=1504644

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22111)
<!-- Reviewable:end -->
2018-11-05 06:46:56 -05:00
Emilio Cobos Álvarez
ac6f921588
style: Fix servo build. 2018-11-05 12:44:54 +01:00
Emilio Cobos Álvarez
64e70e28fc
style: Add the safe area constant names as atoms. 2018-11-05 12:36:14 +01:00
Emilio Cobos Álvarez
8560c8dd5a
Fix tidy issues. 2018-11-05 12:33:39 +01:00
Emilio Cobos Álvarez
29f56919e2
Update remaining references to cssparser 0.24. 2018-11-05 12:33:37 +01:00
Emilio Cobos Álvarez
99f9d84555
style: Simplify invalid custom property handling.
It's a bit useless to keep a set of invalid properties if we're going
to use them just to reject lookups into another key. This makes it more
consistent with the cascade / no-references code, and should not change
behavior.

Differential Revision: https://phabricator.services.mozilla.com/D9632
2018-11-05 12:33:28 +01:00