Commit graph

15724 commits

Author SHA1 Message Date
bors-servo
09e987b559 Auto merge of #9661 - jdm:devtools-inspector-get-layout, r=pcwalton
Completed implementation of devtools' `getLayout`.

Rebase of #7267. Fixes #3598.

This avoids all of the sketchy issues of trying to read the style data for margins from the script thread. I replaced it with a layout query that fetches the margin style properties for a given element.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9661)
<!-- Reviewable:end -->
2016-02-25 00:22:43 +05:30
benshu
0785d91ae4 Completed implementation of devtools' getLayout. 2016-02-24 13:51:47 -05:00
bors-servo
3212d3a91e Auto merge of #9731 - paulrouget:mozbrowserRootPipelineOnly, r=jdm
allow mozbrowser only for top level windows

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9731)
<!-- Reviewable:end -->
2016-02-24 22:18:19 +05:30
bors-servo
9ab2da3cd1 Auto merge of #9741 - larsbergstrom:update_webrender, r=nox
Pick up new webrender for doc build fixes

Fixes #9704

r? @nox

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9741)
<!-- Reviewable:end -->
2016-02-24 21:07:04 +05:30
Lars Bergstrom
1423fb5a63 Pick up new webrender for doc build fixes 2016-02-24 09:32:52 -06:00
bors-servo
438b3a444b Auto merge of #9722 - mbrubeck:slow-selector, r=nox
Dirty elements whose selectors are affected by sibling changes

This fixes incremental layout of nodes that match pseudo-class selectors such as :first-child, :nth-child, :last-child, :first-of-type, etc.  Fixes #8191 and other intermittent layout bugs.

This code is based on the following flags from Gecko:
https://hg.mozilla.org/mozilla-central/file/e1cf617a1f28/dom/base/nsINode.h#l134

Depends on servo/rust-selectors#71. r? @SimonSapin

There are a couple of TODO items in this commit, but I'd appreciate feedback on the general approach before I finish it up.  (Also, if someone who knows more than I do could give some advice about atomic orderings...)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9722)
<!-- Reviewable:end -->
2016-02-24 18:55:39 +05:30
bors-servo
7d25243af1 Auto merge of #9739 - saurvs:master, r=nox
Inline functions HTMLCollection::get_length and get_item

Fixes https://github.com/servo/servo/issues/9726

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9739)
<!-- Reviewable:end -->
2016-02-24 18:01:29 +05:30
Saurav Sachidanand
52059740e3 Inline functions HTMLCollection::get_length and get_item 2016-02-24 17:41:07 +05:30
bors-servo
2fcf1a2179 Auto merge of #9738 - servo:wpt-20160224, r=Ms2ger
Update web-platform-tests to revision 7ed49cff4d031720f829c01df837ed7a09ad5c60

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9738)
<!-- Reviewable:end -->
2016-02-24 15:35:00 +05:30
Ms2ger
62a9bebeef Update web-platform-tests to revision 7ed49cff4d031720f829c01df837ed7a09ad5c60 2016-02-24 11:04:43 +01:00
Matt Brubeck
973918967f Dirty elements whose selectors are affected by sibling changes
This fixes incremental layout of nodes that match pseudo-class selectors such
as :first-child, :nth-child, :last-child, :first-of-type, etc.

* Fixes #8191
* Fixes #9063
* Fixes #9303
* Fixes #9448

This code is based on the following flags from Gecko:
https://hg.mozilla.org/mozilla-central/file/e1cf617a1f28/dom/base/nsINode.h#l134
2016-02-23 17:31:38 -08:00
bors-servo
33f0040496 Auto merge of #9733 - servo:servo-webrender, r=glennw
Update webrender crate refs to reflect ownership change.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9733)
<!-- Reviewable:end -->
2016-02-24 06:52:40 +05:30
Corey Farwell
83b22fd97f Update webrender crate refs to reflect ownership change.
Also updated the 'webrender' ref to point to the latest commit.
2016-02-23 19:49:50 -05:00
bors-servo
d85ee09bc7 Auto merge of #9729 - Ms2ger:bc-option, r=jdm
Stop returning an Option from Window::browsing_context.

A Window always has a WindowProxy; the only reason it's wrapped in a nullable
field is the order in which those objects are created.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9729)
<!-- Reviewable:end -->
2016-02-24 01:21:01 +05:30
Paul Rouget
322e71627c allow mozbrowser only for top level windows 2016-02-23 20:31:56 +01:00
bors-servo
7840aae1b9 Auto merge of #9660 - servo:websocketup, r=jdm
Update websocket

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9660)
<!-- Reviewable:end -->
2016-02-23 23:51:54 +05:30
bors-servo
7192495e1a Auto merge of #9067 - nox:unenumerable-named-properties, r=jdm
Make NamedNodeMap's named properties unenumerable

https://dom.spec.whatwg.org/#dom-htmlcollection-item

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9067)
<!-- Reviewable:end -->
2016-02-23 22:58:30 +05:30
Anthony Ramine
86f3f37950 Always implement getOwnEnumerablePropertyKeys
According to JSProxy.h, without this the default implementation calls
ownPropertyKeys and filters out the unenumerable properties. We know when such
things exist so we don't need to do that.
2016-02-23 17:23:56 +01:00
Anthony Ramine
7696a6bd20 Fix HTMLCollection::NamedItem 2016-02-23 17:23:54 +01:00
Anthony Ramine
7f36247d03 Support [LegacyUnenumerableNamedProperties] 2016-02-23 17:23:51 +01:00
Anthony Ramine
cbf514d63f Fix a typo in CGDOMJSProxyHandler_getOwnPropertyDescriptor
Named properties are read-only if there is no named setter.
2016-02-23 17:23:03 +01:00
Anthony Ramine
b783d96749 Make fill_property_descriptor take a flags argument 2016-02-23 17:14:27 +01:00
Anthony Ramine
c95855c7ea Implement [LegacyUnenumerableNamedProperties] in the WebIDL parser
http://github.com/heycam/webidl/issues/82
2016-02-23 17:06:13 +01:00
bors-servo
433232a7ff Auto merge of #9598 - TimNN:xhr-header-step-3, r=Ms2ger
Implement XHR::SetRequestHeader Step 3

Closes #9548.

Alternative implementation of #9595.

cc @timvandermeij

I'm not sure if a utility method on `ByteString` is the best place for this functionality, maybe a free function in XHR module would be more suitable.

Also where would be the correct place to add a test for this functionality (if required)?

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9598)
<!-- Reviewable:end -->
2016-02-23 21:08:43 +05:30
Ms2ger
0e35931152 Stop returning an Option from Window::browsing_context.
A Window always has a WindowProxy; the only reason it's wrapped in a nullable
field is the order in which those objects are created.
2016-02-23 16:08:28 +01:00
bors-servo
3550993075 Auto merge of #9728 - nox:lazy-preliminaries, r=Ms2ger
Preliminary commits for lazy interface objects in #9652

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9728)
<!-- Reviewable:end -->
2016-02-23 20:13:45 +05:30
Anthony Ramine
0af373cef6 Just pass global to CreateInterfaceObjects
The receiver parameter is useless here.
2016-02-23 15:42:45 +01:00
Anthony Ramine
96e28086e3 Clean up CGDOMJSClass 2016-02-23 15:42:44 +01:00
Anthony Ramine
144e215548 Don't use the hasOwn hook anymore in browsingcontext
There is no [[HasOwnProperty]] hook in the ES spec, we should just define
the has proxy trap.

https://bugzilla.mozilla.org/show_bug.cgi?id=980565
2016-02-23 15:42:43 +01:00
Anthony Ramine
a734b8fa21 Reorder js imports in browsingcontext 2016-02-23 15:42:42 +01:00
Anthony Ramine
ebae503a24 Bump phf to 0.7.12 2016-02-23 15:42:38 +01:00
Tim Neumann
43c46090cf add XHR::SetRequestHeader Step 3 unit test 2016-02-23 15:22:37 +01:00
Tim Neumann
fac4c31b42 implement XHR::SetRequestHeader Step 3 2016-02-23 15:22:37 +01:00
Tim Neumann
746f7dd29e move method from ByteString to module where it was used 2016-02-23 15:21:35 +01:00
Tim Neumann
3af3926d63 remove rarely used is_token method from ByteString 2016-02-23 15:21:35 +01:00
bors-servo
90c7b78b12 Auto merge of #9727 - Ms2ger:xhr-import, r=KiChjang
Remove an unused import from xmlhttprequest.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9727)
<!-- Reviewable:end -->
2016-02-23 18:29:59 +05:30
Ms2ger
2547fcb1e9 Remove an unused import from xmlhttprequest. 2016-02-23 13:59:02 +01:00
bors-servo
dd5f338254 Auto merge of #9721 - servo:rustup, r=larsbergstrom,nox
Bump to Rust 2016-02-22

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9721)
<!-- Reviewable:end -->
2016-02-23 07:15:04 +05:30
Anthony Ramine
dab9b4700c Bump to Rust 2016-02-22 2016-02-23 02:43:57 +01:00
Lars Bergstrom
ef95eb3bbe Fix for gonk bootstrapping 2016-02-23 02:29:06 +01:00
bors-servo
57a96ece0c Auto merge of #9716 - servo:disable-intermittents, r=nox
Disable some intermittents

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9716)
<!-- Reviewable:end -->
2016-02-22 16:42:13 +05:30
Keith Yeung
1b41f4544e Disable some intermittents 2016-02-22 06:07:13 -05:00
bors-servo
8f278109ce Auto merge of #8603 - benschulz:timers-clean-up, r=jdm
Timers clean up

This PR splits the `ActiveTimers` abstraction into

 - `OneshotTimers` for scheduling "arbitrary" oneshot timers, such as XHR timeouts, and
 - `JsTimers`, based on `OneshotTimers`, for scheduling JS timers (`setTimeout`/`setInterval`).

The result is mich cleaner and the timer initialization steps now closely resemble the specification.

**Notes**
 - The second and third commit are strictly renames and code rearrangements.
 - I'm not particularily happy with the `OneshotTimerCallback` enum and its circular dependency with `XHRTimeoutCallback`, but I couldn't come up with anything better.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8603)
<!-- Reviewable:end -->
2016-02-21 21:43:28 +05:30
bors-servo
f5193ebd82 Auto merge of #9714 - servo:browsingcontext, r=nox
Improvements to Documents' browsing contexts.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9714)
<!-- Reviewable:end -->
2016-02-21 04:33:32 +05:30
benshu
f2d4a7bbca Clean up of script timer code.
The code was split into the following two abstractions.
 - OneshotTimers can be used to schedule arbitrary oneshot timers, such
   as XHR-Timeouts.
 - JsTimers (`setTimeout` and `setInterval`) which use OneshotTimers to
   schedule individual callbacks.

With this change the implementation (of JsTimers in particular) is in
much closer alignment with the specification.
2016-02-20 22:43:16 +01:00
bors-servo
581aa1a14f Auto merge of #9713 - timvandermeij:move-persistent-list, r=nox
Move util::persistent_list to layout

Fixes #9694.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9713)
<!-- Reviewable:end -->
2016-02-21 00:15:19 +05:30
Tim van der Meij
307f2915f2 Move util::persistent_list to layout 2016-02-20 19:20:38 +01:00
Josh Matthews
f5b5079e2a Use the browsing context from the document where appropriate.
This should not change behaviour.
2016-02-20 18:47:11 +01:00
Josh Matthews
7045056173 Make it possible for XMLDocuments to have a browsing context. 2016-02-20 18:03:14 +01:00
bors-servo
875f1e92cc Auto merge of #9710 - paulrouget:fix9702, r=glennw
do not send mouseevent twice

Fix #9702

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.svg" height="40" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9710)
<!-- Reviewable:end -->
2016-02-20 11:33:06 +05:30