Commit graph

14183 commits

Author SHA1 Message Date
Ralph Giles
135bcacee4 Use the correct .png extension for the image placeholder.
This was changed to the mozilla broken image resource
without changing the filename, even though the file
type changed.
2015-11-13 11:45:09 -08:00
bors-servo
4f855dc63a Auto merge of #8515 - servo:usc, r=Manishearth
Update string_cache_shared.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8515)
<!-- Reviewable:end -->
2015-11-13 23:00:33 +05:30
bors-servo
9bcaedde82 Auto merge of #8514 - Ms2ger:test-ref, r=Manishearth
Use wptrunner for some old-style reftests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8514)
<!-- Reviewable:end -->
2015-11-13 22:31:18 +05:30
Ms2ger
d34ea70212 Update string_cache_shared. 2015-11-13 17:52:03 +01:00
bors-servo
0735cec351 Auto merge of #6935 - jdm:sslverify, r=Manishearth
Make SSL cert verification errors work again. Add a horrible, no-good…

…, very bad regression test.

Here are the list of awful things this test exploits:
- Servo can't load HTTPS content in WPT tests (#6919)
- Our web workers don't report error events to the parent worker object after the initial network load completes
- Our worker resource load don't have a same-origin check

The good news is that this test should start failing if any of those "features" change, so this should not silently break on us.

Other attempts to test this included:
- iframes (didn't work because of #6672 and #3939)
- XMLHttpRequest (I was hit by CORS, I think; maybe I could have made it work if I returned the right headers)

r? @Ms2ger

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6935)
<!-- Reviewable:end -->
2015-11-13 22:00:57 +05:30
Josh Matthews
5e123df7a7 Make SSL cert verification errors work again. Add a horrible, no-good, very bad regression test. 2015-11-13 11:30:38 -05:00
bors-servo
ca85e3f2e7 Auto merge of #8280 - Manishearth:attrNode-tests, r=nox
Add tests for get/set/removeAttributeNode()

Fixes https://github.com/w3c/web-platform-tests/issues/2262

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8280)
<!-- Reviewable:end -->
2015-11-13 20:48:19 +05:30
Manish Goregaokar
c11b756973 Add tests for get/set/removeAttributeNode()
Fixes https://github.com/w3c/web-platform-tests/issues/2262
2015-11-13 20:21:33 +05:30
bors-servo
50be4bb09e Auto merge of #8510 - servo:mozjs, r=nox
Update mozjs.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8510)
<!-- Reviewable:end -->
2015-11-13 19:49:35 +05:30
Ms2ger
002a418fe8 Update mozjs. 2015-11-13 15:14:57 +01:00
Ms2ger
6ef1f559e0 Move linear_gradients_smoke_a.html to wpt reftests. 2015-11-13 14:52:46 +01:00
Ms2ger
d0b7f1628b Move linear_gradients_corners_a.html to wpt reftests. 2015-11-13 14:42:12 +01:00
Ms2ger
1948b6914e Move line_height_a.html to wpt reftests. 2015-11-13 12:28:09 +01:00
Ms2ger
45d0fecb89 Move legacy_td_width_attribute_a.html and legacy_th_width_attribute_a.html to wpt reftests. 2015-11-13 12:03:50 +01:00
bors-servo
f078f8fdf4 Auto merge of #8505 - frewsxcv:html-table-cell-element-bgcolor-idl-attribute, r=Ms2ger
Implement 'bgcolor' IDL attribute for 'HTMLTableCellElement'

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8505)
<!-- Reviewable:end -->
2015-11-13 15:07:53 +05:30
Ms2ger
86ab0eb860 Move legacy_cellspacing_attribute_a.html to wpt reftests. 2015-11-13 10:31:20 +01:00
bors-servo
231bf425f2 Auto merge of #8478 - KiChjang:constellation-two-receivers, r=Ms2ger
Split chan and receiver_port into script and compositor flavors

Partial #8356. Currently this doesn't build because of a lint denying me to user unsafe code, which unfortunately the select! macro falls under. Not sure what to do there.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8478)
<!-- Reviewable:end -->
2015-11-13 14:35:08 +05:30
Keith Yeung
d04615f44b Split chan and receiver_port into script and compositor flavors 2015-11-13 01:01:57 -08:00
Corey Farwell
765ade6892 Implement 'bgcolor' IDL attribute for 'HTMLTableCellElement' 2015-11-13 00:47:20 -05:00
bors-servo
1763a37e3b Auto merge of #8504 - frewsxcv:more-atoms, r=jdm
Prefer atoms over strs for string comparisons

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8504)
<!-- Reviewable:end -->
2015-11-13 10:56:13 +05:30
Corey Farwell
7b8d5bbb97 Prefer atoms over strs for string comparisons 2015-11-12 23:46:48 -05:00
Corey Farwell
ef18b49b35 Upgrade string_cache_shared 2015-11-12 23:46:29 -05:00
bors-servo
ef74bf5d42 Auto merge of #8500 - frewsxcv:subpage, r=jdm
Consolidate 'subpage finding' script_task logic

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8500)
<!-- Reviewable:end -->
2015-11-13 08:52:18 +05:30
bors-servo
118fbd6120 Auto merge of #8493 - notriddle:fct_cleanup, r=jdm
Clean up use of Option in `font_cache_task`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8493)
<!-- Reviewable:end -->
2015-11-13 08:04:50 +05:30
bors-servo
62acdd303b Auto merge of #8477 - asajeffrey:opaque-domstring, r=asajeffrey
Opaque DOMString

This patch makes DOMString an opaque wrapper round String (currently it's a transparent wrapper).

The changes are:

* Replacing DOMString(foo) by DOMString::from(foo).
* Replacing foo.0 by String::from(foo).
* Adding functions clear, push_str and extend for in-place mutation of DOMStrings.
* Replacing DOMString by String in other threads (devtools, storage and filereader).
* Making DOMString implement !Send.
* Removing the pub attribute from the contents of DOMString.

This enables experimenting with other string representations in the DOM.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8477)
<!-- Reviewable:end -->
2015-11-13 07:17:30 +05:30
bors-servo
e63b1e83d4 Auto merge of #8147 - nox:weakref, r=Ms2ger
Implement weak-referenceable JS-managed objects

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8147)
<!-- Reviewable:end -->
2015-11-13 06:22:40 +05:30
Alan Jeffrey
0da1623788 Made DOMString opaque.
Removed the "pub" attribute from the String field of DOMString.
This enables experimenting with other string representations.
2015-11-12 17:53:01 -06:00
Alan Jeffrey
5db67b5981 Added in-place mutation to DOMString.
The methods which are currently implemented are the ones on String that are currently being used:
string.push_str(...), string.clear() and string.extend(...). We may want to revisit this API.
2015-11-12 17:53:01 -06:00
Alan Jeffrey
034769f280 Code generation uses DOMString::from("...") rather than DOMString("...".to_owned()). 2015-11-12 17:53:00 -06:00
Alan Jeffrey
84bde75b42 Replaced DOMString constructor by conversion functions.
Replaced DOMString(...) by DOMString::from(...).
Replaced ....0 by String::from(...).
Removed any uses of .to_owner() in DOMString::from("...").
2015-11-12 17:52:59 -06:00
Alan Jeffrey
736323a779 Made DOMString implement HeapSizeOf.
We have to do this by hand because DOMString is defined in util.
2015-11-12 17:52:59 -06:00
Alan Jeffrey
c8af5b68fa Made DOMString implement !Send.
This change makes DOMStrings only accessible from the main JS thread.
2015-11-12 17:52:59 -06:00
Alan Jeffrey
cf340be758 Replaced DOMString by String in storage APIs. 2015-11-12 17:52:59 -06:00
Alan Jeffrey
582273eb07 Replaced DOMString by String in filereader. 2015-11-12 17:52:58 -06:00
Alan Jeffrey
5101506089 Replaced DOMString by String in devtools. 2015-11-12 17:52:58 -06:00
Alan Jeffrey
9cbc4393eb Added conversion functions between DOMString and String.
Implemented From<String> and From<&str> for DOMString,
and From<DOMString> for String.
2015-11-12 17:51:18 -06:00
bors-servo
9eaa8e7b1f Auto merge of #8492 - jdm:e10s-timer-events, r=jdm
script: Make timer events e10s-safe.

Closes #8235.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8492)
<!-- Reviewable:end -->
2015-11-13 05:19:48 +05:30
bors-servo
1720595a85 Auto merge of #8479 - frewsxcv:domstring-default, r=Ms2ger
Implement Default trait for DOMString

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8479)
<!-- Reviewable:end -->
2015-11-13 04:51:32 +05:30
bors-servo
c44c73aa00 Auto merge of #8498 - nox:fix-variadic-and-default-arguments, r=jdm
Properly handle variadic arguments preceded by default values

I broke that in #8197.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8498)
<!-- Reviewable:end -->
2015-11-13 04:22:11 +05:30
Corey Farwell
607cb0eeb7 Consolidate 'subpage finding' script_task logic 2015-11-12 17:32:37 -05:00
bors-servo
fafc280179 Auto merge of #8430 - jdm:errorhandler, r=Ms2ger
Invoke specialized callback behaviour for OnErrorEventHandler.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8430)
<!-- Reviewable:end -->
2015-11-13 03:54:00 +05:30
Josh Matthews
c4c0809934 Add test for OnErrorEventHandler special case. 2015-11-12 16:21:24 -05:00
Josh Matthews
2340583e56 Differentiate between error and non-error event handlers per the spec. 2015-11-12 16:21:24 -05:00
bors-servo
1e10b67b18 Auto merge of #8485 - hfaulds:make-layout-task-fields-private, r=Ms2ger
Make layout task fields private

For https://github.com/servo/servo/issues/8471

The second commit I'm slightly less sure about but with `chan` made private this warning was shown:

```
components/layout/layout_task.rs:152:5: 152:21 warning: struct field is never used: `chan`, #[warn(dead_code)] on by default
```

There might be some cleanup around `layout_chan` in https://github.com/hfaulds/servo/blob/make-layout-task-fields-private/components/layout/layout_task.rs#L244-L261 as well but that was a bit beyond me.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8485)
<!-- Reviewable:end -->
2015-11-13 02:26:12 +05:30
Anthony Ramine
d4ce25d07c Properly handle variadic arguments preceded by default values
I broke that in #8197.
2015-11-12 21:10:45 +01:00
bors-servo
b40882093a Auto merge of #8428 - Ms2ger:conversions, r=Manishearth
Update js.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8428)
<!-- Reviewable:end -->
2015-11-13 01:13:52 +05:30
Patrick Walton
1dc0d61c3c script: Make timer events e10s-safe.
Closes #8235.
2015-11-12 14:30:25 -05:00
bors-servo
022b06e564 Auto merge of #8494 - jdm:disablewebgl, r=Manishearth
Disable WebGL tests on mac due to #8486.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8494)
<!-- Reviewable:end -->
2015-11-12 23:49:39 +05:30
Josh Matthews
de70ae0c81 Disable WebGL tests on mac due to #8486. 2015-11-12 12:31:52 -05:00
Michael Howell
4fccb9e74f Clean up use of Option in font_cache_task. 2015-11-12 10:27:38 -07:00