Commit graph

31516 commits

Author SHA1 Message Date
Emilio Cobos Álvarez
1804f135ec
style: Optimize @keyframes rule insertions.
Bug: 1435214
Reviewed-by: xidorn,hiro
MozReview-Commit-ID: AHwhZynLBv
2018-02-05 11:54:01 +01:00
Emilio Cobos Álvarez
9c66b07b67
style: Make insertion of @font-face rules not necessarily restyle the whole document.
Bug: 1435214
Reviewed-by: xidorn
MozReview-Commit-ID: 5ewKiShUHNi
2018-02-05 11:24:40 +01:00
bors-servo
f2df3052d9
Auto merge of #19952 - servo-wpt-sync:wpt_update_04-02-2018, r=jdm
Sync WPT with upstream (04-02-2018)

Automated downstream sync of changes from upstream as of 04-02-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19952)
<!-- Reviewable:end -->
2018-02-04 23:22:42 -05:00
WPT Sync Bot
cd5bf022bd Update web-platform-tests to revision 68a256f49be380ca4add535ce8ece9de28820e6b 2018-02-04 21:05:56 -05:00
bors-servo
e54935c25a
Auto merge of #19949 - emilio:bye-cef, r=mbrubeck
ports: Remove leftover CEF config file.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19949)
<!-- Reviewable:end -->
2018-02-04 13:45:30 -05:00
Emilio Cobos Álvarez
a6fa64fc79
ports: Remove leftover CEF config file. 2018-02-04 19:01:00 +01:00
bors-servo
7c112c7dcc
Auto merge of #19944 - o0Ignition0o:mach_run_bin, r=jdm
Add a --bin flag to the |mach run and rr-record commands

Add a --bin flag to the |mach run and rr-record commands to specify which servo binary to run

<!-- Please describe your changes on the following line: -->

Step 1 for #19505.
This flag allows to specify a downloaded servo binary for the ./mach run and ./mach rr-record commands.
The base issue is mentored by @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because | I would love to write tests on this, but I'm not really sure I can, since it's on ./mach commands

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19944)
<!-- Reviewable:end -->
2018-02-04 10:13:52 -05:00
bors-servo
7f7a460a15
Auto merge of #19945 - servo:derive-all-the-things, r=emilio
Simplify counter CSS properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19945)
<!-- Reviewable:end -->
2018-02-04 09:11:05 -05:00
Anthony Ramine
df11a7fec7 Simplify counter CSS properties 2018-02-04 14:52:38 +01:00
o0Ignition0o
c3b2751eef Add a --bin flag to the |mach run and rr-record commands to specify which servo binary to run 2018-02-04 13:00:30 +01:00
bors-servo
f84e9236ae
Auto merge of #19929 - terracotaPie:master, r=jdm
Verify that all values in include.ini represent real directories

<!-- Please describe your changes on the following line: -->
wpt manifest(include.ini) contains directories as headers. With this test in **test-tidy** we check if they are present in respective wtp test folders.

---
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes fix #19703

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19929)
<!-- Reviewable:end -->
2018-02-03 22:39:23 -05:00
Timur Borkhodoev
1027644cb6 Remove a expected fail test 2018-02-03 15:52:26 -05:00
bors-servo
2f8cd0fe22
Auto merge of #19941 - emilio:cleanup-style-builder, r=emilio
style: Handle correctly nested links.

Followup to #19935, since I'm dumb and missed some orange in my try run.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19941)
<!-- Reviewable:end -->
2018-02-03 15:28:58 -05:00
Emilio Cobos Álvarez
2e08ab1492
style: Handle correctly nested links.
Followup to #19935, since I'm dumb and missed that orange.
2018-02-03 20:45:56 +01:00
bors-servo
bad455138f
Auto merge of #19938 - servo:single-keyword, r=emilio
Simplify single_keyword

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19938)
<!-- Reviewable:end -->
2018-02-03 14:27:18 -05:00
Anthony Ramine
70a99cef15 Derive ToComputedValue for keywords without extra specified values 2018-02-03 18:44:56 +01:00
bors-servo
a0d9d3633b
Auto merge of #19935 - emilio:cleanup-style-builder, r=nox
style: Cleanup StyleBuilder.

This is in preparation of a cascade optimization for custom properties.

This fixes various fishiness around our StyleBuilder stuff. In particular,
StyleBuilder::for_derived_style (renamed to for_animation) is only used to
compute specified values, and thus doesn't need to know about rules, visited
style, or other things like that.

The flag propagation that was done in StyleAdjuster is now done in StyleBuilder,
since we know beforehand which ones are always inherited, and it simplified the
callers and the StyleAdjuster code. It also fixed some fishiness wrt which flags
were propagated to anon boxes and text.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19935)
<!-- Reviewable:end -->
2018-02-03 12:24:23 -05:00
Emilio Cobos Álvarez
349d6e7167
style: Cleanup StyleBuilder.
This is in preparation of a cascade optimization for custom properties.

This fixes various fishiness around our StyleBuilder stuff. In particular,
StyleBuilder::for_derived_style (renamed to for_animation) is only used to
compute specified values, and thus doesn't need to know about rules, visited
style, or other things like that.

The flag propagation that was done in StyleAdjuster is now done in StyleBuilder,
since we know beforehand which ones are always inherited, and it simplified the
callers and the StyleAdjuster code. It also fixed some fishiness wrt which flags
were propagated to anon boxes and text.

The text-decoration-lines bit is interesting, because the way it was implemented
in #17722 meant that display: contents elements did get HAS_DECORATION_LINES
flags only if its parent also had it, so in practice the Contents check
preserves behavior, but it's only an optimization looking at Gecko's call-sites,
so we can remove it too.

MozReview-Commit-ID: 6BHCyEO2U8c
2018-02-03 18:07:25 +01:00
Emilio Cobos Álvarez
7fb470c373
style: Remove some uses of StyleBuilder::for_derived_style.
for_derived_style(default_values) is effectively for_inheritance(default_values).

MozReview-Commit-ID: DfTeD49uTlp
2018-02-03 17:40:35 +01:00
Anthony Ramine
ccc932ad10 Don't duplicate specified and computed keywords
The previous code would generate two distinct types for specified and
computed values if some variants had aliases.
2018-02-03 15:22:08 +01:00
Timur Borkhodoev
607306af91 Add update-wpt generated ini 2018-02-02 17:37:19 -05:00
Timur Borkhodoev
515300a20c Change bad namings 2018-02-02 15:39:59 -05:00
Timur Borkhodoev
c351b526f6 Add test that actually tests the test 2018-02-02 15:34:08 -05:00
Timur Borkhodoev
06e439ef40 Add correct file test for manifest test 2018-02-02 14:48:43 -05:00
bors-servo
1662fd7357
Auto merge of #19932 - servo:jdm-patch-14, r=aneeshusa
Fix syntax error in WPT syncing script.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19932)
<!-- Reviewable:end -->
2018-02-02 01:15:27 -05:00
Josh Matthews
ee2ef627c8
Fix syntax error in WPT syncing script. 2018-02-01 23:10:45 -05:00
bors-servo
b5e5a99cb7
Auto merge of #19920 - servo:jdm-patch-10, r=aneeshusa
Supress output from git push in WPT sync.

Pushing to the remote exposes sensitive data in the logs of the job. The old token has been revoked as a consequence.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19920)
<!-- Reviewable:end -->
2018-02-01 18:09:55 -05:00
Josh Matthews
b003f5ad06 Supress output from git push in WPT sync. 2018-02-01 18:08:57 -05:00
bors-servo
ac9b1cfd03
Auto merge of #19930 - jonleighton:enable-wpt-css-fonts, r=jdm
Enable css-fonts WPT tests

See https://github.com/servo/servo/pull/19928#issuecomment-362354270

Note that some of these tests require you to install the fonts found in
tests/wpt/web-platform-tests/css/fonts.

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19930)
<!-- Reviewable:end -->
2018-02-01 15:30:41 -06:00
Jon Leighton
f578ec9b70 Enable css-fonts WPT tests
See https://github.com/servo/servo/pull/19928#issuecomment-362354270

Note that some of these tests require you to install the fonts found in
tests/wpt/web-platform-tests/css/fonts.
2018-02-01 22:14:53 +01:00
Timur Borkhodoev
bcb4bd2f30 Add self-test and modify tidy to accomodate the test 2018-02-01 15:57:11 -05:00
Timur Borkhodoev
41bf86631b Modify(remove, add) tests in include.ini 2018-02-01 14:29:46 -05:00
bors-servo
0a8c58dce9
Auto merge of #19927 - bholley:sheet_flush_optimization, r=emilio
Avoid stylist flushes when sheets are appended and then removed again before flusing layout

https://bugzilla.mozilla.org/show_bug.cgi?id=1434756

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19927)
<!-- Reviewable:end -->
2018-02-01 12:59:35 -06:00
Timur Borkhodoev
3919a7f4fd Add proper formatting and ignore _mozilla 2018-02-01 13:57:17 -05:00
Timur Borkhodoev
23bfb54ab2 Prints errors if wpt manifest directoriries are not present 2018-02-01 13:37:30 -05:00
bors-servo
b20f01f1de
Auto merge of #19926 - servo:jdm-patch-13, r=emilio
Make the syncing PR a bit harder to mess up.

While the system is in testing, it's best to err on the side of making the PRs harder to merge.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19926)
<!-- Reviewable:end -->
2018-02-01 12:04:55 -06:00
bors-servo
a32db10d01
Auto merge of #19921 - servo:jdm-patch-11, r=asajeffrey
test commit for wpt syncing

This is just a test of the automated syncing service.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19921)
<!-- Reviewable:end -->
2018-02-01 11:14:22 -06:00
Bobby Holley
1d6841b9fd Avoid stylist flushes when sheets are appended and then removed again before flushing layout.
MozReview-Commit-ID: CHgbqfHnjwI
2018-02-01 09:14:07 -08:00
Josh Matthews
bce6d59102 test commit for wpt syncing 2018-02-01 11:32:59 -05:00
bors-servo
a07002a0f0
Auto merge of #19923 - emilio:less-crappy-code, r=nox
style: Cleanup and remove unused / dubious Length stuff.

On top of #19918, turns out that the parse_numbers_are_pixels stuff is unused.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19923)
<!-- Reviewable:end -->
2018-02-01 10:27:57 -06:00
bors-servo
38ef515463
Auto merge of #19529 - DonatJR:counter-reset-out-of-mako, r=emilio
style: moved css longhand counter-reset out of mako

<!-- Please describe your changes on the following line: -->
This is a sub-PR of #19015
Code does not yet compile with `build-geckolib`.
r? emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19387

<!-- Either: -->
- [x] These changes do not require tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19529)
<!-- Reviewable:end -->
2018-02-01 09:42:40 -06:00
Josh Matthews
910e9db277
Make the syncing PR a bit harder to mess up. 2018-02-01 09:53:56 -05:00
Jonas Reinwald
d24301b7a0
moved css longhand counter-reset out of mako 2018-02-01 15:43:40 +01:00
Emilio Cobos Álvarez
deac051cb9
style: Cleanup and remove unused / dubious Length stuff.
On top of #19918, turns out that the parse_numbers_are_pixels stuff is unused.
2018-02-01 15:27:39 +01:00
bors-servo
d222c9501b
Auto merge of #19924 - emilio:bim, r=emilio
style: Move border-image-repeat outside of mako.

This is a rebased / nitpick-addressed / bug-fixed version of #19021, and with a commit from #19668 renaming the two `RepeatKeyword`s to different names.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19924)
<!-- Reviewable:end -->
2018-02-01 08:24:12 -06:00
Mauricio Collares
8e411105ce
style: Rename background::RepeatKeyword and border::RepeatKeyword. 2018-02-01 15:23:41 +01:00
chansuke
50b517d0db
style: Move border-image-repeat outside of mako. 2018-02-01 13:59:10 +01:00
bors-servo
dcd13b857c
Auto merge of #19918 - emilio:font-stuff-is-a-mess, r=nox
style: Refactor font-feature-settings and font-variation-settings.

This fixes all known issues with serialization and parsing of these two
properties, and in particular calc handling and such:

  https://bugzilla.mozilla.org/show_bug.cgi?id=1434692
  https://bugzilla.mozilla.org/show_bug.cgi?id=1434724

Also does a fair amount of cleanup and all that, which was needed, this code
was a mess.

There are further cleanups that can be done, like renaming the
font-variation-settings animation stuff.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19918)
<!-- Reviewable:end -->
2018-02-01 06:45:20 -06:00
Emilio Cobos Álvarez
3b34d734e6
style: Refactor font-feature-settings and font-variation-settings.
This fixes all known issues with serialization and parsing of these two
properties, and in particular calc handling and such:

  https://bugzilla.mozilla.org/show_bug.cgi?id=1434692
  https://bugzilla.mozilla.org/show_bug.cgi?id=1434724

Also does a fair amount of cleanup and all that, which was needed.
2018-02-01 12:54:45 +01:00
bors-servo
b4339ab5c8
Auto merge of #19903 - servo:derive-all-the-things, r=emilio
Derive more Parse implementations (fixes #19827)

Fixes #19827.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19903)
<!-- Reviewable:end -->
2018-02-01 05:52:08 -06:00