Commit graph

30538 commits

Author SHA1 Message Date
Josh Matthews
1d2456e076
Add clang packages for non-debian linuxes. 2017-11-23 09:13:25 -05:00
bors-servo
cd70a01d32 Auto merge of #19341 - emilio:traversal-new-faster, r=heycam
stylo: Make TraverseSubtree cheaper in the initial styling case.

This helps with bug 1419694.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19341)
<!-- Reviewable:end -->
2017-11-23 05:44:09 -06:00
bors-servo
ac576910d2 Auto merge of #19339 - CYBAI:moz-script-size-multiplier-out-of-mako, r=emilio
style: Move -moz-script-size-multiplier outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19333
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19339)
<!-- Reviewable:end -->
2017-11-23 04:28:18 -06:00
bors-servo
ca15c10003 Auto merge of #19346 - servo:SimonSapin-patch-1, r=asajeffrey
Remove compiletest from Travis script

This should have been in https://github.com/servo/servo/pull/19338

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19346)
<!-- Reviewable:end -->
2017-11-22 21:05:07 -06:00
CYBAI
20cfefbbbd style: Move -moz-script-size-multiplier outside of mako 2017-11-23 10:26:50 +08:00
bors-servo
72e7f6095e Auto merge of #19330 - Eijebong:sanitize_color, r=KiChjang
Add a sanitize_value implementation for the color input

I had to change the test a little bit to avoid some failures due to
color and text both having a sanitizedValue which was making the test
use the first assertion instead of the second one in some cases.

The sanitize_value implementation is pretty simple, we iterate over the
content and checks that the content is 7 characters long, that the first
character is a `#` and then that all the following characters are
hexadecimal. If all those requirements are met, we lowercase the
content, otherwise we put `#000000` in it.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19330)
<!-- Reviewable:end -->
2017-11-22 19:42:58 -06:00
Simon Sapin
754341895d
Remove compiletest from Travis script
This should have been in https://github.com/servo/servo/pull/19338
2017-11-23 01:35:44 +01:00
bors-servo
976f9e3d13 Auto merge of #19329 - Manishearth:fetchcanceller, r=jdm
Add RAII guard for cancelling fetch when the consumer no longer cares about it

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19329)
<!-- Reviewable:end -->
2017-11-22 18:30:57 -06:00
bors-servo
369ae1d7e7 Auto merge of #19345 - moz-servo-sync:gecko-backout, r=moz-servo-sync
Backed out changeset 2e20100d8f59 (bug 1417709) for error in toolkit/library/rust/target r=backout on a CLOSED TREE

Backed out changeset 2e20100d8f59 (bug 1417709) for error in toolkit/library/rust/target r=backout on a CLOSED TREE

Backs out https://github.com/servo/servo/pull/19255

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19345)
<!-- Reviewable:end -->
2017-11-22 17:26:52 -06:00
Gecko Backout
a06a80b5da Backed out changeset 2e20100d8f59 (bug 1417709) for error in toolkit/library/rust/target r=backout on a CLOSED TREE
Backs out https://github.com/servo/servo/pull/19255
2017-11-22 23:20:51 +00:00
Manish Goregaokar
3900f5e616
Use FetchCanceller for document loads 2017-11-22 14:06:27 -08:00
Bastien Orivel
05c4e08d58 Add a sanitize_value implementation for the color input
I had to change the test a little bit to avoid some failures due to
color and text both having a sanitizedValue which was making the test
use the first assertion instead of the second one in some cases.

The sanitize_value implementation is pretty simple, we iterate over the
content and checks that the content is 7 characters long, that the first
character is a `#` and then that all the following characters are
hexadecimal. If all those requirements are met, we lowercase the
content, otherwise we put `#000000` in it.
2017-11-22 22:36:21 +01:00
Emilio Cobos Álvarez
269077f317
stylo: Also tidy Servo_AnimationValue_DeepEqual while here. 2017-11-22 21:16:38 +01:00
Emilio Cobos Álvarez
663794fe2d
stylo: Tidy up create_shared_context. 2017-11-22 21:09:37 +01:00
Emilio Cobos Álvarez
b13f62714a
stylo: Make TraverseSubtree cheaper in the initial styling case.
We assert against the display: none / unstyled parent already, so there's no
need to check it here as well.
2017-11-22 21:07:57 +01:00
bors-servo
9ac05a5bee Auto merge of #19255 - mstange:bug1417709, r=emilio
Bug 1417709 - Add -moz-appearance: -moz-mac-vibrant-titlebar-light/dark and system colors with the same name.

<!-- Please describe your changes on the following line: -->

These are the servo changes that need to go with [bug 1417709](https://bugzilla.mozilla.org/show_bug.cgi?id=1417709).

r? emilio

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because without these changes Firefox doesn't build.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19255)
<!-- Reviewable:end -->
2017-11-22 13:32:38 -06:00
Markus Stange
7be33e3a45 Regenerate structs.rs. 2017-11-22 14:09:55 -05:00
Markus Stange
b3ad54f468 Servo changes for system colors -moz-mac-vibrant-titlebar-light/dark 2017-11-22 14:00:05 -05:00
Markus Stange
753304411a Servo changes for -moz-appearance values -moz-mac-vibrant-titlebar-light/dark 2017-11-22 14:00:05 -05:00
bors-servo
a812af51d6 Auto merge of #19325 - m-novikov:tidy-ignore-without-duplicates, r=jdm
Report an errror if a package has duplicates allowed but there are no duplicates

Resolves: #19306

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19306 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19325)
<!-- Reviewable:end -->
2017-11-22 11:49:40 -06:00
bors-servo
218edeb883 Auto merge of #19336 - servo:jdm-patch-6, r=emilio
Instruct how to deal with outdated manifests.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19336)
<!-- Reviewable:end -->
2017-11-22 10:36:04 -06:00
Josh Matthews
b45e4fecff
Address tidy checks. 2017-11-22 10:48:51 -05:00
bors-servo
5213e2a5a9 Auto merge of #19338 - servo:compiletest, r=nox
Replace compiletest suite by doc-tests with `compile_fail`

`compiletest-rs` use internal rustc APIs and is broken in today’s Nightly. rustdoc however is maintained with rustc and so much less fragile.

Closes #9945.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19338)
<!-- Reviewable:end -->
2017-11-22 09:35:54 -06:00
Simon Sapin
b1ce298d4b Replace compiletest suite by doc-tests with compile_fail
compiletest-rs use internal rustc APIs and is broken in today’s Nightly.
rustdoc however is maintained with rustc and so much less fragile.
2017-11-22 16:25:17 +01:00
Simon Sapin
d96f0ff6a7 Use rustdoc --document-private-item instead of deprecated flags
… and use $RUSTDOCFLAGS instead of $RUSTDOC with a wrapper script
2017-11-22 15:32:40 +01:00
Josh Matthews
b501c8fa03
Instruct how to deal with outdated manifests. 2017-11-22 08:16:54 -05:00
bors-servo
3a08f87ec8 Auto merge of #19335 - servo:jdm-patch-5, r=nox
Unbreak docs build.

Running rustdoc on gecko-media is broken right now.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19335)
<!-- Reviewable:end -->
2017-11-22 06:48:10 -06:00
Josh Matthews
da46fe4812
Unbreak docs build. 2017-11-22 07:47:04 -05:00
bors-servo
3ecd0174cc Auto merge of #19332 - wilsoniya:moving-fixme, r=emilio
moving :dir() param serialization FIXME

<!-- Please describe your changes on the following line: -->
Per emilio's comment, https://github.com/servo/servo/pull/19195#discussion_r152205644, a `FIXME` regarding `:dir()` parameter serialization has been moved.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they only modify comment lines

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19332)
<!-- Reviewable:end -->
2017-11-22 04:04:39 -06:00
Michael Wilson
1ebc1382ce moving :dir() param serialization FIXME 2017-11-21 21:47:41 -08:00
bors-servo
a6ce817045 Auto merge of #19331 - hiikezoe:resolve-base-style-for-pseudo, r=emilio
Resolve base style for pseudo

<!-- Please describe your changes on the following line: -->
This is a PR for https://bugzilla.mozilla.org/show_bug.cgi?id=1418867

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
2017-11-21 22:16:58 -06:00
Hiroyuki Ikezoe
64bd97a0d3 Update bindings. 2017-11-22 13:02:45 +09:00
bors-servo
78fb3c206d Auto merge of #19328 - Eijebong:remove_old_cancellation_code, r=KiChjang
Remove cancellation map and ResourceId from the net* components

Fixes #19327

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19328)
<!-- Reviewable:end -->
2017-11-21 21:01:35 -06:00
Hiroyuki Ikezoe
dcedf11013 Pass element or pseudo element to Servo_StyleSet_GetBaseComputedValuesForElement() 2017-11-22 11:06:05 +09:00
bors-servo
93c2a5da89 Auto merge of #19326 - servo:jdm-patch-2, r=asajeffrey
Use same build environment during mutation testing.

ccache complains that the C++ compiler doesn't match the cached version.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19326)
<!-- Reviewable:end -->
2017-11-21 19:43:49 -06:00
Manish Goregaokar
78c8b4232f
Use FetchCanceller in XHR 2017-11-21 16:45:04 -08:00
Manish Goregaokar
57bb4553c1
Add FetchCanceller RAII handle 2017-11-21 16:45:03 -08:00
bors-servo
37fa711657 Auto merge of #19314 - servo:wr, r=jdm
Update WR and the whole macOS crate stack

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19314)
<!-- Reviewable:end -->
2017-11-21 18:40:36 -06:00
Dzmitry Malyshau
ba214bcec5 WR multi-document support 2017-11-22 00:43:34 +01:00
bors-servo
a20efc6d7b Auto merge of #19324 - drewler:fix_matchbat, r=jdm
Get back to working dir after vcvarsall.bat

<!-- Please describe your changes on the following line: -->

When using cmd.exe directly (instead of `x86_x64 Cross Tools Command Prompt for VS 2017`), vcvarsall.bat changes the working directory.
To prevent this, pushd and popd could be used.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] These changes do not require tests because they are part of the build process.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19324)
<!-- Reviewable:end -->
2017-11-21 17:27:34 -06:00
Bastien Orivel
d55e0fa802 Remove cancellation map and ResourceId from the net* components
Fixes #19327
2017-11-21 23:03:16 +01:00
bors-servo
06d834c1b9 Auto merge of #19321 - emilio:supports-dumb, r=SimonSapin
style: Avoid unneessary malloc churn when evaluating @supports rules.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19321)
<!-- Reviewable:end -->
2017-11-21 15:27:59 -06:00
Maxim Novikov
e6d9fd8a4f Report an errror if a package has duplicates allowed but there are no duplicates
Resolves: #19306
2017-11-21 21:08:14 +01:00
bors-servo
d1e4fdb7fa Auto merge of #19322 - CYBAI:x-lang-out-of-mako, r=emilio
style: Move -x-lang outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19320
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19322)
<!-- Reviewable:end -->
2017-11-21 13:46:49 -06:00
Josh Matthews
5a36c481f0
Use same build environment during mutation testing. 2017-11-21 13:47:54 -05:00
bors-servo
dc35457b4a Auto merge of #19318 - jdm:webdriver, r=jgraham
Make wdspec tests runnable

This makes it possible to run tests in tests/wpt/web-platform-tests/webdriver/tests and focus on investigating why they fail.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix (partially) #15274.
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19318)
<!-- Reviewable:end -->
2017-11-21 12:25:55 -06:00
Andrés Barreiro
1f2b5d684f Get back to working dir after vcvarsall.bat
When using cmd.exe directly, vcvarsall.bat changes the working directory.
To prevent this, pushd and popd could be used.
2017-11-21 19:17:29 +01:00
bors-servo
755fa371cb Auto merge of #19244 - asajeffrey:test-perf-submit-to-s3, r=jdm
Submit test-perf CSV files to S3

<!-- Please describe your changes on the following line: -->

Submit CSV files to S3 rather than json files to Perfherder.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19244)
<!-- Reviewable:end -->
2017-11-21 11:07:55 -06:00
bors-servo
b13107a318 Auto merge of #19225 - servo:media, r=jdm
Shut down the media stack when shutting down the constellation

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19225)
<!-- Reviewable:end -->
2017-11-21 10:13:02 -06:00
CYBAI
d671859426 style: Move -x-lang outside of mako 2017-11-21 23:46:34 +08:00