Commit graph

11710 commits

Author SHA1 Message Date
Manish Goregaokar
2114ffd0b9 Rollup merge of #7039 - jdm:squashed-6992, r=jdm
Add a reftest for <body background>. Fixes #6838

Rebased from #6992.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7039)
<!-- Reviewable:end -->
2015-08-07 03:45:30 +05:30
Manish Goregaokar
730ee4d341 Rollup merge of #7034 - Ms2ger:mem, r=jdm
Create a run_with_memory_reporting method to reduce the boilerplate a…

…ssociated with registering memory reporters.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7034)
<!-- Reviewable:end -->
2015-08-07 03:45:29 +05:30
Manish Goregaokar
fb28b3ddb4 Rollup merge of #7028 - Yoric:master, r=SimonSapin
Issue #5478 - use std::process::exit instead of lib::exit in constellation.rs

First patch.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7028)
<!-- Reviewable:end -->
2015-08-07 03:45:28 +05:30
bors-servo
889ef3aef0 Auto merge of #7010 - HarryLovesCode:master, r=jdm
Fixes #6879 (Improper connections to the devtools server)

Modifies how we behave in the case that something attempts to communicate with the devtools server improperly. This includes...

- Invalid encoding (Non `UTF8`) of the packet length / error parsing / none specified
- JSON encoding error (such as a `Parser::SyntaxError` or a `Parser::IoError`)

Happy to make changes if anyone has an issue with this or feels another way is more idiomatic!

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7010)
<!-- Reviewable:end -->
2015-08-06 14:00:26 -06:00
bors-servo
522ebe7a3b Auto merge of #7027 - Ms2ger:lock-stderr, r=jdm
Lock stderr while printing the alert() message.

2a7f262b7d was unsufficient for the case where
the interleaved output was actually on stderr rather than stdout, such as
output from the error macro.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7027)
<!-- Reviewable:end -->
2015-08-06 12:46:31 -06:00
Ms2ger
c98d35ea6b Lock stderr while printing the alert() message.
2a7f262b7d was unsufficient for the case where
the interleaved output was actually on stderr rather than stdout, such as
output from the error macro.
2015-08-06 20:11:37 +02:00
bors-servo
cf4b411832 Auto merge of #7008 - pcwalton:floated-negative-margins, r=mbrubeck
layout: Take negative margins of floats into account when placing them.

Removes extraneous inline space on GitHub pull requests.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7008)
<!-- Reviewable:end -->
2015-08-06 11:55:58 -06:00
bors-servo
0a8ea98183 Auto merge of #7002 - Ms2ger:eventtarget, r=jdm
Remove the unused WorkerGlobalScope::eventtarget method.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7002)
<!-- Reviewable:end -->
2015-08-06 10:31:58 -06:00
s142857
29c4643a4a Add a reftest for <body background>. Fixes #6838 2015-08-06 10:57:56 -04:00
bors-servo
d2ba81ead2 Auto merge of #6998 - mbrubeck:upgrade, r=Manishearth
Update to unicode-bidi 0.2.1

Also includes some missing changes from #6416.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6998)
<!-- Reviewable:end -->
2015-08-06 08:57:53 -06:00
Matt Brubeck
73ce2325a2 Update to unicode-bidi 0.2.1
Fixes #6978.
2015-08-06 06:52:17 -07:00
bors-servo
106361443d Auto merge of #6451 - jgraham:onkey_attributes, r=Ms2ger
Add onkey* global event handler attributes



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6451)
<!-- Reviewable:end -->
2015-08-06 07:44:51 -06:00
Ms2ger
bf3ecaa901 Create a run_with_memory_reporting method to reduce the boilerplate associated with registering memory reporters. 2015-08-06 15:24:27 +02:00
bors-servo
ddd2840eed Auto merge of #7001 - farodin91:filereader, r=Ms2ger
Remove Unnecessary Code in FileReader #6753

@jdm r?

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7001)
<!-- Reviewable:end -->
2015-08-06 06:13:56 -06:00
bors-servo
4726f58d15 Auto merge of #6970 - dzbarsky:getimagedata, r=Ms2ger
GetImageData should return un-premultiplied alpha values



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6970)
<!-- Reviewable:end -->
2015-08-06 04:34:20 -06:00
David Rajchenbach-Teller
d2a3a68170 Resolves #5478 - use std::process::exit instead of lib::exit in constellation.rs 2015-08-06 12:10:26 +02:00
bors-servo
172f046688 Auto merge of #6836 - nick-thompson:layout_refactor, r=Ms2ger
Extract layout query code into layout/query.rs

Fix for #6787. I left the commits split up for ease of review, happy to squash when this gets accepted.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6836)
<!-- Reviewable:end -->
2015-08-06 03:29:16 -06:00
David Zbarsky
fee8abe5a2 GetImageData should return un-premultiplied alpha values 2015-08-06 05:14:53 -04:00
bors-servo
729e003c5d Auto merge of #6996 - frewsxcv:prevent-tidy-crash, r=jdm
Prevent flake8 from crashing tidy

If someone were to write:

    def hello() :
        print "hello world"

flake8 would warn:

    stdin:54:45: E203 whitespace before ':'

Normally there are only three colons in a flake8 error message, but this
one has four, which causes issue with this line:

    _, line_num, _, message = error.split(":")

...causing this error:

    ValueError: too many values to unpack

This commit updates the `str.split` call to utilize the `maxsplit`
parameter to prevent this error from occurring.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6996)
<!-- Reviewable:end -->
2015-08-06 02:32:43 -06:00
bors-servo
3b4b59551d Auto merge of #6991 - Manishearth:readme-doc, r=Ms2ger
Add doc.s.o to the readme



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6991)
<!-- Reviewable:end -->
2015-08-06 01:36:22 -06:00
bors-servo
1b54e9c30c Auto merge of #6985 - dzbarsky:drawimage_refactor, r=jdm
Refactor DrawImage implementations to avoid code duplication



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6985)
<!-- Reviewable:end -->
2015-08-06 00:24:02 -06:00
bors-servo
b9dcd49778 Auto merge of #6989 - dzbarsky:compositing, r=metajack
Respect the composition op when drawing images.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6989)
<!-- Reviewable:end -->
2015-08-05 22:57:20 -06:00
David Zbarsky
8690414a47 Refactor DrawImage implementations to avoid code duplication 2015-08-06 00:52:28 -04:00
bors-servo
be8798b73a Auto merge of #6994 - servo:warnings, r=Manishearth
Fix unused mutability warnings.

They were introduced in 35ba731123.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6994)
<!-- Reviewable:end -->
2015-08-05 22:02:45 -06:00
Jack Moffitt
f570da28c2 Merge pull request #6988 from glennw/no-arc
No need for paint layer in stacking context to be an arc.
2015-08-05 20:06:09 -06:00
David Zbarsky
1d02239804 Respect the composition op when drawing images 2015-08-05 20:38:48 -04:00
bors-servo
afe3d7e747 Auto merge of #6990 - Ms2ger:update-animatiom-timimg, r=saneyuki
Update Animation Timing links and terminology to the HTML specification.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6990)
<!-- Reviewable:end -->
2015-08-05 14:55:55 -06:00
Harrison G
8943f11e54 Fixes #6879 2015-08-05 14:53:53 -04:00
bors-servo
315c4f5ed7 Auto merge of #6983 - glennw:tf2, r=pcwalton
Support transforms for display list optimization. Prevents clipping in #6643.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6983)
<!-- Reviewable:end -->
2015-08-05 12:50:36 -06:00
Patrick Walton
95c9d3cefe layout: Take negative margins of floats into account when placing them.
Removes extraneous inline space on GitHub pull requests.
2015-08-05 11:15:32 -07:00
bors-servo
debd7d87d6 Auto merge of #6974 - dzbarsky:tiny-create, r=jdm
Fix createImageData with sizes < 1 pixel



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6974)
<!-- Reviewable:end -->
2015-08-05 11:40:20 -06:00
Nick Thompson
f114304a3a Extract layout query code into query.rs 2015-08-05 10:24:00 -07:00
bors-servo
95269bba39 Auto merge of #6971 - dzbarsky:negative-radius, r=Ms2ger
Make createRadialGradient throw for negative radii



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6971)
<!-- Reviewable:end -->
2015-08-05 10:42:57 -06:00
Ms2ger
9b084b604e Remove the unused WorkerGlobalScope::eventtarget method. 2015-08-05 18:41:54 +02:00
farodin91
41620421c3 Remove Unnecessary Code in FileReader #6753 2015-08-05 18:24:09 +02:00
bors-servo
b3d61878dc Auto merge of #6964 - Ms2ger:dwgs-eventloop, r=jdm
Cleanup DedicatedWorkerGlobalScope::run_worker_scope.

It was getting overcrowded.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6964)
<!-- Reviewable:end -->
2015-08-05 09:21:10 -06:00
Corey Farwell
5eeb53413e Prevent flake8 from crashing tidy
If someone were to write:

    def hello() :
        print "hello world"

flake8 would warn:

    stdin:54:45: E203 whitespace before ':'

Normally there are only three colons in a flake8 error message, but this
one has four, which causes issue with this line:

    _, line_num, _, message = error.split(":")

...causing this error:

    ValueError: too many values to unpack

This commit updates the `str.split` call to utilize the `maxsplit`
parameter to prevent this error from occurring.
2015-08-05 10:23:16 -04:00
bors-servo
8602d01af2 Auto merge of #6416 - jgraham:hosts_replaced, r=jdm
Use hosts-replaced URL only when loading resources



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6416)
<!-- Reviewable:end -->
2015-08-05 08:01:03 -06:00
Ms2ger
a7ca54a325 Fix unused mutability warnings.
They were introduced in 35ba731123.
2015-08-05 15:45:05 +02:00
bors-servo
11acfbc29f Auto merge of #6981 - pcwalton:github-font-fallback, r=metajack
gfx: Fix Core Text font instantiation for Web fonts on Mac.

r? @metajack

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6981)
<!-- Reviewable:end -->
2015-08-05 06:11:36 -06:00
Manish Goregaokar
432e36dc81 Add doc.s.o to the readme 2015-08-05 16:51:41 +05:30
bors-servo
cc70e2f91f Auto merge of #6980 - pcwalton:inline-border-baseline, r=glennw
layout: Take borders into account when positioning inline fragments on their baselines.

Improves the Rust GitHub page.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6980)
<!-- Reviewable:end -->
2015-08-05 05:03:43 -06:00
bors-servo
0d8825c25c Auto merge of #6959 - servo:warnings_, r=jdm
Fix warnings

Adds on top of #6949.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6959)
<!-- Reviewable:end -->
2015-08-05 03:44:22 -06:00
James Graham
f52276d2cc Use hosts-replaced URL only when loading resources 2015-08-05 10:34:20 +01:00
Ms2ger
d2077dd245 Update Animation Timing links and terminology to the HTML specification. 2015-08-05 09:21:08 +02:00
bors-servo
56a9eab2a0 Auto merge of #6976 - pcwalton:vertical-marker-placement, r=mbrubeck
layout: Place list item markers correctly in the block direction.

r? @mbrubeck

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6976)
<!-- Reviewable:end -->
2015-08-05 00:57:19 -06:00
Glenn Watson
aca98b2901 No need for paint layer in stacking context to be an arc. 2015-08-05 14:35:49 +10:00
bors-servo
ac533b1466 Auto merge of #6944 - r0e:testing, r=jdm
Fix for issue #6768. Refactor ReadData and BlobBody

Fix for issue #6768.

Merge common fields of ReadData and BlobBody to avoid passing redundant information to functions.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6944)
<!-- Reviewable:end -->
2015-08-04 20:21:35 -06:00
Glenn Watson
11b1c19b05 Support transforms for display list optimization. Prevents clipping in #6643. 2015-08-05 11:48:07 +10:00
bors-servo
b9f00190e1 Auto merge of #6979 - mbrubeck:counter, r=pcwalton
Fix crash caused by negative numbers in list counters.

Fixes #6818.  The test still fails because of #6978.

r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6979)
<!-- Reviewable:end -->
2015-08-04 18:37:10 -06:00