Commit graph

7432 commits

Author SHA1 Message Date
Jack Britton
1dd1cb4f4f Implement DocumentFragment XML serialization. 2019-04-12 12:49:18 -04:00
Emilio Cobos Álvarez
a1d224b823 Remove style system serialization tests that are tested via wpt. 2019-04-12 12:20:17 +02:00
WPT Sync Bot
dd79cdc697 Update web-platform-tests to revision 386d27678c48bf468b8d374e2ba718e32185a5b7 2019-04-12 01:21:13 -04:00
WPT Sync Bot
7e807a0d1e Update web-platform-tests to revision e3d0146264093a389148cc555ee9be69bd75719b 2019-04-11 00:31:30 -04:00
krk
4af50f96fa Add css-align tests with failure expectations. 2019-04-10 21:41:02 +02:00
Josh Matthews
1bdca9ce84
Delete Secure-Send-binary-65K-arraybuffer.any.js.ini 2019-04-09 07:17:43 -04:00
WPT Sync Bot
1a4444a557 Update web-platform-tests to revision 687b6cba3385c4c2ca85f44fe072961e651621b5 2019-04-09 00:21:08 -04:00
WPT Sync Bot
733bcbdd2b Update web-platform-tests to revision 2221fe343f0f4cb4e4e382bfd43bc8b1e69a98ba 2019-04-08 00:34:34 -04:00
bors-servo
8073e9a505
Auto merge of #23174 - soniasingla:DefaultPaths, r=jdm
Add default paths for WPT tests

Set the following default configs for WPT tests.
```--ca-cert-path=tests\wpt\web-platform-tests\tools\certs\cacert.pem
--host-key-path=tests\wpt\web-platform-tests\tools\certs\web-platform.test.key
--host-cert-path=tests\wpt\web-platform-tests\tools\certs\web-platform.test.pem
--ssl-type=pregenerated
```
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23133

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23174)
<!-- Reviewable:end -->
2019-04-07 12:18:17 -04:00
Sonia Singla
9d48ca1298 fix identation 2019-04-07 20:37:05 +05:30
Sonia Singla
37259d216d Add default paths for WPT tests 2019-04-07 18:17:07 +05:30
WPT Sync Bot
401e01095b Update web-platform-tests to revision 923923a01f38577f471b1e613c4223a21ac027ff 2019-04-07 00:02:56 -04:00
WPT Sync Bot
ce9f8f32f1 Update web-platform-tests to revision 4688078c2cc6e81651b220f3c1944d956f63046b 2019-04-05 23:55:05 -04:00
WPT Sync Bot
2575230dce Update web-platform-tests to revision 0cde5f6b37c9b3e3f9153eb1b172680e9aea9bf9 2019-04-05 00:50:36 -04:00
bors-servo
f142b1d1c7
Auto merge of #23145 - pylbrecht:performance.resource.timing, r=jdm
Add connectEnd attribute to PerformanceResourceTiming interface

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #21262

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23145)
<!-- Reviewable:end -->
2019-04-04 18:39:35 -04:00
pylbrecht
f478357567 Add connectEnd attribute to PerformanceResourceTiming interface 2019-04-04 07:19:25 +02:00
WPT Sync Bot
bde105ca2e Update web-platform-tests to revision b8669365b81965f5400d6b13a7783415b44e679d 2019-04-03 23:56:16 -04:00
bors-servo
6fa1853bb1
Auto merge of #23156 - servo-wpt-sync:wpt_update_03-04-2019, r=jdm
Sync WPT with upstream (03-04-2019)

Automated downstream sync of changes from upstream as of 03-04-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23156)
<!-- Reviewable:end -->
2019-04-03 07:17:10 -04:00
Josh Matthews
01b82f5e68
remove intermittent failure. 2019-04-03 07:16:29 -04:00
bors-servo
b9b729caa0
Auto merge of #23103 - ferjm:srcObject, r=Manishearth
Implement srcObject logic for Blob media providers

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23103)
<!-- Reviewable:end -->
2019-04-03 05:05:32 -04:00
WPT Sync Bot
52045cb370 Update web-platform-tests to revision 0a28ecf697d96db228f8382db0e41f1c54314dad 2019-04-03 00:53:26 -04:00
Josh Matthews
4138fb689b
Delete insecure-protocol.http.html.ini
Remove intermittent failure.
2019-04-02 10:15:44 -04:00
WPT Sync Bot
b55cc798b6 Update web-platform-tests to revision 3bbb55915a04548e70c63b7c143a83e0e9d3c5e7 2019-04-02 01:37:24 -04:00
WPT Sync Bot
f62d961249 Update web-platform-tests to revision f24d88b7d2cd2d851533e9c1180b1c5c5d118bc3 2019-03-31 23:38:25 -04:00
WPT Sync Bot
7cb8ac2fe2 Update web-platform-tests to revision d4f8820261cce3f9ee37353b6d76d247cb12a972 2019-03-30 23:51:59 -04:00
WPT Sync Bot
6ed2abf735 Update web-platform-tests to revision add24188a1226f3598ad6b455e71641c9ac6a5fd 2019-03-29 23:56:29 -04:00
Maharsh
6c6fb676b7 Created CanvasRect fro OffscreenCanvas and Updated Testcases 2019-03-29 15:12:53 -04:00
WPT Sync Bot
cb63cfd5c7 Update web-platform-tests to revision 3bfdeb8976fc51748935c8d1f1014dfba8e08dfb 2019-03-29 00:51:32 -04:00
Fernando Jiménez Moreno
d15640081c Implement srcObject logic for Blob media providers 2019-03-27 07:11:29 +01:00
George Roman
e63de4d52c Update Event's timestamp 2019-03-26 09:39:07 +02:00
bors-servo
5ae562bfc3
Auto merge of #22944 - ferjm:player.shutdown, r=ceyusa
Shutdown player when HTMLMediaElement is dropped

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22931
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22944)
<!-- Reviewable:end -->
2019-03-25 07:47:06 -04:00
Fernando Jiménez Moreno
36825b82f3 Shutdown player when HTMLMediaElement is dropped 2019-03-25 09:29:30 +01:00
WPT Sync Bot
c858882d3c Update web-platform-tests to revision 3b0abc897b6f4f3997ed42b9ef902e98b2893d8d 2019-03-24 23:52:38 -04:00
bors-servo
7a67443fcb
Auto merge of #23086 - servo-wpt-sync:wpt_update_23-03-2019, r=jdm
Sync WPT with upstream (23-03-2019)

Automated downstream sync of changes from upstream as of 23-03-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23086)
<!-- Reviewable:end -->
2019-03-24 08:30:11 -04:00
bors-servo
5f4030d028
Auto merge of #23011 - dboyan:open-feature-tokenize, r=gterzian,cybai
Add tokenizer for features in window.open

<!-- Please describe your changes on the following line: -->
This is a prototype implementation of feature tokenizer ~~and "noreferrer" feature~~ for window.open. I'm not very sure where the tokenizer code should be placed. Building now generates the following warning

```
warning: unused attribute
  --> components/script/dom/bindings/conversions.rs:74:5
   |
74 |     rustc_on_unimplemented(message = "The IDL interface `{Self}` is not derived from `{T}`.")
   |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
   |
   = note: #[warn(unused_attributes)] on by default
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes _partially_ fix #22869 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23011)
<!-- Reviewable:end -->
2019-03-24 05:31:24 -04:00
WPT Sync Bot
93d826f7ba Update web-platform-tests to revision 122a4672fa0dc554a6e7528fa3487fd907c792ee 2019-03-23 23:57:08 -04:00
Boyan Ding
f261799e64 Add a tokenizer for features in window.open() 2019-03-23 15:31:14 +08:00
bors-servo
059ac12c00
Auto merge of #23073 - sbansal3096:master, r=emilio
Expose public getter to stylesheet's owner

<!-- Please describe your changes on the following line: -->

- [x] expose a public getter on CSSStyleSheet to return the stylesheet's owner
- [x] in CSSRuleList::insert_rule, use the new getter to pass a non-None value as an argument to arc.insert_rule
- [x] add a test for this that verifies that the new stylesheet is actually loaded
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23028

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23073)
<!-- Reviewable:end -->
2019-03-22 19:45:08 -04:00
bors-servo
525484a4d9
Auto merge of #22973 - paulrouget:wrupdate, r=emilio
WR update

~Need https://github.com/tomaka/winit/issues/803~

@emilio can I ask you to look at the *"WR udpate: layout"* commit? There are a few changes I'm not sure about (should_inflate, the new filters_data and cache_tiles).

Fix: #22993

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22973)
<!-- Reviewable:end -->
2019-03-22 08:48:16 -04:00
Paul Rouget
f1f7779c1a WR update: test ompositing_simple_div.html: PASS to FAIL 2019-03-22 18:23:46 +08:00
Paul Rouget
0b8ea51509 WR update: transform3d-perspective-005.html: PASS to FAIL 2019-03-22 18:23:46 +08:00
Paul Rouget
06621ade41 WR update: border_radius_zero_sizes_a.html: PASS to FAIL 2019-03-22 18:23:30 +08:00
sbansal3096
13eebbfe56 Fix insertRule crash by exposing getter on stylesheet's owner 2019-03-22 15:45:18 +05:30
WPT Sync Bot
953dbda9a6 Update web-platform-tests to revision b7a8b84debb42268ea95a45bdad8f727d1facdf7 2019-03-21 23:44:37 -04:00
George Roman
c6433efc1d Implement XMLSerializer interface 2019-03-21 09:50:29 +02:00
bors-servo
93dc2295f7
Auto merge of #23051 - servo-wpt-sync:wpt_update_17-03-2019, r=jdm
Sync WPT with upstream (17-03-2019)

Automated downstream sync of changes from upstream as of 17-03-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23051)
<!-- Reviewable:end -->
2019-03-20 18:53:44 -04:00
bors-servo
6d308c3577
Auto merge of #22480 - cdeler:implement-DOMException-constructor, r=jdm
Implement dom exception constructor

The constructor method was implemented

I have a question: should I edit `./mach test-wpt` expectations?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22412
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22480)
<!-- Reviewable:end -->
2019-03-20 16:13:17 -04:00
cdeler
76fed04f6b #22412 disabled /bluetooth/requestDevice/canonicalizeFilter wpt tests due to #23066 2019-03-20 22:36:02 +03:00
bors-servo
5ec725488f
Auto merge of #22923 - peterjoel:issue_8539_prefs_refactor, r=jdm
#8539 Config preferences backend restructure

<!-- Please describe your changes on the following line: -->

A procedural macro for generating static structures for use as the backend for config preferences, as well a mapping from string names to accessors.

Preferences can be accessed and updated via a map-like interface with `String` keys, and now also via a convenience macro: `get_pref!(path.to.pref)`. Various `serde`-compatible field attributes are also supported, including renaming the string keys. This could be useful when changing the backend structure without breaking existing usages.

I have added the choice to use `i64` as well as `f64` for storing numbers. As it turns out, none of the existing preferences used non-integer values. Setting a floating point value from a command-line argument requires a decimal point in order to parse correctly.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #8539

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

-----

I have a few outstanding problems or questions:

1. I am unable to get rid of this warning:
    ```
    warning: unnecessary path disambiguator
       --> components/config/prefs.rs:130:51
        |
    130 |         accessor_type = crate::pref_util::Accessor::<Prefs, crate::pref_util::PrefValue>,
        |                                                   ^^ try removing `::`
    ```
    See: https://stackoverflow.com/questions/54710797/how-to-disable-unnecessary-path-disambiguator-warning
2. Several of the preferences in use were not represented in `prefs.json`. Some of these may be in error, but it is hard to tell. For example `js.offthread_compilation.enabled` vs `js.ion.offthread_compilation.enabled` could be different preferences or could be intended to have the same value.
3. Previously, several pieces of code provided default values when accessing a preference that may not be present. For example:
    ```Rust
    let DBL_CLICK_TIMEOUT = Duration::from_millis(
        PREFS
            .get("dom.document.dblclick_timeout")
            .as_u64()
            .unwrap_or(300),
    );
    ```
    Fallback values don't really make sense now and I've added these defaults to `prefs.json`. Does this sound right?
4. I have kept `PrefValue::Missing`, though it doesn't seem very useful any more. An error might be more appropriate now for an incorrect preference key. I've kept this partly because [`webdriver_server` uses it](https://github.com/servo/servo/blob/master/components/webdriver_server/lib.rs#L224).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22923)
<!-- Reviewable:end -->
2019-03-20 14:33:37 -04:00
bors-servo
43cc2a0224
Auto merge of #23029 - KwanEsq:insertRuleNoIndex, r=SimonSapin
Update StyleSheet.insertRule WebIDL to make index optional.

Update wpt metadata to show the new passes.
Add one test as crashing since currently passing an \@import rule to insertRule
leads to "Expected a stylesheet loader for \@import"

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23025
- [x] There are tests for these changes
- [x] ./mach test-wpt css/cssom passes with these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23029)
<!-- Reviewable:end -->
2019-03-20 13:04:13 -04:00