Mirrors/servo
1
0
Fork 0
mirror of https://github.com/servo/servo.git synced 2025-08-07 14:35:33 +01:00
Code Issues Projects Releases Packages Wiki Activity
12164 commits 161 branches 5 tags 1.6 GiB
Commit graph

12164 commits

This branch
This branch
All branches
Author SHA1 Message Date
Anthony Ramine
275907f256 Remove dead code that surfaced when moved outside helper trait 2015-08-27 16:59:03 +02:00
Anthony Ramine
c831c2c0a5 Remove helper traits 
Now that JSRef<T> is gone, there is no need to have helper traits.

On components/script/*.rs:

    # Remove imports.
    /^ *use dom::[a-z]+::\{.*Helpers/ {
        s/\{(Raw[^L]|[^L][^a])[a-zA-Z]+Helpers, /\{/
        s/, (Raw[^L]|[^L][^a])[a-zA-Z]+Helpers([,}])/\2/g
        s/\{([a-zA-Z]+)\}/\1/
        /\{\}/d
        s/::self;$/;/
    }
    /^ *use dom::[a-z]+::\{?(Raw[^L]|[^L][^a])[a-zA-Z]+Helpers\}?;$/d

On components/script/dom/*.rs:

    # Ignore layout things.
    /^(pub )?(impl|trait).*Layout.* \{/,/^}$/ { P; D; }

    # Delete helpers traits.
    /^(pub )?trait ([^L][^ ]|L[^a])[^ ]+Helpers(<'a>)? \{$/,/^\}$/D

    # Patch private helpers.
    /^impl.*Private.*Helpers/,/^\}$/ {
        s/^impl<'a> Private([^L][^ ]|L[^a])[^ ]+Helpers(<'a>)? for &'a ([^ ]+) \{$/impl \3 {/
        /^ *(unsafe )?fn .*\(self.*[<&]'a/ {
            s/&'a /\&/g
            s/<'a, /</g
        }
        /^ *(unsafe )?fn /s/\(self([,)])/\(\&self\1/
    }

    # Patch public helpers.
    /^impl.*Helpers/,/^\}$/ {
        s/^impl(<'a>)? ([^L][^ ]|L[^a])[^ ]+Helpers(<'a>)? for (&'a )?([^ ]+) \{$/impl \5 {/
        /^ *(unsafe )?fn .*\(self.*[<&]'a/ {
            s/&'a /\&/g
            s/<'a, /</g
        }
        /^ *(unsafe )?fn .*\(&?self[,)]/s/(unsafe )?fn/pub &/
        /^ *pub (unsafe )?fn /s/\(self([,)])/\(\&self\1/
    }

The few error cases were then fixed by hand.
 2015-08-27 16:59:02 +02:00
bors-servo
1384ff5e9f Auto merge of #7406 - servo:update-css, r=Ms2ger 
Update CSS tests to revision 2a5740eaf7fa99181681a89bc6789dbf5b839995



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7406)
<!-- Reviewable:end -->
 2015-08-27 05:36:24 -06:00
Ms2ger
5fb39b2af9 Update CSS tests to revision 2a5740eaf7fa99181681a89bc6789dbf5b839995 2015-08-27 13:35:08 +02:00
bors-servo
532fd19d69 Auto merge of #7361 - jxs:master, r=Ms2ger 
make dom_struct derive HeapSizeOf

closes #7357

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7361)
<!-- Reviewable:end -->
 2015-08-27 02:35:45 -06:00
bors-servo
a897795dab Auto merge of #7387 - Yoric:2240-2, r=Ms2ger 
Fixes #2240 - NamedGetter and NamedSetter do not assume that the arg is named `name`

I'm not totally sure about how to test this.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7387)
<!-- Reviewable:end -->
 2015-08-27 00:38:46 -06:00
bors-servo
98728a6c75 Auto merge of #7395 - Manishearth:doc-inherit, r=nox 
Document InheritTypes



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7395)
<!-- Reviewable:end -->
 2015-08-26 20:56:02 -06:00
bors-servo
7a6d8a30d3 Auto merge of #7403 - jxs:delete_get_unsound_ref_forever, r=nox 
Remove get_unsound_ref_forever function

closes #7383

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7403)
<!-- Reviewable:end -->
 2015-08-26 18:37:58 -06:00
João Oliveira
8d86f89f63 Remove get_unsound_ref_forever function 
closes #7383
 2015-08-27 01:36:43 +01:00
João Oliveira
fd87c8cb3e make dom_struct derive HeapSizeOf, 
closes #7357
 2015-08-27 01:17:48 +01:00
Manish Goregaokar
4ee5b664c2 Document InheritTypes 2015-08-27 04:35:50 +05:30
bors-servo
af4c3901d8 Auto merge of #7399 - frewsxcv:document.all-tracking-issue, r=jdm 
Mention tracking issue for implementing document.all



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7399)
<!-- Reviewable:end -->
 2015-08-26 16:43:18 -06:00
Corey Farwell
6650636063 Mention tracking issue for implementing document.all 2015-08-26 18:19:26 -04:00
bors-servo
48945b0fc1 Auto merge of #7397 - Manishearth:doublepointer-meet-fire, r=nox 
Remove doublepointer in VirtualMethods, and from_borrowed_ref



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7397)
<!-- Reviewable:end -->
 2015-08-26 15:01:12 -06:00
Manish Goregaokar
4678ec16bb remove to_borrowed_ref, fix Activatable 2015-08-27 02:27:42 +05:30
Manish Goregaokar
b33c5427bc Remove doublepointer in VirtualMethods, and from_borrowed_ref 
Most of the heavy lifting done by:

```
$ ls *rs | xargs gawk -i inplace '/let .*: &&.*from_borrowed_ref/{sub("&&", "\\&");sub("_borrowed_","_");} {print $0}'
$ ls *rs | xargs gawk -i inplace "/impl.*VirtualMethods/{in_vm=1; sub(/<'a>/,\"\");sub(/&'a /,\"\")} /^}\$/{in_vm=0;} in_vm{\$0=gensub(/\\*self([^.])/,\"self\\\1\",\"g\"); sub(/from_borrowed_ref/,\"from_ref\")} {print}"
```
 2015-08-27 02:14:48 +05:30
bors-servo
fa5ad1c6b4 Auto merge of #7392 - mrobinson:layered-separate, r=pcwalton 
Split out layered child stacking contexts in display lists

This patch is in preparation for more dynamic layerization of the
pieces of display lists. It also prevents having to sort the children
by z-index multiple times.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7392)
<!-- Reviewable:end -->
 2015-08-26 11:38:34 -06:00
Martin Robinson
1c09b1d8aa Split out layered child stacking contexts in display lists 
This patch is in preparation for more dynamic layerization of the
pieces of display lists. It also prevents having to sort the children
by z-index multiple times.
 2015-08-26 10:20:28 -07:00
bors-servo
98d9203d1c Auto merge of #7032 - Yoric:issue-7031, r=jdm 
Issue 7031



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7032)
<!-- Reviewable:end -->
 2015-08-26 09:34:42 -06:00
David Rajchenbach-Teller
d3ab0c2909 Fixes #2240 - NamedGetter and NamedSetter do not assume that the argument is named name 2015-08-26 16:58:39 +02:00
bors-servo
0e78815242 Auto merge of #7386 - Ms2ger:emitter, r=jdm 
Remove Emitter::markers.

The vector is filled in and immediately emptied again. It is clearer to
keep the vector in the caller instead.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7386)
<!-- Reviewable:end -->
 2015-08-26 08:52:16 -06:00
David Rajchenbach-Teller
ec9502b0de Resolves #7031 - Fix warnings in ./mach test-ref 2015-08-26 16:37:50 +02:00
Ms2ger
18b9532b25 Remove Emitter::markers. 
The vector is filled in and immediately emptied again. It is clearer to
keep the vector in the caller instead.
 2015-08-26 16:19:01 +02:00
bors-servo
186c1d14d5 Auto merge of #6880 - dzbarsky:rAF, r=jdm 
Don't try to unwrap the result of requestAnimationFrame callback



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6880)
<!-- Reviewable:end -->
 2015-08-26 08:13:11 -06:00
bors-servo
9e52dd8cee Auto merge of #7378 - Ms2ger:url, r=SimonSapin 
Update url.



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7378)
<!-- Reviewable:end -->
 2015-08-26 07:18:34 -06:00
bors-servo
5f9097c0b4 Auto merge of #7368 - mbrubeck:closed, r=jdm 
Quit when the glutin window closes

Fixes a regression from #7096.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7368)
<!-- Reviewable:end -->
 2015-08-26 06:32:27 -06:00
bors-servo
78d72f6a9b Auto merge of #7352 - saratang:issue_7347, r=Ms2ger 
BinaryOrPlaintextClassifier::classify_impl does not need to return Option

Fixes for Issue #7347, though I wasn't sure how to test my code afterwards.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7352)
<!-- Reviewable:end -->
 2015-08-26 05:53:38 -06:00
bors-servo
06ba2167ba Auto merge of #7360 - wilmoz:ErgonomicSignature, r=Ms2ger 
Make handle_potential_webgl_error more ergonomic

https://github.com/servo/servo/issues/7358

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7360)
<!-- Reviewable:end -->
 2015-08-26 05:21:42 -06:00
Ms2ger
d75ba49034 Update url. 2015-08-26 13:17:45 +02:00
bors-servo
e1122313f9 Auto merge of #7376 - servo:wpt_20150826, r=Ms2ger 
Update web-platform-tests to revision acd60f9e55532f03fc905e61591b7fd7db2f08d1



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7376)
<!-- Reviewable:end -->
 2015-08-26 04:19:24 -06:00
Ms2ger
be4f0ad8de Update web-platform-tests to revision acd60f9e55532f03fc905e61591b7fd7db2f08d1 2015-08-26 12:14:08 +02:00
bors-servo
def249b67a Auto merge of #7371 - frewsxcv:enable-ref-test, r=SimonSapin 
Enable commented out inline_text_align_* ref test

At some point this test did not work, but now it does

Closes #1575

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7371)
<!-- Reviewable:end -->
 2015-08-26 03:20:58 -06:00
Corey Farwell
574e11d70a Enable commented out inline_text_align_* ref test 
At some point this test did not work, but now it does

Closes #1575
 2015-08-25 23:25:23 -04:00
bors-servo
a1cd27e6a3 Auto merge of #7369 - pcwalton:relative-layer-overflow, r=glennw 
layout: Fix calculation of overflow for stacking contexts that contain `position: relative` fragments.

Fixes placement of the header on espn.go.com.

r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7369)
<!-- Reviewable:end -->
 2015-08-25 17:16:34 -06:00
Patrick Walton
5c51a6214e layout: Fix calculation of overflow for stacking contexts that contain 
`position: relative` fragments.

Fixes placement of the header on espn.go.com.
 2015-08-25 15:08:28 -07:00
Matt Brubeck
54e8374b6c Quit when the glutin window closes 2015-08-25 13:32:35 -07:00
bors-servo
ab55e3ec10 Auto merge of #7364 - aweinstock314:update-clipboard-20140825, r=jdm 
Update rust-clipboard to a version that works on Windows and Mac.

Possibly completes #5376.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7364)
<!-- Reviewable:end -->
 2015-08-25 13:59:45 -06:00
Avi Weinstock
09a20bb0a5 Update rust-clipboard to a version that works on Windows and Mac. 2015-08-25 15:29:29 -04:00
wilmoz
363183d12a Make handle_potential_webgl_error more ergonomic 2015-08-25 13:04:55 -05:00
bors-servo
121110a52a Auto merge of #7362 - wilmoz:ForbidMultilineImports, r=jdm 
Forbid multiline imports

https://github.com/servo/servo/issues/7356
 2015-08-25 11:29:56 -06:00
wilmoz
63851f2650 Forbid multiline imports 2015-08-25 12:27:42 -05:00
bors-servo
f79220f1a8 Auto merge of #7355 - servo:iframe_size_attributes_vertical_writing_mode, r=pcwalton 
Refactor tests/ref/iframe/size_attributes_vertical_writing_mode.html

… to not use an arbitrary 104px offset that just happens to match the reference and relies on incorrect behavior.

See discussion in #7313.

r? @pcwalton

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7355)
<!-- Reviewable:end -->
 2015-08-25 10:04:39 -06:00
bors-servo
a109a333f1 Auto merge of #6770 - ecoal95:webgl-again, r=jdm 
Add multiple WebGL calls and improve error detection

Since it probably won't merge until multiprocess lands, I plan to use this PR to keep improving WebGL support until it can land.

Main TODOs are integration of tests, since it seems https://github.com/KhronosGroup/WebGL/issues/1105 is going nowhere, adding missing calls and proper painting via native surfaces instead of readback.

I can't resolve conflicts right now because of time but I will do it soon.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6770)
<!-- Reviewable:end -->
 2015-08-25 09:23:00 -06:00
ecoal95
6341c77700 webgl: Implement multiple calls and improve error detection 
This commit implements WebGL's:
 * cullFace
 * frontFace
 * enable
 * disable
 * depthMask
 * colorMask
 * clearDepth
 * clearStencil
 * depthFunc
 * depthRange
 * hint
 * lineWidth
 * pixelStorei
 * polygonOffset
 * texParameteri
 * texParameterf
 * texImage2D (partially)

It inlines a lot of OpenGL calls to keep the file
`components/canvas/webgl_paint_task.rs` as small as possible while
keeping readability.

It also improves error detection on previous calls, and sets node damage
on the canvas in the drawing calls.

It adds a `TexImage2D` reftest, even though it's not enabled because:
 * WebGL paints the image when it loads (asynchronously), so the reftest doesn't wait for it and it finishes early
 * If we change the source for the base64 src of the image it works as expected in non-headless mode, but the test harness locks
 2015-08-25 17:16:46 +02:00
ecoal95
af3310f149 Update gleam to 0.1.9 2015-08-25 17:16:46 +02:00
bors-servo
4d0b4a7b8c Auto merge of #7359 - servo:build, r=jdm 
Fix the build.
 2015-08-25 08:34:13 -06:00
Ms2ger
13086abfdc Check the return code of cargo build (except on Android). 2015-08-25 16:32:51 +02:00
Ms2ger
bd53792269 Fix the CEF build. 2015-08-25 16:31:58 +02:00
Simon Sapin
97f71bb257 Refactor tests/ref/iframe/size_attributes_vertical_writing_mode.html 
… to not use an arbitrary 104px offset that just happens to match the reference
and relies on incorrect behavior.
 2015-08-25 12:39:49 +02:00
Sara Tang
8c39e968cd Fixed mismatched type error 2015-08-24 23:11:31 -04:00