Commit graph

34802 commits

Author SHA1 Message Date
bors-servo
2bc086762e
Auto merge of #21946 - emilio:remove-inherits-all, r=nox
style: Stop using PseudoElement::inherits_all.

This was done that way just because Servo didn't support the `all` property at
the time.

We should do it this way and optimize it if it's slow. Though I suspect that
most of stuff doesn't actually need to be inherited, my patch at bug 1498943
should make it much faster than what it would otherwise be.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21946)
<!-- Reviewable:end -->
2018-10-15 09:53:26 -04:00
bors-servo
d22b10391d
Auto merge of #21945 - codehag:devtools-add-emulation-actor, r=jdm
DevTools - add Emulation Actor

Last one for today, this one adds the Emulation actor, which allows the netmonitor panel to load. The emulation actor has no methods for now, but will eventually be used by the netmonitor to throttle connections.

Currently the netmonitor shows but doesn't have any values. will get to that soon!

<img width="901" alt="screen shot 2018-10-14 at 19 26 16" src="https://user-images.githubusercontent.com/26968615/46920018-30a0b180-cfe8-11e8-83ec-51ca71f0e8c3.png">

Combined with the changes for the stylesheets actor, the device actor, and the extra methods added in browserContext and threadActor, the devtools are now all loading \o/

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21945)
<!-- Reviewable:end -->
2018-10-15 03:33:03 -04:00
codehag
9ccf7c0a57 DevTools - add Emulation Actor 2018-10-15 08:48:30 +02:00
Emilio Cobos Álvarez
6d7d1e5691
style: Remove useless declarations in servo.css.
Margin is a reset property, there's no point in setting it to zero since it's
zero by default.
2018-10-15 02:17:03 +02:00
Emilio Cobos Álvarez
7ed3995725
style: Stop using PseudoElement::inherits_all.
This was done that way just because Servo didn't support the `all` property at
the time.

We should do it this way and optimize it if it's slow. Though I suspect that
most of stuff doesn't actually need to be inherited, my patch at bug 1498943
should make it much faster than what it would otherwise be.
2018-10-15 02:17:03 +02:00
bors-servo
5327758b9b
Auto merge of #21944 - codehag:devtools-add-thread-interrupt, r=jdm
DevTools - add Interrupt method to ThreadActor

This is one of three pull requests that allows the DevTools Debugger to render.

The two related prs are #21942 and #21943

In this pr, I introduced the `interrupt` method to the threadActor. This is arguably a carry-over from the firefox devtools, where the debugger server is running in the same event loop as the content scripts, and it can only update itself when the debugger server is paused. Depending on how debugging is, or how debugging will be implemented on servo, this method may need to be adjusted for "debugger events" and "script events".

After all three patches on this topic are merged, you should be able to see the debugger \o/ (but no sources yet)

<img width="900" alt="screen shot 2018-10-14 at 16 57 07" src="https://user-images.githubusercontent.com/26968615/46918408-35f30180-cfd2-11e8-9a98-8e1540adc894.png">

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21944)
<!-- Reviewable:end -->
2018-10-14 16:14:40 -04:00
bors-servo
4dcd1e71fa
Auto merge of #21943 - codehag:devtools-add-list-workers-method, r=jdm
DevTools - add ListWorkers method to BrowsingContextTargetActor

This is one of three pull requests that allows the DevTools Debugger to render.

The two related prs are #21942 and #21944

This pr introduces a `ListWorkers` method, which the debugger relies on for startup. At the moment, we are returning an empty array, but later on we can return an array populated by all workers associated with a target.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21943)
<!-- Reviewable:end -->
2018-10-14 15:07:01 -04:00
bors-servo
a59bcd6749
Auto merge of #21942 - codehag:devtools-add-device-actor, r=jdm
DevTools - add DeviceActor and update Root to own global actors

This is one of three pull requests that allows the DevTools Debugger to render. This pr also introduces global actors to the root actor, the same as exists in FF devtools. At a later point I would like to reorganize this.

The two related prs are #21943 and #21944

This is the most significant change of the three. It introduces both Device and Performance as global actors, and leaves the Performance actor also as a target actor. It also introduces the concept of ownership to the root actor, with regards to the two Global Actors.

The Device actor as added to allow the JS Debugger to start up. This required the DeviceActor's `getDescription` method. `getDescription`, in the case of servo, returns a couple of basic fields that the debugger is interested in but doesn't use, specifically `apptype` -- which is returning a fake value of `servo`, and the version number `63.0`.

The version number is interesting because devtools has [dropped support for any versions below 2 version numbers from the current firefox](https://searchfox.org/mozilla-central/rev/3a54520d8d2319a4116866371ed3d9ed2ec0cc2b/devtools/client/debugger/new/src/client/firefox/commands.js#398).

This means that if we want the servo server to be supported, we will need to keep this number synced with FF's versioning. It isn't great, but hopefully we can introduce a different approach later on.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21942)
<!-- Reviewable:end -->
2018-10-14 14:17:51 -04:00
codehag
61d31a5494 fix lint issues 2018-10-14 19:31:26 +02:00
bors-servo
f3533b4c78
Auto merge of #21941 - codehag:devtools-add-stylesheets-actor, r=jdm
DevTools - add preliminary StyleSheetActor

Based on an error coming from devtools, that the server did not support a stylesheets actor, this patch introduces a [StyleSheetsActor](https://searchfox.org/mozilla-central/rev/26b40a44691e0710838130b614c2f2662bc91eec/devtools/server/actors/stylesheets.js#590-853). It has no methods yet, but it is a small step towards getting the devtools up and running.

Before the change:
No stylesheet editor

After the change we can see that the style editor now loads. It has no information but I will get to that later.
<img width="902" alt="screen shot 2018-10-14 at 12 51 51" src="https://user-images.githubusercontent.com/26968615/46915813-61192900-cfb1-11e8-8382-3d9dc8db4114.png">

Status after this PR:
* Debugger does not load
* Netmonitor does not load
* Console is loading but doesn't receive messages.
* Inspector is, but does not have any information
* style editor is *now loading* but does not have any information
* Performance is an out of date tab, and will likely need to be changed substantially

next steps for this will be to implement the [protocol methods](https://searchfox.org/mozilla-central/source/devtools/shared/specs/stylesheets.js#74-95)

I am not too sure how to test this, it doesn't look like there are tests yet for the devtools, is that right?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21941)
<!-- Reviewable:end -->
2018-10-14 11:13:44 -04:00
codehag
8d738f6499 remove any fields that are not totally necessary 2018-10-14 17:04:33 +02:00
codehag
74e44078d7 DevTools - add Interrupt method to ThreadActor 2018-10-14 16:40:33 +02:00
codehag
a424ba9b2d DevTools - add ListWorkers method to BrowsingContextTargetActor 2018-10-14 16:40:01 +02:00
codehag
5c8492d760 DevTools - add DeviceActor and update Root to own global actors 2018-10-14 16:39:20 +02:00
codehag
c88cc3e966 DevTools - add preliminary StyleSheetActor 2018-10-14 16:33:24 +02:00
bors-servo
cdd7f0a658
Auto merge of #21940 - servo-wpt-sync:wpt_update_13-10-2018, r=jdm
Sync WPT with upstream (13-10-2018)

Automated downstream sync of changes from upstream as of 13-10-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21940)
<!-- Reviewable:end -->
2018-10-14 08:35:47 -04:00
WPT Sync Bot
81f079c722 Update web-platform-tests to revision 74d709131e3c91d09f1708378648a01957c47b38 2018-10-13 23:47:44 -04:00
bors-servo
e4657c1496
Auto merge of #21931 - jdm:reload-images, r=emilio
Make layout use available image data before querying the image cache.

These changes make layout more efficient for any page which contains images that have already loaded, since it does not require synchronously querying the image cache thread for each image present. It also makes reloading a page actually display the images that are already in the image cache.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21919
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21931)
<!-- Reviewable:end -->
2018-10-13 07:56:11 -04:00
bors-servo
42ca43e51f
Auto merge of #21928 - servo-wpt-sync:wpt_update_11-10-2018, r=jdm
Sync WPT with upstream (11-10-2018)

Automated downstream sync of changes from upstream as of 11-10-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21928)
<!-- Reviewable:end -->
2018-10-12 23:12:27 -04:00
bors-servo
a9eaed44d5
Auto merge of #21927 - Eijebong:unicode_serialization, r=jdm
Remove Origin::unicode_serialization

Fixes #20701

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21927)
<!-- Reviewable:end -->
2018-10-12 21:57:34 -04:00
Josh Matthews
49d2ea4f74 Make layout use available image data before querying the image cache. 2018-10-12 21:55:09 -04:00
bors-servo
8902a26721
Auto merge of #21898 - servo:jdm-patch-39, r=SimonSapin
Skip css-text i18n tests.

#21795 is becoming ridiculous and shows no sign of stopping.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21898)
<!-- Reviewable:end -->
2018-10-12 16:58:30 -04:00
bors-servo
fa94fc7146
Auto merge of #21922 - Eijebong:storage, r=SimonSapin
Add support for StorageEvent.initstorageevent()

Fixes #21874

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21922)
<!-- Reviewable:end -->
2018-10-12 14:16:07 -04:00
bors-servo
7e78edcff9
Auto merge of #21725 - pyfisch:update-wr, r=jdm
Update Webrender

New version is
9156a4465f6ad715a0206cdd9a7e9a6f0385fbd6

---

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because just updating WR

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21725)
<!-- Reviewable:end -->
2018-10-12 12:49:23 -04:00
bors-servo
69e5243810
Auto merge of #21856 - zcorpan:zcorpan/remove-td-th-interfaces, r=jdm
Remove the HTMLTable{Header,Data}CellElement interfaces

Fixes #17222.

<!-- Please describe your changes on the following line: -->
This removes the `HTMLTableHeaderCellElement` and `HTMLTableDataCellElement` interfaces and uses the `HTMLTableCellElement` interface for both `th` and `td` elements, as per the spec.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #17222.

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21856)
<!-- Reviewable:end -->
2018-10-12 09:30:41 -04:00
bors-servo
2d8cef30fa
Auto merge of #21921 - servo:jdm-patch-6-1, r=gw3583
Use a depth buffer when embedding Servo on android.

Webrender uses the z-buffer but does not check that it's present. We need to provide one for pages to render correctly.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21807
- [x] These changes do not require tests because there are no automated tests for embedding Servo in Firefox Reality.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21921)
<!-- Reviewable:end -->
2018-10-12 08:15:23 -04:00
bors-servo
5f463d3c97
Auto merge of #21911 - servo:webgl, r=jdm
Simplify ctx.drawImage a bit

There is no need to swap between RGBA and BGRA twice.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21911)
<!-- Reviewable:end -->
2018-10-12 04:45:11 -04:00
Bastien Orivel
a97ba4f57d Remove Origin::unicode_serialization
Fixes #20701
2018-10-12 10:25:03 +02:00
Simon Pieters
5a3e4b3749 More test expectations 2018-10-12 10:14:20 +02:00
WPT Sync Bot
4cf0a092d0 Update web-platform-tests to revision d647a1bc742a533186d8297cae2a2bee669c7780 2018-10-11 23:44:24 -04:00
bors-servo
79f0291924
Auto merge of #21912 - servo:lighter-bootstrap, r=jdm
Add `--build` and `--emulator-x86` to `./mach bootstrap-android`

This allows not downloading dependencies that are not needed for a particular task.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21912)
<!-- Reviewable:end -->
2018-10-11 23:15:38 -04:00
Josh Matthews
4e5b3bcf15 Fix windows build errors. 2018-10-11 22:34:33 -04:00
bors-servo
bf192caf4b
Auto merge of #21910 - ferjm:audiobuffer.shared.fix, r=Manishearth
Allow reusing AudioBuffers

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21887
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21910)
<!-- Reviewable:end -->
2018-10-11 17:46:15 -04:00
Manish Goregaokar
b7e9aeb4ac Update servo-media to include DestinationNode fix 2018-10-11 14:38:14 -07:00
Manish Goregaokar
40641ac8a4 More accurate names for .started and .stopped 2018-10-11 14:28:05 -07:00
Bastien Orivel
5347e25d1a Add support for StorageEvent.initstorageevent()
Fixes #21874
2018-10-11 22:17:46 +02:00
Josh Matthews
03a75f418e
Use a depth buffer when embedding Servo on android. 2018-10-11 16:07:58 -04:00
bors-servo
7b464ab75d
Auto merge of #21918 - servo:cache-gradle, r=jdm
Taskcluster: cache ~/.gradle

This is where are kept files whose downloads sometimes fail, so downloading less often will reduce the impact of those failures.

```
> Could not get resource 'https://jcenter.bintray.com/com/android/tools/build/gradle/3.1.3/gradle-3.1.3.pom'.
   > Could not GET 'https://jcenter.bintray.com/com/android/tools/build/gradle/3.1.3/gradle-3.1.3.pom'.
      > Read timed out
```

https://tools.taskcluster.net/groups/PGuIkH5QQmqghZozhVtmoQ/tasks/CBa6IbLmQJqYgoswRn-hiw/runs/0/logs/public%2Flogs%2Flive.log#L3411

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21918)
<!-- Reviewable:end -->
2018-10-11 14:06:04 -04:00
Fernando Jiménez Moreno
afb824e09c Regenerate WebAudio WPTs expectations 2018-10-11 19:33:17 +02:00
Fernando Jiménez Moreno
52d898df3f Add test to check that AudioBuffers can be reused between AudioBufferSourceNodes 2018-10-11 19:27:22 +02:00
Fernando Jiménez Moreno
091ad49d68 Allow reusing AudioBuffers 2018-10-11 19:27:21 +02:00
Simon Sapin
f0d8e8af49 Reduce log spam when running sdkmanager 2018-10-11 19:11:32 +02:00
Simon Sapin
60eff32c9b Taskcluster: cache ~/.gradle
This is where are kept files whose downloads sometimes fail, so downloading less often will reduce the impact of those failures.

```
> Could not get resource 'https://jcenter.bintray.com/com/android/tools/build/gradle/3.1.3/gradle-3.1.3.pom'.
   > Could not GET 'https://jcenter.bintray.com/com/android/tools/build/gradle/3.1.3/gradle-3.1.3.pom'.
      > Read timed out
```

https://tools.taskcluster.net/groups/PGuIkH5QQmqghZozhVtmoQ/tasks/CBa6IbLmQJqYgoswRn-hiw/runs/0/logs/public%2Flogs%2Flive.log#L3411
2018-10-11 18:54:31 +02:00
Simon Sapin
960cb50ffd Taskcluster: use servo-* cache names 2018-10-11 18:31:37 +02:00
Simon Pieters
806db5e47b Update test expectations 2018-10-11 18:19:06 +02:00
Manish Goregaokar
3c6e99498c Update servo-media 2018-10-11 09:01:38 -07:00
bors-servo
61fe737885
Auto merge of #21904 - Manishearth:gst-readme, r=jdm
Remove gst-plugins-ugly dep from README

We don't use it and shouldn't be using it because of the license

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21904)
<!-- Reviewable:end -->
2018-10-11 10:18:13 -04:00
Simon Sapin
6c82c471c5 Add --accept-all-licences to ./mach bootstrap-android 2018-10-11 16:08:41 +02:00
Anthony Ramine
bb2101f540 Simplify ctx.drawImage a bit
There is no need to swap between RGBA and BGRA twice.
2018-10-11 15:46:42 +02:00
Simon Sapin
89e1878bd6 Add --build and --emulator-x86 to ./mach bootstrap-android
This allows not downloading dependencies that are not needed for a praticular task.
2018-10-11 15:24:57 +02:00