Commit graph

3424 commits

Author SHA1 Message Date
Daniel Robertson
2d9d31ee04
Add style property for flex-basis
Add the style property for flex-basis. The property should allow all
values acceptable for `width`|`height` with the addition of `content`.
2016-04-24 14:04:40 -04:00
bors-servo
e12fc2a6f7 Auto merge of #10769 - saneyuki:keyevents, r=frewsxcv
Drop support for keyevents in Document::createEvent

Fix #10735

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10769)
<!-- Reviewable:end -->
2016-04-22 15:56:49 -07:00
bors-servo
8163347e34 Auto merge of #10762 - canaltinova:has_attributes, r=nox
Implement Element::hasAttributes

Fixes #10748 .
Implement Element::hasAttributes. I'm not sure if tests are enough. I'm open to suggestion :)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10762)
<!-- Reviewable:end -->
2016-04-22 15:11:20 -07:00
bors-servo
47a0f58f98 Auto merge of #10654 - notriddle:no_resize_on_initial_load, r=asajeffrey
compositing/script: Do not dispatch the resize event when initially l…

…oading.

No bug report corresponds to this, but I noticed it while trying to
reduce #10593

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10654)
<!-- Reviewable:end -->
2016-04-22 14:25:51 -07:00
Michael Howell
7940b22158 compositing/script: Do not dispatch the resize event when initially loading.
No bug report corresponds to this, but I noticed it while trying to
reduce #10593
2016-04-22 13:36:43 -07:00
bors-servo
82938547ed Auto merge of #10757 - ineol:root-node, r=Ms2ger
Implement Node::rootNode

Fixes #10747.

I don't know whether it's OK to recurse up the tree, though it is a tail call.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10757)
<!-- Reviewable:end -->
2016-04-22 12:10:52 -07:00
bors-servo
f1defb446e Auto merge of #10443 - emilio:webgl-teximage2d-overload, r=jdm
webgl: Implement the pending texImage2D overload, and add more validation

This is a large-ish refactor of the Texture2D code, but it should be
easier to read and of course more correct.

I tried to annotate every error condition with a spec paragraph.

I made just a reftest to ensure this works as intended, since I expect #10373 to land pretty soon.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10443)
<!-- Reviewable:end -->
2016-04-22 11:25:29 -07:00
bors-servo
d926b5d376 Auto merge of #10751 - zwn:tidy-start-operator, r=Wafflespeanut
Report lines starting with && in tidy

Partial implementation of the issue #10692 (the easy part).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10751)
<!-- Reviewable:end -->
2016-04-22 10:40:06 -07:00
bors-servo
4da6855e23 Auto merge of #10651 - craftytrickster:10601/current-color, r=Ms2ger
Setting current color to black if canvas is not rendered in document

Fixes #10601

The change seems deceptively easy, I hope I am not missing anything...

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10651)
<!-- Reviewable:end -->
2016-04-22 09:26:51 -07:00
David Raifaizen
b5159dc7ff Setting current color to black if canvas is not rendered in document 2016-04-22 09:59:49 -04:00
Zbynek Winkler
924d804583 Move '&&' to the end of the previous line.
Following https://github.com/servo/servo/issues/10692 this is just a
formating change to satisfy a new tidy requirement of not having '&&' at
the beginning of a line.
2016-04-22 14:28:18 +02:00
Nazım Can Altınova
47f43d45a7 Implement Element::hasAttributes 2016-04-22 15:18:08 +03:00
Léo Stefanesco
00b3f7930e Implement Node::rootNode 2016-04-22 13:18:50 +02:00
bors-servo
dff217c2e3 Auto merge of #10723 - edunham:modelines, r=Wafflespeanut
Remove some Emacs & Vim modelines

This might be a bad idea, especially on the webidl side. However, we started talking about the idea that modelines are a lint error (https://github.com/servo/servo/issues/10719), and these changes would be required before enabling a modeline lint.

If it bitrots, it's easy to recreate with
```
find * -type f -exec sed '/- Mode:/d' -i {} +
find * -type f -exec sed '/ vim:/d' -i {} +
git checkout -- python/tidy/servo_tidy/tidy.py
git checkout -- python/tidy/servo_tidy_tests/spec.webidl
git commit -a
```

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10723)
<!-- Reviewable:end -->
2016-04-21 20:05:04 -07:00
bors-servo
7e370c4df4 Auto merge of #10710 - Ms2ger:js, r=nox
Update js.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10710)
<!-- Reviewable:end -->
2016-04-21 15:41:44 +05:30
Tetsuharu OHZEKI
b4cf3b802e Drop support for keyevents in Document::createEvent 2016-04-21 11:04:00 +09:00
Emilio Cobos Álvarez
f6f1e37b29
webgl: Fix a few typos in comments 2016-04-20 20:30:05 +02:00
Emilio Cobos Álvarez
d152c7fe88
webgl: texture: Make initialize only mark as initialized the current face
Also refactor a bit the code, and remove the unused `is_initialized`
flag.
2016-04-20 20:27:37 +02:00
Emilio Cobos Álvarez
21e2f97cfa
webgl: Fix filling a non-zero level
You can fill a level > 0 as long as the width and height values are
power of two, so the previous test was bogus.
2016-04-20 20:24:56 +02:00
edunham
7ae63b1213 Remove modelines everywhere but tests/wpt 2016-04-20 10:49:09 -07:00
Emilio Cobos Álvarez
1ad7f73caf
webgl: Reset bound buffer when appropiate in BufferData
This makes the test bufferDataBadArgs pass appropiately.
2016-04-20 19:22:05 +02:00
bors-servo
f051028ee8 Auto merge of #9942 - jdm:load_error, r=ms2ger
Moving the error handling out of network loader

Rebase of #8851. Fixes #8678. Fixes #9944.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9942)
<!-- Reviewable:end -->
2016-04-20 22:19:22 +05:30
Ravi Shankar
5e6f32a59b Propagating the load errors from network loader 2016-04-20 12:38:35 -04:00
bors-servo
89b276c889 Auto merge of #10750 - servo:num, r=nox
Use num's constituent crates.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10750)
<!-- Reviewable:end -->
2016-04-20 20:40:24 +05:30
Ms2ger
03d4bacc05 Use num-traits in script. 2016-04-20 15:23:43 +02:00
bors-servo
8d988f20c1 Auto merge of #9968 - izgzhen:scroll, r=asajeffrey
Implement scroll, scrollLeft, scrollTop and friends, addressing issue #9650

This is a work in progress to solve https://github.com/servo/servo/issues/9650. Thanks a lot for helping the review.

- [x] scroll
- [x] scrollTo
- [x] scrollBy
- [x] scrollTop (setter and getter)
- [x] scrollLeft (setter and getter)

The setters will be implemented in another PR after this is merged.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9968)
<!-- Reviewable:end -->
2016-04-20 18:40:26 +05:30
Ms2ger
12b922b67f Update js. 2016-04-20 11:44:32 +02:00
zakorgyula
95bebb9945 Remove extra definition of WHITESPACE under components/util/str.rs 2016-04-20 10:40:57 +02:00
Zhen Zhang
11b12f677b element scroll setters 2016-04-20 08:29:17 +08:00
bors-servo
82873d688e Auto merge of #10718 - mbrubeck:trace, r=jdm
Lower the logging level of a really chatty fn

Reduces the amount of spew when running with settings like `RUST_LOG=script=debug`.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10718)
<!-- Reviewable:end -->
2016-04-20 03:36:52 +05:30
Matt Brubeck
6882ce8ec1 Lower the logging level of a really chatty fn 2016-04-19 12:16:43 -07:00
Emilio Cobos Álvarez
bc08762414
webgl: Rename UniformType to UniformSetterType and hoist to the bottom 2016-04-19 20:25:30 +02:00
bors-servo
4d5fa963fd Auto merge of #10708 - Ms2ger:warnings, r=emilio
Fix some compile warnings.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10708)
<!-- Reviewable:end -->
2016-04-19 23:35:34 +05:30
Ms2ger
5645a59e05 Fix some compile warnings. 2016-04-19 18:15:16 +02:00
bors-servo
3d4416e1b0 Auto merge of #10634 - amarant:10574-image-document-base, r=metajack
Issue #10574 Use the document base url in img

add a test with base path set to the resources path and an img with a cat and the reference directly to the image

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10634)
<!-- Reviewable:end -->
2016-04-19 20:51:18 +05:30
bors-servo
a7c885706e Auto merge of #10592 - canaltinova:stylesheet_with_base, r=Ms2ger
Use the document base url when resolving stylesheets

Use the document base url when resolving stylesheets. Fixes #10575 .

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10592)
<!-- Reviewable:end -->
2016-04-19 17:20:32 +05:30
Emilio Cobos Álvarez
6a15c2f245
webgl: Remove active_uniform related validation.
It's broken for uniform arrays, since uniform.id() stops being the index
then.

We need to add a more complex integration with angle for this to ever
be correct.

Unfortunately the ANGLE part that we should touch is C++, and it has
destructors, so we need to hook destructors there, and I can't do it
right now.
2016-04-19 13:27:19 +02:00
Emilio Cobos Álvarez
f470ad0d88
webgl: Refactor WebGLProgram::link
This makes it more correct, since we don't blindly send the Link
command. It's not observable though.
2016-04-19 13:25:45 +02:00
Emilio Cobos Álvarez
c807cab300
webgl: Validate that the texture should be power of two if the level is
greater than 1
2016-04-19 13:25:44 +02:00
Emilio Cobos Álvarez
87e112dea7
webgl: Implement the pending texImage2D overload, and add more validation
This is a large-ish refactor of the Texture2D code, but it should be
easier to read and of course more correct.

I tried to annotate every error condition with a spec paragraph.
2016-04-19 13:25:40 +02:00
Zhen Zhang
fefdaf76de Implement ScrollTop and ScrollLeft getters:
Add new compositor message to get scroll_offset;
Add new layout query for computed value of overflow-x/y;
Implement layer_id method for ThreadSafeLayoutNode;
Add new layout query for layer_id;
Implement script interface for getting scrollTop and scrollLeft, as well as relavant helper functions.
2016-04-19 12:27:35 +08:00
bors-servo
82b952c03f Auto merge of #10652 - dzbarsky:reserved, r=dzbarsky
Prevent use of reserved names in BindAttribLocation

(Depend on the WebGL tests landing)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10652)
<!-- Reviewable:end -->
2016-04-19 09:46:24 +05:30
bors-servo
19a5a9ad08 Auto merge of #10508 - g-k:insert-row, r=KiChjang
Insert row

Fixes #9269

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10508)
<!-- Reviewable:end -->
2016-04-19 01:38:38 +05:30
Greg Guthe
1d59d8784d Implement HTMLTableElement.insertRow()
refs: https://github.com/servo/servo/issues/9269

and update HTMLTableElement.webidl

insertRow returns an HTMLTableRowElement and throws an IndexSizeError
sortable and stopSorting were removed.
2016-04-18 15:18:16 -04:00
Nazım Can Altınova
ffd7960ad8 Use the document base url when resolving stylesheets 2016-04-18 19:54:37 +03:00
Keith Yeung
c6b6d2c84e Avoid generating parameter names that are Rust keywords 2016-04-17 19:37:42 -04:00
David Zbarsky
a67a744057 Prevent use of reserved names in BindAttribLocation 2016-04-17 11:52:40 -07:00
bors-servo
b00c2740e3 Auto merge of #10612 - autrilla:textdir, r=emilio
Implement HTMLTextArea.setSelectionRange (continuation of #10007)

Tests on `tests/wpt/web-platform-tests/html/semantics/forms/textfieldselection/textfieldselection-setSelectionRange.html` all pass and the other tests don't panic due to double borrows anymore.

cc: @KiChjang

Fixes #9994.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10612)
<!-- Reviewable:end -->
2016-04-17 21:58:31 +05:30
Zbynek Winkler
b6dc34862a Use os.path.basename instead of split('/')[-1]
Fixes #10596.
2016-04-17 17:37:29 +02:00
Alberto Corona
5e863f2eb8
Implement HTMLTextArea.setSelectionRange 2016-04-17 17:27:26 +02:00