Commit graph

23986 commits

Author SHA1 Message Date
Fernando Jiménez Moreno
31d833f32c s/nodes_from_point/nodes_from_point_response and change test from reftest to regular test checking only the fixed crash 2017-03-02 16:59:04 +01:00
Fernando Jiménez Moreno
7426d902a3 Trigger reflow on document.elementsFromPoint 2017-03-02 10:44:38 +01:00
bors-servo
d0856fd4cd Auto merge of #15791 - emilio:hint, r=bholley
Bug 1340334: Allow sibling hints in StoredRestyleHint, and handle them correctly.

Reviewed upstream by Bobby.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15791)
<!-- Reviewable:end -->
2017-03-01 18:08:43 -08:00
Emilio Cobos Álvarez
32bf8093cc
Bug 1340334: Allow sibling hints in StoredRestyleHint, and handle them correctly. r=bholley
MozReview-Commit-ID: H6NuKsfjEdj
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-03-02 03:05:56 +01:00
bors-servo
c87524c888 Auto merge of #15779 - upsuper:shorthand, r=emilio
Don't serialize shorthand if some but not all its longhands have CSS-wide keyword

This also changes `LonghandsToSerialize` to store references to specified value directly rather than declared value, which significantly simplify many serialization code.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15779)
<!-- Reviewable:end -->
2017-03-01 16:12:36 -08:00
Xidorn Quan
4bc0fbeeb1 Impl ToCss on LonghandsToSerialize directly 2017-03-02 11:10:30 +11:00
Xidorn Quan
f327b2fc73 Make LonghandsToSerialize store reference to specified value
This significantly simplify the code.
2017-03-02 11:09:06 +11:00
Xidorn Quan
2cc6593fa1 Don't serialize shorthand when some but not all of its longhands are CSS-wide keyword
Shorthand cannot represent CSS-wide keyword in individual longhands, and
thus we cannot serialize longhand with CSS-wide keyword as part of a
shorthand.
2017-03-02 11:09:05 +11:00
Xidorn Quan
03f6d21cb5 Make DeclaredValue store CSSWideKeyword
Rather than having separate variant for each CSS-wide keyword.
2017-03-02 11:09:05 +11:00
Xidorn Quan
29fd30601e Simplify values of CSSWideKeyword 2017-03-02 11:09:05 +11:00
bors-servo
67638bdcf2 Auto merge of #15762 - glennw:basic-page-zoom, r=mbrubeck
Add support for page zoom via new WR API.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15762)
<!-- Reviewable:end -->
2017-03-01 11:53:35 -08:00
bors-servo
f0257364c2 Auto merge of #15416 - karlding:servo-15395_border_serialization, r=emilio
Fix border shorthand serialization

Fix border shorthand serialization when sides are not identical. I think I managed to get the serialization to work as expected.

I added a check to ensure that the **border-width**, **border-style** and **border-color** were the same, before performing the serialization.

I'm still a Rust newbie, so if there's a more idiomatic way of doing things (or any critiques in general), please let me know!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15395

<!-- Either: -->
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15416)
<!-- Reviewable:end -->
2017-03-01 09:50:49 -08:00
bors-servo
57ff19ec83 Auto merge of #15778 - glennw:update-wr-mbm, r=nox
Update WR (mix-blend-mode isolate support).

This makes several of the mix-blend-mode tests pass.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15778)
<!-- Reviewable:end -->
2017-03-01 00:44:00 -08:00
Glenn Watson
ade9e02e42 Update WR (mix-blend-mode isolate support).
This makes several of the mix-blend-mode tests pass.
2017-03-01 17:02:36 +10:00
Karl
ec865c3702 Fix border shorthand serialization
Fix border shorthand serialization when sides are not identical
2017-02-28 20:27:09 -05:00
bors-servo
7902842730 Auto merge of #15774 - mbrubeck:tidy, r=nox
Remove tidy exceptions for serde and syn

r? @nox
2017-02-28 16:32:42 -08:00
Matt Brubeck
49234ce2b1 Remove tidy exceptions for serde and syn 2017-02-28 15:56:42 -08:00
bors-servo
74e7afa1c8 Auto merge of #15769 - nox:die-codegen-die, r=jdm
Kill serde_codegen 💣

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15769)
<!-- Reviewable:end -->
2017-02-28 11:10:17 -08:00
Anthony Ramine
f8467a26c4 Kill serde_codegen 💣 2017-02-28 19:31:25 +01:00
bors-servo
fbfcfc2dbe Auto merge of #15766 - servo:cssparserup, r=Manishearth
Update cssparser

<!-- Please describe your changes on the following line: -->

https://github.com/servo/rust-cssparser/pull/123

In particular, `match_ignore_ascii_case` now supports the full `match` syntax.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15766)
<!-- Reviewable:end -->
2017-02-28 08:22:27 -08:00
Simon Sapin
288ef97055 Update cssparser for https://github.com/servo/rust-cssparser/pull/123 2017-02-28 17:16:36 +01:00
Simon Sapin
bcd4d166ac Fix unused warning 2017-02-28 17:16:34 +01:00
bors-servo
7ee6294922 Auto merge of #15761 - upsuper:shorthand, r=Manishearth
Have shorthand parsing functions not return Option for their longhands

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15761)
<!-- Reviewable:end -->
2017-02-27 23:08:33 -08:00
Xidorn Quan
e850d9572a Don't serialize currentcolor for border shorthand 2017-02-28 17:17:54 +11:00
Glenn Watson
fc349b4a4f Add support for page zoom via new WR API. 2017-02-28 15:54:09 +10:00
bors-servo
b8b23fda5f Auto merge of #15760 - glennw:update-wr-deps, r=jdm
Update WR (mostly dep updates, clip-scroll work).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15760)
<!-- Reviewable:end -->
2017-02-27 20:40:00 -08:00
Xidorn Quan
f33b0b4ea3 Have shorthand parsing functions return values
Shorthands are responsible to set all its longhands to a proper value,
rather than returning None.

Fixes #15380.
2017-02-28 15:24:08 +11:00
Xidorn Quan
2e07ce7e84 Add get_initial_specified_value to many longhands 2017-02-28 15:20:34 +11:00
Glenn Watson
1601003fa0 Update WR (mostly dep updates, clip-scroll work). 2017-02-28 14:15:06 +10:00
Xidorn Quan
ce46e6d034 Remove raw_longhand helper function 2017-02-28 13:45:12 +11:00
Xidorn Quan
b24614f894 Resolve color:currentcolor during computing
The keyword value "currentcolor" should be preserved rather than being
replaced by the CSS-wide keyword "inherit" during parsing.
2017-02-28 13:44:50 +11:00
bors-servo
4b39431215 Auto merge of #15464 - KiChjang:pseudo-lang, r=emilio
Support lang pseudo class

Fixes #8219.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15464)
<!-- Reviewable:end -->
2017-02-27 17:21:50 -08:00
Keith Yeung
7456bcf02b Support lang pseudo class 2017-02-27 17:21:20 -08:00
bors-servo
eb8d0c3df8 Auto merge of #15568 - samgiles:15513-space-scroll, r=asajeffrey
Fix #15513: Stop spacebar scrolling directly from the glutin window.

This completely removes spacebar scrolling using the current method, fixing #15513.

See #15513 for a discussion, as the _right thing to do_ is perhaps a UX problem - and perhaps worth a follow up.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15513.

No tests for these changes yet, as I'm just kicking off a discussion about how this should work.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15568)
<!-- Reviewable:end -->
2017-02-27 12:54:26 -08:00
bors-servo
28bd00debc Auto merge of #15753 - UK992:tidy, r=jdm
Fix Cargo.toml in servo_tidy_tests

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15737

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15753)
<!-- Reviewable:end -->
2017-02-27 08:56:30 -08:00
UK992
7e348fa2a1 Fix Cargo.toml in servo_tidy_tests 2017-02-27 17:02:21 +01:00
bors-servo
cecbc33c01 Auto merge of #15742 - emilio:stylo-orig-display, r=bzbarsky
stylo: Fix adjustment of the display property to save mOriginalDisplay properly.

r? @heycam

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15742)
<!-- Reviewable:end -->
2017-02-27 07:54:30 -08:00
bors-servo
63320730a5 Auto merge of #15752 - nox:syn, r=SimonSapin
Update syn to 0.11

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15752)
<!-- Reviewable:end -->
2017-02-27 05:48:43 -08:00
Anthony Ramine
626e212fcb Update syn to 0.11
The last remnants of syn 0.10 are due to the WR stack still using
serde_codegen to build on stable, but that isn't actually used in
servo.
2017-02-27 14:46:50 +01:00
Anthony Ramine
7b334d84be Remove unused function match_ty_unwrap 2017-02-27 14:46:48 +01:00
bors-servo
29e3347242 Auto merge of #15747 - hiikezoe:fix-wrong-index-in-keyframe, r=emilio
Fix wrong index for missing properties in keyframes

<!-- Please describe your changes on the following line: -->
This is PR of https://bugzilla.mozilla.org/show_bug.cgi?id=1342323 , reviewed by @emilio.  Thank you Emilio!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it's for stylo.

I think we have test cases for this in gecko tree.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15747)
<!-- Reviewable:end -->
2017-02-27 02:28:55 -08:00
bors-servo
b2539090fa Auto merge of #15613 - Varentsov:master, r=upsuper
fix {transform,perspective}-origin accepts (and ignores) anything for…

… their second part of value

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15487.

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15613)
<!-- Reviewable:end -->
2017-02-26 17:40:23 -08:00
bors-servo
3086b3d291 Auto merge of #15733 - absoludity:fix-background-serialization, r=upsuper
Background serialization of multiple values.

Similar to animation, the serialization of multiple backgrounds should
return the longhands serialization if there are an unequal number of
values for the required properties. This is part of #15398

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15733)
<!-- Reviewable:end -->
2017-02-26 16:54:11 -08:00
bors-servo
c025a794dd Auto merge of #15749 - glennw:update-wr-tiling, r=nox
Update WR (image tiling, inset box shadow fixes, new key api).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15749)
<!-- Reviewable:end -->
2017-02-26 15:22:25 -08:00
Glenn Watson
64a9a45b2a Update WR (image tiling, inset box shadow fixes, new key api). 2017-02-27 08:54:28 +10:00
Hiroyuki Ikezoe
8ced5db704 Fix wrong index for missing properties in the initial and final keyframes. 2017-02-27 07:34:19 +09:00
Simon Sapin
7c5ac06cd2 Merge pull request #15745 from servo/hoist
Cascade: skip duplicated properties before rather than after a virtual call
2017-02-26 23:09:44 +01:00
Neck Varentsov
89f96c0848 rebase and fix tidiness lint 2017-02-26 22:52:51 +03:00
Simon Sapin
d007eef5c7 Remove some accessors for public fields.
(Maybe they date from this was a trait?)
2017-02-26 19:24:51 +01:00
Simon Sapin
e0c63efe01 Remove/don’t call no-op compute_font_hash method for stylo.
This removes a potentially-costly Arc::mut call.
2017-02-26 19:24:51 +01:00