Manish Goregaokar
cd6f68c545
stylo: Clean up keyword values
2017-09-23 11:02:22 -07:00
Manish Goregaokar
df9d7cd941
stylo: Move font-size stuff to values::*::font
2017-09-23 10:52:07 -07:00
Manish Goregaokar
e1a39a2012
stylo: Remove FontComputationData, switch over to using the new font tracking
2017-09-23 10:51:55 -07:00
Manish Goregaokar
c73dc5704b
stylo: Add font keyword info fields on nsStyleFont
2017-09-23 10:51:44 -07:00
Manish Goregaokar
c2fcc9ce1a
stylo: Add keyword info to computed value of font-size
2017-09-23 10:51:21 -07:00
Hiroyuki Ikezoe
dcd959fc72
Use Atom::from(nsIAtom) to increment reference count in case of dynamic atom for will-change.
...
If we don't increment the reference count for the Atom in servo side, it's
possible to try to release the Atom in servo side even if we have already
released in gecko side. When it happens, nsIAtom::mKind is no longer reliable.
2017-09-21 15:44:26 +09:00
Xidorn Quan
8cac727f92
Use array instead of linked list for -moz-border-*-colors
2017-09-21 11:37:57 +10:00
Gecko Backout
7bcd57d3c6
Backed out changeset 5b56ebe80e22 (bug 1400438) for heap write hazard. r=backout
...
Backs out https://github.com/servo/servo/pull/18574
2017-09-20 14:53:59 +00:00
Xidorn Quan
4c24ae8d30
Use array instead of linked list for -moz-border-*-colors
2017-09-20 19:05:59 +10:00
Gecko Backout
cff911dd36
Backed out changeset 5d3fe46e02cc (bug 1400438) for crashing chrome test mobile/android/components/extensions/test/mochitest/test_ext_options_ui.html on Android. r=backout on a CLOSED TREE
...
Backs out https://github.com/servo/servo/pull/18557
2017-09-19 14:36:25 +00:00
Xidorn Quan
18a555eaeb
Use array instead of linked list for -moz-border-*-colors
2017-09-19 16:48:00 +10:00
bors-servo
f95da332a3
Auto merge of #18525 - emilio:border-spacing, r=nox
...
style: various serialization fixes
This should close https://github.com/servo/servo/pull/18458 , and fix https://bugzilla.mozilla.org/show_bug.cgi?id=1397619 .
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18525 )
<!-- Reviewable:end -->
2017-09-17 15:12:46 -05:00
Emilio Cobos Álvarez
2ac1327e4b
style: Make border-spacing serialization consistent, and move it to precomputed_type.
2017-09-17 21:33:17 +02:00
Emilio Cobos Álvarez
162acd6cab
style: Remove unused stubbing support for Gecko properties.
...
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-09-17 04:31:21 +02:00
Emilio Cobos Álvarez
041de7ba65
style: Remove useless skip_additionals argument in gecko.mako.rs.
...
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-09-17 04:31:20 +02:00
Emilio Cobos Álvarez
0c2ebcbd1f
style: Remove a useless level of indirection in gecko.mako.rs
...
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-09-17 04:31:20 +02:00
Emilio Cobos Álvarez
6139f8175c
style: Remove useless Data::manual_style_structs.
...
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-09-17 04:31:19 +02:00
Emilio Cobos Álvarez
680f8368ef
style: No more need_clone.
...
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-09-17 04:31:18 +02:00
Gecko Backout
1aa0b20e09
Backed out changeset 616bd23b9896 (bug 1391145) for frequently failing mochitests layout/style/test/test_animations.html and layout/style/test/test_animations_omta.html on Linux x64. r=backout
...
Backs out https://github.com/servo/servo/pull/18492
2017-09-16 13:48:06 +00:00
bors-servo
90689b7916
Auto merge of #18492 - Manishearth:stylo-translate, r=hiikezoe
...
stylo: Preserve variants of 2d translate/rotate/scale functions in computed transform
Necessary for the animation inspector to show the right thing.
r=hiikezoe https://bugzilla.mozilla.org/show_bug.cgi?id=1391145
fixes bug 1391145
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18492 )
<!-- Reviewable:end -->
2017-09-16 03:33:44 -05:00
Manish Goregaokar
06300999e9
stylo: Preserve the variant of rotate() values in computed transforms
...
MozReview-Commit-ID: Dmw7P21I6FN
2017-09-15 14:36:27 -07:00
Manish Goregaokar
e74d04c040
stylo: Preserve the variant of scale() values in computed transforms
2017-09-15 14:36:25 -07:00
bors-servo
9dd0513647
Auto merge of #18498 - upsuper:enum-keyword-exhaustive, r=emilio
...
Use exhaustive match for cloning keyword value by default for property using enum class
rather than casting them to `u8` then do inexhaustive match.
I don't see why we couldn't do this.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18498 )
<!-- Reviewable:end -->
2017-09-14 06:28:16 -05:00
Emilio Cobos Álvarez
c34c92e904
style: Add a TLS-based style struct caching mechanism.
2017-09-14 17:13:39 +08:00
Xidorn Quan
53a786cea6
Use exhaustive match for cloning keyword value by default for property using enum class
2017-09-14 18:48:12 +10:00
Manish Goregaokar
83e3394904
stylo: Preserve the variant of translate() values in computed transforms
2017-09-13 15:21:26 -07:00
Boris Chiou
b89286e8e7
Use CSSPixelLength in LengthOrPercentage{*}.
...
Replace Au with CSSPixelLength in LengthOrPercentage,
LengthOrPercentageOrAuto, and LengthOrPercentageOrNone.
2017-09-13 18:10:46 +08:00
Boris Chiou
a949e2a057
Introduce CSSPixelLength and update NonNegativeLength.
...
First, we define computed::CSSPixelLength which contains a CSSFloat, a
pixel value, and then we replace computed::Length with CSSPixelLength.
Therefore, the |ComputedValue| of NoCalcLength, AbsoluteLength,
FontRelativeLength, ViewportPercentageLength, CharacterWidth, and
PhysicalLength is CSSPixelLength.
Besides, we drop NonNegativeAu, and replace computed::NonNegativeLength
with NonNegative<computed::Length>. (i.e. NonNegative<CSSPixelLength>)
2017-09-13 18:05:14 +08:00
Manish Goregaokar
2db5fbbe56
stylo: Replace FontComputationData with typedef
2017-09-11 17:29:39 -07:00
Manish Goregaokar
1ad9463558
stylo: Add (unused) absolute offset to FontComputationData
2017-09-11 16:05:37 -07:00
Emilio Cobos Álvarez
64ab73eabd
style: Properly use integers on grid properties, and derive ToComputedValue.
2017-09-11 11:29:27 +02:00
bors-servo
8129cf5563
Auto merge of #18206 - ferjm:bug1382369.grid.repeat.function, r=wafflespeanut
...
stylo: store specified value of grid layout repeat() function
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1382369](https://bugzilla.mozilla.org/show_bug.cgi?id=1382369 )
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18206 )
<!-- Reviewable:end -->
2017-09-11 02:32:38 -05:00
Manish Goregaokar
e4de8d10a6
stylo: Use saturating subtraction for script level
2017-09-06 15:42:24 -07:00
Josh Matthews
ca9b231173
Reduce duplication in generated ServoComputedData::to_declaration_block.
2017-09-06 11:02:53 -07:00
Fernando Jiménez Moreno
8306946e7f
stylo: store specified value of grid layout repeat() function
2017-09-06 12:53:07 +02:00
bors-servo
1cf87a243a
Auto merge of #18376 - kuoe0:set-fallbacktype-to-none-when-the-fallback-color-of-context-property-is-none, r=xidorn
...
Support None and NotSet for the fallback type of SVGPaint.
<!-- Please describe your changes on the following line: -->
We didn't set None and NotSet for the fallback type of SVGPaint, and it caused the fallback color is wrong when fallback color is empty or keyword `none`. So, we add the None and NotSet support for it.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1380590](https://bugzilla.mozilla.org/show_bug.cgi?id=1380590 )
<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because of the test cases already in Gecko.
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18376 )
<!-- Reviewable:end -->
2017-09-05 21:43:02 -05:00
Daisuke Akatsuka
951662848f
Implement clone_font_variation_settings method
2017-09-05 15:56:15 +09:00
KuoE0
2d84686113
Support None and NotSet for the fallback type of SVGPaint.
2017-09-05 13:06:09 +08:00
bors-servo
174c37fddd
Auto merge of #18301 - servo:derive-all-the-things, r=emilio
...
Use generics for the vertical-align property
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18301 )
<!-- Reviewable:end -->
2017-08-31 09:41:50 -05:00
Xidorn Quan
673c4f6420
Rewrite CounterStyleOrNone::from_gecko_value to use fewer binding functions
2017-08-31 14:03:59 +10:00
Anthony Ramine
542a9337a4
Use generics for the vertical-align property
2017-08-30 23:01:12 +02:00
Emilio Cobos Álvarez
c69f769285
Revert "Rewrite CounterStyleOrNone::from_gecko_value to use fewer binding functions"
...
This reverts commit 65c2047df2
.
2017-08-30 14:21:13 +02:00
Xidorn Quan
65c2047df2
Rewrite CounterStyleOrNone::from_gecko_value to use fewer binding functions
2017-08-30 13:52:19 +10:00
bors-servo
2136dd2bb7
Auto merge of #18244 - kahsieh:master, r=Manishearth
...
stylo: Update CSS fallback font when lang changes
r=manishearth in BugZilla.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix [Bug 1367860](https://bugzilla.mozilla.org/show_bug.cgi?id=1367860 ).
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18244 )
<!-- Reviewable:end -->
2017-08-25 17:30:22 -05:00
Kevin Hsieh
cfa98a3ab6
Update CSS fallback font when lang changes
2017-08-25 14:12:34 -07:00
Nazım Can Altınova
81be90cce2
Implement font feature values lookup for stylo
2017-08-25 12:03:38 -07:00
Gecko Backout
12b02ce9d5
Backed out changeset 01348a3860f7 for build bustage
...
CLOSED TREE
Backs out https://github.com/servo/servo/pull/18222
2017-08-25 03:45:31 +00:00
Nazım Can Altınova
6d7a1903b8
Implement font feature values lookup for stylo
2017-08-24 12:41:36 -07:00
Mantaroh Yoshinaga
1c574cf93b
Add SVGLengthOrPercentageOrNumber for stroke-*.
...
We need to use enum instead of Either since we can't interpolate stroke-* between
unitless length and unit length(e.g. '5' -> '10px').
This coomit make following:
* Introduce SVGLengthOrPercentageOrNumber on computed and specified values.
* Make SVGLengthOrPercentageOrNumber animatable.
* Make stroke-dasharray not-accumulate.
2017-08-18 10:28:11 +09:00
Simon Sapin
35282042bc
geckolib: Fix some warnings (treated as error) new in Rust Nigthly
2017-08-17 15:59:33 +02:00