Nicholas Nethercote
8705fb3783
Convert StylePrefs to StaticPrefs.
2018-04-03 11:41:03 +10:00
Emilio Cobos Álvarez
15c416b133
style: Use a more consistent style for parsing functions.
2018-04-02 19:34:58 +02:00
Emilio Cobos Álvarez
744809a8b2
style: Add support for 'flex-basis:content' in the style system.
...
Bug: 1105111
Reviewed-by: xidorn
MozReview-Commit-ID: 5WhgHJJ0mDB
2018-04-02 03:17:56 +02:00
Mats Palmgren
3532f64b32
[css-multicol] style: Implement percentages for 'column-gap'.
...
Bug: 1398537
Reviewed-by: emilio,dholbert
2018-04-02 00:56:45 +02:00
Li Hao Tan
8d5a2a9aeb
Refactor text-emphasis-position
to use ${helpers.predefined_type(..)}
2018-04-01 21:12:01 +08:00
Emilio Cobos Álvarez
839eda000a
style: Avoid serializing the counter type in counter functions if it's decimal.
...
See https://github.com/w3c/web-platform-tests/pull/9862 and such.
2018-03-14 16:41:33 +01:00
Igor Gutorov
217c4be2bf
style: Fix a typo in Integer struct docs
2018-03-13 02:02:38 +02:00
bors-servo
aa8fb3a204
Auto merge of #20252 - NeverHappened:extract_text_emphasis_style, r=upsuper
...
Extract text emphasis style
<!-- Please describe your changes on the following line: -->
Extracted the text-emphasis-style property out of the inherited_text.mako.rs.
This is a part of #19015
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] `./mach cargo-geckolib check` does not report any errors
- [X] These changes fix #19940 (github issue number if applicable).
<!-- Either: -->
- [X] These changes do not require tests because it's a refactoring
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20252 )
<!-- Reviewable:end -->
2018-03-09 19:20:10 -05:00
Dmitry
a1dd888c23
Rename entities that belong to text-emphasis-style value. Fix order of imports
2018-03-09 20:55:26 +03:00
Anthony Ramine
afaa00a344
Remove some uses of trivial_to_computed_value
2018-03-09 11:57:22 +01:00
Dmitry
acdb4df53b
Fix test-tidy formatting errors
2018-03-09 01:39:31 +03:00
Dmitry
4739775877
Remove duplicate derive for text emphasis style enum
2018-03-09 00:27:09 +03:00
Dmitry
6febdf3751
Add docs for text-emphasis-property values
2018-03-09 00:04:32 +03:00
Dmitry
73113e28dd
Move text-emphasis-style variables out of mako templates
2018-03-09 00:04:32 +03:00
bors-servo
212c321145
Auto merge of #20240 - emilio:special-color-fix, r=upsuper
...
style: Fix special color keywords.
They're -moz-activehyperlinktext and -moz-visitedhyperlinktext.
This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1444059 .
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20240 )
<!-- Reviewable:end -->
2018-03-08 10:06:03 -05:00
Emilio Cobos Álvarez
0717047e1e
style: Make weird color parsing marginally faster.
2018-03-08 14:08:54 +01:00
Emilio Cobos Álvarez
2192090ea5
style: Fix special color keywords.
...
They're -moz-activehyperlinktext and -moz-visitedhyperlinktext.
2018-03-08 14:01:09 +01:00
Xidorn Quan
fa5d76c395
Split CssUrl from SpecifiedUrl for non-value URLs.
2018-03-08 23:34:34 +11:00
Xidorn Quan
0090fbb3c8
Move ComputedUrl into their impl mods.
2018-03-08 23:34:33 +11:00
Xidorn Quan
d001fd9a0a
Move Parse impl of SpecifiedUrl into corresponding files.
2018-03-08 23:34:33 +11:00
Xidorn Quan
a99ca543cd
Add SpecifiedImageUrl for <url> used as images.
2018-03-08 23:34:32 +11:00
Anthony Ramine
90b23963b7
Introduce #[css(if_empty = "…", iterable)]
2018-03-07 13:07:13 +01:00
Anthony Ramine
92f116a95c
Derive ToCss for TemplateAreas
2018-03-07 12:32:53 +01:00
Anthony Ramine
85950a801f
Move #[css(iterable)] on fields rather than variants
2018-03-06 11:08:19 +01:00
Anthony Ramine
2aa5f68c92
Derive ToCss for FontSize
2018-03-05 15:53:16 +01:00
Anthony Ramine
ca45695db1
Introduce #[css(skip)]
2018-03-05 15:53:15 +01:00
bors-servo
fbeb5a81a8
Auto merge of #20194 - emilio:ascii-ext-stuff, r=nox
...
style: remove unused AsciiExt imports.
eq_ignore_ascii_case is not in AsciiExt since rustc 1.23.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20194 )
<!-- Reviewable:end -->
2018-03-04 13:35:04 -05:00
Emilio Cobos Álvarez
39a3d93b4f
style: remove unused AsciiExt imports.
...
eq_ignore_ascii_case is not in AsciiExt since rustc 1.23.
2018-03-04 15:31:06 +01:00
Jonathan Kew
33ead015b1
style: Make 'font' shorthand reset the 'font-variation-settings' property.
...
As required by the spec: https://drafts.csswg.org/css-fonts-4/#font-prop
See https://bugzilla.mozilla.org/show_bug.cgi?id=1435983
Basically, make font-variation-settings work in the same way as font-feature-settings
already does.
2018-03-04 12:26:32 +00:00
Emilio Cobos Álvarez
9ace0e43ce
style: Cleanup indentation in a couple places.
2018-03-04 01:07:29 +01:00
Emilio Cobos Álvarez
50a299f82c
style: Don't guard the context opacity keywords with the svg in opentype pref.
...
This is effectively the stylo version of the second patch for bug 1365926, and
should fix bug 1442867.
2018-03-04 01:07:20 +01:00
Anthony Ramine
91ed0b0aa5
Derive ToCss for ContentItem
2018-03-02 16:07:02 +01:00
Anthony Ramine
a4d3a8d74a
Make ContentItem use a CustomIdent for counter names
...
See https://github.com/w3c/csswg-drafts/pull/2377
2018-03-02 16:06:54 +01:00
Anthony Ramine
c4efbb4d51
Replace ColorOrAuto by CaretColor
...
This is its only use.
2018-02-28 10:25:59 +01:00
Anthony Ramine
27732c7dbb
Replace NonNegativeLengthOrNumber by a specific type for -moz-tab-size
...
This is the only use of this type.
2018-02-27 11:26:52 +01:00
bors-servo
6df0dc5b27
Auto merge of #20124 - servo:perspective, r=emilio
...
Replace LengthOrNone by a specific type for the perspective property
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20124 )
<!-- Reviewable:end -->
2018-02-26 16:35:32 -05:00
Anthony Ramine
260e05320c
Replace LengthOrNone by a specific type for the perspective property
...
This was its only use, and it was bugged: AFAIK this didn't properly
clamp animated values below 0.
2018-02-26 22:32:06 +01:00
Anthony Ramine
4a98fa70bf
Streamline parsing of NonNegativeLengthOrNumber a bit
2018-02-26 22:11:17 +01:00
Anthony Ramine
f10e485740
Remove 2 unused type aliases
2018-02-26 16:40:19 +01:00
Anthony Ramine
761689f32d
Replace PositiveIntegerOrAuto by ColumnCount
...
It was its only use.
2018-02-22 10:16:46 +01:00
Anthony Ramine
b44ffcf498
Replace IntegerOrAuto with ZIndex
...
It's its only use.
2018-02-20 15:18:22 +01:00
Emilio Cobos Álvarez
7473796aba
style: Unship the legacy syntax for -moz-transform.
...
Intent to unship link:
https://groups.google.com/d/msg/mozilla.dev.platform/T3PGm97MPNU/59XUavMlCgAJ
Reviewed-by: xidorn
Bug: 1438297
MozReview-Commit-ID: 6ybGBasPAWU
2018-02-19 10:46:14 +01:00
Emilio Cobos Álvarez
fdc8405330
style: Trivially cleanup length parsing.
...
Mostly formatting signatures properly, but also removing useless functions and
stuff.
2018-02-16 16:04:19 +01:00
Anthony Ramine
b17fea1d7f
Make KeywordInfo generic
2018-02-15 12:03:00 +01:00
Anthony Ramine
aea66a9fb6
Move FontTag to the generic module
2018-02-15 12:03:00 +01:00
Nupur Baghel
8116962298
Added derive ToCss for Content and removed manual Impl
2018-02-12 00:35:56 +05:30
bors-servo
41fb6ed1ff
Auto merge of #19980 - servo:derive-all-the-things, r=emilio
...
Merge all keyword arms in Clone for PropertyDeclaration 🐉 🐲
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19980 )
<!-- Reviewable:end -->
2018-02-09 16:17:01 -05:00
Anthony Ramine
335cb4c9f4
Whitelist Copy types when generating PropertyDeclaration
2018-02-07 22:49:15 +01:00
bors-servo
a0e4ea9f56
Auto merge of #19974 - emilio:atom-serialization, r=nox
...
style: Optimize serialization of identifiers of length <= 16 🐉 🐲
Much like we optimize to_ascii_lowercase.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19974 )
<!-- Reviewable:end -->
2018-02-07 13:33:36 -05:00
Emilio Cobos Álvarez
e41d724694
style: Derive ToCss for FontFamilyList.
...
The extra reference in to_css is needed because the family list iterator returns
by value in Gecko.
2018-02-07 17:44:15 +01:00