Xidorn Quan
a99ca543cd
Add SpecifiedImageUrl for <url> used as images.
2018-03-08 23:34:32 +11:00
Emilio Cobos Álvarez
0d7dae1f85
style: Derive ToCss for TimingFunction.
2018-03-08 10:28:11 +01:00
Anthony Ramine
90b23963b7
Introduce #[css(if_empty = "…", iterable)]
2018-03-07 13:07:13 +01:00
Anthony Ramine
92f116a95c
Derive ToCss for TemplateAreas
2018-03-07 12:32:53 +01:00
bors-servo
785b7c7775
Auto merge of #20211 - servo:derive-all-the-things, r=emilio
...
Improve #[derive(ToCss)]
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20211 )
<!-- Reviewable:end -->
2018-03-06 11:42:58 -05:00
Emilio Cobos Álvarez
a5fc724349
style: Add a comment about the weird setup for justify-items.
...
And derive ToCss while at it.
2018-03-06 11:28:41 +01:00
Anthony Ramine
85950a801f
Move #[css(iterable)] on fields rather than variants
2018-03-06 11:08:19 +01:00
Anthony Ramine
2aa5f68c92
Derive ToCss for FontSize
2018-03-05 15:53:16 +01:00
Anthony Ramine
ca45695db1
Introduce #[css(skip)]
2018-03-05 15:53:15 +01:00
bors-servo
fbeb5a81a8
Auto merge of #20194 - emilio:ascii-ext-stuff, r=nox
...
style: remove unused AsciiExt imports.
eq_ignore_ascii_case is not in AsciiExt since rustc 1.23.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20194 )
<!-- Reviewable:end -->
2018-03-04 13:35:04 -05:00
bors-servo
1783e41f34
Auto merge of #20191 - jfkthame:font-shorthand-resets-variation-settings, r=emilio
...
style: Make 'font' shorthand reset 'font-variation-settings' property
As required by the spec: https://drafts.csswg.org/css-fonts-4/#font-prop
See https://bugzilla.mozilla.org/show_bug.cgi?id=1435983
Basically, make font-variation-settings work in the same way as font-feature-settings
already does.
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because font-variation-settings isn't supported in servo; it is implemented here for gecko/stylo, and will be tested by mozilla-central mochitests.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20191 )
<!-- Reviewable:end -->
2018-03-04 11:50:56 -05:00
Emilio Cobos Álvarez
39a3d93b4f
style: remove unused AsciiExt imports.
...
eq_ignore_ascii_case is not in AsciiExt since rustc 1.23.
2018-03-04 15:31:06 +01:00
Jonathan Kew
33ead015b1
style: Make 'font' shorthand reset the 'font-variation-settings' property.
...
As required by the spec: https://drafts.csswg.org/css-fonts-4/#font-prop
See https://bugzilla.mozilla.org/show_bug.cgi?id=1435983
Basically, make font-variation-settings work in the same way as font-feature-settings
already does.
2018-03-04 12:26:32 +00:00
bors-servo
86a7010082
Auto merge of #20189 - servo:squared-distance-for-real, r=emilio
...
Never store a squared root in SquaredDistance
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20189 )
<!-- Reviewable:end -->
2018-03-03 20:11:41 -05:00
Anthony Ramine
6ce5e9a869
Never store a squared root in SquaredDistance
2018-03-04 02:10:44 +01:00
Emilio Cobos Álvarez
9ace0e43ce
style: Cleanup indentation in a couple places.
2018-03-04 01:07:29 +01:00
Emilio Cobos Álvarez
50a299f82c
style: Don't guard the context opacity keywords with the svg in opentype pref.
...
This is effectively the stylo version of the second patch for bug 1365926, and
should fix bug 1442867.
2018-03-04 01:07:20 +01:00
Anthony Ramine
b517bcd42b
Unconditionally derive ToComputedValue as Clone for non-generics
...
We assume that types such as `<Self as ToComputedValue>::ToComputedValue == Self`
just construct a new value that is just a clone of the original one without any
additional code.
2018-03-03 18:41:50 +01:00
Anthony Ramine
91ed0b0aa5
Derive ToCss for ContentItem
2018-03-02 16:07:02 +01:00
Anthony Ramine
a4d3a8d74a
Make ContentItem use a CustomIdent for counter names
...
See https://github.com/w3c/csswg-drafts/pull/2377
2018-03-02 16:06:54 +01:00
Anthony Ramine
c4efbb4d51
Replace ColorOrAuto by CaretColor
...
This is its only use.
2018-02-28 10:25:59 +01:00
Anthony Ramine
27732c7dbb
Replace NonNegativeLengthOrNumber by a specific type for -moz-tab-size
...
This is the only use of this type.
2018-02-27 11:26:52 +01:00
bors-servo
6df0dc5b27
Auto merge of #20124 - servo:perspective, r=emilio
...
Replace LengthOrNone by a specific type for the perspective property
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20124 )
<!-- Reviewable:end -->
2018-02-26 16:35:32 -05:00
Anthony Ramine
260e05320c
Replace LengthOrNone by a specific type for the perspective property
...
This was its only use, and it was bugged: AFAIK this didn't properly
clamp animated values below 0.
2018-02-26 22:32:06 +01:00
Anthony Ramine
4a98fa70bf
Streamline parsing of NonNegativeLengthOrNumber a bit
2018-02-26 22:11:17 +01:00
Anthony Ramine
f10e485740
Remove 2 unused type aliases
2018-02-26 16:40:19 +01:00
Anthony Ramine
0a3f30fb12
Return an error when animating column-count: auto
...
This changes the behaviour of animations of `column-count`
(hello Captain Obvious) but this is a bugfix.
2018-02-22 10:23:58 +01:00
Anthony Ramine
761689f32d
Replace PositiveIntegerOrAuto by ColumnCount
...
It was its only use.
2018-02-22 10:16:46 +01:00
Anthony Ramine
b44ffcf498
Replace IntegerOrAuto with ZIndex
...
It's its only use.
2018-02-20 15:18:22 +01:00
bors-servo
be902d56c0
Auto merge of #20073 - servo:keywordsize, r=emilio
...
Remove some useless manual layout optimisation for KeywordSize
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20073 )
<!-- Reviewable:end -->
2018-02-19 07:02:45 -05:00
Anthony Ramine
e976955634
Remove some useless manual layout optimisation for KeywordSize
2018-02-19 12:37:46 +01:00
Emilio Cobos Álvarez
7473796aba
style: Unship the legacy syntax for -moz-transform.
...
Intent to unship link:
https://groups.google.com/d/msg/mozilla.dev.platform/T3PGm97MPNU/59XUavMlCgAJ
Reviewed-by: xidorn
Bug: 1438297
MozReview-Commit-ID: 6ybGBasPAWU
2018-02-19 10:46:14 +01:00
Emilio Cobos Álvarez
fdc8405330
style: Trivially cleanup length parsing.
...
Mostly formatting signatures properly, but also removing useless functions and
stuff.
2018-02-16 16:04:19 +01:00
Anthony Ramine
d8c43ac855
Animate NonNegativeLength as its inner type
2018-02-15 12:03:02 +01:00
Anthony Ramine
52f0fcabad
Properly implement ToAnimatedZero for BorderSpacing
2018-02-15 12:03:01 +01:00
Anthony Ramine
b17fea1d7f
Make KeywordInfo generic
2018-02-15 12:03:00 +01:00
Anthony Ramine
aea66a9fb6
Move FontTag to the generic module
2018-02-15 12:03:00 +01:00
bors-servo
112bb55b92
Auto merge of #20040 - servo:derive-all-the-things, r=emilio
...
Change how some clamped types are animated
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20040 )
<!-- Reviewable:end -->
2018-02-14 05:48:10 -05:00
Anthony Ramine
056abcbf5f
Change AnimatedValue for GreaterThanOrEqualToOneNumber to CSSFloat
2018-02-13 16:12:31 +01:00
Anthony Ramine
f89ebf7fe9
Change AnimatedValue for NonNegativeNumber to CSSFloat
2018-02-13 16:12:30 +01:00
Anthony Ramine
da5acc81d2
Change AnimatedValue for NonNegativeLengthOrPercentage to its inner type
2018-02-13 16:12:29 +01:00
Anthony Ramine
b79dc269f7
Change AnimatedValue for PositiveInteger to CSSInteger
2018-02-13 16:12:29 +01:00
Xidorn Quan
caa15ab6a7
Output unquoted family name as a series of identifiers.
...
It tries to serialize unquoted family names as a series of identifiers.
For family names which contain special white spaces like leading white
space, trailing white space, and consective white spaces, unquoted names
are marked quoted in parsing to avoid complicating serialization code.
2018-02-13 09:17:19 +11:00
bors-servo
9c94fe4279
Auto merge of #20017 - servo:derive-all-the-things, r=emilio
...
Optimise more AnimationValue methods 🐉 🐲
```
__TEXT __DATA __OBJC others dec hex
87101440 5226496 0 64122880 156450816 9534000 XUL.old
87072768 5226496 0 64122880 156422144 952d000 XUL.new
```
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20017 )
<!-- Reviewable:end -->
2018-02-11 18:43:17 -05:00
Nupur Baghel
8116962298
Added derive ToCss for Content and removed manual Impl
2018-02-12 00:35:56 +05:30
Anthony Ramine
c92d0a8902
Implement Clone for AnimationValue by hand 🐉 🐲
...
We use the same trick as in PropertyDeclaration::clone.
2018-02-11 09:47:14 +01:00
Anthony Ramine
a90e660eac
Kill AnimatedValueAsComputed
2018-02-10 16:31:47 +01:00
bors-servo
41fb6ed1ff
Auto merge of #19980 - servo:derive-all-the-things, r=emilio
...
Merge all keyword arms in Clone for PropertyDeclaration 🐉 🐲
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19980 )
<!-- Reviewable:end -->
2018-02-09 16:17:01 -05:00
Emilio Cobos Álvarez
655e0c6beb
style: Remove unneeded clone.
2018-02-09 12:30:20 +01:00
bors-servo
c22baf58d0
Auto merge of #19985 - servo:derive-these-things-too, r=emilio
...
Derive ComputeSquaredDistance for animated filters
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19985 )
<!-- Reviewable:end -->
2018-02-08 06:41:22 -05:00