Commit graph

324 commits

Author SHA1 Message Date
bors-servo
776a1d9cac Auto merge of #13784 - TooManyBees:13363-check-script-enabled, r=Ms2ger
Issue 13363 - Step 1.2 of compiling event handler

<!-- Please describe your changes on the following line: -->
Adds the conditional to test that scripting is enabled in `EventTarget#get_compiled_event_handler`, and return `None` early if not.

Adds tests for "scripting enabled" and "scripting disabled" cases.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13363 (github issue number if applicable).

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13784)
<!-- Reviewable:end -->
2016-10-21 09:24:05 -05:00
Jesse Kipp
4f0ffbd1f6 Issue 13363 - Step 1.2 of compiling event handler
When compiling event handlers, check whether scripting is enabled
and early return None/null if not.

https://html.spec.whatwg.org/multipage/
webappapis.html#getting-the-current-value-of-the-event-handler

Issue 13363 - Fix spec for disabled scripting

The original spec for this PR was bad because it depended on the
DOM without scripting enabled to use Javascript to signal the test's
failure, so it could never fail.

Use an onerror handler on `window` where scripting is enabled, and
use an invalid string of JavaScript for the handler, to detect
whether or not the event handler is *really* being compiled or not.

Condense tests into a single HTML file

Yup, didn't even realize I could do that at the time.

Remove an unnecessary test
2016-10-20 11:08:44 -04:00
Corey Farwell
957e1d8e7a Make 'reset-form.html' test more granular. 2016-10-20 00:02:53 -04:00
Ms2ger
c69ce9deef Add a test for stylesheet links with an empty href. 2016-09-30 11:23:35 +02:00
bors-servo
7fe688b8e9 Auto merge of #13461 - servo:media, r=Manishearth
Pass the correct attribute to handle_stylesheet_url.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13461)
<!-- Reviewable:end -->
2016-09-30 01:21:08 -05:00
Jake Goldsborough
ce249d9384 adding macro to return string or url,
using that macro with the form action,
making the form submit process use base url,
adding tests.
2016-09-27 09:33:11 -07:00
Ms2ger
361e41f0e7 Add a test for changing the media attribute on a link element. 2016-09-27 17:46:29 +02:00
Alexandrov Sergey
2173545cdb fix existing test expectations and add new tests for HTMLOptionsCollection 2016-09-26 21:54:01 +03:00
Ms2ger
3b4f0ec0bb Update web-platform-tests to revision 3b3585e368841b77caea8576fa56cef91c3fbdf0 2016-09-26 13:24:06 +02:00
Keith Yeung
4c616dad90 Add crossorigin attribute and implement step 14 of prepare a script
Add WPT test for HTMLScriptElement crossOrigin IDL attribute
2016-09-21 11:50:51 -07:00
Taryn Hill
2cb5adf6c6 Implement minlength for text inputs 2016-09-21 07:54:39 -05:00
Connor Brewster
e9b2f1b916 Replace current session entry for reloads 2016-09-19 14:23:03 -05:00
Ms2ger
079092dfea Update web-platform-tests to revision dc5cbf088edcdb266541d4e5a76149a2c6e716a0 2016-09-09 16:17:14 +02:00
Ms2ger
ac111b96fd Correct and improve addEventListener.html.
We do now fire (trusted) events for onerror.
2016-09-02 11:44:45 +02:00
Ms2ger
aeb6b1795a Add a test for the exact timing of the error event for invalid event handlers. 2016-08-31 13:20:25 +02:00
Alexandrov Sergey
e4006fa9dd add HTMLOptionElement form attribute test 2016-08-30 17:30:06 +03:00
bors-servo
6beec195ed Auto merge of #13028 - ofekd:implement-data-value-attr, r=KiChjang
Implement HTMLDataElement#value

<!-- Please describe your changes on the following line: -->
Implement HTMLDataElement#value

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12966

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13028)
<!-- Reviewable:end -->
2016-08-25 12:48:06 -05:00
clstl
aa5edd1118 Implements HTMLDialogElement#close 2016-08-25 16:13:30 +03:00
Ofek
cc23f9a87a implement HTMLDataElement#value 2016-08-25 16:08:09 +03:00
Paul Rouget
a48cf1d215 Trigger image.onerror 2016-08-23 07:51:47 +02:00
Mike MacDonald (crazymykl)
aed761509b
Fire load event for external stylesheets
Do not load stylesheets with the wrong Content-Type

Fixes #11912, #11910
2016-08-03 17:13:26 -04:00
bors-servo
9693295aaf Auto merge of #12594 - GuillaumeGomez:remove_row, r=Ms2ger
Add DeleteRow method

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12594)
<!-- Reviewable:end -->
2016-07-27 11:29:21 -05:00
Guillaume Gomez
cf9fd7eb46 Add DeleteRow method 2016-07-27 02:06:26 +02:00
vrod
9b7e38e95d Write a test for HTMLDialogElement#open
These changes fix #12574
2016-07-26 03:08:19 -03:00
Ms2ger
06ab3e0158 Add a test for changing the charset attribute of a script while it is loading. 2016-07-14 15:08:54 +02:00
Ms2ger
0edf0ececb Update web-platform-tests to revision 53f3408ffe1fd0e56a37aff4aaf1fa8441c41d6d 2016-07-12 10:52:41 +02:00
zeusintuivo
d26bb29bb2 Rename SharedKeyboardAndMouseEventInit to EventModifierInit 2016-07-11 16:39:59 +02:00
Connor Brewster
3f285fd437 Add test for scripts running after its script thread is closed 2016-07-08 09:02:07 -06:00
Ms2ger
a972fdb353 Update web-platform-tests to revision 1e42017386ce1eaeed4925fb8bc7f5417752019a 2016-07-06 09:18:04 +02:00
Manish Goregaokar
c953b07108
Add test for ensuring a bad <img> src does not crash 2016-07-05 21:52:24 +05:30
Josh Matthews
a8407174c5 Add a test for documents without browsing contexts loading stylesheets. 2016-07-04 16:52:35 -04:00
bors-servo
e30b288ed6 Auto merge of #11934 - jdm:navigatefragment, r=emilio
Special-case setting location.hash to the empty string

This avoids endless redirect loops on facebook and makes us compliant with https://github.com/whatwg/html/pull/1318.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #10952
- [X] There are tests for these changes OR

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11934)
<!-- Reviewable:end -->
2016-06-29 17:39:58 -05:00
Josh Matthews
5cc8de8067 Ensure that a navigation to the same URL is aborted. Fixes #10952. 2016-06-29 13:40:16 -04:00
bors-servo
aa9141277e Auto merge of #11906 - asajeffrey:textinput-ok-selection, r=ConnorGBrewster
Added checks that selection is valid, and fix set_selection_range.

<!-- Please describe your changes on the following line: -->

Fixed range checking for text inputs. Included some `debug_assert!` statements to check that the selection range is always valid.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11901.
- [X] These changes do not require tests because the code includes debug_asserts to ensure invariants are maintained.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11906)
<!-- Reviewable:end -->
2016-06-29 12:36:01 -05:00
Josh Matthews
1b495de29c Allow pages to finish loading when external stylesheets have network errors. 2016-06-29 09:06:20 -04:00
Alan Jeffrey
7ed8408f12 Added checks that selection is valid, and fix set_selection_range. 2016-06-29 07:24:19 -05:00
Ms2ger
79b1e6c40c Update web-platform-tests to revision 346d5b51a122f7bb1c7747064499ef281a0200f7 2016-06-24 11:36:34 +02:00
bors-servo
2086d216dd Auto merge of #11697 - mrmiywj:form-index-getter, r=Ms2ger
indexed getter of form elements

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11405 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11697)
<!-- Reviewable:end -->
2016-06-15 01:10:49 -05:00
mrmiywj
4bb88432b2 indexed getter of form elements 2016-06-14 21:40:32 -07:00
bors-servo
0b2cc910d4 Auto merge of #11666 - asajeffrey:cross-origin-parentage-test, r=ConnorGBrewster
Added tests for cross-origin iframe parentage.

<!-- Please describe your changes on the following line: -->
Added (currently failing) tests for cross-origin iframe parentage.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11478
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/11666)
<!-- Reviewable:end -->
2016-06-12 09:54:51 -05:00
Alan Jeffrey
07ea9e6332 Added tests for cross-origin iframe parentage. 2016-06-10 08:56:02 -05:00
Alan Jeffrey
fad91e3de5 Added test for whether only fully active documents contribute to the joint session history. 2016-06-09 15:13:17 -05:00
Alan Jeffrey
999e057cb7 Added a test for changing an iframe's parentage. 2016-06-09 12:06:36 -05:00
Ms2ger
7c4281f3da Update web-platform-tests to revision bda2059150dca8ab47f088b4cc619fcdc1f262fa 2016-05-30 14:04:50 +02:00
Bharath M R
a4d9a1d6a1 Fixes #11407: Implement Window.status 2016-05-27 02:28:36 -07:00
Manish Goregaokar
90d72c5de0
Add tests for submit buttons with values 2016-05-23 15:26:10 +05:30
mrmiywj
904e9ea17c htmlanchorelement getter work before href setting is called
update tests

rewrite it
2016-05-18 12:37:41 +08:00
bors-servo
42141870e7 Auto merge of #10714 - KiChjang:user-interaction-task, r=Ms2ger
Implement user interaction task source

Part of #7959.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10714)
<!-- Reviewable:end -->
2016-05-12 09:00:14 -07:00
Keith Yeung
f60de52aae Fire 'select' event in SetSelectionRange 2016-05-12 10:44:04 -04:00
bors-servo
641b374f0b Auto merge of #10953 - KiChjang:text-plain-encoding, r=jdm
Implement text/plain form encoding

Fixes #3649.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10953)
<!-- Reviewable:end -->
2016-05-11 19:43:37 -07:00