Commit graph

33063 commits

Author SHA1 Message Date
Emilio Cobos Álvarez
5c19eb5998
style: Nix -moz-user-input: disabled.
It does nothing, and there's only one use of it anyway.

See the intent to unship for research on out of the tree usage:

  https://groups.google.com/d/msg/mozilla.dev.platform/E6tfP__wkwg/YVW6nPX9CQAJ

Bug: 1405087
Reviewed-by: bz
MozReview-Commit-ID: 5XnsewYdvgQ
2018-02-15 11:49:00 +01:00
bors-servo
b9862f7b28
Auto merge of #20053 - servo-wpt-sync:wpt_update_14-02-2018, r=jdm
Sync WPT with upstream (14-02-2018)

Automated downstream sync of changes from upstream as of 14-02-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20053)
<!-- Reviewable:end -->
2018-02-14 21:22:06 -05:00
WPT Sync Bot
9882351fad Update web-platform-tests to revision 6be7f242bbcec40802cda8f670bbec31570dd077 2018-02-14 21:14:13 -05:00
bors-servo
2b9acb12dd
Auto merge of #20050 - paavininanda:NewTests, r=jdm
Adding left over tests using DRY coding

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes add the tests using DRY technique to reduce redundant code for https://github.com/servo/servo/pull/19963

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20050)
<!-- Reviewable:end -->
2018-02-14 15:59:51 -05:00
paavininanda
06f0ad1be7 Adding tests with DRY coding technique 2018-02-15 01:48:48 +05:30
bors-servo
6f82110c92
Auto merge of #20049 - emilio:cleanup-serialization-a-bit, r=SimonSapin
style: Cleanup serialization a bit.

Mostly minor cleanups, in preparation for more refactoring.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20049)
<!-- Reviewable:end -->
2018-02-14 15:09:30 -05:00
Emilio Cobos Álvarez
502b734a1a
style: Update a couple other spec links. 2018-02-14 20:29:40 +01:00
Emilio Cobos Álvarez
808102035e
style: Deindent and reuse some more code in single_value_to_css.
This method is a hack on its own, let's try to scope it a bit...
2018-02-14 20:29:11 +01:00
Emilio Cobos Álvarez
f3e38aca1b
style: Move the shorthand serialization code to its own function. 2018-02-14 20:29:10 +01:00
Emilio Cobos Álvarez
5c2ac8cf8b
style: Deindent a giant loop guarded by an !is_empty() condition. 2018-02-14 20:29:09 +01:00
Emilio Cobos Álvarez
ba7629a17e
style: Update a spec link. 2018-02-14 20:29:09 +01:00
bors-servo
bdbb298bac
Auto merge of #20046 - emilio:less-dumb, r=nox
style: Move most of allowed_in to NonCustomPropertyId.

Also simplify the servo property id to gecko property id conversion to be faster
and less repetitive.

This is in preparation of some patches to properly allow disabled longhands on enabled shorthands, something that we don't contemplate right now.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20046)
<!-- Reviewable:end -->
2018-02-14 13:23:07 -05:00
Emilio Cobos Álvarez
1548520710
style: Move most of allowed_in to NonCustomPropertyId.
Also simplify the servo property id to gecko property id conversion to be faster
and less repetitive.
2018-02-14 19:10:28 +01:00
bors-servo
7945dff8ea
Auto merge of #20043 - servo-wpt-sync:wpt_update_13-02-2018, r=jdm
Sync WPT with upstream (13-02-2018)

Automated downstream sync of changes from upstream as of 13-02-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20043)
<!-- Reviewable:end -->
2018-02-14 09:18:16 -05:00
bors-servo
5af219e818
Auto merge of #19925 - upsuper:cstr, r=emilio
Use cstr macro for ffi literal strings

Use `cstr!()` macro with `CStr` to ensure that literal strings used with FFI is properly nul-terminated to avoid cases like #19915.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19925)
<!-- Reviewable:end -->
2018-02-14 06:49:38 -05:00
Xidorn Quan
92feec1974 Use cstr macro for ffi literal strings. 2018-02-14 22:11:38 +11:00
bors-servo
112bb55b92
Auto merge of #20040 - servo:derive-all-the-things, r=emilio
Change how some clamped types are animated

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20040)
<!-- Reviewable:end -->
2018-02-14 05:48:10 -05:00
bors-servo
9f3ce51d50
Auto merge of #20044 - upsuper:font-face-initial, r=SimonSapin
Remove initial values from font-face descriptors

They are not used anyway.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20044)
<!-- Reviewable:end -->
2018-02-14 02:19:22 -05:00
Xidorn Quan
ea8a952d51 Remove initial values from font-face descriptors
They are not used anyway.
2018-02-14 17:35:57 +11:00
WPT Sync Bot
432648745e Update web-platform-tests to revision 1e4fe87a7f01c0b5c614c8f601ffa68b4a00662a 2018-02-13 21:19:19 -05:00
bors-servo
27cd4f7b53
Auto merge of #20042 - upsuper:font-variation-desc, r=emilio
Integrate font-variation-settings descriptor with stylo

This is the Servo side change for [bug 1435984](https://bugzilla.mozilla.org/show_bug.cgi?id=1435984).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20042)
<!-- Reviewable:end -->
2018-02-13 19:16:34 -05:00
Xidorn Quan
6ffa888dd6 Integrate font-variation-settings descriptor with stylo 2018-02-14 11:15:58 +11:00
bors-servo
4c3f1756da
Auto merge of #20038 - emilio:no-need-for-strings, r=nox
style: Avoid an intermediate buffer in Servo_Shorthand_AnimationValues_Serialize.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20038)
<!-- Reviewable:end -->
2018-02-13 12:06:02 -05:00
bors-servo
6cb78057bb
Auto merge of #20022 - Eijebong:syn, r=nox
Update syn, quote and synstructure

Right now they're duplicated because we need a new serde release (ping @dtolnay), a new cssparser release (ping @SimonSapin) and a new release of html5ever with https://github.com/servo/html5ever/pull/336

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20022)
<!-- Reviewable:end -->
2018-02-13 11:15:54 -05:00
bors-servo
7e31ae35e1
Auto merge of #20039 - emilio:indent, r=nox
style: Use consistent formatting for functions in the glue file.

I'm tired of only drive-by fixing them :)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20039)
<!-- Reviewable:end -->
2018-02-13 10:25:30 -05:00
Anthony Ramine
056abcbf5f Change AnimatedValue for GreaterThanOrEqualToOneNumber to CSSFloat 2018-02-13 16:12:31 +01:00
Anthony Ramine
f89ebf7fe9 Change AnimatedValue for NonNegativeNumber to CSSFloat 2018-02-13 16:12:30 +01:00
Anthony Ramine
da5acc81d2 Change AnimatedValue for NonNegativeLengthOrPercentage to its inner type 2018-02-13 16:12:29 +01:00
Anthony Ramine
b79dc269f7 Change AnimatedValue for PositiveInteger to CSSInteger 2018-02-13 16:12:29 +01:00
Emilio Cobos Álvarez
1b24ba12b7
style: Use consistent formatting for functions in the glue file.
I'm tired of only drive-by fixing them :)
2018-02-13 14:26:04 +01:00
Emilio Cobos Álvarez
a02431d2ef
style: Avoid an intermediate buffer in Servo_Shorthand_AnimationValues_Serialize. 2018-02-13 14:11:45 +01:00
bors-servo
b1d3d6f632
Auto merge of #19975 - paulrouget:killbhtml, r=mbrubeck,emilio
Kill browserhtml

Fixes https://github.com/servo/servo/issues/19971

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19975)
<!-- Reviewable:end -->
2018-02-13 04:54:47 -05:00
bors-servo
9e64008e75
Auto merge of #19754 - ferjm:innertext, r=mbrubeck
Implement element.innerText getter

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19754)
<!-- Reviewable:end -->
2018-02-13 03:41:48 -05:00
Paul Rouget
ee25413c0f report panic to embedder 2018-02-13 09:40:08 +01:00
Paul Rouget
d09bb477f9 remove mozbrowser tests 2018-02-13 09:40:07 +01:00
Paul Rouget
da349ee8a9 remove mozbrowser code 2018-02-13 09:40:06 +01:00
Fernando Jiménez Moreno
2a4535f43e Implement element.innerText getter 2018-02-13 09:12:00 +01:00
bors-servo
3d6ce6c36a
Auto merge of #20033 - upsuper:font-space, r=emilio
Output unquoted family name as a series of identifiers

It tries to serialize unquoted family names as a series of identifiers. For family names which contain special white spaces like leading white space, trailing white space, and consective white spaces, unquoted names are marked quoted in parsing to avoid complicating serialization code.

This fixes [bug 1434802](https://bugzilla.mozilla.org/show_bug.cgi?id=1434802).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20033)
<!-- Reviewable:end -->
2018-02-12 18:21:47 -05:00
Xidorn Quan
caa15ab6a7 Output unquoted family name as a series of identifiers.
It tries to serialize unquoted family names as a series of identifiers.
For family names which contain special white spaces like leading white
space, trailing white space, and consective white spaces, unquoted names
are marked quoted in parsing to avoid complicating serialization code.
2018-02-13 09:17:19 +11:00
bors-servo
62e1fc7899
Auto merge of #19963 - paavininanda:Issue#19958, r=<try>
Correct default SelectionStart and SelectionEnd

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] Added unit tests and wpt for these changes
- [x] These changes fix #19958

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19963)
<!-- Reviewable:end -->
2018-02-12 11:56:27 -05:00
Bastien Orivel
9faa579c89 Bump syn/quote in style_derive 2018-02-12 17:08:55 +01:00
Bastien Orivel
cf6330b6c1 Bump syn/quote in malloc_size_of_derive 2018-02-12 17:08:19 +01:00
Bastien Orivel
3670d4d3e5 Bump syn/quote in jstraceable_derive 2018-02-12 17:07:58 +01:00
Bastien Orivel
c18137b4ea Bump syn/quote in domobject_derive 2018-02-12 17:07:40 +01:00
bors-servo
e0b38f9c49
Auto merge of #20025 - servo:derive-all-the-things, r=emilio
Merge similar arms in AnimationValue::from_declaration 🐉🐲

This slims that function by 12KB according to bloaty.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20025)
<!-- Reviewable:end -->
2018-02-12 10:46:42 -05:00
bors-servo
66141e95bb
Auto merge of #20024 - servo:jdm-patch-17, r=emilio
Propagate error code from fetching WPT changes.

http://build.servo.org/builders/mac-nightly/builds/606 shows a completely error-free run, despite encountering an error early on in `./etc/ci/update-wpt-checkout fetch-and-update-expectations`. We were swallowing the nonzero error code in this case.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20024)
<!-- Reviewable:end -->
2018-02-12 10:02:01 -05:00
Bastien Orivel
0a0d37bea3 Bump syn/quote in deny_public_fields 2018-02-12 15:05:18 +01:00
bors-servo
3a42f6f988
Auto merge of #20030 - emilio:useless-return-is-useless, r=nox
style: Remove useless code after #19994

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20030)
<!-- Reviewable:end -->
2018-02-12 08:47:36 -05:00
Emilio Cobos Álvarez
9744840e5a
style: Remove useless code after #19994 2018-02-12 13:52:29 +01:00
bors-servo
889bb012ef
Auto merge of #20027 - emilio:bye-ordermap, r=nox
style: Back out ordermap.

It was worth a shot!

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20027)
<!-- Reviewable:end -->
2018-02-12 07:36:04 -05:00