Ms2ger
3e031bdaf8
Make parse_html's base_url argument non-optional.
...
It turns out the case where it woul be None can't happen.
2014-12-08 12:44:49 +01:00
Ms2ger
c7c7dc03ee
Move the networking code in parse_html into ScriptTask::load.
...
This doesn't really have anything to do with parsing HTML, and fits in better
with the code in ScriptTask::load. In particular, all changes to Page's url
now go through ScriptTask methods.
2014-12-08 12:44:49 +01:00
Ms2ger
de318ae8f1
Simplify the LoadData creation in parse_html.
2014-12-08 12:44:49 +01:00
Ms2ger
5d0934d8ec
Pass the load data to parse_html directly, rather than in an Option.
2014-12-08 12:44:49 +01:00
Ms2ger
69e13f3267
Cleanup last_loaded_url/last_url handling in ScriptTask::load.
2014-12-08 12:44:49 +01:00
Ms2ger
6374d74d6e
Simplify the content_changed call in ScriptTask::load.
2014-12-08 12:44:49 +01:00
bors-servo
ea907c1311
auto merge of #4266 : Ms2ger/servo/js-document-crash, r=Manishearth
...
This prevents a crash when the script in the javascript URL accesses the
document attribute.
2014-12-08 02:49:06 -07:00
bors-servo
bdb3a2538b
auto merge of #4257 : johnathan79717/servo/4008, r=jdm
...
This is a fix for issue #4008 .
2014-12-08 01:55:08 -07:00
bors-servo
673dc33971
auto merge of #4277 : mttr/servo/style_button_element, r=SimonSapin
2014-12-07 22:22:07 -07:00
bors-servo
ccef723851
auto merge of #4207 : glennw/servo/fix-cef, r=larsbergstrom
2014-12-07 15:25:07 -07:00
Glenn Watson
ad9e76b04c
Update cargo.lock for CEF and fix left over line from libgreen removal.
2014-12-08 08:03:06 +10:00
Glenn Watson
b12311ada5
Fix path for CEF build.
2014-12-08 07:36:56 +10:00
Matthew Rasmus
e520cfd86b
servo.css: Style <button> like <input type=button>
2014-12-07 13:00:04 -08:00
bors-servo
a6768b6244
auto merge of #4269 : mttr/servo/mach_test_fix, r=mbrubeck
...
When running commands through Registrar.dispatch, mach does not behave
in the same way it would as if it were running through the command line.
Defaults normally provided through a combination of @CommandArgument and
argparse magic are ignored.
I have some ideas as to how to fix this, but until then, this will allow
`./mach test` to run through test-unit properly.
2014-12-06 13:49:03 -07:00
Matthew Rasmus
2bdf84d5f7
Fix breakage of ./mach test
...
When running commands through Registrar.dispatch, mach does not behave
in the same way it would as if it were running through the command line.
Defaults normally provided through a combination of @CommandArgument and
argparse magic are ignored.
I have some ideas as to how to fix this, but until then, this will allow
`./mach test` to run through test-unit properly.
2014-12-06 09:23:10 -08:00
bors-servo
c68e2af0a7
auto merge of #4263 : Ms2ger/servo/or_init, r=jdm
2014-12-06 08:01:06 -07:00
Ms2ger
f0ef1f97ad
Use or_init where appropriate.
2014-12-06 15:59:17 +01:00
bors-servo
b805e74fef
auto merge of #4265 : ProgramFOX/servo/issue-4251, r=Ms2ger
...
Resolves #4251
2014-12-06 07:31:01 -07:00
Ms2ger
10e39161f7
Create the root frame before evaluating the javascript URL.
...
This prevents a crash when the script in the javascript URL accesses the
document attribute.
2014-12-06 15:04:37 +01:00
bors-servo
2d0e96e133
auto merge of #4229 : mttr/servo/mach_unit_test_select_component, r=Manishearth
...
Example usage:
`./mach test-unit -c style`
2014-12-06 04:49:00 -07:00
bors-servo
3eec780c00
auto merge of #4262 : tamird/servo/4261, r=jdm
...
`self` is never used, so there's no need for this to be a method.
Fixes #4261 . @jdm
2014-12-06 04:28:01 -07:00
bors-servo
19c69b1625
auto merge of #4002 : Manishearth/servo/activation, r=jdm
...
Still need to impl `Activatable` on all activatable elements. I'll probably push those changes to this PR, however they can be made separately as well.
2014-12-06 03:55:04 -07:00
Manish Goregaokar
5511e02a78
Add Comparable trait to js.rs; fixups
2014-12-06 02:51:52 -08:00
Jonathan Hao
8b8eea15c7
Remove an expected failure from tests/wpt/metadata/dom/events/EventTarget-dispatchEvent.html.ini
2014-12-06 02:04:55 -08:00
bors-servo
507fdbeb6d
auto merge of #4264 : Ms2ger/servo/panic, r=jdm
2014-12-06 02:37:04 -07:00
Ms2ger
6322b0bfab
Clarify the panic in get_uint_attribute.
2014-12-06 10:19:05 +01:00
Tamir Duberstein
b916974f78
should_move_clip_rect
is a bare function
...
`self` is never used, so there's no need for this to be a method.
Fixes #4261 .
2014-12-05 20:11:02 -08:00
bors-servo
33836715a8
auto merge of #4254 : medopaw/servo/settimeout-on-sync-error, r=Manishearth
...
fix #4253
2014-12-05 20:13:02 -07:00
Manish Goregaokar
e7b3caa386
Add oninput/onchange so tests work
2014-12-05 18:49:34 -08:00
Manish Goregaokar
e7ac792ed6
Switch to NodeFlags (the footprint has not changed)
2014-12-05 18:34:53 -08:00
Manish Goregaokar
b20d7d89c1
Switch over to query_selector_iter
2014-12-05 18:34:52 -08:00
Manish Goregaokar
3ba4bba28b
Implement QuerySelectorIterator ( fixes #4082 )
2014-12-05 18:34:52 -08:00
Manish Goregaokar
a2f7e0fbd6
Address review comments
2014-12-05 18:34:51 -08:00
Manish Goregaokar
6482e313d6
Implement implicit form submission
2014-12-05 18:34:49 -08:00
Manish Goregaokar
c89ec3910f
Hook up synthetic click activation to script_task and <>.click()
2014-12-05 18:33:03 -08:00
Manish Goregaokar
e68119f82f
Move InputRadio to Activatable
2014-12-05 18:32:13 -08:00
Manish Goregaokar
a5180a473d
Refactor code for fetching radio siblings
2014-12-05 18:32:13 -08:00
Manish Goregaokar
14a6e54371
Move InputCheckbox to Activatable
2014-12-05 18:32:13 -08:00
Manish Goregaokar
d1547e3a7c
Move InputSubmit to Activatable
2014-12-05 18:32:13 -08:00
Manish Goregaokar
2ed9626f1a
Some reorganization of activation code:
...
- Make method name apply to trait implementor better (When a user agent is to run post-click activation steps on an element, it must run the activation behavior defined for that element)
- Mention invariants and conditions on authentic_click_activation
2014-12-05 18:32:12 -08:00
Manish Goregaokar
03207dea81
Hook up authentic click activation to the script task
2014-12-05 18:32:12 -08:00
Manish Goregaokar
ddfa0c7de7
Implement basic (unhooked) framework for element activation
2014-12-05 18:32:12 -08:00
Manish Goregaokar
c3fdd60adc
Add trusted setter to Event
2014-12-05 18:32:12 -08:00
Manish Goregaokar
e2376a64bf
Add stub Activatable trait
2014-12-05 18:32:11 -08:00
Manish Goregaokar
7d51a543d8
Implement form control mutability, rename FormOwner -> FormControl
2014-12-05 18:32:11 -08:00
Manish Goregaokar
2c2d741b1f
Split up the InputButton variant
2014-12-05 18:32:11 -08:00
Med0paW
dacd21ac52
Issue 4253 - Setting timeout on a sync XHR should throw InvalidAccessErr
2014-12-05 18:29:39 -08:00
bors-servo
bc7b5b35b4
auto merge of #4234 : tterribe/servo/issue4158, r=metajack
...
This makes these parameters self-documenting.
This patch does not attempt to push those enums into the data
structures that feed calls to this function.
Fixes #4158 .
2014-12-05 17:34:03 -07:00
bors-servo
d5c62ac2c4
auto merge of #4256 : ema-fox/servo/password_input, r=jdm
2014-12-05 17:13:05 -07:00
bors-servo
a369dcfa01
auto merge of #4152 : mttr/servo/textview, r=jdm
...
Fixes #3918
Can be tested in `tests/html/textarea.html`. Also implemented some content reflecting IDL attributes for HTMLTextAreaElement while I was in there.
There are some major problems with TextInput when Multiple is enabled that I haven't addressed here, but I'm prepared to open up a follow-up issue.
2014-12-05 16:25:07 -07:00