Commit graph

37596 commits

Author SHA1 Message Date
Manish Goregaokar
480a9988d1 Update requiredness of some fields 2019-07-02 10:10:58 -07:00
Manish Goregaokar
c19240a454 Update to latest xrtest api 2019-07-01 17:42:46 -07:00
bors-servo
faea7716cf
Auto merge of #23575 - asajeffrey:webvr-glwindow-eventloop, r=Manishearth
Pass events loop to glwindow test webvr implementation

<!-- Please describe your changes on the following line: -->

Pass the event loop to the glwindow webvr test device, so it can implement keyboard controls. The matching rust-webvr PR is https://github.com/servo/rust-webvr/pull/84

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this enables testing webvr pose

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23575)
<!-- Reviewable:end -->
2019-07-01 18:15:09 -04:00
Alan Jeffrey
1e5e3c95c9 Pass events loop to glwindow test webvr implementation 2019-07-01 11:55:43 -05:00
bors-servo
18477d1e1e
Auto merge of #23574 - asajeffrey:glutin-reduce-borrow-duration, r=paulrouget
Don't process events while borrowing the event loop

<!-- Please describe your changes on the following line: -->

At the moment, the glutin embedder holds onto a borrow of the events loop while processing events, which is dangerous if any of the event handlers end up using the events loop reentrantly. (This caused a panic while integrating https://github.com/servo/rust-webvr/pull/84.)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is low-level embedding code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23574)
<!-- Reviewable:end -->
2019-07-01 10:01:46 -04:00
Alan Jeffrey
f2a64db151 Dead code elimination 2019-07-01 09:00:59 -05:00
bors-servo
da168de296
Auto merge of #23662 - atouchet:test, r=jdm
Remove passing test

<!-- Please describe your changes on the following line: -->
This was added in #23310. Was that a mistake?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23662)
<!-- Reviewable:end -->
2019-06-30 11:10:45 -04:00
bors-servo
3e446ef718
Auto merge of #23667 - saschanaz:msbuild2019, r=jdm
Support VS Build Tools 2019

<!-- Please describe your changes on the following line: -->

This detects VS Build Tools 2019 installation, which optionally provides VC2017 to be compatible with Servo.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23666

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23667)
<!-- Reviewable:end -->
2019-06-30 08:50:50 -04:00
Kagami Sascha Rosylight
8cd436c892 Support VS Build Tools 2019 2019-06-30 19:12:47 +09:00
Alex Touchet
534c1dff8d
Remove passing test 2019-06-29 21:08:54 -07:00
bors-servo
489ff5e932
Auto merge of #23310 - KaczuH:add-domain-lookup-start, r=jdm
Add domain_lookup_start functionality

<!-- Please describe your changes on the following line: -->
Added the domain_lookup_start functionality in http_loader.rs (http_redirect_fetch function)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21259 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23310)
<!-- Reviewable:end -->
2019-06-29 20:37:54 -04:00
Josh Matthews
98be2df981
Remove passing test. 2019-06-29 20:37:27 -04:00
Kamil Niski
d84513cc50 Add PerformanceResourceTiming: domainLookupStart
Remove wpt tests for domainLookupStart

Set ResourceAttribute::DomainLookupTime

Move DomainLookupStart timing before HTTP request initialization

Change label of domainLookupStart TAO zero test to PASS

Adjust the from_resource_timing method to initialize domain_lookup_start value

Restore domainLookupsStart test
2019-06-30 00:20:26 +02:00
bors-servo
23c49bbbea
Auto merge of #23344 - KaczuH:enter_dom_compartment_wrapper, r=jdm
Enter dom compartment wrapper

I'm still not sure if the changes are entirely correct.
Replaced occurrences:
 `JSAutoCompartment::new(global.get_cx(), global.reflector().get_jsobject().get());` with `fn enter_compartment(object: &DomObject) -> JSAutoCompartment`

There are still occurrences of `JSAutoCompartment` that i was unable to replace. Could anyone give me a hint if it is possible?
```
→ rg -Fi --type rust "JSAutoCompartment::"
components/script/compartments.rs
38:    JSAutoCompartment::new(

components/script/dom/create.rs
159:                                let _ac = JSAutoCompartment::new(

components/script/dom/eventtarget.rs
527:                let _ac = JSAutoCompartment::new(cx, self.reflector().get_jsobject().get());

components/script/dom/windowproxy.rs
223:            let _ac = JSAutoCompartment::new(cx, window_jsobject.get());

components/script/dom/customelementregistry.rs
337:            let _ac = JSAutoCompartment::new(cx, proto_object.get());
349:            let _ac = JSAutoCompartment::new(cx, constructor.get());
538:            let _ac = JSAutoCompartment::new(cx, self.constructor.callback());
668:        let _ac = JSAutoCompartment::new(cx, constructor.callback());

components/script/dom/window.rs
2216:            let _ac = JSAutoCompartment::new(cx, obj.get());

components/script/dom/paintworkletglobalscope.rs
254:        let _ac = JSAutoCompartment::new(cx, self.worklet_global.reflector().get_jsobject().get());

components/script/dom/globalscope.rs
544:                let _ac = JSAutoCompartment::new(cx, globalhandle.get());

components/script/dom/websocket.rs
573:            let _ac = JSAutoCompartment::new(cx, ws.reflector().get_jsobject().get());

components/script/dom/workerglobalscope.rs
397:                        let _ac = JSAutoCompartment::new(

components/script/dom/promise.rs
144:        let _ac = JSAutoCompartment::new(cx, global.reflector().get_jsobject().get());
156:        let _ac = JSAutoCompartment::new(cx, global.reflector().get_jsobject().get());

components/script/dom/bindings/htmlconstructor.rs
118:        let _ac = JSAutoCompartment::new(window.get_cx(), callee.get());

components/script/dom/bindings/utils.rs
411:    let _ac = JSAutoCompartment::new(cx, obj.get());

components/script/dom/bindings/callback.rs
276:                let _ac = JSAutoCompartment::new(

components/script/dom/bindings/interface.rs
163:    let _ac = JSAutoCompartment::new(cx, rval.get());
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix  #23266

<!-- Either: -->
- [X] These changes do not require tests because no logic was changed only some code extracted to wrapper function

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23344)
<!-- Reviewable:end -->
2019-06-29 13:55:45 -04:00
Kamil Niski
adb402487e Create a helper API for entering a DOM object's compartment
Revert some unnecessary changes

Fix fmt errors
2019-06-29 19:23:17 +02:00
bors-servo
14cddab699
Auto merge of #23660 - servo-wpt-sync:wpt_update_29-06-2019, r=servo-wpt-sync
Sync WPT with upstream (29-06-2019)

Automated downstream sync of changes from upstream as of 29-06-2019.
[no-wpt-sync]
2019-06-29 10:17:39 -04:00
WPT Sync Bot
686c6b89ed Update web-platform-tests to revision c0a3e93389bdcc9e8ad12d3988e4568d48b78c9d 2019-06-29 14:17:20 +00:00
bors-servo
84786add22
Auto merge of #23653 - Manishearth:nested, r=jdm
Improve support for nested dictionaries

Fixes https://github.com/servo/servo/issues/23640

Some IDLs need `= null`, that's something that needs to be updated upstream too.

After talking with @bzbarsky I realized that it was our IDLs which were incorrect, causing Options to appear where we don't want them to. In the media code we _do_ want Options. `= null` is the correct fix for that (and should be upstreamed).

r? @jdm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23653)
<!-- Reviewable:end -->
2019-06-28 20:44:41 -04:00
bors-servo
177b2a6fa9
Auto merge of #23649 - jdm:marketplace, r=jdm
Add support for market:// urls

Rebased from #23648.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21992.
- [x] These changes do not require tests because can't test embedders.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23649)
<!-- Reviewable:end -->
2019-06-28 17:31:25 -04:00
akshitkrnagpal
027514c3e6 Add support for market:// urls 2019-06-28 17:30:42 -04:00
bors-servo
f81da9824e
Auto merge of #23647 - jdm:wpt-permissions, r=Manishearth
Run DOM permissions tests in WPT.

We have an implementation, so we should be testing it to catch problems like #23645.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23647)
<!-- Reviewable:end -->
2019-06-28 14:14:17 -04:00
bors-servo
2e9637477c
Auto merge of #23628 - emilio:path-shuffling-cleanup, r=Manishearth
build: Cleanup some path-munging code.

I was looking at this today, and this seems better than the pre-existing code,
generally pre-pending to these paths isn't great...

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23628)
<!-- Reviewable:end -->
2019-06-28 12:18:36 -04:00
Josh Matthews
6ebd8dd2e6 Run permissions tests in WPT. 2019-06-28 10:14:46 -04:00
bors-servo
a8f4c64021
Auto merge of #23650 - optmzr:fix-gentoo-instructions, r=jdm
Update Gentoo instructions to work with 17.1 and add missing dependency

 * libunwind was required when building.
 * Since Gentoo 17.1 the symlink between lib and lib64 has been removed.
    - Update export so it works with both older and newer profiles.
---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

- [ ] There are tests for these changes OR
- [X] These changes do not require tests because it's installation instructions / documentation

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23650)
<!-- Reviewable:end -->
2019-06-28 00:40:25 -04:00
Manish Goregaokar
3c7ceff46d Improve support for nested dictionaries 2019-06-27 18:13:23 -07:00
bors-servo
2a667648fa
Auto merge of #23644 - servo-wpt-sync:wpt_update_27-06-2019, r=servo-wpt-sync
Sync WPT with upstream (27-06-2019)

Automated downstream sync of changes from upstream as of 27-06-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23644)
<!-- Reviewable:end -->
2019-06-27 20:21:46 -04:00
William Wennerström
b7308dcf8b
Update Gentoo instructions to work with 17.1 and add missing dependency
* libunwind was required when building.
 * Since Gentoo 17.1 the symlink between lib and lib64 has been removed.
    - Update export so it works with both older and newer profiles.
2019-06-27 21:41:10 +02:00
bors-servo
9e12b4175e
Auto merge of #23583 - servo:jdm-patch-56, r=SimonSapin
Force clang use on all platforms.

gcc builds are unlinkable on Linux at the moment. Let's standardize on clang.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23583)
<!-- Reviewable:end -->
2019-06-27 13:34:20 -04:00
Josh Matthews
6167005997 Set CC/CXX defaults right before starting cargo build. 2019-06-27 18:40:56 +02:00
WPT Sync Bot
67592a2228 Update web-platform-tests to revision ef44bff0adaa07f2e420a0cbc1bc493cd5786656 2019-06-27 14:52:50 +00:00
bors-servo
61cadfa9a6
Auto merge of #23539 - oneturkmen:script-remove-opts-get, r=jdm
Script: removed a few opts::get()

<!-- Please describe your changes on the following line: -->
I removed only a few opts::get() from the components/script because all other code with "opts::get()" is reused by many other parts within the same component.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix *partially* #22854 (GitHub issue number if applicable)

<!-- Either: -->
- [x] These changes do not require tests because these are cleanup changes.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23539)
<!-- Reviewable:end -->
2019-06-27 00:48:20 -04:00
oneturkmen
42569280e2 Script: removed a few opts::get() 2019-06-26 22:23:07 -06:00
bors-servo
57205318c5
Auto merge of #23587 - jdm:smup67, r=asajeffrey
Upgrade to SpiderMonkey 67

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23587)
<!-- Reviewable:end -->
2019-06-26 18:51:14 -04:00
Josh Matthews
63714c90fb Upgrade to Spidermonkey 67. 2019-06-26 18:10:46 -04:00
bors-servo
d170f43b53
Auto merge of #23636 - asajeffrey:webvrup, r=jdm
Update to rust-webvr 0.11.5

<!-- Please describe your changes on the following line: -->

Update to rust-webvr 0.11.5, which includes magicleap 6DoF pose.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because we don't have magicleap test infra

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23636)
<!-- Reviewable:end -->
2019-06-26 16:46:32 -04:00
Alan Jeffrey
13c2c55ce0 Updated to rust-webvr 0.11.5 2019-06-26 11:24:00 -05:00
Alan Jeffrey
373ae0e341 Handle resize events during run_forever 2019-06-26 10:13:22 -05:00
bors-servo
a06a573f80
Auto merge of #23635 - servo-wpt-sync:wpt_update_26-06-2019, r=servo-wpt-sync
Sync WPT with upstream (26-06-2019)

Automated downstream sync of changes from upstream as of 26-06-2019.
[no-wpt-sync]
2019-06-26 09:58:37 -04:00
WPT Sync Bot
12f4ae132e Update web-platform-tests to revision 66dc9c93f2c8ebd7c8fdc28fae20d92713c97806 2019-06-26 13:58:19 +00:00
bors-servo
e488ea750b
Auto merge of #23633 - servo:buildbot, r=jdm
Remove some jobs from Buildbot

* `arm64`: “no good reason to continue to maintain”: https://github.com/servo/servo/pull/23414#issuecomment-505045672
* `mac-rel-intermittent`: disabled since https://github.com/servo/saltfs/pull/965
* `linux-rel-intermittent`: judged unnecessary https://github.com/servo/servo/pull/23633#issuecomment-505576450
* `linux-nigthly`: only perf data collection and upload now. Closes https://github.com/servo/servo/issues/23302, where this jobs has been know to be broken for 8 weeks but nobody cared enough to fix it

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23633)
<!-- Reviewable:end -->
2019-06-25 18:27:49 -04:00
Simon Sapin
91da718253 Also remove linux-rel-intermittent
Judged unnecessary: https://github.com/servo/servo/pull/23633#issuecomment-505576450
2019-06-25 21:37:30 +02:00
Simon Sapin
251315dbaf Remove some jobs from Buildbot
* `arm64`: “no good reason to continue to maintain”: https://github.com/servo/servo/pull/23414#issuecomment-505045672
* `mac-rel-intermittent`: disabled since https://github.com/servo/saltfs/pull/965
* `linux-nigthly`: only perf data collection and upload now. Closes https://github.com/servo/servo/issues/23302, where this jobs has been know to be broken for 8 weeks but nobody cared enough to fix it
2019-06-25 20:34:10 +02:00
bors-servo
e100af57a5
Auto merge of #23605 - servo:jdm-patch-28, r=SimonSapin
Always create a WPT update task.

This fixes #23603.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23605)
<!-- Reviewable:end -->
2019-06-25 11:01:05 -04:00
bors-servo
1001c7a441
Auto merge of #23609 - emilio:gecko-sync, r=emilio
style: Sync changes from mozilla-central.

See individual commits for details.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23609)
<!-- Reviewable:end -->
2019-06-25 08:37:14 -04:00
Emilio Cobos Álvarez
d1640f43bd
Update WPT expectations. 2019-06-25 13:11:33 +02:00
Emilio Cobos Álvarez
dd65470dd9
style: Rustfmt again. 2019-06-25 13:11:32 +02:00
Emilio Cobos Álvarez
15f7daf5f5
Update test expectations. 2019-06-25 13:11:32 +02:00
Emilio Cobos Álvarez
a7e441fc15
style: Servo doesn't implement white-space: break-spaces. 2019-06-25 13:11:32 +02:00
Emilio Cobos Álvarez
36c39d53f7
style: Give up on test_parse_stylesheet.
It's not particularly useful.
2019-06-25 13:11:32 +02:00
Emilio Cobos Álvarez
add08518cd
Fix style system build with recent changes. 2019-06-25 13:11:32 +02:00