Commit graph

13340 commits

Author SHA1 Message Date
Nathan Froyd
50b14e6670 add un-premultiply table for GetImageData
Fixes #6969.
2015-10-20 04:51:29 -04:00
bors-servo
6111cf9ffc Auto merge of #7943 - pierrechevalier83:fix_issue_7941, r=Ms2ger
Clarify some code in do_create_interface_objects

rval.get() is believed to be always null upon entering this function.
This assumption is verified by the added assertion.
It makes more sense to move the block of code that was moved inside
the if statement which is the only place where it can be initialized.

Fixes #7941.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7943)
<!-- Reviewable:end -->
2015-10-19 09:37:03 -06:00
bors-servo
2e308e9ecc Auto merge of #8068 - martiansideofthemoon:my-code-fix, r=Manishearth
Implementing getAttributeNode() and similar methods

Attempting to solve #8066 Does it look good so far @Manishearth ?

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8068)
<!-- Reviewable:end -->
2015-10-19 07:58:41 -06:00
bors-servo
eeffa795a7 Auto merge of #8025 - frewsxcv:remove-app-units-from-tree, r=nox
Remove 'app_units' component from tree

Part of #8012

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8025)
<!-- Reviewable:end -->
2015-10-19 07:26:17 -06:00
bors-servo
1a376aa75d Auto merge of #8060 - nox:deref-js, r=Ms2ger
Implement Deref<Target=T> for JS<T> where T: Reflectable

We can only borrow `JS<T>` from rooted things, so it's safe to deref it.
The only types that provide mutable `JS<T>` things are `MutHeap<JS<T>>` and
`MutNullableHeap<JS<T>>`, which don't actually expose that they contain
`JS<T>` values.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8060)
<!-- Reviewable:end -->
2015-10-19 06:32:05 -06:00
KALPESH KRISHNA
3971b8ce27 Implementing getAttributeNode() and similar methods. 2015-10-19 16:14:43 +05:30
bors-servo
50ad1b064d Auto merge of #8071 - romankl:gh/8063, r=nox
remove unused methods from ThreadSafeLayoutNode

`get_input_size ` and `get_input_value ` aren't used in the codebase.

Ref.-Issue: #8063

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8071)
<!-- Reviewable:end -->
2015-10-19 04:32:34 -06:00
bors-servo
ff2151b8bb Auto merge of #7935 - bholley:eventstate_element, r=nox
Move event state from Node to Element

Just getting my feet wet with Rust here. Please feel free to nit the hell out of it stylistically and idiomatically. :-)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7935)
<!-- Reviewable:end -->
2015-10-19 02:47:21 -06:00
Anthony Ramine
6dc42dd1d6 Do not root XMLHttpRequest::upload 2015-10-19 09:37:09 +02:00
Anthony Ramine
d28de59e4a Return a reference in ServoHTMLParser::window() 2015-10-19 09:37:08 +02:00
Anthony Ramine
da06341578 Do not root ServoHTMLParser::document 2015-10-19 09:37:07 +02:00
Anthony Ramine
7c47a6b78e Do not root Sink::document 2015-10-19 09:37:06 +02:00
Anthony Ramine
b0d1ccdf5f Do not root Performance::timing 2015-10-19 09:37:05 +02:00
Anthony Ramine
17cd4202e7 Do not root ChildrenList::node 2015-10-19 09:37:04 +02:00
Anthony Ramine
b149e0c979 Do not root NodeIterator::root_node 2015-10-19 09:37:03 +02:00
Anthony Ramine
6849510526 Do not root NamedNodeMap::owner 2015-10-19 09:37:02 +02:00
Anthony Ramine
5889a75b10 Do not root Location::window 2015-10-19 09:37:01 +02:00
Anthony Ramine
dee3aecea1 Do not root HTMLScriptElement::parser_document 2015-10-19 09:37:00 +02:00
Anthony Ramine
e8f358d178 Do not root InputActivationState::checked_radio 2015-10-19 09:36:58 +02:00
Anthony Ramine
71dcabfad8 Do not root DOMTokenList::element 2015-10-19 09:36:57 +02:00
Anthony Ramine
822e6f0d48 Do not root DOMStringMap::element 2015-10-19 09:36:56 +02:00
Anthony Ramine
ff0da2f642 Do not root DOMParser::window 2015-10-19 09:36:55 +02:00
Anthony Ramine
ce6aab6cb1 Do not root DOMImplementation::document 2015-10-19 09:36:54 +02:00
Anthony Ramine
6ab7f64620 Return a reference in BrowserContext::active_window() 2015-10-19 09:36:53 +02:00
Anthony Ramine
409b5e3695 Return a reference in Document::window() 2015-10-19 09:36:52 +02:00
Anthony Ramine
e889b0914b Do not root Document::window 2015-10-19 09:36:51 +02:00
Roman Klauke
b5439a7c61 remove unused methods from ThreadSafeLayoutNode
`get_input_size ` and `get_input_value ` aren't used in the codebase.

Ref.-Issue: #8063
2015-10-18 22:17:34 +02:00
bors-servo
b847e4dd77 Auto merge of #8059 - frewsxcv:fix-codegen-docs, r=jdm
Fix formatting for variable in doc-comment within codegen



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8059)
<!-- Reviewable:end -->
2015-10-18 07:55:48 -06:00
bors-servo
23fa9de714 Auto merge of #8038 - martiansideofthemoon:my-code-fix, r=jdm
Adding window.onstorage WindowEventHandler

Well it built successfully this time around 😄 @jdm . Working to solve #7994

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8038)
<!-- Reviewable:end -->
2015-10-17 22:36:13 -06:00
bors-servo
810d28a257 Auto merge of #7415 - tschneidereit:dom-rect, r=nox
Improve implementation of DOMRect and implement DOMRectReadOnly

Passes most tests from test-css. The remaining ones should pass once we have https://github.com/w3c/csswg-test/pull/834.

r? @Ms2ger

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7415)
<!-- Reviewable:end -->
2015-10-17 15:17:27 -06:00
Till Schneidereit
4c1c05fac6 Improve implementation of DOMRect and implement DOMRectReadOnly
Passes most tests from test-css.
2015-10-17 22:47:01 +02:00
Till Schneidereit
499a847141 Whitelist drafts.fxtf.org in tidy.py's webidl spec link check 2015-10-17 22:25:21 +02:00
Corey Farwell
26abff9663 Fix formatting for variable in doc-comment within codegen 2015-10-17 15:20:12 -04:00
bors-servo
ef8119511c Auto merge of #7977 - frewsxcv:htmltablerowelement-insertcell-deletecell, r=eefriedman
Implement HTMLTableRowElement insertCell and deleteCell



<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7977)
<!-- Reviewable:end -->
2015-10-16 23:54:52 -06:00
bors-servo
45ed1e7bc1 Auto merge of #8057 - frewsxcv:reftests, r=jdm
Use wptrunner for some old-style reftests.

Part of #5618

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8057)
<!-- Reviewable:end -->
2015-10-16 23:16:20 -06:00
Corey Farwell
1f58169263 Implement HTMLTableRowElement insertCell and deleteCell 2015-10-17 00:07:22 -04:00
Corey Farwell
c10eecf671 Move inset.html to wpt reftests. 2015-10-16 21:50:50 -04:00
Corey Farwell
e35846eb36 Move inline_padding_a.html to wpt reftests. 2015-10-16 21:50:49 -04:00
Corey Farwell
4f72f82e70 Move inline_border_baseline_a.html to wpt reftests. 2015-10-16 21:50:48 -04:00
Corey Farwell
ca6c655497 Move inline_element_border_a.html to wpt reftests. 2015-10-16 21:50:46 -04:00
Corey Farwell
9673d81618 Move inline_margins_a.html to wpt reftests. 2015-10-16 21:50:45 -04:00
Corey Farwell
990eba8583 Move issue-1324.html to wpt reftests. 2015-10-16 21:50:44 -04:00
Corey Farwell
3b72bb6fce Move letter_spacing_a.html to wpt reftests. 2015-10-16 21:50:43 -04:00
Corey Farwell
8bb3445565 Move jumpiness_a.html to wpt reftests. 2015-10-16 21:50:41 -04:00
Corey Farwell
39efcf7bae Move legacy_td_bgcolor_attribute_a.html to wpt reftests. 2015-10-16 21:50:40 -04:00
Corey Farwell
6ebe6fdebe Move legacy_table_border_attribute_a.html to wpt reftests. 2015-10-16 21:50:39 -04:00
Corey Farwell
b503ffaa8d Move legacy_input_size_attribute_override_a.html to wpt reftests. 2015-10-16 21:50:38 -04:00
Corey Farwell
5b879ae8c0 Move layerization_z_order_a.html to wpt reftests. 2015-10-16 21:50:37 -04:00
Corey Farwell
6580f8f4c7 Move nth_child_pseudo_a.html to wpt reftests. 2015-10-16 21:50:36 -04:00
Corey Farwell
0755f21517 Move word_break_a.html to wpt reftests. 2015-10-16 21:50:34 -04:00