Commit graph

43005 commits

Author SHA1 Message Date
bors-servo
53467b80b9
Auto merge of #27536 - kunalmohan:update-wgpu, r=kvark
Major fixes in error reporting in GPUCommandEncoder and ErrorScope Model

<!-- Please describe your changes on the following line: -->
1. Update wgpu to use the error model on wgpu-core side. Register error Ids separately.
2. ~~Record errors only in `GPUCommandEncoder.finish()`. Errors are no longer recorded in ErrorScopes in transfer commands or while recording passes. Any errors that occur are stored on the server-side in `error_command_encoders: HashMap<id::CommandEncoderId, String>` and reported on `CommandEncoderFinish`. Note: This should be reverted when the spec gets updated.~~
3. Correct a major flaw in ErrorScope Model. If multiple operations are issued inside scope and an early operation fails, the promise resolves and script execution continues. The scope, however, was not popped until the results of all its operations were received. This meant that if the user issues another operation, it was assumed to be issued in an error scope that has already been popped by the user, which led to the failure of a number of tests. This is solved by storing a `popped` boolean to check whether `popErrorScope()` has been called on a scope or not. Operation is now issued in the lastest scope for which `popped == false`.

One of the tests used to crash, but it no longer does (All subtests under it fail now). That explains the large number of failing test expectations that have been added. Most of them fail due to the tests being outdated. I'll switch to the updated branch in the next PR.

r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-08-07 15:38:17 -04:00
Kunal Mohan
ecb8c91446 update test expectations 2020-08-07 22:40:18 +05:30
Kunal Mohan
1d80f57aab Record errors in GPUCommandEncoder.BeginPass() and EncoderPass.endPass() 2020-08-07 22:36:05 +05:30
bors-servo
9eab0acbb6
Auto merge of #27543 - paulrouget:strup, r=Manishearth
UWP: better pref label

@Manishearth r?
2020-08-07 12:40:32 -04:00
bors-servo
8067a2fe94
Auto merge of #27537 - jdm:armmedia, r=Manishearth
Use gstreamer on UWP targets

This fixes a regression that cause our arm64 builds to use the dummy media stack by default. Oops.

Fix #27531. Fix #27532.
2020-08-07 10:29:16 -04:00
Josh Matthews
47e6430d30 Pipe GST_DEBUG output to its own log file on UWP. 2020-08-07 10:28:54 -04:00
bors-servo
5854e1500d
Auto merge of #27542 - servo-wpt-sync:wpt_update_07-08-2020, r=servo-wpt-sync
Sync WPT with upstream (07-08-2020)

Automated downstream sync of changes from upstream as of 07-08-2020.
[no-wpt-sync]
r? @servo-wpt-sync
2020-08-07 07:26:26 -04:00
Paul Rouget
872a1f5390 UWP: better pref label 2020-08-07 12:52:36 +02:00
WPT Sync Bot
f99a7ba468 Update web-platform-tests to revision 688aeffbd02c1e05a159c64938ad9b43e3d8ec6e 2020-08-07 10:51:32 +00:00
bors-servo
4d1b96e605
Auto merge of #27522 - jdm:home-override, r=paulrouget
Use override value for home button when available.

Fixes #27521.
2020-08-07 06:26:59 -04:00
Kunal Mohan
78c9466fdb fix ErrorScope model 2020-08-07 11:35:50 +05:30
bors-servo
080e9dc6df
Auto merge of #27538 - asajeffrey:webxr-texture-invalidation, r=Manishearth
Make textures that come from webxr invalid outside an rAF

<!-- Please describe your changes on the following line: -->

Implements "The colorTexture and depthStencilTexture objects MUST only be used during the XR animation frame of the current session and MUST be made invalid once the XR animation frame completes." from https://immersive-web.github.io/layers/#xrwebglsubimagetype

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are no tests for these changes because we can't test this until we have projection layers

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-08-06 22:57:35 -04:00
Alan Jeffrey
c1d064b626 Make textures that come from webxr invalid outside an rAF 2020-08-06 17:51:58 -05:00
Josh Matthews
261cf4f641 Enable gstreamer media stack for UWP targets. 2020-08-06 18:27:59 -04:00
bors-servo
776b564db1
Auto merge of #27530 - jdm:media, r=Manishearth
Fix crashes on video playback in UWP

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27529 and fix #27526
- [x] These changes do not require tests because there's no way to test UWP right now.
2020-08-06 16:30:04 -04:00
bors-servo
0573e9c60d
Auto merge of #27425 - jdm:preserve-draw-buffer, r=asajeffrey
Support preserveDrawingBuffer

Depends on https://github.com/asajeffrey/surfman-chains/pull/9 and https://github.com/servo/webxr/pull/190.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24604
- [x] There are tests for these changes
2020-08-06 16:11:26 -04:00
Josh Matthews
a5e488bc2c webgl: Support preserveDrawingBuffer. 2020-08-06 14:25:17 -04:00
Josh Matthews
1839f44dbb Use override value for home button when available. 2020-08-06 14:19:20 -04:00
Josh Matthews
5de6074ad8 Add missing media session callback in UWP embedding. 2020-08-06 14:17:58 -04:00
Josh Matthews
c6049eda7b Enter a realm when handling mediasession commands. 2020-08-06 14:09:38 -04:00
bors-servo
6a7e9ff438
Auto merge of #27512 - jdm:devtools-panic, r=Manishearth
Handle devtools clients disconnecting better

These changes fix many opportunities for the devtools server to panic if a client disconnects early. Now that it's easy to have multiple clients connected simultaneously, this also makes it easier for server code to distinguish between different clients and ensure that one client disconnecting doesn't affect another client that's still connected.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #27509
- [x] These changes do not require tests because the devtools server is a wild west.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-08-06 14:02:17 -04:00
Josh Matthews
f4915ef6c9 devtools: Track multiple clients better, and cleanup streams when a client isn't reachable. 2020-08-06 09:55:01 -04:00
bors-servo
08328c22d6
Auto merge of #27517 - servo-wpt-sync:wpt_update_06-08-2020, r=servo-wpt-sync
Sync WPT with upstream (06-08-2020)

Automated downstream sync of changes from upstream as of 06-08-2020.
[no-wpt-sync]
r? @servo-wpt-sync
2020-08-06 06:31:33 -04:00
WPT Sync Bot
92d17be4fe Update web-platform-tests to revision 5fe9625d7445a6b88640f830d90dd5489c4bda05 2020-08-06 10:31:21 +00:00
Kunal Mohan
072770dbc0 Register invalid resources separately 2020-08-06 10:48:17 +05:30
bors-servo
39c3f46375
Auto merge of #27513 - asajeffrey:webxr-layer-event, r=Manishearth
Add XRLayerEvent

<!-- Please describe your changes on the following line: -->

Implement the `XRLayerEvent` spec.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-08-05 21:22:02 -04:00
Alan Jeffrey
c4dd171dfb Add XRLayerEvent 2020-08-05 18:07:54 -05:00
Josh Matthews
0b619bf920 devtools: Don't panic when sending to a disconnected client fails. 2020-08-05 14:55:48 -04:00
Kunal Mohan
01c8b24e9f update wgpu 2020-08-06 00:21:45 +05:30
bors-servo
90aa0a3d41
Auto merge of #27506 - paulrouget:morePrefMemIssues, r=jdm
Keep C++ pref value in memory longer
2020-08-05 10:58:15 -04:00
Paul Rouget
3b8773940a Keep C++ pref value in memory longer 2020-08-05 16:33:27 +02:00
bors-servo
611c57bfdf
Auto merge of #27491 - paulrouget:devPreviewTab, r=jdm
UWP: only show promoted preferences

This depends on changes made in #27438
Fix #27419
2020-08-05 08:51:13 -04:00
bors-servo
55d21b1210
Auto merge of #27504 - servo-wpt-sync:wpt_update_05-08-2020, r=servo-wpt-sync
Sync WPT with upstream (05-08-2020)

Automated downstream sync of changes from upstream as of 05-08-2020.
[no-wpt-sync]
r? @servo-wpt-sync
2020-08-05 06:35:05 -04:00
WPT Sync Bot
f1ca6b4be4 Update web-platform-tests to revision ad99a9e949c6006cc0f609501de77a0edb1e593a 2020-08-05 10:31:54 +00:00
Paul Rouget
a019db648c Show only a limited list of preferences 2020-08-05 11:41:10 +02:00
bors-servo
6e28d7b3ec
Auto merge of #27500 - jdm:revert-wrup, r=Manishearth
Revert webrender upgrade

These commits revert the webrender and font-related updates from #27207. This will unbreak our FxR nightly builds while we continue to investigate the underlying crash in ANGLE. Unfortunately it also returns us to the status quo of broken canvas text rendering on UWP, but there's no way to upgrade font-kit without any of the other crates because of the underlying freetype dependency changes that happened.

Fixes #27492.
2020-08-04 22:53:40 -04:00
Josh Matthews
98edaee311 Update allowed duplicate crates. 2020-08-04 21:21:23 -04:00
bors-servo
748e60814a
Auto merge of #27490 - servo-wpt-sync:wpt_update_04-08-2020, r=jdm
Sync WPT with upstream (04-08-2020)

Automated downstream sync of changes from upstream as of 04-08-2020.
[no-wpt-sync]
r? @servo-wpt-sync
2020-08-04 20:42:20 -04:00
Josh Matthews
ecfaba9304 Revert "Update raqote, font-kit, fontconfig."
This reverts commit a6ca582a55.
2020-08-04 19:16:19 -04:00
Josh Matthews
6b520850f3 Revert "Update harfbuzz, freetype, unicode-script."
This reverts commit 327fed6084.
2020-08-04 19:16:13 -04:00
Josh Matthews
10ae3bfbbb Revert "Update font-kit and freetype and unicode-script."
This reverts commit 5c0d7998bd.
2020-08-04 19:16:05 -04:00
Josh Matthews
c1920357b0 Revert "Update webrender."
This reverts commit 2ca1b06e77.
2020-08-04 19:15:52 -04:00
bors-servo
f8c8307f94
Auto merge of #27499 - asajeffrey:webxr-xrmedia-dummy, r=Manishearth
Add dummy implementations of missing XR layer types

<!-- Please describe your changes on the following line: -->

Add dummy implementations of the missing layer types, and the functions that create them.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-08-04 19:08:41 -04:00
Alan Jeffrey
a2fa556315 Add tests for layer creation failing 2020-08-04 15:41:51 -05:00
bors-servo
549179bbd6
Auto merge of #27480 - kunalmohan:gpu-void-error, r=kvark
WebGPU-Report errors in Promise or void returning operations

<!-- Please describe your changes on the following line: -->
This also updates GPUBuffer mapping to match latest spec.

r?@kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-08-04 16:37:16 -04:00
Alan Jeffrey
d255dc9f7b Add a dummy implementation of all the XR Layer types 2020-08-04 15:10:01 -05:00
bors-servo
9fbdbddb0c
Auto merge of #27402 - kunalmohan:webgpu-cts, r=jdm
Add a copy of WebGPU CTS to wpt.

<!-- Please describe your changes on the following line: -->
The test suite is generated from `glsl-dependent` branch in https://github.com/gpuweb/cts
We already have 6/44 tests passing and a number of subtests in other tests also pass.

r?@jdm
cc @kvark

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #27395  (GitHub issue number if applicable)

<!-- Either: -->
- [X] These changes do not require tests because we don't have tests for tests.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-08-04 14:12:45 -04:00
bors-servo
9c59dae708
Auto merge of #27481 - Monty0045:master, r=jdm
Support Linux Mint 20.04 for mach bootstrap

<!-- Please describe your changes on the following line: -->
Adds support for Linux Mint 20.04 (based on Ubuntu 20.04) to mach bootstrap.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-08-04 13:17:45 -04:00
Alan Jeffrey
754019f6bc Add test for layers feature (currently always false) 2020-08-04 11:55:06 -05:00
Kunal Mohan
75fb6ca589 Improve intermittent filtering 2020-08-04 21:42:53 +05:30