Commit graph

37215 commits

Author SHA1 Message Date
Emilio Cobos Álvarez
5e4fdf647d style: Implement ArcSlice::default().
Share a singleton to avoid allocating for empty lists.

Differential Revision: https://phabricator.services.mozilla.com/D30543
2019-05-29 16:14:08 +02:00
Emilio Cobos Álvarez
ab8776a144 style: Use OwnedSlice in the specified and computed values of most vector properties.
This is just a refactor in the right direction. Eventual goal is:

 * All inherited properties use ArcSlice<>.
 * All reset properties use OwnedSlice<> (or ThinVec<>).

No conversion happens at all, so we can remove all that glue, and also
compute_iter and co.

Of course there's work to do, but this is a step towards that.

Differential Revision: https://phabricator.services.mozilla.com/D30127
2019-05-29 16:14:07 +02:00
Emilio Cobos Álvarez
b61eb84d96 style: Use ManuallyDrop for style structs.
We destroy them manually, so it's the right thing to do.

This allows us to not run destructors of any members of nsStyle*, which in turn allows us to:

 * Remove the hack that replaced all nsStrings for nsStringReprs.
 * Remove ns{,C}StringRepr (followup)
 * Add members with destructors to the style structs (you see where I'm going :)).

Differential Revision: https://phabricator.services.mozilla.com/D30450
2019-05-29 16:14:07 +02:00
Cameron McCormack
3a22bb6c49 style: Add Gecko profiler labels for when the style threads are doing work.
Differential Revision: https://phabricator.services.mozilla.com/D30869
2019-05-29 16:14:06 +02:00
bors-servo
8dc7a25893
Auto merge of #23381 - maharsh312:master, r=jdm
Canvas Components for OffscreenCanvas

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23381)
<!-- Reviewable:end -->
2019-05-28 23:13:23 -04:00
bors-servo
84ec1316c9
Auto merge of #23471 - asajeffrey:mlsdkup, r=jdm
Update magicleap SDK to v0.20.0+ndk19c

<!-- Please describe your changes on the following line: -->

Updates the magicleap SDK to our (hopefully temporary) frankensdk.
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23458
- [X] These changes do not require tests because this fixes build issues

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23471)
<!-- Reviewable:end -->
2019-05-28 19:06:03 -04:00
Alan Jeffrey
06745fcb9f Update magicleap SDK to v0.20.0+ndk19c 2019-05-28 15:26:35 -05:00
bors-servo
e394c71230
Auto merge of #23469 - servo-wpt-sync:wpt_update_28-05-2019, r=jdm
Sync WPT with upstream (28-05-2019)

Automated downstream sync of changes from upstream as of 28-05-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23469)
<!-- Reviewable:end -->
2019-05-28 14:10:07 -04:00
Josh Matthews
6b8179a57e
Remove intermittent failure. 2019-05-28 11:28:06 -04:00
Josh Matthews
bbccaf1f4c
Remove intermittent failure. 2019-05-28 11:27:38 -04:00
WPT Sync Bot
fde011e73d Update web-platform-tests to revision f915dfd69790e7ca09f9bef4eb08cd30163cb3e3 2019-05-28 13:59:31 +00:00
bors-servo
96ac540a24
Auto merge of #23461 - TheOriginalAlex:issue-23408, r=jdm
Switched from using thread for websocket requests to ipc_channel::router::ROUTER

<!-- Please describe your changes on the following line: -->
Switched from using thread for websocket requests to ipc_channel::router::ROUTER

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #23408  (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because the existing websocket tests should cover these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23461)
<!-- Reviewable:end -->
2019-05-28 07:36:12 -04:00
bors-servo
2ac916b5a1
Auto merge of #23465 - servo-wpt-sync:wpt_update_27-05-2019, r=servo-wpt-sync
Sync WPT with upstream (27-05-2019)

Automated downstream sync of changes from upstream as of 27-05-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23465)
<!-- Reviewable:end -->
2019-05-27 13:06:43 -04:00
WPT Sync Bot
d97dd12540 Update web-platform-tests to revision ecf36e0069be779649c30b647f6b13f2842c14da 2019-05-27 13:57:44 +00:00
bors-servo
2a61a0dbb0
Auto merge of #23464 - kleinph:layout-type-alias-enums, r=jdm
Use type alias enums in layout code

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22862 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because tests should already be there and no functional changes are made.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23464)
<!-- Reviewable:end -->
2019-05-27 09:12:25 -04:00
bors-servo
0957328ee2
Auto merge of #23453 - jdm:no-vcvars, r=paulrouget
Remove restrictions on cross-compiling on Windows.

This allows us to successfully build Servo when targeting UWP.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23453)
<!-- Reviewable:end -->
2019-05-27 06:05:14 -04:00
Philipp Klein
0ed8e6f98e Use type alias enums in layout code
closes #22862
2019-05-27 10:10:10 +02:00
Alex Johnson
1c35c44c35 Fixes #23408
Switched from using thread for websocket requests to ipc_channel::router::ROUTER

Signed-off-by: Alex Johnson <hello@alex-johnson.net>
2019-05-26 09:46:48 -07:00
bors-servo
5b79711ece
Auto merge of #23462 - servo-wpt-sync:wpt_update_26-05-2019, r=servo-wpt-sync
Sync WPT with upstream (26-05-2019)

Automated downstream sync of changes from upstream as of 26-05-2019.
[no-wpt-sync]
2019-05-26 09:57:22 -04:00
WPT Sync Bot
a6792ec098 Update web-platform-tests to revision a4df0fa7be958c11e80caf57fd36c935d11a2a34 2019-05-26 13:57:10 +00:00
bors-servo
4aad79f9d2
Auto merge of #23460 - servo-wpt-sync:wpt_update_25-05-2019, r=servo-wpt-sync
Sync WPT with upstream (25-05-2019)

Automated downstream sync of changes from upstream as of 25-05-2019.
[no-wpt-sync]
2019-05-25 09:58:27 -04:00
WPT Sync Bot
db54f176d0 Update web-platform-tests to revision ac3d096a5972dea5ecca1c43e324086895db7c6f 2019-05-25 13:58:15 +00:00
bors-servo
a97eb93d99
Auto merge of #23457 - jdm:glutes, r=jdm
Glutin 0.21

This is just #23288 taking into account the lessons learned in #23448 so that Android builds successfully.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23457)
<!-- Reviewable:end -->
2019-05-25 07:18:40 -04:00
Josh Matthews
2875e5ccb3 Upgrade parking_lot to 0.8. 2019-05-25 07:18:06 -04:00
Paul Rouget
e2cfe5d05f Glutin update: ignore gl_generator duplicate 2019-05-25 07:15:32 -04:00
Paul Rouget
53bb2e8743 Glutin update: new Context API 2019-05-25 07:15:32 -04:00
Paul Rouget
7f61160277 Glutin update: ignore rand-core and nix duplicate 2019-05-25 07:15:32 -04:00
Paul Rouget
1758207393 Glutin update: dependencies update 2019-05-25 07:15:30 -04:00
bors-servo
1c74a80e28
Auto merge of #23449 - Eijebong:winapi, r=jdm
Dedupe winapi

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23449)
<!-- Reviewable:end -->
2019-05-25 00:06:29 -04:00
Josh Matthews
0d831117ec Remove restrictions on cross-compiling on Windows. 2019-05-24 22:32:34 -04:00
bors-servo
df882a757f
Auto merge of #23455 - mboros1:master, r=emilio
Add missing dependency to build servo in Fedora 30

<!-- Please describe your changes on the following line: -->
Add missing dependency libunwind-devel to mach bootstrap for dnf and updating README file to reflect changes

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23454 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because mach build tests it

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23455)
<!-- Reviewable:end -->
2019-05-24 22:21:29 -04:00
Martin Boros
900e951d53 fixed formatting in bootstrap file 2019-05-24 21:45:01 -04:00
Martin Boros
5d1e4b32fc adds libunwind-devel to fedora dnf dependencies for bootstrap and updates README file 2019-05-24 21:27:20 -04:00
bors-servo
61d2641a7d
Auto merge of #23364 - jdm:ndk-llvm2, r=asajeffrey
Use llvm toolchain for android build

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23364)
<!-- Reviewable:end -->
2019-05-24 18:15:37 -04:00
Josh Matthews
ccde5867fb Use llvm toolchain for entirety of android build. 2019-05-24 16:05:01 -04:00
Bastien Orivel
3e7a9a012e Dedupe winapi
Since mio still hasn't been released, this uses custom forks with just
winapi bumped to 0.3 in them.
2019-05-24 19:07:56 +02:00
bors-servo
2181872973
Auto merge of #23452 - servo-wpt-sync:wpt_update_24-05-2019, r=servo-wpt-sync
Sync WPT with upstream (24-05-2019)

Automated downstream sync of changes from upstream as of 24-05-2019.
[no-wpt-sync]
2019-05-24 10:00:14 -04:00
WPT Sync Bot
732399d5d9 Update web-platform-tests to revision 138d2e938d493a5c8435025162759c2e34b3b1d1 2019-05-24 13:59:54 +00:00
bors-servo
ce37d5ebf2
Auto merge of #23437 - Eijebong:darling, r=jdm
Update darling to 0.9

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23437)
<!-- Reviewable:end -->
2019-05-24 00:51:36 -04:00
bors-servo
ce756346a4
Auto merge of #23383 - jdm:tc-parent, r=jdm
Reuse more tasks

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23383)
<!-- Reviewable:end -->
2019-05-23 22:51:41 -04:00
bors-servo
5ffa689e9f
Auto merge of #23412 - servo:ssh, r=Manishearth
Add some SSH keys to tc-mac workers

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23412)
<!-- Reviewable:end -->
2019-05-23 21:12:40 -04:00
bors-servo
3eca80e5b2
Auto merge of #23439 - servo-wpt-sync:wpt_update_22-05-2019, r=jdm
Sync WPT with upstream (22-05-2019)

Automated downstream sync of changes from upstream as of 22-05-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23439)
<!-- Reviewable:end -->
2019-05-23 19:00:55 -04:00
Simon Sapin
3d0be552d8 git show --pretty=%P sometimes prints a diff. Use git cat-file instead. 2019-05-23 16:38:28 -04:00
Simon Sapin
0ed6cdbb42 Compute the "task ID" only when needed 2019-05-23 16:16:40 -04:00
bors-servo
965477eb96
Auto merge of #23407 - georgeroman:reintroduce_parallelism_in_bluetooth_tests, r=jdm
Reintroduce parallelism in the bluetooth tests

<!-- Please describe your changes on the following line: -->
With https://github.com/web-platform-tests/wpt/pull/16819 in place, https://github.com/servo/servo/issues/22619 should be fixed, so the changes introduced by https://github.com/servo/servo/pull/22662 can be reverted.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23407)
<!-- Reviewable:end -->
2019-05-23 13:41:25 -04:00
Josh Matthews
0edf865deb Index taskcluster tasks by merge parents if available. 2019-05-23 18:35:07 +02:00
bors-servo
f24f517965
Auto merge of #23272 - tdelacour:ISSUE-20455, r=SimonSapin
ISSUE-20455: introduce stronger types for textinput indexing

<!-- Please describe your changes on the following line: -->
Added two new types:
- ByteOffset
- UTF16CodeUnitOffset

I've replaced any instance of `usize` that would be better represented by one or the other of these. I also updated any downstream code, including the unit tests for `textinput.rs`. Along the way, I tried to add or edit comments to better reflect my understanding of this file - happy to revisit if I have misrepresented anything.

I did not end up finding any places where types were very obviously being mixed, as the issue description suggested I should do... LMK if I should re-audit the file for that (might need a bit of guidance)!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20455 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23272)
<!-- Reviewable:end -->
2019-05-23 12:01:29 -04:00
Josh Matthews
8426c14422
Remove intermittent failure. 2019-05-23 09:47:19 -04:00
Simon Sapin
ed4c1ff3d6 Add some SSH keys to tc-mac workers 2019-05-23 13:35:36 +02:00
Bastien Orivel
c7ff341768 Update darling to 0.9 2019-05-23 12:14:56 +02:00