Commit graph

16765 commits

Author SHA1 Message Date
Alberto Corona
5e863f2eb8
Implement HTMLTextArea.setSelectionRange 2016-04-17 17:27:26 +02:00
bors-servo
db4481b450 Auto merge of #10619 - perlun:add-update-cargo-all-packages-warning, r=Wafflespeanut
mach: Added warning for update-cargo -a

To quote Lars Bergstrom:

> yeah, that's a giant footgun :-)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10619)
<!-- Reviewable:end -->
2016-04-15 03:05:48 +05:30
Per Lundberg
6653c26c90 Added warning for update-cargo -a
To quote Lars Bergstrom:

> yeah, that's a giant footgun :-)
2016-04-14 22:57:03 +03:00
bors-servo
d9ffefe562 Auto merge of #10589 - fitzgen:lock-stdout-when-printing-profile, r=larsbergstrom
Take the stdout lock when printing profile data

Acquiring the stdout lock while printing the profile data prevents other
messages printed to stdout from being interleaved with prints from elsewhere.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10589)
<!-- Reviewable:end -->
2016-04-15 01:03:54 +05:30
Nick Fitzgerald
1997d034fa Take the stdout lock when printing profile data
Acquiring the stdout lock while printing the profile data prevents other
messages printed to stdout from being interleaved with prints from elsewhere.
2016-04-14 12:28:00 -07:00
bors-servo
4807dadf19 Auto merge of #10609 - asajeffrey:add-panic-object-borrows, r=Manishearth
Make add_panic_object in thread.rs borrow rather than own the object.

r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10609)
<!-- Reviewable:end -->
2016-04-14 22:59:08 +05:30
bors-servo
e21e5551ec Auto merge of #10556 - bholley:keyword_setters, r=SimonSapin
Automatically generate Gecko style struct setters for most keyword properties

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10556)
<!-- Reviewable:end -->
2016-04-14 21:58:34 +05:30
bors-servo
415fd93a50 Auto merge of #10610 - jdm:unwrap, r=SimonSapin
Replace instances of infallible unwrap with expect.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10610)
<!-- Reviewable:end -->
2016-04-14 21:02:22 +05:30
Josh Matthews
cacbf95de8 Replace instances of infallible unwrap with expect. 2016-04-14 11:30:30 -04:00
Alan Jeffrey
941093d983 Make add_panic_object in thread.rs borrow rather than own the object. 2016-04-14 10:24:20 -05:00
bors-servo
2b910678db Auto merge of #10587 - asajeffrey:add-failure-panic-message, r=Manishearth
Added panic message to failures.

Added the panic message to failures. This is a step towards #10334, since it gives us access to the panic error message when we fire a `mozbrowsererror` event. The remaining steps are also to record the backtrace, and to report the failure in the event.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10587)
<!-- Reviewable:end -->
2016-04-14 19:55:17 +05:30
bors-servo
3368565b3c Auto merge of #10606 - servo:remove-url-plugin, r=nox
Remove the url! plugin.

In rust-url 1.0 the `Url` struct is going to have private fields, and there is no way to to create an aribitrary one without going through the parser.

The plugin never had a clear demonstrated performance benefit, it was made mostly because it was possible and relatively easy at the time.

This commit was originally part of #9840, but it’s taking a while to land and I keep removing new uses of `url!` when rebasing.

r? @nox

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10606)
<!-- Reviewable:end -->
2016-04-14 19:14:35 +05:30
Simon Sapin
6889f37d9e Remove the url! plugin.
In rust-url 1.0 the `Url` struct is going to have private fields, and there
is no way to to create an aribitrary one without going through the parser.

The plugin never had a clear demonstrated performance benefit,
it was made mostly because it was possible and relatively easy at the time.
2016-04-14 15:35:28 +02:00
bors-servo
87d5424d4d Auto merge of #10603 - Ms2ger:tests, r=jdm
Note bugs for some 2dcontext test failures.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10603)
<!-- Reviewable:end -->
2016-04-14 18:22:12 +05:30
bors-servo
7845d670d0 Auto merge of #10436 - autrilla:uniform2, r=emilio
Added Uniform{2i, 2iv, 2fv, 3f, 3i, 3iv, 3fv}

@emilio r?

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10436)
<!-- Reviewable:end -->
2016-04-14 17:41:12 +05:30
Ms2ger
c1ccf9d74b Note bugs for some 2dcontext test failures. 2016-04-14 13:00:44 +02:00
bors-servo
11f4d3f356 Auto merge of #10594 - sliz1:10576, r=Ms2ger
Remove containing_page_pipeline_id

Fixes https://github.com/servo/servo/issues/10569

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10594)
<!-- Reviewable:end -->
2016-04-14 14:10:11 +05:30
Bobby Holley
6546fe770b Remove handling for style structs with no gecko counterpart.
This is no longer necessary thanks to all the aligning we've done.
2016-04-14 00:13:44 -07:00
Bobby Holley
873bd82fff Stop cascading servo-internal properties in geckolib builds. 2016-04-14 00:13:42 -07:00
Bobby Holley
e12ee065dc Add automatic generation of geckolib property setters for keyword properties.
This adds gecko support for ~45 CSS properties.
2016-04-14 00:13:36 -07:00
Bobby Holley
1bbdadc1ba Massage some of the newly-added properties to line up with Gecko. 2016-04-13 23:45:58 -07:00
Adrian Utrilla
89c432b2d2
Added remaining uniforms 2016-04-14 07:42:14 +02:00
Stephen (Ziyun) Li
29e268b659
Remove containing_page_pipeline_id 2016-04-14 00:25:28 -04:00
Bobby Holley
8ece21e651 Add support for gecko_constant_prefix kwarg for Keyword.
This allows us to auto-generate settings when the gecko naming is slightly
different than the obvious auto-generated thing.
2016-04-13 18:14:55 -07:00
Bobby Holley
c61a04bd82 Add a gecko_ffi_name property on longhands for the cases where Gecko has a weird property name.
Long-term it'd be better to just rename the stuff in Gecko, but this is more expedient for now.
2016-04-13 18:14:55 -07:00
Bobby Holley
d8e0d97fd8 Add more annotations to the properties. 2016-04-13 18:14:55 -07:00
Bobby Holley
c6ded128ab Add style struct mapping support to regen_bindings.sh and eliminate the manual hack. 2016-04-13 18:14:14 -07:00
Bobby Holley
7751628bd9 Regenerate the bindings after shuffling properties on the gecko side. 2016-04-13 18:14:14 -07:00
bors-servo
25ae04057c Auto merge of #10582 - bholley:no_move_style_structs, r=Manishearth
Avoid moves of Gecko style structs

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10582)
<!-- Reviewable:end -->
2016-04-14 05:22:20 +05:30
Bobby Holley
8153a468ef Avoid moves of Gecko style structs. 2016-04-13 16:51:13 -07:00
bors-servo
84f01d1d7b Auto merge of #10579 - notriddle:overflow_premature_clip, r=pcwalton
Propogate transformed clipping regions to nested flows.

Fixes #10559

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10579)
<!-- Reviewable:end -->
2016-04-14 03:32:33 +05:30
bors-servo
697300bb16 Auto merge of #10566 - xudifsd:error-result, r=Ms2ger
replace Fallible<()> with ErrorResult

Fixes #10541

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10566)
<!-- Reviewable:end -->
2016-04-14 02:51:48 +05:30
Alan Jeffrey
8c0fa01884 Added panic message to failures. 2016-04-13 16:09:48 -05:00
bors-servo
4f6331953e Auto merge of #10573 - jdm:xhrintermittent, r=Manishearth
Do not support XHR.responseXML in worker globals. Fixes #8931.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10573)
<!-- Reviewable:end -->
2016-04-14 02:11:26 +05:30
bors-servo
628c54948a Auto merge of #10489 - timvandermeij:constellation-debug-warn, r=jdm
Replace use of `debug!` by `warn!` in `constellation.rs`

Fixes #10483.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10489)
<!-- Reviewable:end -->
2016-04-14 00:50:05 +05:30
Michael Howell
3c2210c5fc Propogate transformed clipping regions to nested flows.
Fixes #10559
2016-04-13 11:50:50 -07:00
bors-servo
66c20b2ced Auto merge of #10557 - emilio:inline-block-max-width, r=pcwalton
layout: Take in account max and min inline size for inline fragments

Improves MDN.

r? @mbrubeck or @pcwalton

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10557)
<!-- Reviewable:end -->
2016-04-14 00:09:52 +05:30
Tim van der Meij
29e564b1f7 Replace use of debug! by warn! in constellation.rs
Fixes #10483.
2016-04-13 20:31:59 +02:00
bors-servo
efd6723442 Auto merge of #10563 - mskrzypkows:tidy_tests, r=mbrubeck
Test for check_spec function, for tidy.py  #9152

Additional test for tidy.py

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10563)
<!-- Reviewable:end -->
2016-04-13 23:28:41 +05:30
Josh Matthews
dd5e28e0e6 Do not support XHR.responseXML in worker globals. Fixes #8931. 2016-04-13 13:56:07 -04:00
bors-servo
d21ff2fa13 Auto merge of #10189 - KiChjang:cors-preflight-fetch, r=jdm
Implement CORS preflight fetch

Fixes #10145.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10189)
<!-- Reviewable:end -->
2016-04-13 21:28:25 +05:30
Keith Yeung
e42481d0e7 Implement CORS preflight fetch 2016-04-13 11:28:14 -04:00
bors-servo
d566f1c143 Auto merge of #10565 - saurvs:master, r=Ms2ger
Update to byteorder 0.5

Finishes https://github.com/servo/servo/issues/10437.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10565)
<!-- Reviewable:end -->
2016-04-13 20:27:50 +05:30
bors-servo
9053721a32 Auto merge of #10558 - frewsxcv:tr-SectionRowIndex, r=KiChjang
Implement `sectionRowIndex` property on `<tr>`.

Fixes https://github.com/servo/servo/issues/10509.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10558)
<!-- Reviewable:end -->
2016-04-13 19:33:26 +05:30
bors-servo
3ad1b9134f Auto merge of #10512 - KiChjang:base-element-attr, r=Ms2ger
Implement HTMLBaseElement attributes

The remaining test failure in `base_multiple.html` looks like there's a problem with the test itself (it does not have a `<base>` tag at all).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10512)
<!-- Reviewable:end -->
2016-04-13 18:51:42 +05:30
Keith Yeung
4a1eb47937 Implement HTMLBaseElement attributes 2016-04-13 08:57:17 -04:00
bors-servo
9954ee1334 Auto merge of #10564 - Ms2ger:url-clone, r=Manishearth
Remove a pointless Url clone.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10564)
<!-- Reviewable:end -->
2016-04-13 18:11:11 +05:30
bors-servo
0e953618d1 Auto merge of #10524 - mauricioc:keyword_values, r=SimonSapin
Add some Gecko-supported CSS keyword properties

I have added all properties that are marked with (exactly) PARSE_VALUES and H | K in [0] to properties.mako.rs, as part of #10408. A few questions and remarks:

* I created a SVG style struct. Should those properties be somewhere else instead?
* I did not know what to do with ime-mode (which lives in nsStyleUIReset), so I did not include it.
* Servo already has a -servo-overflow-clip-box property, while Gecko has overflow-clip-box. Should those be consolidated?
* There is a code comment (marked with XXX) about scroll-snap-type-y. Should I add a <%self:longhand> template tag for that, similar to the one in overflow-y?

I am getting error E0053 while trying to run "./mach build-geckolib -r" on master, and the bholley/stylo branch doesn't support the products keyword argument yet, so I haven't exactly checked this compiles properly. It doesn't add any new compilation errors before the E0053 one, though.

Let me know if some extra information (say, a table saying where each property went) would be useful in the review process. r? @bholley

[0] https://docs.google.com/spreadsheets/d/1pSw2SjNxXZAQ19SAuNKcs5u4S7Zkc1ebEOkSP4oITUQ/edit?pref=2&pli=1

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10524)
<!-- Reviewable:end -->
2016-04-13 17:31:12 +05:30
Di Xu
76f57efb58 replace Fallible<()> with ErrorResult 2016-04-13 19:56:52 +08:00
bors-servo
650e3502f6 Auto merge of #10562 - servo:gcc, r=Manishearth
Update gcc.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/10562)
<!-- Reviewable:end -->
2016-04-13 16:49:59 +05:30