Commit graph

30251 commits

Author SHA1 Message Date
Gregory Terzian
6196a6e65d add pref to disable http cache, mozilla tests 2017-11-19 13:52:13 +08:00
Gregory Terzian
5f8a310bd1 also cache redirects 2017-11-17 21:36:30 +08:00
Gregory Terzian
b98635f212 allow unknown HTTP methods 2017-11-16 13:36:22 +08:00
Gregory Terzian
2799b4eac9 more http cache work 2017-11-16 13:36:12 +08:00
Gregory Terzian
f36a4fb6d7 pass cache_mode from request to request init 2017-11-15 19:28:22 +08:00
Gregory Terzian
d196f3de62 copy headers from script request to net request 2017-11-15 19:28:03 +08:00
Josh Matthews
f674cba612 Beginnings of a http cache
Doom cache entries based on the initial response, and prevent matching against doomed cache enties.

Evict cache entries that have passed their expiry date instead of matching them.

Document the cache. Refactor incomplete entries to lessen Option-itis.

Revalidate expired cache entries instead of unconditionally evicting them.

Forbid missing docs in cache code.

Revalidate must-revalidate entries.

Fetch content tests from a local HTTP server.

Track requests made to the test HTTP server.

Add a simple test that a cached resource with no expiry is not revalidated. Correct inverted expiry check in revalidation code.

Fix incorrect revalidation logic that dropped the consumer channels on the floor.

Ensure that requests are cached based on their request headers.

Run a separate http server instance for each test to avoid intermittent failures due to concurrent cache tests.

Add a test for uncacheable responses.

Address review comments.
2017-11-14 17:20:39 +08:00
bors-servo
333c6ef7fa Auto merge of #19175 - emilio:children-changed, r=nox
script: Call content_and_heritage_changed from children_changed instead of add_child / remove_child.

add_child / remove_child aren't called when a node character data changed. This
is important for finer grained invalidation.

The only test that tests this is now wallpapered, but won't be after #19164.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19175)
<!-- Reviewable:end -->
2017-11-10 08:47:50 -06:00
bors-servo
26ff6111ff Auto merge of #19176 - emilio:indentation-fixup, r=emilio
layout: Fixup indentation of ThreadSafeLayoutNodeHelpers::flags.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19176)
<!-- Reviewable:end -->
2017-11-10 07:28:29 -06:00
Emilio Cobos Álvarez
e4d6296f3f
layout: Fixup indentation of ThreadSafeLayoutNodeHelpers::flags.
Signed-off-by: Emilio Cobos Álvarez <emilio@crisal.io>
2017-11-10 13:13:19 +01:00
Emilio Cobos Álvarez
c9d9304912
script: Call content_and_heritage_changed from children_changed instead of add_child / remove_child.
add_child / remove_child aren't called when a node character data changed. This
is important for finer grained invalidation.

The only test that tests this is now wallpapered, but won't be after #19164.
2017-11-10 13:12:24 +01:00
bors-servo
a3f2fae561 Auto merge of #19165 - CYBAI:font-synthesis-out-of-mako, r=emilio
style: Move font-synthesis outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19160  (github issue number if applicable).
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19165)
<!-- Reviewable:end -->
2017-11-09 22:13:51 -06:00
CYBAI
b5370aa688 style: Move font-synthesis outside of mako 2017-11-10 09:00:31 +08:00
bors-servo
338e2ae520 Auto merge of #18262 - KiChjang:value-sanitization, r=nox
Implement value sanitization on HTMLInputElement

https://html.spec.whatwg.org/multipage/input.html#value-sanitization-algorithm

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18262)
<!-- Reviewable:end -->
2017-11-09 18:35:07 -06:00
Keith Yeung
8203605c04 Implement value sanitization on HTMLInputElement 2017-11-09 16:34:14 -08:00
bors-servo
a1331169f6 Auto merge of #19169 - glennw:update-ww-aa-dots, r=jdm
Update WR (dotted border fix, better AA for split primitives)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19169)
<!-- Reviewable:end -->
2017-11-09 17:28:07 -06:00
Glenn Watson
b1ec2b260a Update WR (dotted border fix, better AA for split primitives) 2017-11-10 08:17:32 +10:00
bors-servo
ff1b58385c Auto merge of #18821 - servo:dupdep, r=jdm
Update metadeps to remove duplicate error-chain crate

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18821)
<!-- Reviewable:end -->
2017-11-09 13:20:27 -06:00
bors-servo
c46c9dc019 Auto merge of #19128 - servo:asciiext, r=nox
Upgrade to rustc 1.23.0-nightly (02004ef78 2017-11-08)

This fixes some new warnings, some of which (in `style`) are treated as errors. See https://users.rust-lang.org/t/psa-dealing-with-warning-unused-import-std-ascii-asciiext-in-today-s-nightly/13726

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19128)
<!-- Reviewable:end -->
2017-11-09 10:00:38 -06:00
Simon Sapin
793bebfc0e Upgrade to rustc 1.23.0-nightly (02004ef78 2017-11-08) 2017-11-09 16:56:39 +01:00
bors-servo
20ccde9a75 Auto merge of #19163 - emilio:useless-opt, r=nox
style: Remove the skip_applying_damage "optimization".

We already remove all change hints down the tree when finding a reframe hint
using ClearServoRestyleFromSubtree in ServoRestyleManager, so this is useless.

MozReview-Commit-ID: 1twx7iPt79x

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19163)
<!-- Reviewable:end -->
2017-11-09 08:25:25 -06:00
Emilio Cobos Álvarez
57121a2e15
style: Remove the skip_applying_damage "optimization".
We already remove all change hints down the tree when finding a reframe hint
using ClearServoRestyleFromSubtree in ServoRestyleManager, so this is useless.

MozReview-Commit-ID: 1twx7iPt79x
2017-11-09 15:21:53 +01:00
bors-servo
e7a654dd13 Auto merge of #19162 - emilio:ascii-ext, r=emilio
Allow unused imports for AsciiExt in style code.

See #19128, this part is cherry-picked so Gecko can build with rust nightly.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19162)
<!-- Reviewable:end -->
2017-11-09 06:49:29 -06:00
bors-servo
1d6b8a5448 Auto merge of #19161 - tigercosmos:python2, r=emilio
remove unused  script in `build_commands.py`

<!-- Please describe your changes on the following line: -->
code in `build_commands.py` duplicates with `openssl.makefile`, so it is unused.
(It only use in openssl)
ae5dca985e/python/servo/build_commands.py (L268)
ae5dca985e/support/android/openssl.makefile (L9-L10)
ae5dca985e/support/android/openssl.sh (L83-L84)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19161)
<!-- Reviewable:end -->
2017-11-09 05:57:43 -06:00
Simon Sapin
954b2cc3d8
Allow unused imports for AsciiExt in style code.
See #19128, this part is cherry-picked so Gecko can build with rust nightly.
2017-11-09 12:43:23 +01:00
tigercosmos
2792369a6d remove unused script 2017-11-09 17:04:20 +08:00
bors-servo
ae5dca985e Auto merge of #19155 - glennw:update-wr-more-opts-2, r=jdm
Update WR (inset box shadow blur fix, subpx text optimizations)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19155)
<!-- Reviewable:end -->
2017-11-08 16:10:52 -06:00
Glenn Watson
748a6f8845 Update WR (inset box shadow blur fix, subpx text optimizations) 2017-11-09 06:38:15 +10:00
Keith Yeung
9d60333af9 Implement string stripping utilities from the Infra spec 2017-11-08 11:58:18 -08:00
bors-servo
5b36b74c06 Auto merge of #19138 - asajeffrey:script-rename-js-dependency-to-mozjs, r=jdm
Rename js crate to mozjs

<!-- Please describe your changes on the following line: -->

This PR renames the `js` dependency to `mozjs', ready for when https://github.com/servo/rust-mozjs/pull/377 lands.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because refactoring

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19138)
<!-- Reviewable:end -->
2017-11-08 11:45:05 -06:00
Alan Jeffrey
8008ba5081 Renamed js crate to mozjs 2017-11-08 11:43:30 -06:00
bors-servo
294a24af48 Auto merge of #19153 - CYBAI:font-size-adjust-out-of-mako, r=emilio
style: Move font-size-adjust outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19151  (github issue number if applicable).
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19153)
<!-- Reviewable:end -->
2017-11-08 09:52:37 -06:00
CYBAI
e73f2377cf style: Move font-size-adjust outside of mako 2017-11-08 23:40:23 +08:00
bors-servo
cbf2ac35f7 Auto merge of #19149 - emilio:random-cleanup, r=nox
style: minor cleanups

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19149)
<!-- Reviewable:end -->
2017-11-08 07:28:47 -06:00
Emilio Cobos Álvarez
5ecf1508ee
style: We never call accumulate_damage_for in a forgetful traversal.
We early-return instead before calling it.

MozReview-Commit-ID: JaRWPHCQAl9
2017-11-08 14:24:10 +01:00
Emilio Cobos Álvarez
92a69fbd9a
style: Tidy up PseudoElement::should_exist.
MozReview-Commit-ID: Enr1NHONmtp
2017-11-08 14:23:58 +01:00
bors-servo
a1f7337221 Auto merge of #19148 - KiChjang:import-sequence-inner-types, r=jdm
Import sequence inner types if it appears in dictionary members

Relands #19133, as it was backed out wrongly in #19143.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19148)
<!-- Reviewable:end -->
2017-11-08 06:22:16 -06:00
Keith Yeung
ce8486ab9b Import sequence inner types if it appears in dictionary members 2017-11-08 04:20:30 -08:00
bors-servo
fd8b4b59c2 Auto merge of #19119 - CYBAI:font-size-out-of-mako, r=emilio
style: Move font-size outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19111  (github issue number if applicable).
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19119)
<!-- Reviewable:end -->
2017-11-08 04:05:47 -06:00
bors-servo
b8fdb90b95 Auto merge of #19140 - glennw:update-wr-windows, r=mbrubeck
Update WR (Windows subpx rendering fix)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19140)
<!-- Reviewable:end -->
2017-11-08 00:55:00 -06:00
CYBAI
0f57d250bb style: Move font-size outside of mako 2017-11-08 14:31:06 +08:00
bors-servo
4a2103b9e6 Auto merge of #19139 - emilio:bye-parse-specified, r=jdm
style: Get rid of parse_specified.

It has a single use, and I don't think we should use it in the future.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19139)
<!-- Reviewable:end -->
2017-11-07 23:44:17 -06:00
bors-servo
d16902c080 Auto merge of #19143 - moz-servo-sync:gecko-backout, r=moz-servo-sync
Backed out changeset dd834d38eaab for Windows debug build bustage

Backed out changeset dd834d38eaab for Windows debug build bustage

Backs out https://github.com/servo/servo/pull/19133

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19143)
<!-- Reviewable:end -->
2017-11-07 19:42:12 -06:00
Gecko Backout
38b9a543a3 Backed out changeset dd834d38eaab for Windows debug build bustage
Backs out https://github.com/servo/servo/pull/19133
2017-11-08 01:21:17 +00:00
Emilio Cobos Álvarez
7adad61db8
style: Get rid of parse_specified.
It has a single use, and I don't think we should use it in the future.
2017-11-08 01:33:13 +01:00
Glenn Watson
b18ecfdadf Update WR (Windows subpx rendering fix) 2017-11-08 09:36:26 +10:00
bors-servo
7ae852b673 Auto merge of #19133 - KiChjang:import-sequence-inner-types, r=jdm
Import sequence inner types if it appears in dictionary members

Fixes #19107.

r? nox

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19133)
<!-- Reviewable:end -->
2017-11-07 17:07:03 -06:00
bors-servo
693c3dcfb2 Auto merge of #16946 - jdm:report, r=Manishearth
Add intermittent failure reporting to filter-intermittents

We need to address https://github.com/servo/saltfs/issues/671 before this can be enabled by default on the builders, but I got the pieces working locally. This collects relevant information about each recorded intermittent failure encountered during a test run and posts them to a webapp which stores them in a database for later investigation. This will allow us to track over time which intermittent test failures are the most frequent, as well as whether they only happen on a particular builder or operating system.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/16946)
<!-- Reviewable:end -->
2017-11-07 13:05:12 -06:00
Josh Matthews
86e3f0deef Use failure reporting API on CI. 2017-11-07 14:01:24 -05:00
Josh Matthews
c469cbbe72 Report instances of intermittent failures to a tracker. 2017-11-07 13:40:38 -05:00