Commit graph

3647 commits

Author SHA1 Message Date
patrick kim
1b8f9c09d3 remove @ fontcontext 2013-12-07 09:52:54 +09:00
patrick kim
964b5e9d9a remove SendableTextRun & remove @mut Font From TextRun&Shaper(Font),Font.shaper,
fontfamily,fontgroup,render_context.font_ctx
2013-12-07 09:52:06 +09:00
patrick kim
c60ab361a5 remove @ from FontContextHandle in linux 2013-12-07 09:48:19 +09:00
Lars Bergstrom
c5e5e5a46b Merge pull request #1344 from kmcallister/layout-boxes
Remove @mut from LineboxScanner and image caching
2013-12-06 12:25:27 -08:00
Keegan McAllister
dda6d2b53c Convert LayoutContext.image_cache from @mut to MutexArc
LocalImageCache isn't Freeze so we have to use unsafe_access,
which exists for MutexArc and not RWArc.
2013-12-06 11:31:49 -08:00
Keegan McAllister
94b70e25e1 Remove unnecessary @mut from LineboxScanner 2013-12-06 11:26:47 -08:00
Lars Bergstrom
e8da737322 Merge pull request #1343 from ryanhc/removing_to_owned
removing unnecessary to_owned
2013-12-06 05:01:06 -08:00
Lars Bergstrom
24e21bcc28 Merge pull request #1341 from deokjinkim/layout_font_optimize
Use last resort font when only there is no font in font group.
2013-12-06 04:54:32 -08:00
Ryan Choi
ecd44fe9a8 removing unnecessary to_owned 2013-12-06 17:50:26 +09:00
Deokjin Kim
a5db5d5eeb Use last resort font when only there is no font in font group.
There is a little bit of performance gain of layout.
2013-12-06 16:50:25 +09:00
Patrick Walton
91fcc6703b Merge pull request #1327 from pcwalton/enumify-boxes
layout: Change `RenderBox` to an enum and shorten its name in preparation for removing its `@`-ness.
2013-12-05 17:44:24 -08:00
Patrick Walton
4fda26f76e layout: Change RenderBox to an enum and shorten its name in
preparation for removing its `@`-ness.

Also removes a few text copies that were taking place.

This sure does remove a lot of code!
2013-12-05 17:41:41 -08:00
Lars Bergstrom
2c4714e803 Merge pull request #1339 from kmcallister/native_graphics_context
Return None from get_graphics_metadata in headless compositor
2013-12-05 14:50:34 -08:00
Lars Bergstrom
101e39a7a2 Merge pull request #1304 from Ms2ger/exceptions
Report exceptions to JS when the DOM implementation fails.
2013-12-05 14:03:54 -08:00
Keegan McAllister
4a72abbbb2 Return None from get_graphics_metadata in headless compositor
This fixes servo -z.
2013-12-05 13:55:33 -08:00
Ms2ger
4bf9bece92 Add test. 2013-12-05 16:14:09 +01:00
Ms2ger
29a7405b4e Report exceptions to JS when the DOM implementation fails.
As a bonus, adds some debugging statements.
2013-12-05 16:14:02 +01:00
Patrick Walton
c5db2ab516 Merge pull request #1337 from brunoabinader/acid1_fix
Acid1 fix (fixed FloatFlow refactory)
2013-12-04 18:58:34 -08:00
Bruno de Oliveira Abinader
10db916137 Acid1 fix (fixed FloatFlow refactory)
While doing the FloatFlow refactory, I forgot to transpose a variable
assignment in assign_widths(). Also did a minor change in
bubble_widths() to avoid creating temporary variables in an iteration
loop.

This patch is for:
https://github.com/mozilla/servo/issues/1335
2013-12-04 17:17:14 -04:00
bors-servo
a92d430007 auto merge of #1331 : SimonSapin/servo/visibility, r=pcwalton
http://www.w3.org/TR/CSS21/visufx.html#visibility

`visibility: collapse` is not supported yet because tables are not, either.

This fixes #1329.
2013-12-04 10:07:06 -08:00
bors-servo
7222048567 auto merge of #1330 : kmcallister/servo/http_loader, r=pcwalton
Serving suggestion: `git show -w`

Fixes #1325.

Some of the control-flow reorganization is for clarity rather than out of necessity.
2013-12-04 09:43:24 -08:00
Simon Sapin
7a4c809436 CSS: Add the 'visibility' property.
http://www.w3.org/TR/CSS21/visufx.html#visibility

'visibility: collapse' is not supported yet because tables are not, either.

This fixes #1329.
2013-12-04 10:58:27 +00:00
Keegan McAllister
5763937ecd http_loader: Don't tail-call for redirects
Serving suggestion: git show -w

Fixes #1325.

Some of the control-flow reorganization is for clarity rather than out of
necessity.
2013-12-03 21:25:11 -08:00
bors-servo
b26fe9a430 auto merge of #1321 : brunoabinader/servo/remove-floatflow, r=pcwalton
Removes 'FloatFlow' in favor of FloatBlockFlow, which is contained
inside BlockFlow in a 'has-a' relationship. This avoids a bunch of
duplicated code.

This patch is for:
https://github.com/mozilla/servo/issues/1281
2013-12-03 15:31:15 -08:00
bors-servo
148d1720e5 auto merge of #1328 : kmcallister/servo/properties, r=jdm
The bug is mozilla/rust#10683 and there's no fix yet, plus it would take us a while to upgrade Rust anyway.

Fixes #1258.
2013-12-03 13:10:14 -08:00
Keegan McAllister
48ce016209 Work around Rust bug causing nondeterministic CSS parse failure
The bug is mozilla/rust#10683 and there's no fix yet, plus it
would take us a while to upgrade Rust anyway.

Fixes #1258.
2013-12-03 12:57:51 -08:00
Bruno de Oliveira Abinader
ac45d70a4a Remove 'FloatFlow'
Removes 'FloatFlow' in favor of FloatBlockFlow, which is cointained
inside BlockFlow in a 'has-a' relationship. This avoids a bunch of
duplicated code.

This patch is for:
https://github.com/mozilla/servo/issues/1281
2013-12-03 14:36:31 -04:00
bors-servo
a0c6075b4d auto merge of #1326 : brunoabinader/servo/rename-flowcontext, r=pcwalton
This patch is for:
https://github.com/mozilla/servo/issues/1282
2013-12-03 09:16:18 -08:00
bors-servo
b5645737da auto merge of #1311 : pradeep90/servo/rule-hash-optimize, r=pcwalton
Commit for #1301
2013-12-03 08:50:30 -08:00
bors-servo
529c21bb65 auto merge of #1252 : jdm/servo/layoutassert, r=jdm,metajack
...224.
2013-12-02 16:32:32 -08:00
Josh Matthews
b502f03fd6 Add forgotten test for Element.attributes. 2013-12-02 19:25:17 -05:00
Josh Matthews
f9f9c42ab7 Ensure that it's safe to modify the DOM node pointers before doing so. Fixes #1224. 2013-12-02 19:25:11 -05:00
Bruno de Oliveira Abinader
bf277e634b s/FlowContext/Flow
This patch is for:
https://github.com/mozilla/servo/issues/1282
2013-12-02 16:14:06 -04:00
bors-servo
0c4b10cc2c auto merge of #1262 : june0cho/servo/acid2_local_bookmark, r=jdm
To test this, execute the followings:
    test_local_bookmark.html#text1
    test_local_bookmark.html#text2
    test_local_bookmark.html#text3
    test_local_bookmark.html#top
    test_local_bookmark.html#h3
    test_local_bookmark.html#num
    acid2.html#top
     - The link from acid2.html works now. ( `<a href="#top">`)

Thanks to @metajack!
2013-11-30 14:37:11 -08:00
bors-servo
123fa47155 auto merge of #1323 : Ms2ger/servo/warnings, r=SimonSapin 2013-11-30 11:22:14 -08:00
Ms2ger
b8a3f8ad5e Remove unused imports. 2013-11-30 19:50:20 +01:00
june0cho
266b551aa4 Implement local bookmark(hashtag) for Acid2. With @joonwonlee
Support hashtag through link (e.g. <a href="#top">)
2013-12-01 00:36:11 +09:00
june0cho
c7ad220178 Add a test file for local bookmark.(#text1, #text2, #text3, #top, #h3, #num) 2013-11-30 23:21:25 +09:00
bors-servo
93a62f4f47 auto merge of #1322 : jdm/servo/renderborder, r=jdm
Implemented a border which was the solid type.
Because of not support css pseudo element(:before, :after), content in css property and base64, So we couldn't test Acid2(http://www.webstandards.org/files/acid2/test.html).

Rebase of #1276.
2013-11-29 17:01:17 -08:00
HyunJune Kim
409699f7ae Render border solid-style properly 2013-11-29 19:57:03 -05:00
Sangeun Kim
34418ec957 Add diamond test code 2013-11-29 19:57:03 -05:00
bors-servo
7dbabdd9e4 auto merge of #1318 : therealglazou/servo/therealglazou/nth-pseudos, r=SimonSapin
Implement :nth-child, :nth-last-child, :nth-of-type, :nth-last-of-type, :first-of-type, :last-of-type and :only-of-type Selectors Level 3 pseudo-classes. Reftests included.
2013-11-29 03:22:16 -08:00
Daniel Glazman
6508bff1cd :nth-child and friends, use div_rem result instead of recomputing it 2013-11-29 12:16:53 +01:00
Daniel Glazman
eb76ea76db :nth-child and friends, changes in response to SimonSapin's review 2013-11-29 09:58:11 +01:00
bors-servo
b867e54dd4 auto merge of #1298 : recrack/servo/overflow_property, r=metajack
Impl #1290

@jaeminMoon @ksh8281 
Thanks @metajack
2013-11-28 21:46:51 -08:00
Daniel Glazman
991d4d8a3c Implement :nth-child, :nth-last-child, :nth-of-type, :nth-last-of-type, :first-of-type, :last-of-type and :only-of-type Selectors Level 3 pseudo-classes 2013-11-28 15:19:43 +01:00
bors-servo
238741f646 auto merge of #1315 : pcwalton/servo/disable-parallel, r=metajack
To verify, turn ON optimizations and go to:

http://en.wikipedia.org/wiki/Yellow_River

r? @metajack
2013-11-26 16:49:16 -08:00
Patrick Walton
362c2718f7 main: Disable parallel selector matching due to races.
To verify, turn ON optimizations and go to:

http://en.wikipedia.org/wiki/Yellow_River
2013-11-26 16:44:03 -08:00
bors-servo
a76f761ed3 auto merge of #1313 : pcwalton/servo/parallel-layout, r=larsbergstrom
This is one small step toward parallel layout.

r? @larsbergstrom
2013-11-26 12:26:18 -08:00
Patrick Walton
c85953deeb net: De-GC the image cache stuff.
This is a step on the way toward parallel layout.
2013-11-26 12:10:40 -08:00