Commit graph

7939 commits

Author SHA1 Message Date
Manish Goregaokar
7d65673561 Remove extra spaces
Command: `find . -maxdepth 1 -type f -print0 | xargs -0 sed -z -i "s/}\\n\\n\\n/}\\n\\n/"`
2014-12-27 02:53:35 +05:30
Manish Goregaokar
552db382d6 Remove manual impls of Reflectors (autogen)
Obtained via:

 `find . -maxdepth 1 -type f -print0 | xargs -0 sed -z -i "s/\\nimpl Reflectable for[^{]*{[^}]*}[^}]*}\\n//"`
 `find . -maxdepth 1 -type f -print0 |xargs -0  grep -lZ dom_struct | xargs -0 grep -LZ  "reflector()\\|Reflector::new" |xargs -0 sed -z -i "s/use dom::bindings::utils::{Reflectable, Reflector, reflect_dom_object};/use dom::bindings::utils::reflect_dom_object;/"`

followed by semi-automated removal of leftover imports
2014-12-27 02:52:33 +05:30
Manish Goregaokar
21607f066c Add internal plugin for creating Reflectable implementations 2014-12-27 02:43:13 +05:30
Manish Goregaokar
dd8360fb10 Use inline(always) for trace() 2014-12-27 02:43:12 +05:30
bors-servo
0e6304dcf7 auto merge of #4467 : servo/servo/dataset, r=Ms2ger 2014-12-25 02:27:43 -07:00
bors-servo
57b6dc9397 auto merge of #4479 : mattnenterprise/servo/globalref-by-value, r=jdm 2014-12-24 16:15:45 -07:00
Matt McCoy
bdb75c2146 This fixes #4166. throw_dom_exception will take the GlobalRef by value, and all generated code will pass it by value. 2014-12-24 17:16:48 -05:00
bors-servo
070008b4c4 auto merge of #4478 : jdm/servo/hyperssl, r=larsbergstrom
This just updates rust-openssl and hyper to use cherry-picked commits that fix this particular issue. I think it's worth it because the experience of trying Servo for the first time right now is pretty terrible.
2014-12-24 11:15:45 -07:00
bors-servo
c35a18e81f auto merge of #4477 : thiagopnts/servo/descriptive-enum, r=jdm
refs #4472
2014-12-24 10:45:45 -07:00
Josh Matthews
22c8d3df8d Fix HTTPS fetches. 2014-12-24 12:41:38 -05:00
Ms2ger
919f2217f0 Implement dummy getOwnPropertyNames and enumerate traps. 2014-12-24 17:17:40 +01:00
thiagopnts
eacbe331c9 Replace bool attribute in Element::update_inline_style with a descriptive enum 2014-12-24 13:23:58 -02:00
bors-servo
194ce20969 auto merge of #4474 : thiagopnts/servo/generic-msgs, r=jdm
This refs #3735. As discussed in the issue, I did it cloning when I couldn't dereference an attribute. The trait method should be on `&self` for object-safety reasons.
2014-12-24 03:45:44 -07:00
bors-servo
71b9f17b6b auto merge of #4457 : jamougha/servo/master, r=jdm
Fixes #4411.

I didn't find any tests for the text control functionality so I didn't write any for this, let me know if I should.
2014-12-23 23:45:45 -07:00
bors-servo
fb59e79299 auto merge of #4453 : mattnenterprise/servo/dispatch-mousemove, r=jdm 2014-12-23 23:15:47 -07:00
thiagopnts
271aa277e9 Replace XHR events for generic ones in ScriptTask
fixup! Replace XHR events for generic ones in ScriptTask

fixup! Replace XHR events for generic ones in ScriptTask
2014-12-23 23:53:38 -02:00
James Moughan
0a6ebfa3ee Allow selection of all text in a text control using the ctrl-a/cmd-a shortcut.
Fixes #4411.
2014-12-24 00:14:17 +00:00
Matt McCoy
75be44e744 This fixes #4259. Dispatching the mousemove event for the top most node when the mouse moves while on top of it 2014-12-23 17:49:03 -05:00
bors-servo
7b7fe964d3 auto merge of #4463 : iterion/servo/get-property-priority, r=jdm
Implementation of #4432 adding `getPropertyPriority` to CSSStyleDeclaration. This is my first attempt at a Servo PR so I'm sure I've done something wrong. Let me know, and I'll fix it up.

As stated in #4432 tests for this are in #4085. If there are additional tests I can write now I would love to do that, I'm just not sure where or what those would be.
2014-12-23 11:06:49 -07:00
Adam Sunderland
674fe910c1 Add GetPropertyPriority to CSSStyleDeclaration
Tweak getPropertyPriority to match recommendations

Adding Tests for Style Priority

Use else if

Adding Content Test for GetPropertyPriority

Revert "Adding Tests for Style Priority"

This reverts commit 8666a37f833b06c3e43f27acd8a9678e94425e55.
2014-12-23 11:41:33 -06:00
bors-servo
49f2c6974d auto merge of #4471 : ProgramFOX/servo/issue-4433, r=jdm
Implemented CSSStyleDeclaration.setPropertyPriority, resolves #4433.
2014-12-23 09:45:49 -07:00
ProgramFOX
07d37af37e Implemented CSSStyleDeclaration.setPropertyPriority
Implemented CSSStyleDeclaration.setPropertyPriority, resolves #4433
2014-12-23 17:14:45 +01:00
Bruno de Oliveira Abinader
57c520d8cf Implement HTMLElement.dataset (fixes #2974). 2014-12-23 14:24:06 +01:00
Bruno de Oliveira Abinader
285a06ff59 Implement Element::set_custom_attribute. 2014-12-23 14:23:30 +01:00
Bruno de Oliveira Abinader
63ed36cfce Factor out the name handling in Element::{Get,Set,Remove}Attribute. 2014-12-23 14:23:30 +01:00
Bruno de Oliveira Abinader
e0bab08754 Correct the generated code for NamedSetter calls. 2014-12-23 14:23:22 +01:00
Bruno de Oliveira Abinader
ade0b7be8e Use the custom defineProperty trap when it exists. 2014-12-23 14:22:30 +01:00
bors-servo
c92a7898b4 auto merge of #4466 : Ms2ger/servo/failing-test, r=larsbergstrom 2014-12-23 05:36:44 -07:00
Bruno de Oliveira Abinader
c82eb3b1a4 Call the NamedGetter method from the get trap in proxy bindings. 2014-12-23 13:02:52 +01:00
Ms2ger
a2521c7e01 Add a test that wptrunner fails when it should. 2014-12-23 11:22:10 +01:00
bors-servo
14df96d772 auto merge of #4465 : servo/servo/revert-wpt, r=Ms2ger 2014-12-23 02:51:46 -07:00
bors-servo
0109cc3ffc auto merge of #4464 : servo/servo/revert-dataset, r=Ms2ger 2014-12-23 01:57:46 -07:00
Ms2ger
c2e4e715ae Revert "Update wptrunner and start running reftests."
This reverts commit 1d68ee689f.

Fixes #4462.
2014-12-23 09:55:12 +01:00
Ms2ger
dc63735ca7 Revert PR #4038 for causing WPT failures. 2014-12-23 09:53:12 +01:00
Ms2ger
01e3449f14 Revert "Enable html/rendering."
This reverts commit dde0702a89.
2014-12-23 09:29:16 +01:00
bors-servo
b83b4932da auto merge of #4461 : glennw/servo/glutin-tests, r=larsbergstrom
This stops some ref tests on linux blocking while waiting for
user input events and never outputting the file.

Also mark vertical writing test as flaky on all platforms. Due
to unrelated timing reasons, this fails reliably on mac when glutin
is enabled. The related bug with details on the root cause is #3926.
2014-12-22 17:57:46 -07:00
Glenn Watson
8e32ba9de9 Update glutin to get mac visibility fix. 2014-12-23 10:13:36 +10:00
bors-servo
63a7742d83 auto merge of #4459 : pcwalton/servo/border-radius-clipping, r=glennw
Together these improve a large number of sites: GitHub, Reddit, Wikipedia, etc.

r? @glennw
2014-12-22 15:51:48 -07:00
Patrick Walton
cc7cacfd5f gfx: Clip the background properly when border-radius is used.
Improves Reddit, GitHub, etc.
2014-12-22 14:48:55 -08:00
Patrick Walton
b22b29533a gfx: Fix a nasty bug whereby the transient clip was not always removed,
causing elements to be randomly clipped out.

Improves Wikipedia, Reddit, etc.
2014-12-22 14:48:55 -08:00
Patrick Walton
dea8375613 gfx: Refactor the border drawing code and split out fragment display
list building into multiple functions.

This should have no functional changes; it's just code cleanup.
2014-12-22 14:48:55 -08:00
Glenn Watson
2accabd554 Use event polling instead of blocking when outputting to a file.
This stops some ref tests on linux blocking while waiting for
user input events and never outputting the file.

Also mark vertical writing test as flaky on all platforms. Due
to unrelated timing reasons, this fails reliably on mac when glutin
is enabled. The related bug with details on the root cause is #3926.
2014-12-23 08:32:53 +10:00
bors-servo
20b961493a auto merge of #4442 : glennw/servo/glutin-events-resize, r=larsbergstrom,larsbergstrom 2014-12-22 14:33:45 -07:00
bors-servo
f06e0a818d auto merge of #4048 : mttr/servo/mach_unit_test_fix, r=larsbergstrom
This is a quick and dirty workaround for issue #3928. Basically, `cargo test` is deleting `./target/servo`, which is clearly not ideal if we want to do anything with servo after running the unit tests. This PR makes sure to rebuild after running `./mach test-unit`.

I'm not familiar enough with cargo yet to know why it's doing this or what better alternatives there are to fixing this. Having to rebuild afterwards feels pretty ugly to me, but my rationalization right now is that the time it takes to build is negligible in comparison to the time it takes to run the tests. Ideally, this should be something we could take care of in Cargo.toml, but again, I'm new to this (and the documentation seems less than helpful from what I can tell so far).

I won't be available for the rest of the day, so if anyone has suggestions, or wants to wait for a better solution, I'll get back to it tomorrow probably. Otherwise, this PR at least makes `./mach test` work properly, so there's that.
2014-12-22 14:05:34 -07:00
bors-servo
1793e0cb0e auto merge of #4448 : michaelwu/servo/fix-gonk-20141220, r=larsbergstrom 2014-12-21 12:18:46 -07:00
bors-servo
bde6c39192 auto merge of #4456 : ema-fox/servo/textinput_selection, r=jdm
Fixes #4447
2014-12-21 07:24:44 -07:00
Emanuel Rylke
c732a779eb On left/right keydown place edit_point correctly when there is a selection in TextInput
Fixes #4447
2014-12-21 14:31:15 +01:00
bors-servo
a773bd5c45 auto merge of #4454 : amwatson/servo/global_update, r=jdm
Changed fn_wrap argument in reflect_dom_object() and reflect_node() to pass GlobalRef by value rather than by reference.  Fixes #4165
2014-12-20 17:51:44 -07:00
bors-servo
6efa7eedbc auto merge of #4452 : Ms2ger/servo/_obj_toString, r=jdm 2014-12-20 17:24:44 -07:00
Amanda Watson
582ba9d796 GlobalRef passed by value in reflect_dom_object, reflect_node #4165 2014-12-20 16:20:53 -08:00