Commit graph

36761 commits

Author SHA1 Message Date
bors-servo
880f3b8b7a
Auto merge of #23268 - asajeffrey:magicleap-package-fixes, r=jdm
Magicleap package fixes

<!-- Please describe your changes on the following line: -->

A couple of fixes for magicleap packaging...
* Move the setting of the debuggable flag into the `.package` file where it belongs,
* Allow compiling with v0.20.0 of the SDK.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it fixes the build

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23268)
<!-- Reviewable:end -->
2019-04-25 18:25:19 -04:00
bors-servo
36bb42525a
Auto merge of #23256 - jdm:clang-cl, r=asajeffrey
Use clang-cl for Windows builds

Depends on https://github.com/servo/mozjs/pull/178.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23256)
<!-- Reviewable:end -->
2019-04-25 14:35:59 -04:00
Alan Jeffrey
73a874f742 Work around deprecated API when packaging for magicleap 2019-04-25 13:02:56 -05:00
Alan Jeffrey
82fcab38a4 Move debuggable flag setting for magicleap package to package file 2019-04-25 12:56:37 -05:00
bors-servo
caac107ae8
Auto merge of #23262 - paulrouget:cursor-update, r=jdm
Update SetCursor behavior

We were initially sending a SetCursor message on every mouse move because of a winit bug, which is now fixed.

Also, we had a layout SetCursor message that was never used.

Fix #18599

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23262)
<!-- Reviewable:end -->
2019-04-25 12:28:08 -04:00
bors-servo
e877dc2759
Auto merge of #23263 - servo:rustup, r=jdm
Upgrade to rustc 1.36.0-nightly (e305df184 2019-04-24)

This includes a `size_of` regression for a few DOM types, due to https://github.com/rust-lang/rust/pull/58623 which replaces the implementation of `HashMap` in the standard library to Hashbrown.

Although `size_of<HashMap>` grows, it’s not obvious how total memory usage is going to be impacted: Hashbrown only has one `u8` instead of one `usize` of overhead per hash table bucket for storing (part of) a hash, and so might allocate less memory itself.

Hashbrown also typically has better run time performance: https://github.com/rust-lang/hashbrown#performance

Still, I’ve filed https://github.com/rust-lang/hashbrown/issues/69 about potentially reducing the `size_of<HashMap>` regression.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23263)
<!-- Reviewable:end -->
2019-04-25 10:58:23 -04:00
Josh Matthews
0136e5a2db Update mozjs. 2019-04-25 10:55:17 -04:00
Josh Matthews
c038ba4c7c Force the use of clang-cl.exe for Windows builds. 2019-04-25 10:55:16 -04:00
Simon Sapin
51d6b6350e Upgrade to rustc 1.36.0-nightly (e305df184 2019-04-24)
This includes a `size_of` regression for a few DOM types,
due to https://github.com/rust-lang/rust/pull/58623 which replaces the
implementation of `HashMap` in the standard library to Hashbrown.

Although `size_of<HashMap>` grows, it’s not obvious how total memory usage
is going to be impacted: Hashbrown only has one `u8` instead of one `usize`
of overhead per hash table bucket for storing (part of) a hash,
and so might allocate less memory itself.

Hashbrown also typically has better run time performance:
https://github.com/rust-lang/hashbrown#performance

Still, I’ve filed https://github.com/rust-lang/hashbrown/issues/69
about potentially reducing the `size_of<HashMap>` regression.
2019-04-25 13:52:09 +02:00
Paul Rouget
7858ede29f Update SetCursor behavior 2019-04-25 09:39:16 +02:00
bors-servo
07d1559141
Auto merge of #23250 - servo-wpt-sync:wpt_update_24-04-2019, r=servo-wpt-sync
Sync WPT with upstream (24-04-2019)

Automated downstream sync of changes from upstream as of 24-04-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23250)
<!-- Reviewable:end -->
2019-04-24 20:25:39 -04:00
bors-servo
0b1a790683
Auto merge of #23252 - servo:jdm-patch-36, r=SimonSapin
Allow mac WPT jobs to run longer than 60 minutes

This should fix #23251 which has been hitting us lately as we run more tests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23252)
<!-- Reviewable:end -->
2019-04-24 17:35:35 -04:00
Josh Matthews
817aa49dc7
Update cmake for MSVC builds. 2019-04-24 15:07:31 -04:00
Josh Matthews
facfa6a417
Allow mac WPT jobs to run longer than 60 minutes 2019-04-24 09:50:53 -04:00
WPT Sync Bot
d4dc41672a Update web-platform-tests to revision 7a7e16ad8d1a1b843340f47101c0a5c24c9bba57 2019-04-24 00:13:37 -04:00
bors-servo
ec680de063
Auto merge of #23248 - asajeffrey:liblzma-dev-dependency, r=jdm
Added liblzma-dev dependency on Debian

<!-- Please describe your changes on the following line: -->

This fixes a link error on Debian Linux
```
  = note: /usr/bin/ld.gold: error: cannot find -llzma
          collect2: error: ld returned 1 exit status
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's a README

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23248)
<!-- Reviewable:end -->
2019-04-23 21:52:59 -04:00
bors-servo
155fad62b3
Auto merge of #23246 - servo:jdm-patch-30, r=SimonSapin
Don't run full WPT testsuite twice.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23246)
<!-- Reviewable:end -->
2019-04-23 18:26:28 -04:00
bors-servo
03b005c7b2
Auto merge of #23178 - tdelacour:ISSUE-21263, r=jdm
Add PerformanceResourceTiming: ResponseEnd

<!-- Please describe your changes on the following line: -->
1. Added `ResponseEnd` to `ResourceAttribute` enum in `net_traits` and added it to the `set_attribute` function on `ResourceFetchTiming`
2. Added `response_end` field to `performanceresourcetiming.rs`
3. In `http_loader.rs`, set ResponseEnd after response body read is complete, or before return due to network error.

I could use a little guidance on testing. After building and running `wpt` tests, I noticed that some tests now "Pass" when they were expected to "Fail". As per the wiki instructions, I've removed those expectations from the `metadata`.

I noticed that there are a handful of other "failing" test expectations associated with `responseEnd`, but those still do not pass. I looked through some similar PRs (`connectEnd`, `redirectStart`, etc) and saw that they also still have a few failing test expectations here and there. Does that mean this is OK for now? How can I better understand which tests we expect to resolve for a given issue? Thanks!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21263 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23178)
<!-- Reviewable:end -->
2019-04-23 16:49:12 -04:00
bors-servo
4c8d29f5a7
Auto merge of #23200 - krk:webidl-lint, r=jdm
Webidl lint

Parse webidl files and lint for inheritance correctness.

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20461

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23200)
<!-- Reviewable:end -->
2019-04-23 15:24:33 -04:00
Alan Jeffrey
61f7f12f58 Updated bootstrap.py 2019-04-23 12:02:40 -05:00
Alan Jeffrey
3aa58eed16 Added liblzma-dev dependency on Debian 2019-04-23 11:42:38 -05:00
Thomas Delacour
fdbec9835c ISSUE-21263: implemented attribute setting in http loader 2019-04-23 12:33:28 -04:00
bors-servo
9a218e659a
Auto merge of #23247 - ferjm:rm.auto.media, r=jdm
Remove use of auto media backend. And update servo-media

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23242

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23247)
<!-- Reviewable:end -->
2019-04-23 11:30:01 -04:00
Fernando Jiménez Moreno
74a48937f1 Remove use of auto media backend. And update servo-media 2019-04-23 16:24:33 +02:00
Josh Matthews
4e4fe97262
Don't run full WPT testsuite twice. 2019-04-23 09:29:58 -04:00
bors-servo
54f54d194d
Auto merge of #23186 - krk:enable-css-align-tests, r=jdm
Add css-align tests with failure expectations.

<!-- Please describe your changes on the following line: -->
Enabled `css-align` wpt tests.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20576

<!-- Either: -->
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23186)
<!-- Reviewable:end -->
2019-04-22 17:07:44 -04:00
bors-servo
abe13a99ed
Auto merge of #23237 - hundredeir:GetTimeouts, r=jdm
Adds webdriver command Get Timeouts

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

- [X] These changes do not require tests because webdriver tests already exists for it

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23237)
<!-- Reviewable:end -->
2019-04-22 15:07:02 -04:00
bors-servo
48ba809719
Auto merge of #23240 - servo-wpt-sync:wpt_update_22-04-2019, r=jdm
Sync WPT with upstream (22-04-2019)

Automated downstream sync of changes from upstream as of 22-04-2019.
[no-wpt-sync]

Fixes #22752.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23240)
<!-- Reviewable:end -->
2019-04-22 13:27:33 -04:00
Josh Matthews
7922359c79 Run bluetooth tests as part of WPT sync. 2019-04-22 11:41:01 -04:00
WPT Sync Bot
a7432be1b3 Update web-platform-tests to revision 8f35eec39a68b77c04b4dbe1f108e4fd86ad7afc 2019-04-22 11:33:36 -04:00
bors-servo
4e12deb7b6
Auto merge of #23115 - pylbrecht:measure.blocked.layout.queries, r=jdm
measure blocked layout queries

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19797

<!-- Either: -->
- [ ] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23115)
<!-- Reviewable:end -->
2019-04-22 10:52:49 -04:00
krk
fea2ad0fab Inherit TestBinding from TestBindingProxy. 2019-04-20 22:39:39 +02:00
krk
e9560617b6 Move WindowProxy declaration to the new WindowProxy.webidl file. 2019-04-20 22:39:39 +02:00
krk
763fc8a1f2 Simplify ParentMismatchError.fmt. 2019-04-20 22:39:38 +02:00
krk
0d3bee28c8 Replace WebIdlError enum with ParentMismatchError struct. 2019-04-20 22:39:38 +02:00
krk
6db7518110 Use iter.next instead of for-break. 2019-04-20 22:39:38 +02:00
krk
32049d1ab6 Remove debug logs. 2019-04-20 22:39:38 +02:00
krk
0e3ee8b60b Allow Reflector as a parent and special case PaintRenderingContext2D. 2019-04-20 22:39:38 +02:00
krk
ef59009aa1 Remove redundant return keyword. 2019-04-20 22:39:38 +02:00
krk
2384e5f4a2 Rename typ to ty and use &str where possible. 2019-04-20 22:39:37 +02:00
krk
3878fe86e7 Increase version of clap to fix test-tidy errors. 2019-04-20 22:39:37 +02:00
krk
ea833b597f Parse webidl files and lint for inheritance correctness. 2019-04-20 22:39:37 +02:00
krk
dfca8ec913 Can collect webidl paths. 2019-04-20 22:39:22 +02:00
hundredeir
114258bf87 Add webdriver command Get Timeouts 2019-04-20 23:58:24 +05:30
bors-servo
328244684a
Auto merge of #23234 - Eijebong:webdriver, r=jdm
Update webdriver to 0.39

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23234)
<!-- Reviewable:end -->
2019-04-20 09:34:07 -04:00
Bastien Orivel
18a90f04db Update webdriver to 0.39 2019-04-20 13:23:12 +02:00
bors-servo
63b4455837
Auto merge of #23235 - servo-wpt-sync:wpt_update_20-04-2019, r=servo-wpt-sync
Sync WPT with upstream (20-04-2019)

Automated downstream sync of changes from upstream as of 20-04-2019.
[no-wpt-sync]
2019-04-20 01:07:26 -04:00
WPT Sync Bot
ecabb8b521 Update web-platform-tests to revision 4657e102531b29ebfbf73b547693288c51c8b8c0 2019-04-20 01:07:12 -04:00
bors-servo
c449cbb8ea
Auto merge of #22769 - gterzian:use_thread_pool_in_resource_thread, r=nox
Use a threadpool for fetch

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22768 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22769)
<!-- Reviewable:end -->
2019-04-19 15:48:56 -04:00
bors-servo
53b752bab7
Auto merge of #23006 - aditj:aditj-patch-7, r=jdm
Added WebDriver DeleteCookies Function

<!-- Please describe your changes on the following line: -->
This change adds DeleteCookies function of the webdriver crate to the servo webdriver server.
See [spec](https://w3c.github.io/webdriver/#delete-all-cookies)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix part of #8623 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23006)
<!-- Reviewable:end -->
2019-04-19 09:48:30 -04:00