Commit graph

14880 commits

Author SHA1 Message Date
bors-servo
9fa56ccfdf Auto merge of #9073 - dsprenkels:issue-8733, r=Wafflespeanut
tidy.py: remove duplicate code patterns in `check_rust(file_name, lines)`

This is an attempt at a reasonable fix for #8733.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9073)
<!-- Reviewable:end -->
2015-12-31 20:20:27 +05:30
bors-servo
2bea29361b Auto merge of #9018 - jdm:corstests, r=Manishearth
Enable cors/ directory for WPT.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9018)
<!-- Reviewable:end -->
2015-12-31 19:40:41 +05:30
bors-servo
66c8aa8cda Auto merge of #8420 - craftytrickster:8371/generic-font-family, r=glennw
Enabled use of FontFamily enum type

https://github.com/servo/servo/issues/8371

In addition to replacing loose strings with the FontFamily enum in `font_cache_task.rs`, I also centralized the add_generic_font calls into one single function. If centralizing into one function is not desired or if anything else needs to be changed, please let me know.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8420)
<!-- Reviewable:end -->
2015-12-31 16:49:48 +05:30
Daan Sprenkels
c9f188d163 tidy.py: made check_rust(file_name, lines) more readable
also added a rule that requires a space before '-' (except in cases of scientific notation)
fixes #8733
2015-12-31 12:00:26 +01:00
bors-servo
77b23d1bb9 Auto merge of #9105 - jdm:buttoneventsintermittent, r=nox
Implement support for modifying the type attribute of <button>

https://github.com/servo/servo/pull/9100

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9105)
<!-- Reviewable:end -->
2015-12-31 15:56:16 +05:30
David Raifaizen
d942bfb474 Enabled use of FontFamily enum type and replaced plain string parameters with enum 2015-12-30 18:21:37 -05:00
Josh Matthews
3ef39e1a30 Implement the onreset event handler. 2015-12-30 16:04:16 -05:00
Josh Matthews
ffc1c777fe Implement support for modifying the type attribute of button elements. Fixes #9091. 2015-12-30 16:04:05 -05:00
bors-servo
3d969e429d Auto merge of #7919 - 6112:master, r=nox
form submission for <textarea> and <select>

Fixes #7849.
Fixes #7850.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/7919)
<!-- Reviewable:end -->
2015-12-30 23:58:40 +05:30
Josh Matthews
c7752bab63 Enable cors/ directory for WPT. 2015-12-30 10:33:43 -05:00
bors-servo
d6d70feabd Auto merge of #9089 - Ms2ger:style-unsafe, r=nox
Deny unsafe code in style.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9089)
<!-- Reviewable:end -->
2015-12-30 20:12:20 +05:30
bors-servo
f34a656b14 Auto merge of #9086 - servo:no-snapshot, r=nox
Rename rust-snapshot-hash to rust-nightly-date

… and remove mentions of "snapshots".

We now use rust-lang.org nightly builds rather than our own snapshots.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9086)
<!-- Reviewable:end -->
2015-12-30 19:20:38 +05:30
Ms2ger
2fa45aa064 Deny unsafe code in style. 2015-12-30 14:46:35 +01:00
Simon Sapin
b2af8567fa Rename rust-snapshot-hash to rust-nightly-date
… and remove mentions of "snapshots".

We now use rust-lang.org nightly builds rather than our own snapshots.
2015-12-30 13:36:47 +00:00
Simon Sapin
856eea3a0e Remove "Servo does not bootstrap 32bit snapshots of Rust" message
We now use rust-lang.org nightly builds rather than our own snapshots.
2015-12-30 12:06:54 +00:00
bors-servo
80135a70ce Auto merge of #9080 - jdm:canvaspattern, r=Ms2ger
Enable Pattern variant of CanvasFillOrStrokeStyle

This is a rebase of #8104, with a test added that exposes pre-existing problems in the canvas code for dealing with patterns.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9080)
<!-- Reviewable:end -->
2015-12-30 13:56:43 +05:30
bors-servo
3f407ea3d6 Auto merge of #9077 - bholley:split_layout_context_etc, r=SimonSapin
Split the style-related bits out of LayoutContext and hoist more stuff into style/

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9077)
<!-- Reviewable:end -->
2015-12-30 11:01:23 +05:30
Nicolas
1f234af2ac form submission for <textarea> and <select>
small changes from code review

!child.get_disabled_state() becomes child.get_enabled_state()
2015-12-30 00:27:35 -05:00
bors-servo
0f5c614609 Auto merge of #9051 - bholley:split_style_and_layout_wrappers, r=SimonSapin
Split layout wrappers into style+layout and layout-only functionality

This is a step towards removing the dependency of stylo on layout/.

This PR depends on #9004.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9051)
<!-- Reviewable:end -->
2015-12-30 10:04:14 +05:30
bors-servo
2bb6ea1321 Auto merge of #9083 - jdm:fetchintegrate, r=jdm
Partial implementation of HTTP-network-or-cache fetch step.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9083)
<!-- Reviewable:end -->
2015-12-30 07:50:43 +05:30
bors-servo
0d52170f35 Auto merge of #9054 - frewsxcv:parse-non-zero-dimension, r=eefriedman
Implement non-zero dimension attribute parsing

Fixes #8445

The only attributes I found that we have implemented that uses non-zero
dimenion attributes:

* `width` for `<td>` and `<th>` (table cells)
* `width` for `<table>`

I updated these implementations to use the new non-zero dimension
attribute parsing and added associated regression tests.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9054)
<!-- Reviewable:end -->
2015-12-30 05:26:56 +05:30
bors-servo
4e3a435450 Auto merge of #9062 - antrik:rust-gdb, r=SimonSapin
mach run --debug: Try using rust-gdb/rust-lldb if available

If the selected debugger (requested explicitly or detected by mozdebug)
is gdb or lldb, use rust-gdb or rust-lldb instead, if it's available in
the path and appears to be working.

(This should usually be the case when using the default debugger on
GNU/Linux or MacOS, as rust-gdb or rust-lldb is provided by the Rust
snapshot in use.)

Note: I cobbled this together without *any* previous Python experience -- so if it violates three dozen rules, and only works by luck on my own system during a favourable moon phase, don't hesitate to suggest improvements :-)

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9062)
<!-- Reviewable:end -->
2015-12-30 04:34:42 +05:30
bors-servo
4a8e22c864 Auto merge of #8109 - jdm:buttonactivate, r=eefriedman
Make button elements activatable.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8109)
<!-- Reviewable:end -->
2015-12-30 03:52:26 +05:30
Nikki
d30998c4a6 Partial implementation of HTTP-network-or-cache fetch step. 2015-12-29 16:37:11 -05:00
Bobby Holley
a05d7f1dfd Hoist style-related context bits into style/.
We do a few things-here:
* Hoist non-layout-dependent fields in SharedLayoutData and LocalLayoutData into style/.
* Hoist parts of css/matching.rs into style/.
* Hoist parts of layout/animation.rs into style/animation.rs.
* Remove the duplicated-but-slightly-different definition of OpaqueNode.
2015-12-29 12:07:07 -08:00
Bobby Holley
47059d2d26 Separate style+layout and layout-specific wrapper functionality.
This patch does a number of things, unfortunately all at once:
* Hoists a large subset of the layout wrapper functionality into the style system.
* Merges TElementAttributes into the newly-created TElement.
* Reorganizes LayoutData by style vs layout, and removes LayoutDataShared.
* Simplifies the API for borrowing style/layout data.

There's still more to do to make the style system usable standalone, but
this is a good start.
2015-12-29 11:50:03 -08:00
Josh Matthews
7693b03468 Make button elements activatable. Fixes #4837. Fixes #8101. 2015-12-29 10:45:04 -05:00
Josh Matthews
832942bc26 Add test for fillStyle/strokeStyle getting/setting roundtrips. 2015-12-29 10:38:02 -05:00
Alberto Corona
e6a3c16e9a Enable Pattern variant of CanvasFillOrStrokeStyle
Closes #7608
2015-12-29 10:38:00 -05:00
bors-servo
c1cb9403a7 Auto merge of #8948 - simartin:issue_8738, r=ecoal95
Issue #8738: bufferSubData and texImage2D argument sanity checks.

Fixes https://github.com/servo/servo/issues/8738

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8948)
<!-- Reviewable:end -->
2015-12-29 17:27:27 +05:30
bors-servo
e7212953f1 Auto merge of #9074 - dagnir:ask-for-reset-on-remove, r=nox
Ask for reset when option is removed.

Now that `UnbindContext` is available, asking the `select` element for a reset when an option is removed is now possible.

Link to the spec: https://html.spec.whatwg.org/multipage/#ask-for-a-reset

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9074)
<!-- Reviewable:end -->
2015-12-29 16:43:32 +05:30
bors-servo
5ef8129ae6 Auto merge of #9058 - Ms2ger:layers, r=mrobinson
Update layers.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9058)
<!-- Reviewable:end -->
2015-12-29 04:05:22 +05:30
bors-servo
b26cd498c6 Auto merge of #9075 - Ms2ger:egl, r=Manishearth
Note egl requirement in the README.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9075)
<!-- Reviewable:end -->
2015-12-28 14:46:19 +05:30
Ms2ger
9970b96cd2 Note egl requirement in the README. 2015-12-28 10:12:40 +01:00
Dongie Agnir
12afd837a0 Ask for reset when option is removed. 2015-12-27 21:47:13 -10:00
bors-servo
941653da65 Auto merge of #8958 - jkachmar:separate-layout-msg, r=KiChjang
Separate script and layout messages, issue #8843

Separated layout-specific messages to the constellation out from the `ScriptMsg` enum into a `LayoutMsg` enum within `script_traits/script_msg.rs`, addresses [#8843](https://github.com/servo/servo/issues/8843).

I initially tried to move `LayoutMsg` into `layout_traits/lib.rs`, but this introduced a cyclic dependency: `layout_traits` depends on `script_traits` for the `LayoutTaskFactory` implementation, and `script_traits/script_task.rs` now depends on `LayoutMsg` for new layout channels in `InitialScriptState` and `ScriptTask`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8958)
<!-- Reviewable:end -->
2015-12-27 03:24:38 +05:30
Simon Martin
f2fe401d7d Issue #8738: bufferSubData and texImage2D argument sanity checks. 2015-12-26 18:56:48 +01:00
Joe Kachmar
655268d111 Separate script and layout messages, issue #8843 2015-12-26 12:24:51 -05:00
bors-servo
d2e7fd8221 Auto merge of #9066 - dsprenkels:issue-9060, r=Wafflespeanut
tidy.py: pass list of lines to each testing function

instead of whole content buffer

See #9060.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9066)
<!-- Reviewable:end -->
2015-12-26 18:44:12 +05:30
Daan Sprenkels
a01400734d tidy.py: split checking functions into {normal,line}-checking categories
This is done, because the majority of the functions splits the lines, and
it would be better to do this just once.
This commit also optimised the licence checking function slightly by only
checking the fist lines of the file (where the amount of lines is the
line span of the longest license)
2015-12-26 13:47:54 +01:00
bors-servo
c6d613f75b Auto merge of #9069 - antrik:cargo_config-location, r=SimonSapin
HACKING_QUICKSTART.md: Don't recommend creating .cargo/config in pare…

…nt directory

Recommend putting crate overrides directly in the servo/.cargo/config,
rather than in Servo's parent directory.

Overrides in the parent directory are unnecessary and confusing for
typical use cases.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9069)
<!-- Reviewable:end -->
2015-12-26 04:40:42 +05:30
bors-servo
89ab368258 Auto merge of #8506 - nox:finish-ranges, r=dzbarsky
Properly propagate changes when range or trees are mutated

Does the same thing as #6817, but storing Range instances directly in their start and end containers.

Cc @dzbarsky

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8506)
<!-- Reviewable:end -->
2015-12-26 04:08:15 +05:30
Anthony Ramine
3c76835615 Properly propagate changes when range or trees are mutated 2015-12-25 23:35:57 +01:00
Olaf Buddenhagen
dac4056d60 HACKING_QUICKSTART.md: Don't recommend creating .cargo/config in parent directory
Recommend putting crate overrides directly in the servo/.cargo/config,
rather than in Servo's parent directory.

Overrides in the parent directory are unnecessary and confusing for
typical use cases.
2015-12-25 21:08:31 +01:00
Corey Farwell
ba659cb99c Implement non-zero dimension attribute parsing
Fixes #8445

The only attributes I found that we have implemented that uses non-zero
dimenion attributes:

* `width` for `<td>` and `<th>` (table cells)
* `width` for `<table>`

I updated these implementations to use the new non-zero dimension
attribute parsing and added associated regression tests.
2015-12-24 13:20:43 -08:00
bors-servo
7db6ce41d2 Auto merge of #8725 - dzbarsky:no_context, r=eefriedman
Handle toDataURL with no context

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8725)
<!-- Reviewable:end -->
2015-12-25 02:04:40 +05:30
David Zbarsky
84ec9c4266 Handle toDataURL with no context 2015-12-24 11:48:04 -08:00
bors-servo
1073cdb408 Auto merge of #9065 - simartin:issue_6601_testcase, r=eefriedman
Issue #6601: Added testcase to ensure we don't regress

Test case for https://github.com/servo/servo/issues/6601

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/9065)
<!-- Reviewable:end -->
2015-12-25 00:37:43 +05:30
Simon Martin
8d08f1156f Issue #6601: Added testcase to ensure we don't regress. 2015-12-24 15:21:00 +01:00
Olaf Buddenhagen
f3cd5d2961 mach run --debug: Try using rust-gdb/rust-lldb if available
If the selected debugger (requested explicitly or detected by mozdebug)
is gdb or lldb, use rust-gdb or rust-lldb instead, if it's available in
the path and appears to be working.

(This should usually be the case when using the default debugger on
GNU/Linux or MacOS, as rust-gdb or rust-lldb is provided by the Rust
snapshot in use.)
2015-12-24 14:26:31 +01:00