Commit graph

39081 commits

Author SHA1 Message Date
Simon Sapin
8f89f59329 2020: parse display: contents 2019-10-24 10:44:31 +02:00
Simon Sapin
13e494d74f More compact debug output for CSS values
```
Rect {
    start_corner: Vec2 { i: 0.0 px, b: 0.0 px },
    size: Vec2 { i: 1024.0 px, b: 20.0 px },
}
```

… instead of:

```
Rect {
    start_corner: Vec2 {
        inline: CSSPixelLength(
            0.0,
        ),
        block: CSSPixelLength(
            0.0,
        ),
    },
    size: Vec2 {
        inline: CSSPixelLength(
            1024.0,
        ),
        block: CSSPixelLength(
            0.0,
        ),
    },
}
```
2019-10-24 10:44:31 +02:00
Simon Sapin
cfc3ffcd54 2020: paint background-color 2019-10-24 10:44:31 +02:00
Simon Sapin
4e8eeda976 2020: add and call Fragment::build_display_list 2019-10-24 10:43:08 +02:00
Simon Sapin
e38cc1a549 2020: run layout after box construction 2019-10-24 10:43:08 +02:00
Simon Sapin
c8a49baa80 Add ./mach test-tidy --no-wpt, for a git pre-push hook
Disabling WPT manifest checking brings the time it takes to run tidy
for ~11 seconds to ~3 seconds, which feels reasonable to have in a
git pre-push hook.
This can help avoid forgetting to run tidy before opening a PR.

```
$ chmod +x .git/hooks/pre-push
$ cat .git/hooks/pre-push
#!/bin/sh
set -e
./mach test-tidy --no-wpt
```
2019-10-24 10:30:25 +02:00
bors-servo
dc8be8f282
Auto merge of #24527 - servo-wpt-sync:wpt_update_23-10-2019, r=servo-wpt-sync
Sync WPT with upstream (23-10-2019)

Automated downstream sync of changes from upstream as of 23-10-2019.
[no-wpt-sync]
r? @servo-wpt-sync
2019-10-23 17:18:10 -04:00
bors-servo
ddc7a37531
Auto merge of #24523 - servo:rand, r=jdm,nox
Update rand to 0.7 (fixes #24448)
2019-10-23 13:38:31 -04:00
WPT Sync Bot
15e68ad3d3 Update web-platform-tests to revision a3dd2ad02c65588ad280ceac378d82e9250d1045 2019-10-23 14:17:29 +00:00
Anthony Ramine
785a344e32 Update rand to 0.7 (fixes #24448) 2019-10-23 15:34:48 +02:00
Simon Sapin
4f8cfd9b48 Use xml-rs instead of rcdom for Android font list parsing 2019-10-23 15:34:48 +02:00
bors-servo
e26530341b
Auto merge of #24489 - garasubo:refactor-submission, r=nox
Refactor submission

This is my first contribution, so please correct me if I'm wrong

I refactored the code as described #22782.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #22782  (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-22 22:05:09 -04:00
bors-servo
30c588ddac
Auto merge of #24516 - servo:jdm-patch-31, r=asajeffrey
Add remaining macs to salt roster.
2019-10-22 21:09:02 -04:00
bors-servo
3e7a0bfc42
Auto merge of #24512 - marmeladema:issue-23607/compat, r=SimonSapin
More changes for Python3 compatibility

Following #24435 for #23607 here are even more changes to be compatible with Python3.
I managed to get `./mach build` properly work with Python3 but `test-tidy` does not work yet because of a lot of problems in `web-platform-tests` which i will have to deal with at some point.

Because flake8 appears to be incompatible with the distro package in some way, i had to change to way we call flake8 (which was deprecated anyway). With this change, we should be able to update flake8 to a recent version but subprocess can be surprising on Windows platform so i'd like someone to try out those changes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-22 13:48:50 -04:00
bors-servo
bf587f22d7
Auto merge of #24508 - pajamapants3000:21254, r=jdm
Add start_time to resource timing.

<!-- Please describe your changes on the following line: -->
`start_time` property added to `ResourceFetchTiming`, which enables the setting of `start_time` in the `PerformanceEntry` member of `PerformanceResourceTiming`.

Following the specification at https://w3c.github.io/resource-timing/#dfn-starttime, `start_time` is set to the value of `redirect_start` if redirection occurs and the timing allow check passes. Otherwise it has the same value as `fetch_start`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21254

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-22 09:34:07 -04:00
bors-servo
75830b717a
Auto merge of #24511 - servo:minimal, r=nox
Don’t install rust-docs, rust-src, or clippy on CI

See https://blog.rust-lang.org/2019/10/15/Rustup-1.20.0.html#profiles
2019-10-22 06:08:02 -04:00
marmeladema
7fdd0b94cf tests/wpt: use iterkeys, itervalues and iteritems from six package 2019-10-22 10:16:01 +01:00
marmeladema
f51ae46570 tests/wpt/update: Use input() from six instead of raw_input() 2019-10-22 10:16:01 +01:00
marmeladema
c0a9d39525 Use input() from six instead of raw_input to be compatible with Python3 2019-10-22 10:16:00 +01:00
marmeladema
0ea1af8b34 tests/wpt/update: remove useless import statement 2019-10-22 10:16:00 +01:00
marmeladema
d8190a7933 tests/wpt/update: use urllib module from six package 2019-10-22 10:16:00 +01:00
marmeladema
179caed30f tests/wpt/update: Fix print statements to be compatible with Python3 2019-10-22 10:16:00 +01:00
marmeladema
45817ac26e Use 'byte' regexp pattern to match on 'byte' string
This is done in order to be compatible with Python3
2019-10-22 10:16:00 +01:00
marmeladema
af7e4d633a Convert git sha hash to text to be compatible with Python3
This also pin the six module version to 1.12 in order to be sure
six.ensure_text is available.
2019-10-22 10:15:59 +01:00
marmeladema
7e9ce2dbd5 Use six.text_type instead of str to check instance type 2019-10-22 10:15:59 +01:00
marmeladema
ff50cdb183 Fix call to flake8 broken when using distro module during test-tidy 2019-10-22 10:15:53 +01:00
bors-servo
dcd98a91d1
Auto merge of #24517 - servo-wpt-sync:wpt_update_21-10-2019, r=servo-wpt-sync
Sync WPT with upstream (21-10-2019)

Automated downstream sync of changes from upstream as of 21-10-2019.
[no-wpt-sync]
r? @servo-wpt-sync
2019-10-22 03:41:46 -04:00
bors-servo
5fb941d6f7
Auto merge of #24491 - servo:rustup, r=nox
Upgrade sccache to 0.2.12

This picks up https://github.com/mozilla/sccache/issues/488, which fixes running Servo’s unit tests with Rust nightly-2019-10-17: https://github.com/rust-lang/rust/issues/65558

https://tools.taskcluster.net/groups/Mh6AMaNkTj-dw0hfmekTYw/tasks/AO0ydhMpTZyBa5HesI1ldw/runs/0/logs/public%2Flogs%2Flive.log#L1443
2019-10-21 22:43:08 -04:00
bors-servo
927dfd15bf
Auto merge of #24500 - kitlith:style_cfg, r=jdm
Remove usage of opts::get() from style.

<!-- Please describe your changes on the following line: -->
Use `AtomicBool`s to create a global storage for a couple of settings used by an implementation of `Default`, suggested in https://github.com/servo/servo/issues/22854#issuecomment-540955207.

I do have one main question: I'm currently setting these statics in `Servo::new()`, would there be a better place to put this? Same goes with making these `pub`, is there a better way to go about this?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
  - Seems to be failing in script for unknown/unrelated reasons, experiencing SIGKILL on two different machines. (May be an issue with the latest commit?) Still works fine on CI though.
- [X] `./mach test-tidy` does not report any errors
- [X] These changes help with #22854

These changes do not require tests because these are cleanup changes.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-21 17:14:46 -04:00
Kitlith
0a07a88904 Remove usage of opts::get() from style.
Part of #22854.
2019-10-21 13:44:31 -07:00
bors-servo
61dc04a293
Auto merge of #24492 - gterzian:update_timer_scheduler, r=asajeffrey
Update timer scheduler to use crossbeam

<!-- Please describe your changes on the following line: -->

It seems time to update the timer scheduler implementation to use crossbeam constructs.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-21 12:18:07 -04:00
Simon Sapin
6913ad086a Don’t install rust-docs, rust-src, or clippy on CI
See https://blog.rust-lang.org/2019/10/15/Rustup-1.20.0.html#profiles
2019-10-21 17:28:41 +02:00
Simon Sapin
52f2d62462 Upgrade sccache to 0.2.12
This picks up https://github.com/mozilla/sccache/issues/488,
which fixes running Servo’s unit tests with Rust nightly-2019-10-17:
https://github.com/rust-lang/rust/issues/65558

https://tools.taskcluster.net/groups/Mh6AMaNkTj-dw0hfmekTYw/tasks/AO0ydhMpTZyBa5HesI1ldw/runs/0/logs/public%2Flogs%2Flive.log#L1443
2019-10-21 17:02:03 +02:00
Simon Sapin
9fd75a1e39 Update Skia and rust-azure
In order to pick up https://github.com/servo/skia/pull/180
2019-10-21 17:02:03 +02:00
WPT Sync Bot
e3a9df4e78 Update web-platform-tests to revision 670f3ef16f9b38e22e3b863dcdc2ea860348929a 2019-10-21 14:37:40 +00:00
Josh Matthews
8da757d219
Add remaining macs to salt roster. 2019-10-21 10:27:39 -04:00
bors-servo
5011e9c21c
Auto merge of #24471 - saschanaz:enum-default, r=ferjm
Support enum value as a union default value

<!-- Please describe your changes on the following line: -->

Didn't implement the actual latency thing because the relevant things are already marked as TODO.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21342

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-21 03:27:18 -04:00
Tommy
328c45a1d8 Minor assert message edits for consistency 2019-10-20 18:03:18 -07:00
marmeladema
4d6f28df35 Use linux_distribution() from distro package instead of builtin platform module
platform.linux_distribution() is deprecated since Python 3.5 and
will be removed with Python 3.8.
2019-10-20 23:56:46 +01:00
marmeladema
0aa6314ee2 Pin six module version to 1.12 2019-10-20 23:43:26 +01:00
marmeladema
bed6f2dbec Use relative import statements to be compatible with Python3 2019-10-20 23:43:26 +01:00
marmeladema
865d7377b3 Replace call to execfile(...) by call to exec(compile(open(...)))
This is done in order to be compatible with Python3
2019-10-20 23:43:25 +01:00
Gregory Terzian
c893c8955d update timer scheduler to use crossbeam 2019-10-20 23:42:34 +08:00
Tommy Lincoln
fcad88cddd Add start_time to resource timing. 2019-10-20 07:28:11 -07:00
bors-servo
882dcc8408
Auto merge of #24507 - servo-wpt-sync:wpt_update_19-10-2019, r=servo-wpt-sync
Sync WPT with upstream (19-10-2019)

Automated downstream sync of changes from upstream as of 19-10-2019.
[no-wpt-sync]
r? @servo-wpt-sync
2019-10-19 15:13:23 -04:00
bors-servo
a905916ede
Auto merge of #23637 - gterzian:continue-message-port, r=jdm
Continue message port

<!-- Please describe your changes on the following line: -->
Fixes #7457.
Fixes #12715.
Fixes #12717.
Fixes #16095.
Fixes #18969.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23637)
<!-- Reviewable:end -->
2019-10-19 13:19:01 -04:00
bors-servo
55e60f992c
Auto merge of #24506 - saschanaz:htmlconstructor, r=jdm
Convert [HTMLConstructor] as constructor extension

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24505

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-19 11:18:05 -04:00
WPT Sync Bot
b209ce8d5b Update web-platform-tests to revision e0875f70f4f33a92d8a935e8d0e09a67a45761e8 2019-10-19 13:35:47 +00:00
Kagami Sascha Rosylight
e271edad92 Convert [HTMLConstructor] as constructor extension 2019-10-19 20:55:45 +09:00
Gregory Terzian
2f8932a6a1 continue messageport, transferable, postmessage options 2019-10-19 14:28:18 +08:00