Commit graph

39081 commits

Author SHA1 Message Date
Keith Yeung
c3b17c1201 begin messageport, transferable objects, impl
Accept transfer argument for StructuredCloneData::write

Allow structured clone reads to return a boolean

Add Transferable trait

Add basic skeletons to MessagePort

Implement transfer and transfer-receiving steps on MessagePort

Use transfer and transfer_receive in StructuredClone callbacks

Implement MessageChannel

Freeze the array object for the MessageEvent ports attribute

Implement transfer argument on window.postMessage

Use ReentrantMutex instead for MessagePortInternal

Accept origin as a parameter in dispatch_jsval

Fix BorrowMut crash with pending_port_message

Detach port on closure and check for detached during transfer

Enable webmessaging tests

fix webidl

fix
2019-10-19 14:12:22 +08:00
bors-servo
175c0d56ca
Auto merge of #24490 - servo-wpt-sync:wpt_update_18-10-2019, r=servo-wpt-sync
Sync WPT with upstream (18-10-2019)

Automated downstream sync of changes from upstream as of 18-10-2019.
[no-wpt-sync]
r? @servo-wpt-sync
2019-10-19 01:31:14 -04:00
bors-servo
605ddbecd4
Auto merge of #24475 - saschanaz:legacywindowalias, r=jdm
Support [LegacyWindowAlias]

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24474 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-18 23:23:28 -04:00
Kagami Sascha Rosylight
40ee701283 Support enum value as a union default value 2019-10-19 12:19:25 +09:00
Kagami Sascha Rosylight
e81b678645 Support [LegacyWindowAlias] 2019-10-19 12:01:00 +09:00
bors-servo
118a9ecdfe
Auto merge of #24476 - saschanaz:nonenumerable, r=jdm
Mark @@iterator as nonenumerable

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #15497

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-18 16:31:17 -04:00
bors-servo
83fb2b06d0
Auto merge of #24464 - rasviitanen:offscreen-canvas, r=jdm
fix getimagedata returns empty pixels

<!-- Please describe your changes on the following line: -->
GetImageData for OffscreenCanvas without an associated canvas element returned blank pixels. To solve this, we now pass a `Size2D` instead of a canvas to relevant functions.

I don't quite know if it's ok that `OffscreenCanvasRenderingContext2D` now have a `width` and `height`, but I found no other reasonable solution to this.

There are some tests that previously were marked as `PASS` that are now failing. It seems that they were passing for the wrong reason.
These are:
> tests/wpt/metadata/offscreen-canvas/pixel-manipulation/2d.imageData.put.unchanged.html.ini
> tests/wpt/metadata/offscreen-canvas/pixel-manipulatio/2d.imageData.put.unchanged.worker.js.ini
> tests/wpt/metadata/offscreen-canvas/the-offscreen-canvas/initial.reset.path.html.ini
> tests/wpt/metadata/offscreen-canvas/the-offscreen-canvas/initial.reset.path.worker.js.ini
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24271 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-18 13:00:37 -04:00
WPT Sync Bot
aff72973cf Update web-platform-tests to revision 2b80e6d28f3c1ca734384ebded282bf07df80657 2019-10-18 13:42:40 +00:00
bors-servo
32eb858a6a
Auto merge of #24469 - saschanaz:urp-default, r=Manishearth
Support USVString as default value of a union argument

<!-- Please describe your changes on the following line: -->

I don't expect this fixes any test though...

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22543

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-18 04:02:13 -04:00
takumi
7ce40080bf [WIP] solve #22782
TODO: write tests for my change
2019-10-18 15:00:03 +09:00
bors-servo
578d9a7fb9
Auto merge of #24453 - jdm:openxr-update, r=Manishearth
Update OpenXR loader package

This fixes two outstanding WACK errors.
2019-10-18 00:51:15 -04:00
bors-servo
8ecbed9e42
Auto merge of #24460 - larsbergstrom:windows_install_reqs, r=nox
Add PYTHON3 and Universal Windows C Runtime requirements to README

<!-- Please describe your changes on the following line: -->
Adds additional documentation for how to properly set up a new Win10 environment to build Servo.

- [x] These changes fix #24457

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24460)
<!-- Reviewable:end -->
2019-10-17 21:53:27 -04:00
bors-servo
01620676c3
Auto merge of #24409 - tigleym:mouse_event_cssom_attributes, r=jdm
Implements pageX and pageY attributes on MouseEvent interface

<!-- Please describe your changes on the following line: -->
Implements missing pageX and pageY on MouseEvent interface.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] These changes fix #24248 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24409)
<!-- Reviewable:end -->
2019-10-17 16:16:15 -04:00
Micah Tigley
4b93a2350c Implements pageX and pageY attributes 2019-10-17 15:32:44 -04:00
bors-servo
5b696bbbd0
Auto merge of #24455 - saschanaz:sequence-strict, r=jdm
Throw when failing to convert sequence inner values

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24406

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-17 14:21:04 -04:00
bors-servo
58c61d3aed
Auto merge of #24315 - notriddle:GH-4577, r=nox
Add simple implementation of content-security-policy on network requests

This needs a lot more hooks before it'll actually be a good implementation, but for a start it can help get some feedback on if this is the right way to go about it.

Part of servo/servo#4577 but we should probably track the rest of the implementation somewhere.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes (before merging, this PR should fix at least some of the WPT tests for CSP)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24315)
<!-- Reviewable:end -->
2019-10-17 10:44:00 -04:00
Kagami Sascha Rosylight
1c717bc086 Mark @@iterator as nonenumerable 2019-10-17 22:08:14 +09:00
bors-servo
d8f2f2ef0e
Auto merge of #24449 - servo-wpt-sync:wpt_update_15-10-2019, r=jdm
Sync WPT with upstream (15-10-2019)

Automated downstream sync of changes from upstream as of 15-10-2019.
[no-wpt-sync]
r? @servo-wpt-sync
2019-10-17 06:39:24 -04:00
bors-servo
9b59a11b7c
Auto merge of #24408 - servo:jdm-patch-31, r=Manishearth
Synchronize WebGL layer creation with underlying GL APIs

I believe the underlying cause of #24373 is that the XR callbacks can end up executing before the XR WebGL layer setup has occurred. This was observed in the following symptom:
* a DOM exception would be thrown from inside the renderVR function, which is only called from XR's requestAnimationFrame callback
* following this, the webgl thread would panic with a GL error when executing the GL operations invoked from XRWebGLLayer::Constructor

This indicates that _somehow_ the XR rAF callback that raised an exception would have been operating on GL state that was not actually the state intended.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24408)
<!-- Reviewable:end -->
2019-10-17 02:22:31 -04:00
Kagami Sascha Rosylight
e905a4606a Support USVString as default value of a union argument 2019-10-17 12:06:41 +09:00
Kagami Sascha Rosylight
6c98292a08 Throw when failing to convert sequence inner values 2019-10-17 10:38:22 +09:00
bors-servo
14240bee81
Auto merge of #24452 - Manishearth:raf-lifecycle, r=asajeffrey
Always request new XR frames

Currently we only request XR frames when there is a rAF callback queued up.

This is incorrect, see https://immersive-web.github.io/webxr/#xr-animation-frame

With this change we always request updated frame state regardless of whether or not the user has queued up callbacks.

In addition to being spec-correct, this means that we can reliably listen for events in the OpenXR backend in the rAF loop itself, instead of having to set up a second spinning loop for when the rAF is inactive. This lets us implement visibility states for openxr without having to worry about the user never receiving the wakeup call because the rAF loop isn't pumping.

See also: https://github.com/immersive-web/webxr/issues/877

r? @asajeffrey
2019-10-16 20:02:10 -04:00
bors-servo
9032207b8a
Auto merge of #24447 - servo:uninit, r=nox
Work around deprecation warnings caused by autocfg $RUSTFLAGS handling

See https://github.com/servo/servo/issues/24446
2019-10-16 17:03:13 -04:00
bors-servo
b5759e7113
Auto merge of #24444 - ferjm:downloadbuffer.android, r=jdm
Update servo-media. Temporarily disable progressive download on Android

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #24413
2019-10-16 15:48:13 -04:00
Michael Howell
b8f3e8bb2e Add simple implementation of content-security-policy on scripts / styles
This needs a lot more hooks before it'll actually be a good
implementation, but for a start it can help get some feedback on if this
is the right way to go about it.

Part of servo/servo#4577
2019-10-16 19:46:45 +00:00
Rasmus Viitanen
328809aebe fix getimagedata returns empty pixels 2019-10-16 21:20:46 +02:00
bors-servo
6d488f1be2
Auto merge of #24435 - marmeladema:issue-23607/compat, r=jdm
Issue 23607: first pass of changes for compatibility with Python3

As much as i want to migrate entirely to Python3 (see #23607), it will require some time as changes in web-platform-tests are significant and rely on upstream fixes to be merged and synced downstream.
In the meantime, lets improve compatibility with Python3 so that later, migration will be less painful.

Build system is definitely not ready yet for Python3, but its a step in the right direction.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x ] `./mach build -d` does not report any errors
- [ x] `./mach test-tidy` does not report any errors

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-16 11:01:28 -04:00
Lars Bergstrom
04f9b91a2a Add PYTHON3 and Universal Windows C Runtime requirements to README 2019-10-16 09:33:54 -05:00
Josh Matthews
a13e559a0f
Remove intermittent failure. 2019-10-16 09:52:12 -04:00
bors-servo
bcd8c5e597
Auto merge of #24422 - pylbrecht:raqote, r=jdm
Use raqote for 2D canvas rendering

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23431

<!-- Either: -->

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/24422)
<!-- Reviewable:end -->
2019-10-16 09:12:17 -04:00
marmeladema
2b3f6a2289 Remove python/_virtualenv/ dir in clean_build_artifacts.sh 2019-10-16 08:28:30 +01:00
bors-servo
f0b708418c
Auto merge of #24451 - servo:jdm-patch-36, r=manishearth
Restore convenience UWP build flags.

Restores the build flags removed in 5367da98f8 to avoid mistakes when specifying the new target.
2019-10-16 02:57:25 -04:00
marmeladema
bf66a08c02 Fix StringIO module import to be compatible with Python3 2019-10-16 00:22:08 +01:00
marmeladema
5bd0fca140 Use iteritems from six module for Python3 compatibility 2019-10-16 00:22:08 +01:00
marmeladema
6c813d073c Use octal literal syntax compatible with Python3 2019-10-16 00:22:07 +01:00
marmeladema
02cfb4f49e Fix except statement in order to be compatible with Python3 2019-10-16 00:22:07 +01:00
marmeladema
f1d42fe787 Use urllib from six module in order to be compatible with Python3 2019-10-16 00:22:07 +01:00
marmeladema
f063ea64a5 Add six module to python requirements.txt for Python3 compatibility 2019-10-16 00:22:06 +01:00
marmeladema
4e1ee07a79 Improve print statement compatibility with Python3 2019-10-16 00:22:06 +01:00
bors-servo
b96b08a3d9
Auto merge of #24443 - ferjm:gst.debug.android, r=jdm
Allow setting GST_DEBUG on Android through mach

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
2019-10-15 18:26:46 -04:00
bors-servo
eda6d3e0c5
Auto merge of #24436 - paulrouget:uwp-tap, r=jdm
Use Tapped event instead of PointerReleased

Fix #24032
2019-10-15 17:18:48 -04:00
Josh Matthews
35dc07ab9e Upgrade OpenXR loader package to 1.0.3. 2019-10-15 15:49:35 -04:00
Josh Matthews
40b473ad03 Remove unnecessary DLLs from UWP project. 2019-10-15 15:49:22 -04:00
Manish Goregaokar
24bfca9b71 Always request new XR frames 2019-10-15 11:21:17 -07:00
Manish Goregaokar
5e098e3a2a Unconditionally set up rAF loop on initialization 2019-10-15 11:21:17 -07:00
bors-servo
aa916ad20e
Auto merge of #24429 - saschanaz:getpropertykeys, r=jdm
Return false when GetPropertyKeys fails

<!-- Please describe your changes on the following line: -->

As stated in https://github.com/servo/servo/pull/24377#discussion_r333844560.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-10-15 11:59:09 -04:00
Josh Matthews
98bcb4bb57
Fix syntax error. 2019-10-15 10:45:19 -04:00
Josh Matthews
6ec5314911
Restore convenience UWP build flags. 2019-10-15 10:44:14 -04:00
Simon Sapin
e0e1d9de64 Fix #24446 2019-10-15 15:34:36 +02:00
WPT Sync Bot
4bc7277be1 Update web-platform-tests to revision 9f31d497bf87bdf5ebc3ba70b5cb9f87786f4071 2019-10-15 13:26:56 +00:00