Commit graph

39231 commits

Author SHA1 Message Date
WPT Sync Bot
a68b59d35a Update web-platform-tests to revision b624f9b794b1fbc6672fb744bb0ed18819be4d44 2019-11-18 15:04:31 +00:00
bors-servo
dfa78986a6
Auto merge of #24753 - servo:mainstream-brew, r=jdm
Use an already-installed Homebrew at /usr/local

This requires https://github.com/servo/taskcluster-config/pull/4 to be deployed.

Having the standard location helps `pkg-config` (CC https://github.com/servo/servo/pull/24688), and allows installing pre-compiled pakcages (which is much faster than compiling from source).
2019-11-17 17:49:14 -05:00
bors-servo
d1db623dfc
Auto merge of #24761 - servo-wpt-sync:wpt_update_17-11-2019, r=jdm
Sync WPT with upstream (17-11-2019)

Automated downstream sync of changes from upstream as of 17-11-2019.
[no-wpt-sync]
r? @servo-wpt-sync
2019-11-17 15:12:16 -05:00
Josh Matthews
e6e440683d
Remove intermittent failure. 2019-11-17 10:34:45 -05:00
bors-servo
a7008d1cf7
Auto merge of #24665 - saschanaz:timerhandler, r=nox
Use TimerHandler IDL union type

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #20700

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-11-17 10:30:51 -05:00
WPT Sync Bot
ea00d34098 Update web-platform-tests to revision 89aa3f42131cce5a77268ddaeb2fab8a2e29c2a6 2019-11-17 14:10:26 +00:00
Simon Sapin
0dad48f54f macOS CI: use a cache of github.com/servo/servo
Relies on https://github.com/servo/taskcluster-config/pull/6
2019-11-17 09:08:21 +01:00
bors-servo
39963266ae
Auto merge of #24749 - saschanaz:windows-rls, r=SimonSapin
Update to rustc 1.41.0-nightly (1bd30ce2a 2019-11-15)

<!-- Please describe your changes on the following line: -->

This is for devs on Windows where the current nightly version of RLS (2019-10-26) is not available.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24756

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-11-17 00:22:59 -05:00
bors-servo
5372931eaa
Auto merge of #24746 - jdm:chains-update, r=asajeffrey
Update surfman-chains

This allows us to get usable results out of babylon demos on the HoloLens 2, and gets us much closer to usable results on desktop.
2019-11-16 22:31:12 -05:00
bors-servo
2c09f94358
Auto merge of #24736 - paulrouget:layoutissue, r=SimonSapin
layout: Ensure abs-pos elements establish block formatting contexts

Updating #16310

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #13495 (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-11-16 20:20:15 -05:00
bors-servo
901fef5fa9
Auto merge of #24742 - servo:jdm-patch-34, r=asajeffrey
Reduce unnecesarily large borrow in script thread

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24730
- [x] There are tests for these changes
2019-11-16 18:32:27 -05:00
bors-servo
db9430755b
Auto merge of #24741 - saneyuki:mailmap, r=jdm
Update Tetsuharu OHZEKI's entry in mailmap

I no longer use these mail addresses (the former is still reachable but I cannot access to the later one). I'll update them with reachable one by myself.
2019-11-16 16:29:33 -05:00
bors-servo
04119ed84b
Auto merge of #24732 - jdm:wptfixes, r=asajeffrey
Address upstream WPT test harness changes

https://github.com/web-platform-tests/wpt/pull/19449 and https://github.com/web-platform-tests/wpt/pull/19993 caused some of our proprietary tests to silently start to fail. This addresses all of the breakage.
2019-11-16 12:27:30 -05:00
bors-servo
5670a4543c
Auto merge of #24734 - paulrouget:tooltip, r=jdm
Better tooltip for UWP port

Fix #24721
2019-11-16 09:23:01 -05:00
Simon Sapin
657fead0ce Don’t fetch git tags 2019-11-16 14:26:37 +01:00
Simon Sapin
188dd9e7ab Reduce git fetch depth. 100 still takes quite some time!
```
(git init servo.git &&
    cd servo.git &&
    time git fetch https://github.com/servo/servo master $ARGS &&
); rm -rf servo.git

Full: 724.75 MiB
      57s home fiber in Paris
    1m25s AWS us-west-2 Oregon
    3m23s Macstadium DC1 Atlanta
    4m22s Macstadium DC2 Las Vegas

--depth 100: 129.00 MiB
    1m21s home
    1m18s AWS
    1m30s Macstadium 1
    1m24s Macstadium 2

--depth 50: 97.62 MiB
    30s home
    30s AWS
    41s Macstadium 1
    40s Macstadium 2

--depth 30: 92.47 MiB
    17s home
    18s AWS
    27s Macstadium 1
    26s Macstadium 2

--depth 10: 88.25 MiB
    11s home
    12s AWS
    26s Macstadium 1
    25s Macstadium 2

--depth 1: 87.53 MiB
    10s home
    10s AWS
    22s Macstadium 1
    28s Macstadium 2
```
2019-11-16 14:15:52 +01:00
Simon Sapin
a74046a3b6 Print timing of git operations 2019-11-16 14:15:15 +01:00
Simon Sapin
591d7ad6c1 Make Cargo print timing information to stdout
This adds lines such as

```
   Completed cssparser v0.27.1 custom-build in 2.4s
   Completed cssparser v0.27.1 custom-build (run) in 0.6s
   Completed cssparser v0.27.1 in 1.1s
```
2019-11-16 14:11:52 +01:00
Simon Sapin
50d5bac736 Reduce macOS build task timeout 2019-11-16 10:11:36 +01:00
Simon Sapin
8b39fd3c7b Verbose Homebrew 2019-11-16 10:10:13 +01:00
Kagami Sascha Rosylight
0621943290 Update to rustc 1.41.0-nightly (1bd30ce2a 2019-11-15) 2019-11-16 11:54:47 +09:00
bors-servo
d92f705573
Auto merge of #24750 - servo:register-tool, r=jdm
Use `#![register_tool]` instead of `Registry::register_attribute`

CC https://github.com/rust-lang/rust/pull/66344, https://github.com/rust-lang/rust/issues/66079
2019-11-15 17:07:13 -05:00
Simon Sapin
d04a2745c6 Make the macOS worker type configurable 2019-11-15 22:21:06 +01:00
Simon Sapin
9b17deb11e Install zlib on macOS
https://community-tc.services.mozilla.com/tasks/fcbLrz33RHeshgRZGvSAjg/runs/0/logs/https%3A%2F%2Fcommunity-tc.services.mozilla.com%2Fapi%2Fqueue%2Fv1%2Ftask%2FfcbLrz33RHeshgRZGvSAjg%2Fruns%2F0%2Fartifacts%2Fpublic%2Flogs%2Flive.log#L1359

Note that the above is on macOS 10.15. Maybe previous versions provided zlib system-wide?
2019-11-15 22:20:47 +01:00
Simon Sapin
c292b1aaf0 Expect Homebrew to already be installed and in $PATH 2019-11-15 22:20:40 +01:00
Josh Matthews
4041cafab0 Update test manifest. 2019-11-15 13:53:26 -05:00
Simon Sapin
bea73951db Use #![register_tool] instead of #![register_attr]
CC https://github.com/rust-lang/rust/issues/66079
2019-11-15 17:24:42 +01:00
Simon Sapin
091feba0ba Use #![register_attr(…)] instead of Registry::register_attribute
CC https://github.com/rust-lang/rust/pull/66344, https://github.com/rust-lang/rust/issues/66080
2019-11-15 16:46:50 +01:00
Josh Matthews
a1df2a75d0 Fix test syntax error. 2019-11-15 10:39:40 -05:00
Josh Matthews
ebf54c9788 Convert deprecated single-page tests to use proper test harness. 2019-11-15 10:37:55 -05:00
bors-servo
b9cdf9ebda
Auto merge of #24728 - servo:tc-readme, r=jdm
Update etc/taskcluster/README.md for Community-TC migration
2019-11-15 09:03:29 -05:00
bors-servo
2caa227e10
Auto merge of #24567 - JoshMcguigan:mach-venv, r=SimonSapin
mach bootstrap - activate virtual env

This modifies the `./mach bootstrap` script to activate the python virtual environment, fixing issues on systems that don't have `six` and `distro` pre-installed.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24561 (also relevant to #24541)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they are in the `./mach bootstrap` script - although this may be something that could be checked in CI - Is there any interest in setting this up?
2019-11-14 20:07:04 -05:00
Josh Matthews
4a687bb822 Update surfman-chains. 2019-11-14 15:47:15 -05:00
Josh Matthews
8846cda501 script: Reduce scope of borrows for history updates. 2019-11-14 14:11:53 -05:00
Tetsuharu OHZEKI
a18c08c2c7 Update Tetsuharu OHZEKI's entry in mailmap 2019-11-15 00:46:45 +09:00
Simon Sapin
efdf31704c Add link to worker list view 2019-11-14 16:09:30 +01:00
bors-servo
36c2a131ac
Auto merge of #24717 - servo:fraaaaaaaaaaaaame, r=jdm
Fix sccache failure when rustc generates thousands of warnings

Fixes https://github.com/servo/servo/issues/24714
2019-11-14 07:47:12 -05:00
bors-servo
f3b1f0d308
Auto merge of #24624 - garasubo:fix-keypress-trigger, r=paulrouget
Fix keypress trigger condition

Fix #22346

keypress event should be triggered for keys representing character
values. So, we should trigger this event for enter key.
This event should not trigger for IME inputs.

TODO:
- It seems we don't handle composition events correctly. To implement this keypress condition correctly, we should fix that first. In my current implementation, onkeypress event will be trigger when the user press Enter key to send inputs in IME (onCompotionEnd).
- I don't update any tests, and I couldn't find any tests related to this change in WPT. It might be better to add some tests for it, but I don't know what is the appropriate way.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-11-14 06:51:33 -05:00
Paul Rouget
0ea9f69ca8 layout: Ensure abs-pos elements establish block formatting contexts 2019-11-14 12:16:23 +01:00
Paul Rouget
8a97aa5647 Better tooltip for UWP port 2019-11-14 05:27:16 +01:00
bors-servo
f65cb94b9e
Auto merge of #24674 - servo:jdm-patch-34, r=nox
Correct inverted logic for available image checks.

From https://html.spec.whatwg.org/multipage/images.html#updating-the-image-data:
Step 3 says to initialize selected source to null.
Step 4 says to set the selected source to the image element's src value if it's not using responsive images and it has a non-empty src value.
Step 6 performs some steps if selected source is not null.

The existing code tried to do the step 6 check in a roundabout way which caused us to always check for an available image when using responsive images, which is incorrect. The new code is easier to read and matches the specification text.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because it's not worth writing a test to verify that an image cache check that would always fail does not happen.
2019-11-13 19:19:59 -05:00
Josh Matthews
610d7d48be Expect new PreconditionFailedError interface during WPT tests. 2019-11-13 16:57:10 -05:00
Simon Sapin
2d8ebc57dd Update etc/taskcluster/README.md for Community-TC migration 2019-11-13 20:24:42 +01:00
bors-servo
eb05af27d2
Auto merge of #24711 - servo:rustc-dev, r=jdm
Make `./mach rustup` install the rustc-dev component
2019-11-13 01:55:15 -05:00
bors-servo
396df40218
Auto merge of #24712 - servo:lz4, r=jdm
Revert "Upload uncompressed Docker images"

https://bugzilla.mozilla.org/show_bug.cgi?id=1593543 is fixed.

This reverts commit 5abb013dfd.
2019-11-12 21:57:04 -05:00
bors-servo
97f1300739
Auto merge of #24704 - Darkspirit:https, r=jdm
HSTS & CA updates; Fix Debian bootstrap; Default to https on Android, too.

- Updated HSTS Preload list using ./mach update-hsts-preload
- Updated CA [database](https://ccadb-public.secure.force.com/mozilla/IncludedCACertificateReportPEMCSV) using etc/cert_generator.sh.
  - No additions.
  - [bug 1552374](https://bugzilla.mozilla.org/show_bug.cgi?id=1552374) removed Certinomis - Root CA
  - [bug 1574670](https://bugzilla.mozilla.org/show_bug.cgi?id=1574670) removed Class 2 Primary CA and Deutsche Telekom Root CA 2
  - [bug 1586081](https://bugzilla.mozilla.org/show_bug.cgi?id=1586081) removed GlobalSign Extended Validation CA - SHA256 - G2
- Updated Public Suffix list using ./mach update-pub-domains
- Default to https on Android, too. Desktop was done in #23363.
Keep http:// after `android.webkit.URLUtil.guessUrl()` url sanitization only if the user explicitly typed it into the address bar.
Small warning: I don't have an Android build environment yet, but still wanted to try to contribute these two lines.
- Fixed `./mach bootstrap` for Debian Testing. Regression from #24512.
After `pip install distro` (#24561) I finally got `Exception: mach bootstrap does not support Debian GNU/Linux, please file a bug`.
distrib and version were "debian" and "bullseye/sid" before, now they are "debian gnu/linux" and "testing".
- Use HSTS preload list for private HttpState, too. Private HttpState currently [creates an empty HSTS list](f7fb130a2a/components/net/http_loader.rs (L93-L95)). In contrast, regular HttpState first creates HstsList from Preload list and then adds further HSTS entries previously saved on disk.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-11-12 17:55:13 -05:00
bors-servo
bd0ae59ca9
Auto merge of #24576 - jaymodi98:iframe-srcdoc, r=jdm
Implement srcdoc support for iframes

<!-- Please describe your changes on the following line: -->
This PR contains changes related to adding srcdoc attribute parsing support for iframes in Servo. The following changes have been made:

- uncomment the [srcdoc](f63b404e0c/components/script/dom/webidls/HTMLIFrameElement.webidl (L10-L11)) WebIDL attribute, and implement the attribute getter.
- add a field to [LoadData](e6b271d329/components/script_traits/lib.rs (L137-L164)) for storing the srcdoc contents when loading a srcdoc iframe.
- (partially) implemented a new `page_load_about_srcdoc` method to `script_thread.rs` which loads the special `about:srcdoc` URL [per the specification](https://html.spec.whatwg.org/multipage/iframe-embed-object.html#process-the-iframe-attributes) and takes the srcdoc contents as an argument
- call this new method from [handle_new_layout](e6b271d329/components/script/script_thread.rs (L2409-L2412)) when it's detected that a srcdoc iframe is being loaded
- (partially) in [attribute_mutated](e6b271d329/components/script/dom/htmliframeelement.rs (L560)), ensure that changing the `srcdoc` attribute of an iframe element [follows the specification](https://html.spec.whatwg.org/multipage/iframe-embed-object.html#the-iframe-element:the-iframe-element-9).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes are a part of fix #4767  (GitHub issue number if applicable)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2019-11-12 14:29:20 -05:00
Josh Matthews
af158de504 dom: Reduce the scope of iframe's load blocker borrow. 2019-11-12 13:57:54 -05:00
jaymodi98
bf69b6fea7 Implement srcdoc support for iframes. 2019-11-12 13:57:54 -05:00
bors-servo
641c732281
Auto merge of #24709 - paulrouget:movefix, r=jdm
Properly set event.buttons value on mousemove

A regular mousemove doesn't have any pressed button. And we were not resetting the pressed buttons after a click. That was messing up some jquery polyfil.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #24596 (GitHub issue number if applicable)
2019-11-12 12:13:40 -05:00