Commit graph

26596 commits

Author SHA1 Message Date
Hiroyuki Ikezoe
b587bf9be1 Use assign_utf8 to set servo's string into nsAString. 2017-06-09 07:03:17 +09:00
Hiroyuki Ikezoe
ba2c73d20a Add a new FFI to convert PropertyDeclarationBlock into nsTArray<RefPtr<RawServoAnimationValue>>.
With this function we can get multiple RawServoAnimationValue(s) for shorthand
properties.
2017-06-09 07:03:16 +09:00
Hiroyuki Ikezoe
2b929a1cb1 Factor out a process that creates AnimationValue iterator from PropertyDeclarationBlock. 2017-06-09 07:03:11 +09:00
Hiroyuki Ikezoe
3244d6264a Drop parent style argument from Gecko_UpdateAnimations. 2017-06-09 06:03:21 +09:00
bors-servo
612f2c1c2a Auto merge of #17235 - bzbarsky:bigger-sharing-cache, r=bholley
Increase the size of the style sharing cache to 31

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1369621

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17235)
<!-- Reviewable:end -->
2017-06-08 12:22:38 -07:00
bors-servo
6b707b3248 Auto merge of #17234 - mbrubeck:dir, r=xidorn
stylo: Make :-moz-locale-dir selector non-internal.

https://bugzilla.mozilla.org/show_bug.cgi?id=1367310

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17234)
<!-- Reviewable:end -->
2017-06-08 11:25:42 -07:00
Boris Zbarsky
2f2b93c521 Increase the size of the style sharing cache to 31.
Still a lot of guesswork here, but this does seem to get us better sharing.  See
https://bugzilla.mozilla.org/show_bug.cgi?id=1369621 for some data.
2017-06-08 14:14:44 -04:00
bors-servo
0dc7190311 Auto merge of #17227 - chenpighead:stylo-fill-opacity-animatable, r=boris
stylo: make fill-opacity animatable

This is just the servo part change. The test part will be landed in gecko directly.

Gecko bug: [Bug 1369624](https://bugzilla.mozilla.org/show_bug.cgi?id=1369624)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17227)
<!-- Reviewable:end -->
2017-06-08 10:24:37 -07:00
Boris Zbarsky
93271e199b Reduce the size of top_down_dom stackframes.
The idea is to put the memmoving of the ThreadLocalContext out of line from the point of view of top_down_dom so we don't need to allocate a large chunk of stack space for it.
2017-06-08 13:02:36 -04:00
bors-servo
2a78fae601 Auto merge of #17233 - emilio:rej, r=bzbarsky
Remove file accidentally added in #17219.

And prevent it from happening again.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17233)
<!-- Reviewable:end -->
2017-06-08 09:18:44 -07:00
Matt Brubeck
2e85790fa0 stylo: Make :-moz-locale-dir selector non-internal. 2017-06-08 09:07:06 -07:00
Emilio Cobos Álvarez
ea90730593
Also ignore orig files. 2017-06-08 17:34:23 +02:00
Emilio Cobos Álvarez
c9320de02e
Remove file accidentally added in #17219.
And prevent it from happening again.
2017-06-08 17:33:58 +02:00
bors-servo
3616b8f0c3 Auto merge of #17225 - bzbarsky:pseudo-sharing-fixage, r=emilio
Fix revalidation selectors when pseudo-elements are involved.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix https://bugzilla.mozilla.org/show_bug.cgi?id=1371112

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because I am adding a Gecko test for them

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17225)
<!-- Reviewable:end -->
2017-06-08 07:21:01 -07:00
bors-servo
09b4f79ed3 Auto merge of #17218 - canaltinova:transform-bug, r=emilio
Don't accept an extra token at the end of transform property

The lack of `input.try` usage makes transform property to accept values like `rotate(70deg)foo`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17218)
<!-- Reviewable:end -->
2017-06-08 03:37:44 -07:00
bors-servo
433b7bf9fa Auto merge of #17221 - aethanyc:support-xbl-stylesheet, r=heycam
stylo: Get rules from Gecko XBL stylesheets in cascading (Bug 1290276)

The change was reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1290276

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17221)
<!-- Reviewable:end -->
2017-06-08 00:19:27 -07:00
Jeremy Chen
a21605a201 Bug 1369624 - stylo: make fill-opacity animatable.
MozReview-Commit-ID: 4iUSBtEYXuR
2017-06-08 14:38:25 +08:00
bors-servo
12dca42dd7 Auto merge of #17196 - glennw:update-wr-cache-glyphs, r=jdm
Update WR (move glyph data to gpu cache and halve glyph alloc/uploads).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17196)
<!-- Reviewable:end -->
2017-06-07 22:55:53 -07:00
Boris Zbarsky
537cf52707 Fix revalidation selectors when pseudo-elements are involved. 2017-06-08 01:19:50 -04:00
bors-servo
caa8343e13 Auto merge of #17077 - asajeffrey:constellation-no-root-browsing-context, r=cbrewster
Removed root browsing context from constellation

<!-- Please describe your changes on the following line: -->

Removed the special root browsing context from the constellation.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13994
- [X] These changes do not require tests because this isn't visible from user code

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17077)
<!-- Reviewable:end -->
2017-06-07 21:57:10 -07:00
bors-servo
24e944ad94 Auto merge of #17219 - upsuper:currentcolor, r=Manishearth,birtles
Support interpolation between currentcolor and numeric color

This is the Servo side change of [bug 1345709](https://bugzilla.mozilla.org/show_bug.cgi?id=1345709).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17219)
<!-- Reviewable:end -->
2017-06-07 21:03:52 -07:00
Alan Jeffrey
2fd925bac9 Removed root browsing context from constellation. 2017-06-07 22:53:50 -05:00
Ting-Yu Lin
108a169216 stylo: Update gecko generated bindings 2017-06-08 11:26:06 +08:00
Ting-Yu Lin
2411749fcf stylo: Get rules from Gecko XBL stylesheets in cascading (Bug 1290276) 2017-06-08 11:18:44 +08:00
Xidorn Quan
5c643adb98 Simplify caret-color conversion. 2017-06-08 12:59:28 +10:00
Xidorn Quan
c62935577a Add separate computed Color value. 2017-06-08 12:59:26 +10:00
Xidorn Quan
742c45f859 Remove complex_color parameter. 2017-06-08 12:59:24 +10:00
Xidorn Quan
7568a19688 Merge CSSColor into Color. 2017-06-08 12:59:22 +10:00
bors-servo
c0f3ec8780 Auto merge of #17192 - mbrubeck:layout, r=pcwalton
Parallel layout optimizations

This takes some of the optimizations made to parallel styling in #16971 and applies them to parallel layout.  Specifically:

* Reduce the chunk size, to increase chances for parallelism on trees with small fan-out.
* Reduce allocations by using SmallVec.
* Reduce task switching by processing up to one chunk of children within the same rayon task as the parent.

This cuts the "Primary Layout Pass" time in **half** on the MySpace page from [tp5n], and on my other real-world test pages it is a small improvement or close to no change.

[tp5n]: https://wiki.mozilla.org/Buildbot/Talos/Tests#tp5n_pages_set

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they affect performance only

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17192)
<!-- Reviewable:end -->
2017-06-07 19:57:57 -07:00
Glenn Watson
392ed2c8db Update WR (move glyph data to gpu cache and halve glyph alloc/uploads). 2017-06-08 12:19:40 +10:00
bors-servo
ad47d33511 Auto merge of #17206 - heycam:lang-snapshots, r=emilio
match :lang() against snapshots correctly

Reviewed in https://bugzilla.mozilla.org/show_bug.cgi?id=1365162.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17206)
<!-- Reviewable:end -->
2017-06-07 19:00:54 -07:00
Cameron McCormack
18d847227c style: Update Gecko bindings. 2017-06-08 09:37:33 +08:00
Cameron McCormack
f492c8fe6e style: Match :lang() using snapshots correctly. 2017-06-08 09:37:09 +08:00
Cameron McCormack
c7e2500311 style: Note :lang() as being sensitive to attributes. 2017-06-08 09:37:09 +08:00
Cameron McCormack
e299905606 style: Define types for pseudo-class string argument storage. 2017-06-08 09:37:09 +08:00
Cameron McCormack
094052c544 style: Clean up extended_filtering a bit. 2017-06-08 09:37:09 +08:00
Cameron McCormack
524794c09a script: Move extended_filtering to the style crate.
We'll need to call it from the style crate in later patches, when matching
:lang() against element snapshots.
2017-06-08 09:37:09 +08:00
Xidorn Quan
bf77f81ed6 Create RGBAColor for colors compute to RGBA. 2017-06-08 10:42:26 +10:00
Xidorn Quan
d0d170767d Unify specified Color type between Stylo and Servo. 2017-06-08 10:42:24 +10:00
Xidorn Quan
f3610d2724 Factor out Gecko-specific color keywords. 2017-06-08 10:42:22 +10:00
Xidorn Quan
b7d8fd0ff5 Move ToComputedValue impl of color types into specified::color. 2017-06-08 10:42:21 +10:00
Xidorn Quan
a7dda61158 Move specified color types into specified::color mod. 2017-06-08 10:42:19 +10:00
Xidorn Quan
6e1b36b32f Remove unused CSSRGBA. 2017-06-08 10:42:18 +10:00
bors-servo
1ea4a44fad Auto merge of #17216 - nox:fix-computed-circle-serialisation, r=canaltinova
Fix serialisation of computed circle() shapes

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17216)
<!-- Reviewable:end -->
2017-06-07 17:31:17 -07:00
Nazım Can Altınova
51066436fa
Don't accept an extra token at the end of transform property 2017-06-08 02:36:52 +03:00
bors-servo
07b0770d21 Auto merge of #17193 - asajeffrey:test-tidy-brace-count, r=jdm
Count number of braces on a line when checking spec links in test-tidy

<!-- Please describe your changes on the following line: -->

Allow more than one brace per line when checking spec links in test-tidy.

We had problems caused  by `if unsafe { ... } {`.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes have tests.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17193)
<!-- Reviewable:end -->
2017-06-07 15:36:36 -07:00
Anthony Ramine
5704e02529 Fix serialisation of computed circle() shapes 2017-06-07 23:47:03 +02:00
bors-servo
3553ae4df9 Auto merge of #17214 - bzbarsky:backout-style-sharing-increase, r=bustage
Back out https://github.com/servo/servo/pull/17198 for Gecko test failures

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17214)
<!-- Reviewable:end -->
2017-06-07 13:50:54 -07:00
Boris Zbarsky
3d3ce51797 Back out https://github.com/servo/servo/pull/17198 for Gecko test failures 2017-06-07 15:57:48 -04:00
bors-servo
0934df77fd Auto merge of #17212 - jryans:visited-selectors, r=emilio
Stylo: Visited selectors for nested links

https://bugzilla.mozilla.org/show_bug.cgi?id=1370358

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/17212)
<!-- Reviewable:end -->
2017-06-07 12:49:34 -07:00