Commit graph

31404 commits

Author SHA1 Message Date
Emilio Cobos Álvarez
9e6c49d479
style: Share code for Element::Matches. 2017-10-13 17:21:26 +02:00
Emilio Cobos Álvarez
77f115b467
stylo: Remove unused function. 2017-10-13 17:01:36 +02:00
Emilio Cobos Álvarez
271d2b4ecd
stylo: Reformat a bunch of signatures. 2017-10-13 17:01:33 +02:00
Emilio Cobos Álvarez
09d3a11c86
style: Reformat a couple signatures.
MozReview-Commit-ID: 7Wdvj7i8ClR
2017-10-13 17:01:31 +02:00
bors-servo
085a0db056 Auto merge of #18857 - servo:jdm-patch-2, r=KiChjang
Remove call to missing method

Somehow the test harness does not report this as a problem, which is scary.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18857)
<!-- Reviewable:end -->
2017-10-13 08:34:42 -05:00
bors-servo
20855c2304 Auto merge of #18862 - emilio:stylo-element-closest, r=heycam
stylo: Use stylo for Element::Closest.

Bug: 1407952
Reviewed-by: heycam
MozReview-Commit-ID: 3H2piFT2CfF

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18862)
<!-- Reviewable:end -->
2017-10-13 07:22:43 -05:00
bors-servo
a89a76e1fc Auto merge of #18847 - emilio:invalidation-generic, r=heycam
style: Split the invalidation processing from the invalidator step.

This is the first step in reusing the invalidation machinery for other stuff,
potentially including QuerySelector / QuerySelectorAll.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18847)
<!-- Reviewable:end -->
2017-10-13 06:14:42 -05:00
Emilio Cobos Álvarez
7fd2ac1704
stylo: Use stylo for Element::Closest.
Bug: 1407952
Reviewed-by: heycam
MozReview-Commit-ID: 3H2piFT2CfF
2017-10-13 12:22:42 +02:00
Emilio Cobos Álvarez
e447f819a2
style: Make InvalidationProcessor methods be &mut self.
This would allow querySelector / querySelectorAll to mutate the list of matched
nodes as it sees fit.
2017-10-13 12:17:02 +02:00
Emilio Cobos Álvarez
9034e6a732
style: Add a way to skip the "invalidation on eager pseudo invalidates self" bit. 2017-10-13 12:17:02 +02:00
Emilio Cobos Álvarez
ecdb10ef5c
Be more precise in should_process_descendants. 2017-10-13 12:17:02 +02:00
Emilio Cobos Álvarez
9e61c1962b
style: Unify invalidated_child with invalidated_descendants.
I think invalidated_descendants was buggy, and this fixes it.
2017-10-13 12:17:01 +02:00
Emilio Cobos Álvarez
557353c1f6
style: Move the bounds up in InvalidationProcessor. 2017-10-13 12:17:00 +02:00
Emilio Cobos Álvarez
a5e2f2c76c
style: Isolate all the restyling related logic in the invalidator in an InvalidationProcessor trait.
Ditto, no change in behavior.
2017-10-13 12:17:00 +02:00
Emilio Cobos Álvarez
b9b3e592dd
style: Split the invalidation collection from the invalidator step.
This is the first step in reusing the invalidation machinery for other stuff,
potentially including QuerySelector / QuerySelectorAll.
2017-10-13 12:16:59 +02:00
Simon Sapin
11bd81e115 Remove usage of unstable feature box_patterns 2017-10-13 11:11:08 +02:00
Simon Sapin
e13ae77daf Remove usage of unstable feature "raw" 2017-10-13 11:11:07 +02:00
Simon Sapin
4727b92754 Remove usage of unstable feature conservative_impl_trait in layout 2017-10-13 11:11:06 +02:00
Simon Sapin
c2d660037a Add a default-except-unstable feature 2017-10-13 11:11:06 +02:00
Simon Sapin
4594b40238 Use wrappers in the nonzero crate so users don’t need unstable features 2017-10-13 11:11:05 +02:00
Simon Sapin
45fd384a91 Make use of impl trait in constellation optional 2017-10-13 11:11:03 +02:00
Simon Sapin
7ebedd02a9 Use NonZeroUsize in script_layout_interface 2017-10-13 11:11:02 +02:00
Simon Sapin
ff23a8536e Abuse Vec as an allocator in gfx 2017-10-13 11:11:00 +02:00
Simon Sapin
d6d772eba0 Make use of unstable alloc_jemalloc crate optional 2017-10-13 11:11:00 +02:00
Simon Sapin
d9a311963f Make usage of simd in gfx optional 2017-10-13 11:10:58 +02:00
Simon Sapin
5e72173e8c Use NonZeroU32 in canvas_traits 2017-10-13 11:10:57 +02:00
Simon Sapin
ecf3b05153 Use NonZeroUsize in remutex 2017-10-13 11:10:55 +02:00
Simon Sapin
8cdf2ad0ed Add NonZeroUsize 2017-10-13 11:10:55 +02:00
Simon Sapin
57709dc0bf Use the new nonzero crate in the msg crate 2017-10-13 11:10:16 +02:00
Simon Sapin
c4bf3ec14f Add a nonzero crate 2017-10-13 11:10:11 +02:00
bors-servo
ec00c660f0 Auto merge of #18861 - upsuper:diagnose-fix, r=Manishearth
Some fixes to diagnostic hashmap

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18861)
<!-- Reviewable:end -->
2017-10-13 02:11:55 -05:00
Xidorn Quan
cb2772b46c Correct the position and record count of broken canary 2017-10-13 15:39:07 +11:00
Josh Matthews
e5f503a166 Remove call to missing method 2017-10-13 00:35:03 -04:00
Xidorn Quan
b547e96b44 Write poison to canary when removing item from diagnostic hashmap 2017-10-13 15:19:55 +11:00
bors-servo
1d0df04695 Auto merge of #18859 - glennw:update-wr-3d-gamma, r=KiChjang
Update WR (mac gamma + alpha fix, 3d transform bug fixes).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18859)
<!-- Reviewable:end -->
2017-10-12 23:07:40 -05:00
bors-servo
1099bc8b92 Auto merge of #18858 - upsuper:cycle-removal, r=SimonSapin
Rewrite cycle removal algorithm of custom properties and integrate it with substitution

This fixes [bug 1403839](https://bugzilla.mozilla.org/show_bug.cgi?id=1403839).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18858)
<!-- Reviewable:end -->
2017-10-12 20:30:28 -05:00
Glenn Watson
b375ec89d1 Update WR (mac gamma + alpha fix, 3d transform bug fixes). 2017-10-13 11:07:26 +10:00
Xidorn Quan
1251537459 Rewrite cycle removal algorithm of custom properties and integrate it with substitution 2017-10-13 10:55:24 +11:00
bors-servo
428ef1111f Auto merge of #18840 - glennw:update-wr, r=jdm
Update WR (fontconfig options, DL optimizations, isolate fixes).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18840)
<!-- Reviewable:end -->
2017-10-12 17:57:43 -05:00
bors-servo
cac88e0e0a Auto merge of #18856 - glennw:fast-test, r=jdm
Reduce the blur and spread radius size of a reftest.

In the near future, we'll be changing the blur algorithm in WR.

On native GPUs, this is fine - but on OSMesa, a blur of this
radius and spread is quite slow, and can cause test timeouts
when running with a lot of processes enabled.

Reducing the spread / blur shouldn't affect what this is testing.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18856)
<!-- Reviewable:end -->
2017-10-12 16:45:53 -05:00
Glenn Watson
7e36704f48 Reduce the blur and spread radius size of a reftest.
In the near future, we'll be changing the blur algorithm in WR.

On native GPUs, this is fine - but on OSMesa, a blur of this
radius and spread is quite slow, and can cause test timeouts
when running with a lot of processes enabled.

Reducing the spread / blur shouldn't affect what this is testing.
2017-10-13 07:30:54 +10:00
Glenn Watson
f54acc4bbe Update WR (fontconfig options, DL optimizations, isolate fixes). 2017-10-13 06:34:18 +10:00
bors-servo
8830f62a10 Auto merge of #18853 - asajeffrey:constellation-chaos-monkey-dont-kill-pending-pipelines, r=jdm
Random pipeline closure is less likely to kill pending pipelines.

<!-- Please describe your changes on the following line: -->

Make it less likely for pending pipelines to be randomly killed. Pending pipelines send more messages to the constellation, so at the moment we're skewing to killing pipelines early in their lifetimes.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #18852
- [X] These changes do not require tests because it's fixing test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18853)
<!-- Reviewable:end -->
2017-10-12 13:07:19 -05:00
bors-servo
8171a5f7fe Auto merge of #18851 - jdm:updatewpt4, r=jdm
Update WPT

This syncs us with 524bea1dd8d0ad58733072bd4e8b8044042f589e from web-platform-tests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18851)
<!-- Reviewable:end -->
2017-10-12 12:08:04 -05:00
Alan Jeffrey
70ce4689e0 Random pipeline closure is less likely to kill pending pipelines. 2017-10-12 11:50:48 -05:00
Pyfisch
6f62723898 Fix several bugs related to scrolling
* scrollLeft/scrollTop returned values of parent or even document root
   Only the scroll of the node itself is returned. Otherwise 0.0.
* Scrolling via script had set viewport.
   This resulted in other nodes appearing scrolled.
   Now scroll_offsets are updated with correct node id.

These bugs caused other odd behavior like both body and
document.documentElement being scrolled or the view for scrolled
elements jumping.
2017-10-12 12:36:32 -04:00
Jonathan Chan
b6667181ee Correctly test CSSStyleRule.style.
Remove the assert_readonly test and add one to verify that assigning to
CSSStyleRule.style correctly forwards to CSSStyleRule.style.cssText.

We currently test for whether CSSStyleRule.style is read-only by
trying to assign to it; however, the spec has it as actually:

interface CSSStyleRule : CSSRule {
  ...
  [SameObject, PutForwards=cssText] readonly attribute CSSStyleDeclaration style;
};

See: https://drafts.csswg.org/cssom/

The `PutForwards=cssText` means that assigning to CSSStyleRule.style
should actually assign to style.cssText.
2017-10-12 12:36:30 -04:00
Josh Matthews
1f531f66ea Update web-platform-tests to revision 8a2ceb5f18911302b7a5c1cd2791f4ab50ad4326 2017-10-12 12:36:21 -04:00
Simon Sapin
faff7806b9 Remove default features in components/servo
They are covered by ports/servo’s defaults.
2017-10-12 17:19:04 +02:00
Simon Sapin
132b540518 Add an 'unstable' top-level cargo feature to control optional unstable stuff. 2017-10-12 17:19:03 +02:00