We are calling `get` when we should call `borrow` or `borrow_mut`. This is causing bugs with iframes because we append the child frame to a copy of the parent's `children` vector rather than the original.
r? @larsbergstrom
We are calling `get` when we should call `borrow` or `borrow_mut`. This is
causing bugs with iframes because we append to a copy of the `children` vector
rather than the original.
There is no good reason to have both unwrap_object and unwrap_jsmanaged.
Removing unwrap_object simplifies the codegen and makes further
simplifications easier.
There is no good reason to have both unwrap_object and unwrap_jsmanaged.
Removing unwrap_object simplifies the codegen and makes further
simplifications easier.
This is a partial fix for #1959. This commit only addresses inline `<style>` elements. Next I will need to move `<link rel="stylesheet">` handling into shared code, but I wanted to get some early feedback on this piece first.
Instead, use shared code to parse stylesheet content when it is inserted,
whether during parsing or dynamically by script.
Based on work by sanools in #1350.
See #2090
One reftest compares a green image to a white div. The other has green text being compared with normal text.
If necessary, I can add some absolute positioning ones.
This improves the code written for #1822 to use a single linear traversal.
The current code uses a binary search with `CompareDocumentPosition()` for comparing element position, however this method internally calls `traverse_preorder()` (i.e. a linear traversal) so calling this on every pass is quite inefficient.
After clicking a link to load a new page, the new page content is never painted. This is because the compositor is still sending render messages to old frame tree's pipeline, not the new one.
This patch fixes this by ensuring that the compositor's new root layer is attached to the correct pipeline. (Note: You will also need to apply #2080 if you want to test this without crashing.)
This fixes a potential pixmap leak and task failure when the LayerBuffer is dropped (#1187).
I wasn't able to reproduce the failure using the steps from #1187, but based on the stack trace I think this is the correct fix. Alternately, would it make sense to `impl Drop for LayerBuffer`?
