Commit graph

30347 commits

Author SHA1 Message Date
bors-servo
bf29f64bf6 Auto merge of #19237 - upsuper:error-nested-rule, r=emilio
Use InvalidRule for nested rule list

This fixes [bug 1417548](https://bugzilla.mozilla.org/show_bug.cgi?id=1417548).

Apparently it makes no sense to have different error between top level rules and nested rules.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19237)
<!-- Reviewable:end -->
2017-11-16 03:03:48 -06:00
bors-servo
ee0294380b Auto merge of #19233 - asajeffrey:test-perf-csv, r=jdm
Save test-perf data in csv

<!-- Please describe your changes on the following line: -->

Most data analytics and visualization tools (e.g. Google Data Studio and Amazon Quick Sight) seem to want .csv input, not .json. This PR makes .csv the default data format.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19233)
<!-- Reviewable:end -->
2017-11-16 00:55:30 -06:00
bors-servo
62aa91e0dc Auto merge of #19232 - jdm:updatewpt8, r=jdm
Update web-platform-tests.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19232)
<!-- Reviewable:end -->
2017-11-15 23:53:19 -06:00
bors-servo
6938b4f3eb Auto merge of #19230 - emilio:lru-cache, r=nox
style: Move lru_cache to its own crate.

One less crate pointlessly in components/.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19230)
<!-- Reviewable:end -->
2017-11-15 22:40:06 -06:00
bors-servo
9ec17ca347 Auto merge of #19229 - servo:bumps, r=emilio
Bump image and offscreen_gl_context

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19229)
<!-- Reviewable:end -->
2017-11-15 20:58:46 -06:00
bors-servo
8c332f5dd3 Auto merge of #19220 - CYBAI:font-variant-east-asian-out-of-mako, r=emilio
style: Move font-variant-east-asian outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19216
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19220)
<!-- Reviewable:end -->
2017-11-15 20:00:48 -06:00
bors-servo
e6b05fa204 Auto merge of #19206 - asajeffrey:test-perf-add-differ-summary, r=aneeshusa
Add total time to test_differ in etc/ci/performance

<!-- Please describe your changes on the following line: -->

Add the total time to test_differ in etc/ci/performance.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19206)
<!-- Reviewable:end -->
2017-11-15 18:34:12 -06:00
bors-servo
2977a4e26e Auto merge of #18710 - mhaessig:remove-rustc-serialize, r=jdm
Replace rustc_serialize with serde_json in style_tests

#12410 Stop using rustc_serialize

Replaced rustc_serialize with serde_json in
- [ ] ~~components/config/Cargo.toml~~
- [ ] ~~components/config/lib.rs~~
- [ ] ~~components/config/prefs.rs~~
- [ ] ~~components/script_traits/Cargo.toml~~
- [ ] ~~components/script_traits/lib.rs~~
- [ ] ~~components/script_traits/webdriver_msg.rs~~
- [ ] ~~components/webdriver_server/Cargo.toml~~
- [ ] ~~components/webdriver_server/lib.rs~~
- [X] tests/unit/style/Cargo.toml
- [X] test/unit/style/lib.rs
- [X] test/unit/style/properties/scaffolding.rs

PR checks:
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [X] These changes fix (partially) #12410.
- [X] These changes do not require tests because functionality was not changed or a test itself was edited

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18710)
<!-- Reviewable:end -->
2017-11-15 17:09:21 -06:00
bors-servo
c9884604e9 Auto merge of #18882 - KiChjang:fix-origin, r=jdm
Use the correct origin in fetch

Fixes #18147.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/18882)
<!-- Reviewable:end -->
2017-11-15 16:08:49 -06:00
Xidorn Quan
faa6898237 Use InvalidRule for nested rule list. 2017-11-15 13:23:52 -08:00
Keith Yeung
1c8d04973e Use the correct URL when checking for bad port 2017-11-15 13:17:17 -08:00
Keith Yeung
d5e7137b52 Use the correct origin in fetch 2017-11-15 13:17:16 -08:00
Josh Matthews
0c83d95d5a Update test expectations. 2017-11-15 15:01:53 -05:00
Josh Matthews
35db26d1a9 Fix WPT lint errors. 2017-11-15 13:50:39 -05:00
bors-servo
8724bc0c73 Auto merge of #19205 - asajeffrey:test-perf-add-error-message, r=edunham
Add 'Error loading page' case for validating correctness of test-perf data

<!-- Please describe your changes on the following line: -->

Add case for `Error loading page` title to test-perf runner.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19205)
<!-- Reviewable:end -->
2017-11-15 12:34:13 -06:00
Alan Jeffrey
45d5d53e55 Added title to example test perf document. 2017-11-15 12:24:11 -06:00
Alan Jeffrey
a1dfce4d3c Made .csv the default file format for perf tests. 2017-11-15 12:24:10 -06:00
Alan Jeffrey
d817b224f5 Support saving test data to .csv as well as .json. 2017-11-15 12:24:09 -06:00
Alan Jeffrey
201f931fa1 Add total time to test_differ in etc/ci/performance. 2017-11-15 11:54:45 -06:00
Josh Matthews
c227604a2c Update web-platform-tests to revision 44702f2bc8ea98bc32b5b244f2fe63c6ce66d49d 2017-11-15 12:47:30 -05:00
Alan Jeffrey
b845d44aa2 Add 'Error loading page' case for validating correctness of test-perf data. 2017-11-15 11:42:21 -06:00
bors-servo
9863d51451 Auto merge of #19227 - servo:array-warn, r=emilio
Work around "this expression will panic at run-time" warnings

CC https://github.com/rust-lang/rust/issues/45850

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19227)
<!-- Reviewable:end -->
2017-11-15 11:00:29 -06:00
bors-servo
85fa6409bb Auto merge of #19226 - emilio:inline-qs, r=nox
style: Sprinkle some inline in trivial methods.

These methods are instantiated by the Gecko library, and used during
querySelector, which means that they end up being super-hot in micro-benchmarks.

MozReview-Commit-ID: K1XJb0QyX5a

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19226)
<!-- Reviewable:end -->
2017-11-15 09:22:14 -06:00
Emilio Cobos Álvarez
47b02658ec
style: Move lru_cache to its own crate.
One less crate pointlessly in components/.
2017-11-15 16:18:11 +01:00
Anthony Ramine
60bde30563 Bump image and offscreen_gl_context 2017-11-15 15:47:15 +01:00
bors-servo
40adc3fd88 Auto merge of #19199 - emilio:no-unused-unsafe, r=nox
style: Stop allowing unused_unsafe.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19199)
<!-- Reviewable:end -->
2017-11-15 08:22:00 -06:00
Simon Sapin
aca0015930 Work around "this expression will panic at run-time" warnings
CC https://github.com/rust-lang/rust/issues/45850
2017-11-15 14:31:39 +01:00
CYBAI
c110c8a131 style: Move font-variant-east-asian outside of mako 2017-11-15 21:27:12 +08:00
bors-servo
d117694ecc Auto merge of #19164 - emilio:more-traversal-cleanup, r=nox
style: More traversal cleanup.

This is cleanup that allows me to fix https://bugzilla.mozilla.org/show_bug.cgi?id=1415013 in a more straight-forward way.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19164)
<!-- Reviewable:end -->
2017-11-15 06:51:27 -06:00
Emilio Cobos Álvarez
28c04278e1
style: Sprinkle some inline in trivial methods.
These methods are instantiated by the Gecko library, and used during
querySelector, which means that they end up being super-hot in micro-benchmarks.

MozReview-Commit-ID: K1XJb0QyX5a
2017-11-15 13:45:32 +01:00
Emilio Cobos Álvarez
f0d749a544
style: Stop allowing unused_unsafe. 2017-11-15 13:26:26 +01:00
Emilio Cobos Álvarez
fd68091491
style: Update bindings. 2017-11-15 13:26:25 +01:00
Emilio Cobos Álvarez
69ddb9501b
style: Remove some uses of unused unsafe. 2017-11-15 13:26:24 +01:00
bors-servo
b2c19b1544 Auto merge of #19222 - upsuper:serialize-group-rule, r=emilio
Serialize media rule and supports rule like Gecko

This should fix [bug 1417207](https://bugzilla.mozilla.org/show_bug.cgi?id=1417207).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19222)
<!-- Reviewable:end -->
2017-11-15 05:40:24 -06:00
bors-servo
2efbf2230a Auto merge of #19202 - jonleighton:issue-19171, r=KiChjang
Fire 'select' event in SetSelection{Start,End}

See #19171.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19202)
<!-- Reviewable:end -->
2017-11-15 04:08:24 -06:00
Jon Leighton
93b047a91b Fire 'select' event in SetSelection{Start,End}
Issue #19171
2017-11-15 10:54:24 +01:00
Xidorn Quan
ae3989ebf0 Serialize media rule and supports rule like Gecko. 2017-11-14 13:42:06 -08:00
bors-servo
6f1d9a198f Auto merge of #19211 - KiChjang:text-decoration-line, r=emilio
Move text-decoration-line out of mako

Part of #19015.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19211)
<!-- Reviewable:end -->
2017-11-14 15:34:10 -06:00
Keith Yeung
6f59a45cdc Move text-decoration-line out of mako 2017-11-14 13:13:23 -08:00
bors-servo
d7b4471c80 Auto merge of #19152 - nox:media, r=jdm
Include gecko-media in the dependency graph

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19152)
<!-- Reviewable:end -->
2017-11-14 11:51:34 -06:00
Anthony Ramine
23d7783e02 Make script depend on gecko-media
It's not used yet though.
2017-11-14 17:33:25 +01:00
bors-servo
7d13e5b83c Auto merge of #19218 - avadacatavra:nav-start, r=jdm
added navigation start for interactive metrics

<!-- Please describe your changes on the following line: -->
 follow up from  #18670, fixing #19099

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19099 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19218)
<!-- Reviewable:end -->
2017-11-14 09:53:30 -06:00
ddh
2ef28d05b5 added navigation start for interactive metrics 2017-11-14 15:21:35 +00:00
bors-servo
c18417db5e Auto merge of #19214 - CYBAI:font-variation-settings-out-of-mako, r=emilio
style: Move font-variation-settings outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19208
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19214)
<!-- Reviewable:end -->
2017-11-14 08:29:58 -06:00
bors-servo
d287ec8d3e Auto merge of #19217 - emilio:bye-mozmm, r=heycam
style: Remove mozmm CSS unit.

Bug: 1416564
Reviewed-by: heycam
MozReview-Commit-ID: AU4CUq09tw4
2017-11-14 07:27:28 -06:00
Emilio Cobos Álvarez
eac0d104a3
style: Remove mozmm CSS unit.
Bug: 1416564
Reviewed-by: heycam
MozReview-Commit-ID: AU4CUq09tw4
2017-11-14 14:25:40 +01:00
CYBAI
c561c2cb9b style: Move font-variation-settings outside of mako 2017-11-14 19:56:27 +08:00
bors-servo
856dc3c90a Auto merge of #19213 - servo:nightly, r=nox
Stop using "alternate" rustc builds

With https://github.com/rust-lang/rust/pull/45810, normal Nightly now has LLVM assertions disabled.

This allows us to entirely stop relying on private/unstable Rust CI artifacts being and remaining available: https://internals.rust-lang.org/t/public-stable-rust-services/6072

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19213)
<!-- Reviewable:end -->
2017-11-14 02:18:20 -06:00
Simon Sapin
3264453284 Stop using "alternate" rustc builds.
With https://github.com/rust-lang/rust/pull/45810,
normal Nightly now has LLVM assertions disabled.
2017-11-14 09:08:11 +01:00
Simon Sapin
250e1b8c3b Upgrade to rustc 1.23.0-nightly (e21df8020 2017-11-13) 2017-11-14 08:57:16 +01:00