bors-servo
8fdcfb2dfe
Auto merge of #20080 - ferjm:innertext.cleanup, r=emilio
...
Minor cleanup of element.innerText
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20080 )
<!-- Reviewable:end -->
2018-02-20 08:43:48 -05:00
Emilio Cobos Álvarez
1359c7c218
style: Don't try to serialize the same shorthand over and over.
...
I looked at what were we doing in that loop, and we're doing tons of dumb stuff.
In particular, we try to serialize the "all" shorthand all the time. This patch
prevents us from trying to serialize shorthands that we've already tried to
serialize.
2018-02-20 14:21:35 +01:00
Emilio Cobos Álvarez
c09257b540
style: There's no need to check the serialized custom properties.
...
Given they're not duplicated, and can't be part of a shorthand.
2018-02-20 14:21:34 +01:00
Emilio Cobos Álvarez
4c979a8346
style: Remove a unit test that relies on disabled-by-default properties.
2018-02-20 14:21:34 +01:00
Fernando Jiménez Moreno
ff81707928
Minor cleanup of element.innerText
2018-02-20 13:50:53 +01:00
Emilio Cobos Álvarez
94b687306f
style: Cleanup always-false argument to Servo_ResolveStyleLazily.
...
I changed this setup in https://bugzilla.mozilla.org/show_bug.cgi?id=1414999 ,
because it was totally unsound.
2018-02-20 12:59:21 +01:00
bors-servo
4d7383f4f3
Auto merge of #20078 - emilio:decl-block-serialization, r=nox
...
style: Rejigger serialization of a declaration block to not look at the shorthands length.
This is because I'm going to make shorthands() and longhands() return an
iterator, so that we account for prefs properly
(https://bugzilla.mozilla.org/show_bug.cgi?id=1438234 ).
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20078 )
<!-- Reviewable:end -->
2018-02-20 06:40:43 -05:00
Emilio Cobos Álvarez
e46f910b66
style: Rejigger serialization of a declaration block to not look at the shorthands length.
...
This is because I'm going to make shorthands() and longhands() return an
iterator, so that we account for prefs properly
(https://bugzilla.mozilla.org/show_bug.cgi?id=1438234 ).
2018-02-20 10:05:58 +01:00
Emilio Cobos Álvarez
c676b52448
style: Sprinkle some #[inline] on trivial methods.
2018-02-20 10:05:12 +01:00
Emilio Cobos Álvarez
f896cb63a6
style: Make DeclarationBlock::get O(1) if we know the longhand isn't there.
2018-02-20 10:04:17 +01:00
bors-servo
6a7ae3b12e
Auto merge of #20077 - servo-wpt-sync:wpt_update_19-02-2018, r=jdm
...
Sync WPT with upstream (19-02-2018)
Automated downstream sync of changes from upstream as of 19-02-2018.
[no-wpt-sync]
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20077 )
<!-- Reviewable:end -->
2018-02-19 23:03:10 -05:00
WPT Sync Bot
8a6476740e
Update web-platform-tests to revision 8fed98324bc133df221d778c62cbff210d43b0ce
2018-02-19 21:42:17 -05:00
bors-servo
be902d56c0
Auto merge of #20073 - servo:keywordsize, r=emilio
...
Remove some useless manual layout optimisation for KeywordSize
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20073 )
<!-- Reviewable:end -->
2018-02-19 07:02:45 -05:00
Anthony Ramine
e976955634
Remove some useless manual layout optimisation for KeywordSize
2018-02-19 12:37:46 +01:00
bors-servo
6afdf7c1cb
Auto merge of #20072 - emilio:moz-transform, r=xidorn
...
style: Unship the legacy syntax for -moz-transform.
Intent to unship link:
https://groups.google.com/d/msg/mozilla.dev.platform/T3PGm97MPNU/59XUavMlCgAJ
Reviewed-by: xidorn
Bug: 1438297
MozReview-Commit-ID: 6ybGBasPAWU
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20072 )
<!-- Reviewable:end -->
2018-02-19 05:46:16 -05:00
Emilio Cobos Álvarez
df132b4954
style: Update bindings.
2018-02-19 11:45:47 +01:00
Emilio Cobos Álvarez
7473796aba
style: Unship the legacy syntax for -moz-transform.
...
Intent to unship link:
https://groups.google.com/d/msg/mozilla.dev.platform/T3PGm97MPNU/59XUavMlCgAJ
Reviewed-by: xidorn
Bug: 1438297
MozReview-Commit-ID: 6ybGBasPAWU
2018-02-19 10:46:14 +01:00
bors-servo
a98da8ce93
Auto merge of #20070 - upsuper:authorstyles-size, r=bholley,njn
...
Add sizeof for AuthorStyles.
This is the Servo side change for [bug 1438497](https://bugzilla.mozilla.org/show_bug.cgi?id=1438497 ).
2018-02-18 23:13:10 -05:00
Xidorn Quan
f518e55c28
Add sizeof for AuthorStyles.
2018-02-19 15:12:13 +11:00
Manish Goregaokar
c36335e031
Remove table_style; tables already get their backgrounds painted correctly
2018-02-16 16:01:54 -08:00
Manish Goregaokar
180b29ae66
Unconditionally remove repaint damage for table cells/rows/rgs
2018-02-16 16:01:53 -08:00
Manish Goregaokar
c2de3eb9ac
Check visibility beforehand
2018-02-16 16:01:52 -08:00
Manish Goregaokar
f796823b94
Handle rowspan
2018-02-16 16:01:51 -08:00
Manish Goregaokar
cfa81e8b79
Refactor column index advancing into its own method
2018-02-16 16:01:50 -08:00
Manish Goregaokar
b72a50d50a
Pass down full ComputedValues to TableCellStyleInfo; use for correct color computation
2018-02-16 16:01:49 -08:00
Manish Goregaokar
21140e7a0a
Make TableCellStyleIterator operate on immutable flows
2018-02-16 16:01:49 -08:00
Manish Goregaokar
265a2ab2cc
Allow for build_display_list to be called immutably
2018-02-16 16:01:48 -08:00
Manish Goregaokar
5cd15eeb54
Don't redraw backgrounds that we've already drawn
2018-02-16 16:01:47 -08:00
Manish Goregaokar
db6ec58e6b
Generate display lists for table cells during display list generation for their table parent
2018-02-16 16:01:46 -08:00
Manish Goregaokar
6232846699
Add stacking_relative_border_box_for_display_list
2018-02-16 16:01:46 -08:00
Manish Goregaokar
f7ac5d712f
Add build_display_list_for_background_if_applicable_with_background
2018-02-16 16:01:45 -08:00
Manish Goregaokar
f3531d1d35
Factor out BlockFlow::background_border_section()
2018-02-16 16:01:44 -08:00
Manish Goregaokar
836e59e5b6
Handle colspan in TableCellStyleIterator
2018-02-16 16:01:44 -08:00
Manish Goregaokar
6317c44ab4
Add Iterator impl for TableCellStyleIterator
2018-02-16 16:01:43 -08:00
Manish Goregaokar
1dd5bed031
Create TableCellStyleIterator
2018-02-16 16:01:42 -08:00
Manish Goregaokar
35be0c50f6
Add TableRowAndGroupIterator
2018-02-16 16:01:41 -08:00
Manish Goregaokar
b416bb3aa7
Add get_column_styles for getting column structure and styles for a table
2018-02-16 16:01:41 -08:00
bors-servo
d423e54d58
Auto merge of #20065 - emilio:note-stuff, r=nox
...
style: Cleanup GeckoElement::note_explicit_hints
What it's doing is not so complicated.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20065 )
<!-- Reviewable:end -->
2018-02-16 15:33:48 -05:00
bors-servo
d092c2e877
Auto merge of #20064 - emilio:cleanup-length-parsing, r=nox
...
style: Trivially cleanup length parsing.
Mostly formatting signatures properly, but also removing useless functions and
stuff.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20064 )
<!-- Reviewable:end -->
2018-02-16 14:43:50 -05:00
bors-servo
e97693ee09
Auto merge of #20062 - servo:iamroot, r=emilio
...
Remove a single use of rooted_vec
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20062 )
<!-- Reviewable:end -->
2018-02-16 13:09:28 -05:00
Emilio Cobos Álvarez
2c03609dc1
style: Cleanup GeckoElement::note_explicit_hints.
...
What it's doing is not so complicated.
2018-02-16 19:00:21 +01:00
Emilio Cobos Álvarez
36e6d57aee
style: Inline maybe_restyle, since it only has one caller.
2018-02-16 19:00:21 +01:00
bors-servo
4454e81878
Auto merge of #20041 - paavininanda:mutflags, r=jdm
...
Added extra bool in Window object to know about its Mutation Observers
<!-- Please describe your changes on the following line: -->
- Added Cell<bool> type variable in Window object to know whether its mutation observers are present/absent
- Added get and set functions for this variable
- Added supporting test files to check for performance
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16936 .
<!-- Either: -->
- [x] There are tests for these changes, but these are manual tests for checking correctness of added code
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20041 )
<!-- Reviewable:end -->
2018-02-16 12:16:55 -05:00
Nupur Baghel
a1fd6c39a2
Added extra bool in Window object to know about its Mutation Observers
2018-02-16 21:52:29 +05:30
bors-servo
a1c79d21c1
Auto merge of #20059 - servo-wpt-sync:wpt_update_15-02-2018, r=jdm
...
Sync WPT with upstream (15-02-2018)
Automated downstream sync of changes from upstream as of 15-02-2018.
[no-wpt-sync]
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20059 )
<!-- Reviewable:end -->
2018-02-16 10:47:22 -05:00
Emilio Cobos Álvarez
fdc8405330
style: Trivially cleanup length parsing.
...
Mostly formatting signatures properly, but also removing useless functions and
stuff.
2018-02-16 16:04:19 +01:00
bors-servo
504b901cc8
Auto merge of #20061 - emilio:author-styles, r=xidorn
...
style: Make XBL / Shadow DOM use something more light-weight than a Stylist.
Introduce AuthorStyles, which is just a struct aggregating stylesheets +
CascadeData, with a quirks_mode parameter because XBL sucks so bad.
Bug: 1436059
Reviewed-by: xidorn
MozReview-Commit-ID: 7q99tSNXo0K
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20061 )
<!-- Reviewable:end -->
2018-02-16 09:54:06 -05:00
Emilio Cobos Álvarez
a6afaf2428
style: Update bindings.
2018-02-16 15:21:08 +01:00
Anthony Ramine
b6b6b46568
Remove a single use of rooted_vec
2018-02-16 14:02:05 +01:00
Emilio Cobos Álvarez
5e64cb3516
style: Make XBL / Shadow DOM use something more light-weight than a Stylist.
...
It's just a struct aggregating stylesheets + CascadeData, with a quirks_mode
parameter because XBL sucks so bad.
Bug: 1436059
Reviewed-by: xidorn
MozReview-Commit-ID: 7q99tSNXo0K
2018-02-16 13:42:36 +01:00