Commit graph

30916 commits

Author SHA1 Message Date
bors-servo
c2cacb69f3 Auto merge of #19606 - glennw:update-wr-bs-artifacts, r=jdm
Update WR (fix incorrect rendering of small box shadows).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19606)
<!-- Reviewable:end -->
2017-12-19 15:40:26 -06:00
Glenn Watson
50c42ab488 Update WR (fix incorrect rendering of small box shadows). 2017-12-20 07:17:22 +10:00
bors-servo
873bc3a726 Auto merge of #19579 - neerjapancholi:master, r=emilio
Bug 1417725 - (Servo) Add -moz-column-span alias for column-span prop…

…erty.

<!-- Please describe your changes on the following line: -->
This is part of the patch for adding a -moz- alias for column-span. See https://bugzilla.mozilla.org/show_bug.cgi?id=1417725
Clean try run for this patch is at:
https://treeherder.mozilla.org/#/jobs?repo=try&revision=faa9c050c9adf10714953b8c5d5af67683992437&selectedJob=151353901

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19579)
<!-- Reviewable:end -->
2017-12-19 14:13:32 -06:00
Emilio Cobos Álvarez
a931789f37
style: Update bindings. 2017-12-19 20:47:16 +01:00
neerpancholi
9bea4baf6f
Bug 1417725 - (Servo) Add -moz-column-span alias for column-span property. 2017-12-19 10:33:46 +01:00
bors-servo
861ceb10ea Auto merge of #19604 - Manishearth:animate-second, r=emilio
stylo: Correctly handle interpolation where optional second argument for translate(), skew(), scale() exists in one but not the other

r=emilio https://bugzilla.mozilla.org/show_bug.cgi?id=1424798
2017-12-18 20:46:31 -06:00
Manish Goregaokar
82e024913b stylo: Correctly handle interpolation where optional second argument for translate(), skew(), scale() exists in one but not the other
MozReview-Commit-ID: 59rNRAXBEN9
2017-12-18 18:45:25 -08:00
bors-servo
d6797db100 Auto merge of #19601 - emilio:adjust-visited, r=upsuper
style: Don't adjust :visited styles.

As the comment says those are not interesting, and it matches what we do for
text and placeholders in Servo_ComputedValues_Inherit.

This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1425893

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19601)
<!-- Reviewable:end -->
2017-12-18 18:00:27 -06:00
bors-servo
89f9af88a3 Auto merge of #19528 - asajeffrey:test-perf-measure-loadEventEnd, r=avadacatavra
Capture loadEventEnd in test-perf

<!-- Please describe your changes on the following line: -->

Capture perf-test data after the load event has finished firing.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because this is test infrastructure

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19528)
<!-- Reviewable:end -->
2017-12-18 16:54:07 -06:00
Emilio Cobos Álvarez
f6d0a14246
style: Don't adjust :visited styles.
As the comment says those are not interesting, and it matches what we do for
text and placeholders in Servo_ComputedValues_Inherit.

This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1425893
2017-12-18 22:48:02 +01:00
bors-servo
7fb6b9fcae Auto merge of #19600 - glennw:update-wr-border-sticky, r=jdm
Update WR (sticky frame fixes, handling overlapping border corners).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19600)
<!-- Reviewable:end -->
2017-12-18 15:38:13 -06:00
Glenn Watson
66ac6e99ef Update WR (sticky frame fixes, handling overlapping border corners). 2017-12-19 06:00:59 +10:00
bors-servo
57277acd27 Auto merge of #19574 - asajeffrey:rustdown-2017-11-14, r=glennw
Downgrade to rustc nightly-2017-11-14

<!-- Please describe your changes on the following line: -->

This is causing nightly servo to crash with hardware acceleration.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes work around #19519
- [X] These changes do not require tests because testing requires AWS instances with GPUs.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19574)
<!-- Reviewable:end -->
2017-12-18 13:59:23 -06:00
bors-servo
a9c17970c1 Auto merge of #19576 - canaltinova:text-align, r=Manishearth,emilio
style: Move text-align outside of the mako file.

I will need this refactoring before my next job. I didn't actually fix the FIXME's along the way. My other PR probably will cover these.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19576)
<!-- Reviewable:end -->
2017-12-18 12:12:52 -06:00
Nazım Can Altınova
9882d0bae5 style: Move text-align outside of the mako file. 2017-12-18 11:58:06 -06:00
bors-servo
92a2c37e65 Auto merge of #19545 - marmistrz:bump-gecko-media, r=jdm
Fix and document build on CentOS 7.4

Fix and document build on CentOS 7.4

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable). **N/A**

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because no code is changed

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19545)
<!-- Reviewable:end -->
2017-12-18 11:19:40 -06:00
bors-servo
37fe9f2957 Auto merge of #19599 - jdm:revertcanvas, r=asajeffrey
Revert canvas IPC changes

https://github.com/servo/servo/pull/19547 is responsible for the surge of new intermittent timeouts in canvas-related tests. There's nothing wrong with the change, so I suspect an underlying problem in ipc-channel instead.

Fixes #19592. #19593. Fixes #19594. Fixes #19597.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19599)
<!-- Reviewable:end -->
2017-12-18 10:19:30 -06:00
Josh Matthews
0e211d0d8f Revert "Send IPC receiver for canvas as part of CreateCanvasPaintThread message"
This reverts commit a504c9358b.
2017-12-18 10:51:00 -05:00
Marcin Mielniczuk
3ff48226e9
Merge branch 'master' into bump-gecko-media 2017-12-18 15:30:30 +01:00
Marcin Mielniczuk
b35c6bc14e
Merge branch 'master' into bump-gecko-media 2017-12-18 15:29:20 +01:00
bors-servo
fab8042fa7 Auto merge of #19595 - emilio:broken-code-all-around, r=emilio
style: Add a FIXME comment that I need to write a test-case for.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19595)
<!-- Reviewable:end -->
2017-12-18 07:24:13 -06:00
Emilio Cobos Álvarez
0e781384cd
style: Add a FIXME comment that I need to write a test-case for. 2017-12-18 14:19:17 +01:00
bors-servo
3a37d80931 Auto merge of #19590 - servo:patch, r=SimonSapin
Use [patch] instead of [replace]

CC https://github.com/servo/webrender/pull/2215

Also, `[replace]` prevented using `[patch]` for other crates. (Cargo forbids using both.)

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19590)
<!-- Reviewable:end -->
2017-12-17 15:18:05 -06:00
Simon Sapin
9eee610c39 Use [patch] instead of [replace]
CC https://github.com/servo/webrender/pull/2215

Also, `[replace]` prevented using `[patch]` for other crates.
(Cargo forbids using both.)
2017-12-17 22:09:45 +01:00
bors-servo
f175649263 Auto merge of #19589 - tigercosmos:e1, r=emilio
remove unused `Auto` in test of serialization

<!-- Please describe your changes on the following line: -->
```
warning: unused import: `Auto`
 --> /Users/tigercosmos/servo/tests/unit/style/properties/serialization.rs:9:40
  |
9 | use style::values::{CustomIdent, RGBA, Auto};
  |                                        ^^^^
  |
  = note: #[warn(unused_imports)] on by default
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19589)
<!-- Reviewable:end -->
2017-12-17 11:51:10 -06:00
tigercosmos
7d8be25030 remove unused Auto in test of serialization 2017-12-18 01:22:02 +08:00
bors-servo
8798e49889 Auto merge of #19559 - tigercosmos:t1, r=KiChjang
implement valid week string

<!-- Please describe your changes on the following line: -->
implement valid week string
part of #19172

r? @KiChjang

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19559)
<!-- Reviewable:end -->
2017-12-17 03:50:33 -06:00
tigercosmos
54c6028033 implement valid week string 2017-12-17 16:57:01 +08:00
bors-servo
f8c09abece Auto merge of #19585 - tigercosmos:b1, r=KiChjang
remove unused `self` in canvas_paint_thread

<!-- Please describe your changes on the following line: -->
```
Compiling canvas v0.0.1 (file:///Users/tigercosmos/servo/components/canvas)
warning: unused import: `self`
  --> components/canvas/canvas_paint_thread.rs:14:24
   |
14 | use ipc_channel::ipc::{self, IpcSender, IpcReceiver};
   |                        ^^^^
   |
   = note: #[warn(unused_imports)] on by default
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19585)
<!-- Reviewable:end -->
2017-12-17 02:47:09 -06:00
tigercosmos
9978f04563 remove unused self in canvas_paint_thread 2017-12-17 12:36:22 +08:00
bors-servo
8aba41d951 Auto merge of #19583 - CYBAI:move-will-change-out-of-mako, r=emilio
style: Move will-change outside of mako

This is a sub-PR of #19015
r? emilio

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #19582
- [x] These changes do not require tests

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19583)
<!-- Reviewable:end -->
2017-12-16 16:39:37 -06:00
Nazım Can Altınova
3ad2687c0b style_derive: Make parse derive work with C like enums. 2017-12-16 15:47:50 -06:00
bors-servo
1501a41704 Auto merge of #19584 - emilio:remove-grid-pref, r=mats
style: Remove the grid pref.

Bug: 1398492
Reviewed-by: mats
MozReview-Commit-ID: 6Qez8NE8oze

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19584)
<!-- Reviewable:end -->
2017-12-16 15:44:21 -06:00
Emilio Cobos Álvarez
af3a50a9d9
style: Remove the grid pref.
Bug: 1398492
Reviewed-by: mats
MozReview-Commit-ID: 6Qez8NE8oze
2017-12-16 22:10:22 +01:00
CYBAI
2eb396613b
style: Move will-change outside of mako 2017-12-16 21:47:59 +01:00
Emilio Cobos Álvarez
09a3db8657
style_derive: Allow css(iterable) to work on non-functions too, as long as there's only one binding. 2017-12-16 21:47:58 +01:00
bors-servo
c9e3fabdfd Auto merge of #19547 - tigercosmos:b1, r=jdm
Send IPC receiver for canvas as part of CreateCanvasPaintThread message

<!-- Please describe your changes on the following line: -->
I am not sure if @jdm want this.
r? @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #19483(github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19547)
<!-- Reviewable:end -->
2017-12-16 11:35:40 -06:00
bors-servo
a31fd24ce9 Auto merge of #19581 - emilio:grid-line-serialize, r=canaltinova
style: Fix grid line serialization to avoid redundant spacing.

This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1425227.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19581)
<!-- Reviewable:end -->
2017-12-16 09:13:48 -06:00
tigercosmos
a504c9358b Send IPC receiver for canvas as part of CreateCanvasPaintThread message 2017-12-16 12:04:59 +08:00
Emilio Cobos Álvarez
de4dd638eb
style: Fix grid line serialization to avoid redundant spacing.
This fixes https://bugzilla.mozilla.org/show_bug.cgi?id=1425227.
2017-12-16 01:26:18 +01:00
bors-servo
f7440bf1a6 Auto merge of #19580 - birtles:update-web-animations-link, r=hiro
Update references to Web Animations spec

This has been reviewed in [Gecko bug 1425548](https://bugzilla.mozilla.org/show_bug.cgi?id=1425548).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19580)
<!-- Reviewable:end -->
2017-12-15 17:39:55 -06:00
Alan Jeffrey
2f9fe8ca22 Add a smoketest to the mac-rel-wpt1 builder. 2017-12-15 16:45:35 -06:00
Brian Birtles
150db42ef6 Update references to Web Animations spec 2017-12-15 16:21:26 -06:00
bors-servo
dbfcb7bc39 Auto merge of #19568 - pyfisch:background-origin-gradients1, r=mbrubeck
layout: background-origin attribute for gradients

Fixes the glitches mentioned in #19554.
Now gradient tiles are placed in the whole bounding box.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19568)
<!-- Reviewable:end -->
2017-12-15 15:54:59 -06:00
Pyfisch
b0492f53af layout: background-origin attribute for gradients
Fixes the glitches mentioned in #19554.
Now gradient tiles are placed in the whole bounding box.
2017-12-15 22:16:58 +01:00
bors-servo
e631d167bf Auto merge of #19578 - emilio:parse-keyword, r=Manishearth,canaltinova
Allow deriving Parse on keywords.

This makes patches like #19576 much easier.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19578)
<!-- Reviewable:end -->
2017-12-15 14:55:49 -06:00
Emilio Cobos Álvarez
5b8f65190a
style: Handle servo-prefixed stuff correctly. 2017-12-15 21:43:29 +01:00
Emilio Cobos Álvarez
8fbdbc8f95
style: Use derive(Parse) for X and Y. 2017-12-15 20:15:32 +01:00
Emilio Cobos Álvarez
4abd1dc819
style: Use derive(Parse) for RepeatKeyword. 2017-12-15 20:15:31 +01:00
Emilio Cobos Álvarez
7036cb0077
Allow deriving Parse for keywords. 2017-12-15 20:01:31 +01:00