Commit graph

40211 commits

Author SHA1 Message Date
wpt-pr-bot
c48934a24f macos: wpt: install pip & virtualenv for Python3 2020-01-25 21:07:58 +00:00
marmeladema
43768ff974 Replace utf8 encoded apostrophe by a regular ascii single quote 2020-01-24 13:53:54 +00:00
marmeladema
19cc74f07d Run first test-wpt chunk with python3 in CI 2020-01-24 13:53:54 +00:00
marmeladema
baec4935f6 Update python requirements to run test-wpt with python3 2020-01-24 13:53:54 +00:00
bors-servo
be409233fd
Auto merge of #25574 - mrobinson:use-euclid-for-physical-structs, r=SimonSapin
Use Euclid data types for physical structs in layout_2020

This removes a bit of duplication and allows layout_2020 to benefit from a
much richer set of utilities.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because they should not change behavior.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-01-24 06:54:34 -05:00
bors-servo
592649ba50
Auto merge of #25583 - servo-wpt-sync:wpt_update_23-01-2020, r=servo-wpt-sync
Sync WPT with upstream (23-01-2020)

Automated downstream sync of changes from upstream as of 23-01-2020.
[no-wpt-sync]
r? @servo-wpt-sync
2020-01-24 05:45:25 -05:00
bors-servo
8b9018cd3e
Auto merge of #25578 - pshaughn:custompicture, r=jdm
Let custom element registry know about picture tag

<!-- Please describe your changes on the following line: -->
This replaces one WPT failure with another, but the previous one failure was preventing multiple cases from running, and now only one of those cases fails (due to #24993).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25577

<!-- Either: -->
- [X] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-01-24 03:57:47 -05:00
bors-servo
425328a64f
Auto merge of #25586 - servo:jdm-patch-35, r=Manishearth
Update windows llvm to 8.0.1.

This makes it possible to build mozjs with llvm's clang-cl and MSVC 2019's header files; otherwise the headers check the clang version and abort compilation because it's 8.0 is too old.
2020-01-24 02:24:43 -05:00
bors-servo
ae1758fec9
Auto merge of #25490 - teapotd:radio-group-iter, r=Manishearth
Simplify and fix iteration over radio button group

- Code for iterating over radio button group elements has been extracted to `radio_group_iter`
- `in_same_group` now checks if elements are in the same tree
- `radio_group_name` returns `None` if name is empty
- Radio buttons now group together in orphan trees (#25486)

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25486
- [ ] There are tests for these changes
2020-01-23 16:56:57 -05:00
bors-servo
d0d3aaa449
Auto merge of #25450 - pshaughn:putforwards, r=jdm,Manishearth
Add PutForwards to implemented attributes that lacked it

Added PutForwards to three relLists and one style. The style already had a test; I added tests for relLists, including one relList that we have commented out right now.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes advance #9990 to be caught up with the attributes we have so far; many unimplemented attributes will need PutForwards when implemented.

<!-- Either: -->
- [X] There are tests for these changes OR

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-01-23 12:12:06 -05:00
Martin Robinson
02deb99a05 Use euclid data types for physical structs in layout_2020
This removes a bit of duplication and allows layout_2020 to benefit from
a much richer set of utilities.
2020-01-23 15:39:32 +01:00
Patrick Shaughnessy
8a4df2ae2a PutForwards cleanup 2020-01-23 08:51:34 -05:00
Josh Matthews
f4c1837eaa
Update windows llvm to 8.0.1. 2020-01-23 13:44:07 +00:00
Patrick Shaughnessy
eb246371f1 Let custom element registry know about picture tag 2020-01-23 08:41:46 -05:00
bors-servo
2b77a992db
Auto merge of #25580 - szeged:wgpu_worker, r=jdm
Support worker for WebGPU

To create resource ids for the WebGPU we need to access the `IdentityHub`.
In order to access the `IdentityHub` from a `Window` or a `Worker` as well, I've moved the `IdentityHub` to the `GlobalScope` from the `Navigator`.

<!-- Please describe your changes on the following line: -->
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25532

cc @kvark @jdm @zakorgy
2020-01-23 07:53:58 -05:00
WPT Sync Bot
36e52003a7 Update web-platform-tests to revision 7ec633bbfbc01de4972e65f81f593983d9cdc17d 2020-01-23 10:58:08 +00:00
Istvan Miklos
dbed5f1364 Support worker for WebGPU
To create resource ids for the WebGPU we need to access the `IdentityHub`.
In order to access the `IdentityHub` from a `Window` or a `Worker` as well, I've moved the `IdentityHub` to the `GlobalScope` from the `Navigator`.
2020-01-23 10:51:21 +01:00
bors-servo
24674687ac
Auto merge of #25573 - servo-wpt-sync:wpt_update_22-01-2020, r=jdm
Sync WPT with upstream (22-01-2020)

Automated downstream sync of changes from upstream as of 22-01-2020.
[no-wpt-sync]
r? @servo-wpt-sync
2020-01-22 09:57:43 -05:00
Josh Matthews
c4a68ec65c
Remove intermittent failure. 2020-01-22 12:55:48 +00:00
WPT Sync Bot
e33f4d3e48 Update web-platform-tests to revision cbbb68edacd8d7dfb23b74f50537b72e06870511 2020-01-22 11:03:14 +00:00
bors-servo
ee3fb92e53
Auto merge of #25504 - Manishearth:features, r=asajeffrey
Support features in webxr

Based on https://github.com/servo/webxr/pull/119

Todo:
 - [x] gate reference space creation on feature presence
 - [x] Fix the `features_deviceSupport` test to correctly use simulateUserActivation

Fixes #24196, #24270
r? @jdm @asajeffrey
2020-01-21 23:19:40 -05:00
Manish Goregaokar
9a04a37c1c Gate reference space creation on requested features 2020-01-21 20:19:22 -08:00
Manish Goregaokar
8cc7c51803 Update xrSession_features_deviceSupport to use new user activations for each session request 2020-01-21 20:19:22 -08:00
Manish Goregaokar
535e05f7b2 Correctly unset pending flag 2020-01-21 15:47:30 -08:00
Manish Goregaokar
d33d21ce72 Add support for requesting features 2020-01-21 15:47:30 -08:00
Manish Goregaokar
e0135fe783 Support profiles 2020-01-21 15:47:30 -08:00
Manish Goregaokar
9c34a6585b Handle SetTargetRayMode and SetHandedness 2020-01-21 15:47:30 -08:00
Manish Goregaokar
e9221e6ce0 Update webxr 2020-01-21 15:47:30 -08:00
bors-servo
35eb6dd074
Auto merge of #25560 - mrobinson:scrollable-overflow-v1, r=SimonSapin
Add initial scrolling support to layout_2020

This adds very early scrolling support to layout_2020. Only the root element scrolls for now, but the idea is to continue to polish this.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [x] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-01-21 13:03:27 -05:00
bors-servo
0c4205ebfe
Auto merge of #25431 - warren-fisher:create-html-element, r=jdm
use create_html_element for HTMLAudioElement and HTMLImageElement

<!-- Please describe your changes on the following line: -->

Updated the Image and Audio constructors to use `create_html_element` via the Element::create method. This was done to meet these specifications of "Let (audio/image) be the result of **creating an element** given document, audio, and the HTML namespace." for [dom-image](https://html.spec.whatwg.org/multipage/embedded-content.html#dom-image) and [dom-audio](https://html.spec.whatwg.org/multipage/media.html#dom-audio)
Not sure what _is_ is according to the [create-element guidelines](https://dom.spec.whatwg.org/#concept-create-element) so I left it as None copying from #25393. Also copied the ElementCreator and CustomElementCreationMode from #25393 as I do not know what they do.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25421 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because it is a small swap out of the way used to generate these HTML elements. The pre-existing tests should be sufficient.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-01-21 12:38:07 -05:00
Martin Robinson
e4a55d7755 Add a workaround to root_scroll.html for #25559
This allows us to test initial root scrolling support in Layout 2020
and can hopefully be removed very soon.
2020-01-21 15:29:23 +01:00
Martin Robinson
1cd772fe5f Answer content box queries for layout_2020 for the root element
This isn't correct yet, but it is necessary to give a value in order for
scrolling from script to work. Later this should give an accurate
content box response as well as work for non-root elements.
2020-01-21 15:29:23 +01:00
Martin Robinson
27e0400891 Fix an issue with unset_boxes_in_subtree in layout_2020
If the root node of the subtree doesn't have any boxes to unset, we
should exit early instead of unsetting boxes on siblings of the root.
This eliminates an infinite loop in this method, since the siblings of
the root are not in the subtree.
2020-01-21 15:29:23 +01:00
Martin Robinson
8825d588c1 Add initial support for scrollable overflow in layout_2020
This still isn't totally correct and non-root scrolling is not handled
at all, but the root frame now scrolls.
2020-01-21 15:29:23 +01:00
bors-servo
52ac5316ad
Auto merge of #25569 - szeged:pipeline_layout_wgpu, r=jdm
Initial implementation of GPUPipelineLayout for WebGPU

Added WebIDL bindings for `GPUPipelineLayout`.
Implemented the createPipelineLayout function of `GPUDevice`.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes addresses a part of #24706

<!-- Either: -->
cc @kvark @jdm @zakorgy

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-01-21 09:11:22 -05:00
Istvan Miklos
d33a4d29a0 Initial implementation of GPUPipelineLayout for WebGPU
Added WebIDL bindings for `GPUPipelineLayout`.
Implemented the createPipelineLayout function of `GPUDevice`.
2020-01-21 14:47:38 +01:00
bors-servo
0dccfd148a
Auto merge of #25557 - servo-wpt-sync:wpt_update_20-01-2020, r=servo-wpt-sync
Sync WPT with upstream (20-01-2020)

Automated downstream sync of changes from upstream as of 20-01-2020.
[no-wpt-sync]
r? @servo-wpt-sync
2020-01-20 20:48:36 -05:00
bors-servo
66aebfdbee
Auto merge of #25556 - szeged:mmatyas__webgl_testexp_updates, r=jdm
Update the WebGL2 test expectations

It seems the WPT test runner/updater has some troubles picking up successful test results, so I've regenerated the `ini` files manually for the WebGL2 tests.

<!-- Please describe your changes on the following line: -->

cc @jdm @zakorgy

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes do not require tests because they are the tests

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-01-20 15:01:01 -05:00
bors-servo
f2d096fa6a
Auto merge of #25555 - warren-fisher:fix-mach-all, r=jdm
Add default arguments so that ./mach test --all works

<!-- Please describe your changes on the following line: -->
Fix `./mach test --all` not getting any default values for `force_cpp` and `no_wpt` in [python/servo/testing_commands.py](2a594821ba/python/servo/testing_commands.py (L319-L334)). For `./mach test-tidy` the default values are obtained using the `@CommandArgument` decorator, but this does not apply for calling `test_tidy()` when using `./mach test --all` (which calls the function directly). This call is found on line 109 of `registrar.py` which should be located in something like `python/_virtualenv2.7/python2.7/site-packages/mach/registrar.py` (but not located in this git repository).

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25554 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because the change is minimal and non breaking. Any existing code should be able to work if it uses keyword arguments because the default values will be overriden. If there is code that calls `test_tidy()` with arguments by position this would cause breakage, but I do not believe this happens anywhere in the `testing_command.py` file. `./mach test-tidy` should still work because the arguments are set using the `@CommandArgument` decorator.

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-01-20 11:44:56 -05:00
bors-servo
0b79fe377d
Auto merge of #25552 - CYBAI:fix-25436, r=jdm
Return the highest priority error from the descendant instead of return the very first one

The test failed because we didn't return the highest priority error (which is network error in this case).

As Manish mentioned in https://github.com/servo/servo/issues/25436#issuecomment-571065323, that's because we're using the Promise.all trick to signal loads.

If we can avoid relying on Promise.all, maybe we don't need to do a complex logic like this; instead, ideally, we should always finish the module load immediately when we hit network failure so that we don't even need to do the `max()` comparison.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #25436
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-01-20 08:09:20 -05:00
WPT Sync Bot
14767cc1ad Update web-platform-tests to revision d7faaa65a15ef351c882e1b457ecee7070ea24c6 2020-01-20 11:01:22 +00:00
Mátyás Mustoha
18d40fb191 Update the WebGL2 test expectations
It seems the WPT test runner/updater has some troubles picking up
successful test results, so I've regenerated the `ini` files manually
for the WebGL2 tests.
2020-01-20 11:46:07 +01:00
CYBAI
33988cd8aa Return the highest priority error from the descendant instead of return the very first one 2020-01-20 19:18:12 +09:00
bors-servo
74d1f02a6a
Auto merge of #25547 - kunalmohan:25531-SnakeCase, r=jdm
Modify `script` to prevent further violations of snake_case

<!-- Please describe your changes on the following line: -->
Remove `#![allow(non_snake_case)]` from `script/lib.rs` and add `#[allow(non_snake_case)]` at each instance of violation.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #25531  (GitHub issue number if applicable)

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-01-20 04:05:27 -05:00
bors-servo
544c41b51f
Auto merge of #25553 - servo-wpt-sync:wpt_update_19-01-2020, r=servo-wpt-sync
Sync WPT with upstream (19-01-2020)

Automated downstream sync of changes from upstream as of 19-01-2020.
[no-wpt-sync]
r? @servo-wpt-sync
2020-01-19 21:00:27 -05:00
bors-servo
8518553805
Auto merge of #25551 - pylbrecht:raqote, r=jdm
Fix canvas wpt test `path-objects/2d.path.rect.zero.4.html`

<!-- Please describe your changes on the following line: -->
After connecting the lines of a rectangle, a new subpath has to be created containing the rectangle's origin as the only point in the subpath.
(see step 4 of https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-rect)

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix part of #25331

<!-- Either: -->
- [x] There are tests for these changes

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
2020-01-19 18:51:20 -05:00
Warren Fisher
6fa50a423e Add default arguments so that ./mach test --all works 2020-01-19 13:20:36 -04:00
WPT Sync Bot
add3067672 Update web-platform-tests to revision 2f346208c2a115a601b580e7869fe112b97c4246 2020-01-19 11:16:38 +00:00
pylbrecht
3c7205c99f Create new subpath with origin after drawing rect
Step 4 has been missing.
https://html.spec.whatwg.org/multipage/canvas.html#dom-context-2d-rect
2020-01-19 09:23:18 +01:00
Kunal Mohan
f7db4b7f80
Modify script to prevent further violations of snake_case 2020-01-18 14:22:15 +05:30