Commit graph

14059 commits

Author SHA1 Message Date
Bobby Holley
c9704992a9 Factor the name-related fields of Attr into a struct and move it to style. 2015-11-09 21:40:22 -08:00
Bobby Holley
488c1291d4 Hoist AttrValue into style. 2015-11-09 21:40:22 -08:00
bors-servo
4ec96963f8 Auto merge of #8440 - mbrubeck:range-unused, r=Manishearth
Remove unused method from Range

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8440)
<!-- Reviewable:end -->
2015-11-10 08:43:59 +05:30
bors-servo
cd6813ea39 Auto merge of #8434 - frewsxcv:dimension-attrvalue, r=eefriedman
Add Dimension member to AttrValue

Fixes #8417

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8434)
<!-- Reviewable:end -->
2015-11-10 08:15:37 +05:30
bors-servo
0d21158eb3 Auto merge of #8378 - Ms2ger:rwdata, r=eefriedman
Reduce LayoutTaskData to the fields used for RPC.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8378)
<!-- Reviewable:end -->
2015-11-10 07:47:45 +05:30
Matt Brubeck
603fb5e1c2 Remove unused method from Range 2015-11-09 17:47:08 -08:00
Corey Farwell
71aa2392f8 Remove HTMLTableElement::width struct field 2015-11-09 20:35:29 -05:00
Corey Farwell
73314ab10c Add Dimension member to AttrValue
Fixes #8417
2015-11-09 20:32:56 -05:00
bors-servo
b386008623 Auto merge of #8431 - eefriedman:table-bgcolor, r=frewsxcv
Move storage of bgcolor for `<tr>` and `<tbody>`.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8431)
<!-- Reviewable:end -->
2015-11-10 06:58:16 +05:30
bors-servo
aa62cc74d3 Auto merge of #8432 - rnestler:refactor_loops, r=frewsxcv
Refactor some loop{} to while let{}

I searched for some similar cases like in #8384 and tried to refactor them as well.
@frewsxcv Care to review?

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8432)
<!-- Reviewable:end -->
2015-11-10 04:33:23 +05:30
Raphael Nestler
98d70aec3c Use while let{} instead of loop{match{}} in run_server() 2015-11-09 23:32:00 +01:00
Raphael Nestler
004ed44755 Use while let{} instead of loop{match{}} in TimerScheduler::run_event_loop() 2015-11-09 23:31:59 +01:00
Eli Friedman
4b68fc18c3 Move storage of bgcolor for <tr> and <tbody>. 2015-11-09 12:27:16 -08:00
bors-servo
f39faaf994 Auto merge of #8227 - asajeffrey:versioned_dom, r=eefriedman
Versioned dom

This PR adds versioning to the DOM. There are now node.get_version and node.get_descendent_version methods that return a counter that is bumped when the node is dirtied. This is used to implement cache invalidation for caching HTMLCollection state. Caching HTMCollections gets a 1000x speedup in the Dromaeo DOM query tests.

Addresses https://github.com/servo/servo/issues/6901, https://github.com/servo/servo/issues/3381 and https://github.com/servo/servo/issues/1916.

Replaces PR https://github.com/servo/servo/pull/6927.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8227)
<!-- Reviewable:end -->
2015-11-10 01:11:23 +05:30
bors-servo
d8df028197 Auto merge of #8404 - eefriedman:misc-attributes, r=nox
Misc cleanup for DOM attributes

No functional change; just cleanups related to parsing attributes.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8404)
<!-- Reviewable:end -->
2015-11-10 00:32:24 +05:30
Eli Friedman
af78173243 Move more unsafe layout calls onto LayoutJS. 2015-11-09 10:47:38 -08:00
Eli Friedman
5293afc122 Move unsafe layout calls onto LayoutJS. 2015-11-09 10:47:37 -08:00
bors-servo
5fda719fa8 Auto merge of #8415 - mrobinson:create-wpt-relative, r=frewsxcv
Form relative reference URLs during create-wpt

Instead of always using the absolute path to the reference file when
creating new reference tests, create-wpt now creates relative URLs if
the files are in the same directory. This is the most common case for
new Servo tests. Also fix some missing quotation marks in the
create-wpt template.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8415)
<!-- Reviewable:end -->
2015-11-09 22:43:25 +05:30
bors-servo
eda59fdd69 Auto merge of #8405 - wenderen:8402-replace-load-whole-resource, r=Ms2ger
replace use of load_whole_resource in net/image_cache_task.rs with Fi…

…le::open

Fixes #8402.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8405)
<!-- Reviewable:end -->
2015-11-09 20:56:49 +05:30
rohan.prinja
51012d17c1 replace use of load_whole_resource in net/image_cache_task.rs with File::open
don't ignore read_to_end's return value
2015-11-10 00:09:17 +09:00
bors-servo
f74754f582 Auto merge of #8175 - benschulz:set-timeout-panic, r=jdm
Fixed panic in ActiveTimers.set_timeout_or_interval.

`ActiveTimers.set_timeout_or_interval` asserts that the pipeline is not currently frozen. Apparently that is too strict. When pending network requests complete after a pipeline is frozen, scripts may be executed and a timer scheduled.

With these changes scheduling a timer while the pipeline is frozen behaves as if the timer was scheduled at the time the pipeline was frozen.

To reproduce the panic
 1. `./mach run -r http://google.com`,
 2. immediately click on any link and
 3. wait for the panic.

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8175)
<!-- Reviewable:end -->
2015-11-09 20:18:38 +05:30
Ms2ger
1919e19633 Move viewport_size from LayoutTaskData to LayoutTask. 2015-11-09 09:04:05 +01:00
Ms2ger
dd920a06f3 Move epoch from LayoutTaskData to LayoutTask. 2015-11-09 09:04:04 +01:00
Ms2ger
4c3038f378 Pass the constellation_chan to animation::update_animation_state directly. 2015-11-09 09:04:03 +01:00
Ms2ger
c469d09543 Move running_animations from LayoutTaskData to LayoutTask. 2015-11-09 09:04:02 +01:00
Ms2ger
ee2b77e8f5 Move visible_rects from LayoutTaskData to LayoutTask. 2015-11-09 09:04:02 +01:00
Ms2ger
e8f31f2ed7 Move root_flow from LayoutTaskData to LayoutTask. 2015-11-09 09:04:01 +01:00
Ms2ger
53da53ef53 Move outstanding_web_fonts from LayoutTaskData to LayoutTask. 2015-11-09 09:04:00 +01:00
Ms2ger
5e4039d328 Move new_animations_receiver from LayoutTaskData to LayoutTask. 2015-11-09 09:03:59 +01:00
Ms2ger
604d1e8400 Move new_animations_sender from LayoutTaskData to LayoutTask. 2015-11-09 09:03:58 +01:00
Ms2ger
bdfa5fe804 Move generation from LayoutTaskData to LayoutTask. 2015-11-09 09:03:57 +01:00
Ms2ger
880fb9be0b Remove LayoutTaskData::image_cache_task. 2015-11-09 09:03:57 +01:00
Ms2ger
be178c0e5e Remove unused RwData arguments from LayoutTask::exit_now and LayoutTask::prepare_to_exit. 2015-11-09 09:03:56 +01:00
Ms2ger
dcea03c2b4 Move parallel_traversal from LayoutTaskData to LayoutTask. 2015-11-09 09:03:55 +01:00
Ms2ger
49691c1638 Make LayoutTask::solve_constraints_parallel a static method.
This matches LayoutTask::solve_constraints, and will be necessary when we
borrow parallel_traversal directly from the LayoutTask.
2015-11-09 09:03:54 +01:00
Ms2ger
cc1b7acbe6 Make LayoutTask::solve_constraints a static method.
It does not use self.
2015-11-09 09:03:53 +01:00
Ms2ger
8674345d61 Move LayoutTask::first_reflow out of its Cell.
As the LayoutTask is uniquely owned, and we no longer have borrows of its
fields hanging around, we can use mutable references to simplify some code.
2015-11-09 09:03:52 +01:00
Ms2ger
3f4c734cf4 Introduce a RwData struct. 2015-11-09 09:03:52 +01:00
Ms2ger
b8d8505463 Disentangle the message handling from the receiver selection in LayoutTask::handle_request.
This ensures no fields of the LayoutTask are borrowed when calling repaint or
handle_request_helper, which I'll need later.
2015-11-09 09:03:51 +01:00
Ms2ger
ff0acccc06 Consolidate ProfilerMetadata and TimerMetadata.
There is no good reason to have the two types.

This also means that the result of LayoutTask::profiler_metadata no longer
borrows the LayoutTask, which I'll need later.
2015-11-09 09:03:50 +01:00
Eli Friedman
ef52da7acd Move storage of color attribute on <font>. 2015-11-08 17:29:50 -08:00
Eli Friedman
0901e5bc97 Move storage of bgcolor attribute on <body>. 2015-11-08 17:29:49 -08:00
bors-servo
3780fb7fe0 Auto merge of #8419 - frewsxcv:html-hr-element-color-attribute, r=eefriedman
Implement <hr> 'color' attribute

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8419)
<!-- Reviewable:end -->
2015-11-09 05:28:51 +05:30
Corey Farwell
ee0800abe9 Implement <hr> 'color' attribute 2015-11-08 18:34:27 -05:00
bors-servo
97791dd317 Auto merge of #8383 - mbrubeck:touch-refactor, r=glennw
Simplify multi-touch state machine code

This is a minor refactoring of the touch tracking in compositor, to simplify the code and prepare for more gesture handling (like pinch to zoom). r? @glennw

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8383)
<!-- Reviewable:end -->
2015-11-09 04:51:21 +05:30
bors-servo
43a5c62fde Auto merge of #8410 - simartin:issue_8407, r=nox
Avoid UnboundLocalError upon "bogus" usage of ./mach create-wpt

Fixes https://github.com/servo/servo/issues/8407

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8410)
<!-- Reviewable:end -->
2015-11-09 01:23:22 +05:30
Martin Robinson
bebbc80129 Form relative reference URLs during create-wpt
Instead of always using the absolute path to the reference file when
creating new reference tests, create-wpt now creates relative URLs if
the files are in the same directory. This is the most common case for
new Servo tests. Also fix some missing quotation marks in the
create-wpt template.
2015-11-08 10:32:35 -08:00
bors-servo
9bcae9a866 Auto merge of #8408 - romankl:websocket-rename-impl, r=jdm
rename WebSocket::Send_Impl

Previos: `Send_Impl`, now: `send_impl`.

Closes: #8345

<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png" height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/8408)
<!-- Reviewable:end -->
2015-11-08 20:31:35 +05:30
Simon Martin
3b087d406a Avoid UnboundLocalError upon "bogus" usage of ./mach create-wpt 2015-11-08 14:48:02 +01:00
Roman Klauke
4f35941b9d rename WebSocket::Send_Impl
Previos: `Send_Impl`, now: `send_impl`.

Closes: #8345
2015-11-08 14:45:59 +01:00