Ms2ger
c98d35ea6b
Lock stderr while printing the alert() message.
...
2a7f262b7d
was unsufficient for the case where
the interleaved output was actually on stderr rather than stdout, such as
output from the error macro.
2015-08-06 20:11:37 +02:00
bors-servo
729e003c5d
Auto merge of #6996 - frewsxcv:prevent-tidy-crash, r=jdm
...
Prevent flake8 from crashing tidy
If someone were to write:
def hello() :
print "hello world"
flake8 would warn:
stdin:54:45: E203 whitespace before ':'
Normally there are only three colons in a flake8 error message, but this
one has four, which causes issue with this line:
_, line_num, _, message = error.split(":")
...causing this error:
ValueError: too many values to unpack
This commit updates the `str.split` call to utilize the `maxsplit`
parameter to prevent this error from occurring.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6996 )
<!-- Reviewable:end -->
2015-08-06 02:32:43 -06:00
bors-servo
3b4b59551d
Auto merge of #6991 - Manishearth:readme-doc, r=Ms2ger
...
Add doc.s.o to the readme
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6991 )
<!-- Reviewable:end -->
2015-08-06 01:36:22 -06:00
bors-servo
1b54e9c30c
Auto merge of #6985 - dzbarsky:drawimage_refactor, r=jdm
...
Refactor DrawImage implementations to avoid code duplication
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6985 )
<!-- Reviewable:end -->
2015-08-06 00:24:02 -06:00
bors-servo
b9dcd49778
Auto merge of #6989 - dzbarsky:compositing, r=metajack
...
Respect the composition op when drawing images.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6989 )
<!-- Reviewable:end -->
2015-08-05 22:57:20 -06:00
David Zbarsky
8690414a47
Refactor DrawImage implementations to avoid code duplication
2015-08-06 00:52:28 -04:00
bors-servo
be8798b73a
Auto merge of #6994 - servo:warnings, r=Manishearth
...
Fix unused mutability warnings.
They were introduced in 35ba731123
.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6994 )
<!-- Reviewable:end -->
2015-08-05 22:02:45 -06:00
Jack Moffitt
f570da28c2
Merge pull request #6988 from glennw/no-arc
...
No need for paint layer in stacking context to be an arc.
2015-08-05 20:06:09 -06:00
David Zbarsky
1d02239804
Respect the composition op when drawing images
2015-08-05 20:38:48 -04:00
bors-servo
afe3d7e747
Auto merge of #6990 - Ms2ger:update-animatiom-timimg, r=saneyuki
...
Update Animation Timing links and terminology to the HTML specification.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6990 )
<!-- Reviewable:end -->
2015-08-05 14:55:55 -06:00
bors-servo
315c4f5ed7
Auto merge of #6983 - glennw:tf2, r=pcwalton
...
Support transforms for display list optimization. Prevents clipping in #6643 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6983 )
<!-- Reviewable:end -->
2015-08-05 12:50:36 -06:00
bors-servo
debd7d87d6
Auto merge of #6974 - dzbarsky:tiny-create, r=jdm
...
Fix createImageData with sizes < 1 pixel
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6974 )
<!-- Reviewable:end -->
2015-08-05 11:40:20 -06:00
bors-servo
95269bba39
Auto merge of #6971 - dzbarsky:negative-radius, r=Ms2ger
...
Make createRadialGradient throw for negative radii
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6971 )
<!-- Reviewable:end -->
2015-08-05 10:42:57 -06:00
bors-servo
b3d61878dc
Auto merge of #6964 - Ms2ger:dwgs-eventloop, r=jdm
...
Cleanup DedicatedWorkerGlobalScope::run_worker_scope.
It was getting overcrowded.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6964 )
<!-- Reviewable:end -->
2015-08-05 09:21:10 -06:00
Corey Farwell
5eeb53413e
Prevent flake8 from crashing tidy
...
If someone were to write:
def hello() :
print "hello world"
flake8 would warn:
stdin:54:45: E203 whitespace before ':'
Normally there are only three colons in a flake8 error message, but this
one has four, which causes issue with this line:
_, line_num, _, message = error.split(":")
...causing this error:
ValueError: too many values to unpack
This commit updates the `str.split` call to utilize the `maxsplit`
parameter to prevent this error from occurring.
2015-08-05 10:23:16 -04:00
bors-servo
8602d01af2
Auto merge of #6416 - jgraham:hosts_replaced, r=jdm
...
Use hosts-replaced URL only when loading resources
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6416 )
<!-- Reviewable:end -->
2015-08-05 08:01:03 -06:00
Ms2ger
a7ca54a325
Fix unused mutability warnings.
...
They were introduced in 35ba731123
.
2015-08-05 15:45:05 +02:00
bors-servo
11acfbc29f
Auto merge of #6981 - pcwalton:github-font-fallback, r=metajack
...
gfx: Fix Core Text font instantiation for Web fonts on Mac.
r? @metajack
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6981 )
<!-- Reviewable:end -->
2015-08-05 06:11:36 -06:00
Manish Goregaokar
432e36dc81
Add doc.s.o to the readme
2015-08-05 16:51:41 +05:30
bors-servo
cc70e2f91f
Auto merge of #6980 - pcwalton:inline-border-baseline, r=glennw
...
layout: Take borders into account when positioning inline fragments on their baselines.
Improves the Rust GitHub page.
r? @glennw
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6980 )
<!-- Reviewable:end -->
2015-08-05 05:03:43 -06:00
bors-servo
0d8825c25c
Auto merge of #6959 - servo:warnings_, r=jdm
...
Fix warnings
Adds on top of #6949 .
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6959 )
<!-- Reviewable:end -->
2015-08-05 03:44:22 -06:00
James Graham
f52276d2cc
Use hosts-replaced URL only when loading resources
2015-08-05 10:34:20 +01:00
Ms2ger
d2077dd245
Update Animation Timing links and terminology to the HTML specification.
2015-08-05 09:21:08 +02:00
bors-servo
56a9eab2a0
Auto merge of #6976 - pcwalton:vertical-marker-placement, r=mbrubeck
...
layout: Place list item markers correctly in the block direction.
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6976 )
<!-- Reviewable:end -->
2015-08-05 00:57:19 -06:00
Glenn Watson
aca98b2901
No need for paint layer in stacking context to be an arc.
2015-08-05 14:35:49 +10:00
bors-servo
ac533b1466
Auto merge of #6944 - r0e:testing, r=jdm
...
Fix for issue #6768 . Refactor ReadData and BlobBody
Fix for issue #6768 .
Merge common fields of ReadData and BlobBody to avoid passing redundant information to functions.
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6944 )
<!-- Reviewable:end -->
2015-08-04 20:21:35 -06:00
Glenn Watson
11b1c19b05
Support transforms for display list optimization. Prevents clipping in #6643 .
2015-08-05 11:48:07 +10:00
bors-servo
b9f00190e1
Auto merge of #6979 - mbrubeck:counter, r=pcwalton
...
Fix crash caused by negative numbers in list counters.
Fixes #6818 . The test still fails because of #6978 .
r? @pcwalton
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6979 )
<!-- Reviewable:end -->
2015-08-04 18:37:10 -06:00
Patrick Walton
d6b9e3bdfd
gfx: Fix Core Text font instantiation for Web fonts on Mac.
...
Fixes GitHub Octicons. A reftest has been added for this.
2015-08-04 17:07:44 -07:00
Patrick Walton
2880aa2b02
layout: Take borders into account when positioning inline fragments on
...
their baselines.
Improves the Rust GitHub page.
2015-08-04 16:20:15 -07:00
Matt Brubeck
35ba731123
Fix handling of negative numbers in list counters.
...
Fixes #6818 .
2015-08-04 16:18:09 -07:00
bors-servo
eecd975209
Auto merge of #6954 - dzbarsky:stroke_rect, r=glennw
...
Implement strokeRect with zero-width or zero-height rects
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6954 )
<!-- Reviewable:end -->
2015-08-04 16:38:57 -06:00
Patrick Walton
a746fa0ac1
layout: Place list item markers correctly in the block direction.
2015-08-04 14:44:54 -07:00
David Zbarsky
9fbe33b6f2
Implement strokeRect with zero-width or zero-height rects
2015-08-04 17:44:18 -04:00
bors-servo
b7e592443f
Auto merge of #6945 - Manishearth:fixedme, r=jdm
...
If let is not an issue for lints
r? @Ms2ger
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6945 )
<!-- Reviewable:end -->
2015-08-04 14:38:31 -06:00
David Zbarsky
2fb5fda5d0
Fix createImageData with sizes < 1 pixel
2015-08-04 15:45:38 -04:00
David Zbarsky
75e444c3b2
Make createRadialGradient throw for negative radii
2015-08-04 15:08:37 -04:00
bors-servo
56d3426431
Auto merge of #6940 - pcwalton:inline-pseudo-repair-jumpiness, r=mbrubeck
...
layout: When repairing styles for incremental reflow, only repair styles of nodes that represent the dirty node, *including its pseudo-element*.
r? @mbrubeck
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6940 )
<!-- Reviewable:end -->
2015-08-04 12:53:26 -06:00
bors-servo
2205570083
Auto merge of #6947 - pcwalton:table-center, r=glennw
...
layout: Don't use the block container inline size as the initial computed table inline size.
Makes google.com fully centered.
r? @glennw
cc @SimonSapin
<!-- Reviewable:start -->
[<img src="https://reviewable.io/review_button.png " height=40 alt="Review on Reviewable"/>](https://reviewable.io/reviews/servo/servo/6947 )
<!-- Reviewable:end -->
2015-08-04 11:36:09 -06:00
Patrick Walton
be5b6ff8c2
Update CSS tests expected data
2015-08-04 09:54:31 -07:00
Patrick Walton
04928bf1e3
layout: Don't use the block container inline size as the initial
...
computed table inline size.
Makes google.com fully centered.
2015-08-04 09:40:35 -07:00
Ms2ger
95763a87b0
Move the worker script evaluation into a method on WorkerGlobalScope.
2015-08-04 18:16:07 +02:00
Ms2ger
11ea299105
Remove the parent_sender_for_reporter local from DedicatedWorkerGlobalScope::run_worker_scope.
2015-08-04 18:16:06 +02:00
Ms2ger
bc97b421d2
Register the worker memory reporter outside the _ar scope.
...
The comment that claims it needs to be in that scope appears to be incorrect.
2015-08-04 18:15:58 +02:00
Patrick Walton
0a589d413d
layout: When repairing styles for incremental reflow, only repair
...
styles of nodes that represent the dirty node, *including its
pseudo-element*.
Fixes lots more jumpiness.
A manual test, `inline-pseudo-repair-jumpiness.html`, has been added. I
was unable to automate it, so I will file a followup issue on that.
2015-08-04 09:02:41 -07:00
Ms2ger
d19ddfe6f3
Use a while let loop for the DedicatedWorkerGlobalScope event loop.
2015-08-04 16:44:18 +02:00
Ms2ger
5e1be29743
Move the event processing in the DedicatedWorkerGlobalScope event loop into its own function.
2015-08-04 16:41:20 +02:00
Ms2ger
4f8827321c
Rename DedicatedWorkerGlobalScope::handle_event to handle_script_event.
2015-08-04 16:37:04 +02:00
Ms2ger
17985e5296
Split out a receive_event method from the DedicatedWorkerGlobalScope event loop.
2015-08-04 16:32:54 +02:00
Josh Matthews
039929da5c
Warning police.
...
Closes #6949 .
2015-08-04 15:16:15 +02:00