Commit graph

22961 commits

Author SHA1 Message Date
Manish Goregaokar
fdd6a409fb Add spec links for mask properties 2017-01-03 14:03:26 -08:00
Manish Goregaokar
3128694bff Add spec links for margin properties, support spec links on four_sides_shorthand 2017-01-03 14:03:25 -08:00
Manish Goregaokar
6138b6aa75 Add spec links for list properties 2017-01-03 14:03:23 -08:00
Manish Goregaokar
26a9b450a2 Add spec links for inherited_text properties 2017-01-03 14:03:20 -08:00
Manish Goregaokar
096dca9171 Add spec links for inherited_table properties 2017-01-03 14:03:18 -08:00
Manish Goregaokar
ff4893e17e Add spec links for inherited_svg properties 2017-01-03 14:03:17 -08:00
Manish Goregaokar
71026c5ddb Add spec links for inherited_box properties 2017-01-03 14:03:16 -08:00
Manish Goregaokar
82835c8b1b Add spec links for font properties 2017-01-03 14:03:14 -08:00
Manish Goregaokar
b56762246f Add spec links for effects properties 2017-01-03 14:03:13 -08:00
Manish Goregaokar
be8f9ad9d7 Add spec links for counter properties 2017-01-03 14:03:12 -08:00
Manish Goregaokar
dedebc5cb5 Add spec links for column properties 2017-01-03 14:03:11 -08:00
Manish Goregaokar
6a88723409 Support logical values for float/clear 2017-01-03 14:03:10 -08:00
bors-servo
57b2c2609e Auto merge of #14828 - bholley:faster_atomic_refcell, r=Manishearth
Reimplement AtomicRefCell with pure atomics

While reviewing @bzbarsky's patches in [1], I started typing out some lore about how mutable AtomicRefCell borrows are actually cheaper than immutable ones, so we should prefer them where possible. But then I decided that this was a really dumb state of affairs and that we should just fix AtomicRefCell instead, and implement a proper AtomicRef{,Mut}::map while we were at it. So here we are.

This PR adds a from-scratch implementation of AtomicRefCell that aims to be 100% sound, even in unrealistic overflow scenarios. We should probably get this on crates.io eventually, but I want to land it landed in-tree first.

With this implementation, each operation (borrow or release) is one atomic instruction, and all borrow/release pairs (mutable or immutable) take 12 ns on my machine, which is what I'd expect. This is a 50% improvement over the previous implementation in the immutable case.

There may be some places where we could get away with Ordering::Release instead of Ordering::AcqRel, but it didn't seem worth it to try to reason it out.

r? @Manishearth

CC @emilio @SimonSapin @heycam @upsuper

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1298588

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14828)
<!-- Reviewable:end -->
2017-01-03 12:24:45 -08:00
Bobby Holley
c26b4bed60 Reimplement AtomicRefCell as a fork of RefCell. 2017-01-03 12:23:06 -08:00
Manish Goregaokar
0b515c2bc9 Add spec links for box properties 2017-01-03 10:27:49 -08:00
Manish Goregaokar
a9c0162000 Add spec links for border properties 2017-01-03 10:24:00 -08:00
Manish Goregaokar
cd2f9734e9 Add spec links for background properties 2017-01-03 10:23:56 -08:00
Manish Goregaokar
d63af611f2 Add spec links for position properties 2017-01-03 10:23:04 -08:00
Manish Goregaokar
29c2db4457 Add spec argument to property helpers 2017-01-03 10:23:02 -08:00
bors-servo
68ecb04847 Auto merge of #14831 - servo:rustfmt-traits, r=nox
Rustfmt script_traits and net_traits.

CC #8553.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14831)
<!-- Reviewable:end -->
2017-01-03 08:11:09 -08:00
bors-servo
672f099c95 Auto merge of #14830 - heycam:bindings-update-15, r=emilio
stylo: update bindings

Bindings update for https://treeherder.mozilla.org/#/jobs?repo=stylo&revision=8ebbde564daf4f7019d874e4b888bd670c81e6cc.

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14830)
<!-- Reviewable:end -->
2017-01-03 06:08:30 -08:00
Ms2ger
b46846e2a0 Rustfmt net_traits. 2017-01-03 15:06:41 +01:00
Ms2ger
b76613a389 Skip rustfmt on to_filtered.
https://github.com/rust-lang-nursery/rustfmt/issues/1262
2017-01-03 15:06:37 +01:00
Ms2ger
01114ebcf8 Reformat WebSocketNetworkEvent::ConnectionEstablished and CoreResourceMsg::SetCookieForUrl. 2017-01-03 15:06:36 +01:00
Ms2ger
22f85bfed6 Reformat fetch_async(). 2017-01-03 15:06:35 +01:00
Ms2ger
410e5c6d6f Use documentation comments for PixelFormat. 2017-01-03 15:06:34 +01:00
bors-servo
2694463b08 Auto merge of #14686 - nox:dom, r=jdm
Improve dead_code handling a bit

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14686)
<!-- Reviewable:end -->
2017-01-03 05:13:23 -08:00
Anthony Ramine
3f91ce1d07 Don't generate constructor IDs for inline interfaces 2017-01-03 14:12:19 +01:00
Ms2ger
2dde348b12 Rustfmt script_traits. 2017-01-03 14:07:30 +01:00
Ms2ger
bf643f5356 Reformat WebDriverScriptCommand::AddCookie. 2017-01-03 14:07:06 +01:00
Ms2ger
ef13f01b8e Simplify ConstellationControlMsg's Debug implementation. 2017-01-03 13:58:18 +01:00
Ms2ger
b214c3c1da Add rustfmt.toml. 2017-01-03 13:56:39 +01:00
Cameron McCormack
8d6c3e0bdf stylo: Regenerate bindings. 2017-01-03 19:09:18 +08:00
Cameron McCormack
1041ce6b98 stylo: Update glue for background-color. 2017-01-03 19:09:17 +08:00
bors-servo
955e2851bf Auto merge of #14706 - faineance:test_unit_no_capture, r=Wafflespeanut
Allow passing --nocapture argument to test-unit mach command

This adds the ` --nocapture` argument to the test-unit mach command.
Defaulting to false, when given it passes `-- --nocapture` to cargo test to show stdout during test-unit runs.

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14595

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14706)
<!-- Reviewable:end -->
2017-01-03 00:36:13 -08:00
faineance
46291fd998 Add nocapture argument to test-unit 2017-01-03 13:54:31 +05:30
bors-servo
128aac921f Auto merge of #14829 - Wafflespeanut:browserhtml, r=UK992
Fix browserhtml path

<!-- Please describe your changes on the following line: -->

I'd missed something in #14817, which now prevents us from running `./mach run -r -b`. @UK992 pointed this in the PR, but it got merged soon 😐

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because it's a fix for mach

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14829)
<!-- Reviewable:end -->
2017-01-02 23:44:19 -08:00
Ravi Shankar
b061ada836 Fix browserhtml path 2017-01-03 13:05:13 +05:30
Bobby Holley
79a552ea45 Add benchmarks for AtomicRefCell borrows. 2017-01-02 15:49:40 -08:00
bors-servo
987b640c54 Auto merge of #14784 - mattnenterprise:fetch-api-updates, r=jdm,KiChjang
Updating http_network_or_cache_fetch to better match the fetch API spec

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #14742

<!-- Either: -->
- [x] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14784)
<!-- Reviewable:end -->
2017-01-02 11:30:51 -08:00
bors-servo
b65eefe7d2 Auto merge of #14825 - fflorent:master, r=jdm
Remove useless call to map() in constellation.rs

Remove a little bit useless call to map() in constellation.rs :)

Context: https://github.com/servo/servo/pull/14724/files#r94317893

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix [this remark](https://github.com/servo/servo/pull/14724/files#r94317893)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [x] These changes do not require tests because these are minor changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14825)
<!-- Reviewable:end -->
2017-01-02 10:35:04 -08:00
Florent FAYOLLE
af55939491 Remove useless call to map() in constellation.rs 2017-01-02 18:55:26 +01:00
Matt McCoy
09194a15ac Updating http_network_or_cache_fetch to better match the fetch API spec 2017-01-02 12:00:57 -05:00
bors-servo
2bf71800ef Auto merge of #14817 - teosz:master, r=Wafflespeanut
Remove duplicate code in mach

<!-- Please describe your changes on the following line: -->
Move get_browserhtml_path to command_base

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #14815 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because removing the duplicate code doesn't affect the behavior itself

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14817)
<!-- Reviewable:end -->
2017-01-02 06:41:00 -08:00
Teodor Szente
48df976bcd Move get_browserhtml_path to command_base #14815
Remove unused import of find_dep_path_newest #14815

Move get_browserhtml_path top along with find_dep_path_newest #14815
2017-01-02 16:39:20 +02:00
bors-servo
87847324a0 Auto merge of #14819 - emilio:no-missing-docs, r=Manishearth
Document most of the remaining parts of the style system, make docs-by-default for the whole style system

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/14819)
<!-- Reviewable:end -->
2017-01-02 04:10:56 -08:00
Emilio Cobos Álvarez
a8fdf5b6b9
style: Require documentation also for a Gecko build. 2017-01-02 12:58:08 +01:00
Emilio Cobos Álvarez
2cebd3bc96
style: Document gecko_string_cache. 2017-01-02 12:58:07 +01:00
Emilio Cobos Álvarez
e9d3ac03a9
style: Document Gecko's wrapper module. 2017-01-02 12:58:06 +01:00
Emilio Cobos Álvarez
94f8c0fc63
style: Document the remaining public parts of Gecko's values module. 2017-01-02 12:58:06 +01:00