Commit graph

20249 commits

Author SHA1 Message Date
Eric Anholt
cc294fffcc webgl: Update the match for WebGLError's new InvalidFramebufferOperation. 2016-09-21 08:05:45 +10:00
bors-servo
66c736194d Auto merge of #13335 - Manishearth:stylo-tests, r=emilio
Add unit test crate for stylo

@canaltinova needs this for his mask work -- we need a way to test stylo code (or style code that's conditionally compiled out for gecko)

We can add this to the CI as well.

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13335)
<!-- Reviewable:end -->
2016-09-20 15:47:27 -05:00
Manish Goregaokar
1d497828a7
Move sanity checks to stylo tests 2016-09-21 00:05:54 +05:30
Manish Goregaokar
c615a0dabc
Add unit test crate for stylo 2016-09-20 20:26:51 +05:30
bors-servo
0d7e747acb Auto merge of #13334 - servo:push_pending_frame, r=nox
Inline push_pending_frame into its callers.

The recently added replace argument makes it less readable, especially with
the second boolean argument I am adding in #11893.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13334)
<!-- Reviewable:end -->
2016-09-20 07:04:38 -05:00
Ms2ger
61402b8ca7 Inline push_pending_frame into its callers.
The recently added replace argument makes it less readable, especially with
the second boolean argument I am adding in #11893.
2016-09-20 14:01:56 +02:00
bors-servo
53938c439f Auto merge of #13329 - pcwalton:last-line-in-flow, r=notriddle
layout: Make `baseline_offset_of_last_line_box_in_flow()` only check blocks in flow.

Improves python.org.

Closes #12124.

r? @notriddle

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13329)
<!-- Reviewable:end -->
2016-09-19 22:45:55 -05:00
bors-servo
f313beee9b Auto merge of #13330 - glennw:update-wr-prim-cache, r=pcwalton
Update webrender (prim cache changes, blend/composite shaders).

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13330)
<!-- Reviewable:end -->
2016-09-19 21:47:40 -05:00
Glenn Watson
7c8664e6ec Update webrender (prim cache changes, blend/composite shaders). 2016-09-20 10:57:48 +10:00
bors-servo
993fbc4320 Auto merge of #13302 - pcwalton:negative-margin-speculation, r=notriddle
layout: Disable the speculation of block formatting contexts' inline sizes if the block formatting contexts have negative margins.

The heuristics that determine how and whether floats flow into the
margins are not valid in that case.

Closes #13299.

r? @notriddle

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13302)
<!-- Reviewable:end -->
2016-09-19 19:22:29 -05:00
Patrick Walton
c6b9b315aa layout: Make baseline_offset_of_last_line_box_in_flow() only check
blocks in flow.

Improves python.org.

Closes #12124.
2016-09-19 17:17:08 -07:00
Patrick Walton
b4aea115b8 layout: Disable the speculation of block formatting contexts' inline
sizes if the block formatting contexts have negative margins.

The heuristics that determine how and whether floats flow into the
margins are not valid in that case.

Closes #13299.
2016-09-19 16:27:55 -07:00
bors-servo
be72afc804 Auto merge of #13328 - glennw:disable-some-tests, r=jdm
Disable intermittent history and iframe tests.

See:
  https://github.com/servo/servo/issues/11825
  https://github.com/servo/servo/issues/12580

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13328)
<!-- Reviewable:end -->
2016-09-19 18:02:14 -05:00
Glenn Watson
ff8786a8f6 Disable intermittent history and iframe tests.
See:
  https://github.com/servo/servo/issues/11825
  https://github.com/servo/servo/issues/12580
2016-09-20 08:20:11 +10:00
bors-servo
dc3e11f96e Auto merge of #13324 - anholt:webgl-default-texture, r=jdm
Update offscreen_gl_context dependency to get webgl fix.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #11618

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13324)
<!-- Reviewable:end -->
2016-09-19 16:41:49 -05:00
bors-servo
7d3c7beb21 Auto merge of #13322 - jdm:msvc-build-fix, r=KiChjang
Make dummy font implementation conform to API changes.

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13321
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13322)
<!-- Reviewable:end -->
2016-09-19 15:37:16 -05:00
bors-servo
9876923b29 Auto merge of #13167 - ConnorGBrewster:reload_replace_current, r=asajeffrey
Replace current session entry when reloading

<!-- Please describe your changes on the following line: -->
This PR adds a replacement option when navigating. It replaces the current session history entry after a new page has been loaded. This will prevent reloading from adding a new entry to the session history.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13123 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13167)
<!-- Reviewable:end -->
2016-09-19 14:32:45 -05:00
Connor Brewster
e9b2f1b916 Replace current session entry for reloads 2016-09-19 14:23:03 -05:00
Josh Matthews
d985741701 Make dummy font implementation conform to API changes. 2016-09-19 14:38:36 -04:00
Eric Anholt
0303767da8 Update offscreen_gl_context dependency to get webgl fix.
Fixes #11618 (intermittent failure in default_texture.html) by not
polluting our context's binding with the texture it created.
2016-09-19 18:48:31 +01:00
bors-servo
0b0495cff4 Auto merge of #13320 - servo:js, r=jdm
Update js.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13320)
<!-- Reviewable:end -->
2016-09-19 11:37:31 -05:00
Ms2ger
630da77744 Update js. 2016-09-19 17:39:33 +02:00
bors-servo
a82d5106bd Auto merge of #12076 - jdm:font-load, r=pcwalton
Make font template data load fallible

Remove a TODO around dealing with a failed file operation.

Can we write an automated test for this? I don't really know what font template data is, but this failure seems to be fontconfig-specific...

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12037
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="35" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12076)
<!-- Reviewable:end -->
2016-09-19 09:14:55 -05:00
bors-servo
55e459ca99 Auto merge of #13319 - emilio:constellation-refactoring, r=Ms2ger
constellation: Minor refactoring to aid legibility.

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [x] These changes do not require tests because refactor only

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

Two things changed, on one hand, avoid a dumb if chain that could be more
idiomatically written with a match expression, and also avoiding use map() to
change state.

In general I'm pretty surprised for our lack of error reporting in this
critical code, but that's not the purpose of this PR.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13319)
<!-- Reviewable:end -->
2016-09-19 07:29:11 -05:00
Emilio Cobos Álvarez
e2db4fe466
constellation: Minor refactoring to aid legibility.
Two things changed, on one hand, avoid a dumb if chain that could be more
idiomatically written with a match expression, and also avoiding use map() to
change state.

In general I'm pretty surprised for our lack of error reporting in this
critical code, but that's not the purpose of this PR.
2016-09-19 14:25:29 +02:00
bors-servo
fe426f65b9 Auto merge of #13306 - Jenselme:13247-decode-utf8-with-utf8-lossy, r=Ms2ger
Decode UTF-8 with from_utf8_lossy in DedicatedWorkerGlobalScope

<!-- Please describe your changes on the following line: -->

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13247

<!-- Either: -->
- [X] There are tests for these changes: `./mach test-wpt /workers/semantics/encodings/004.worker` passes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13306)
<!-- Reviewable:end -->
2016-09-19 04:07:14 -05:00
Julien Enselme
9adda6e38d Decode UTF-8 with from_utf8_lossy in DedicatedWorkerGlobalScope 2016-09-19 10:29:05 +02:00
bors-servo
d76091ef0f Auto merge of #13314 - Phrohdoh:update-string_cache-to29patch, r=KiChjang
Update string_cache to 0.2.29

<!-- Please describe your changes on the following line: -->
Update string-cache from 0.2.28 to 0.2.29 which includes `minlength` for #13313.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Either: -->
- [X] These changes do not require tests because this is only adding a single string to string-cache (ref https://github.com/servo/string-cache/pull/172)

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13314)
<!-- Reviewable:end -->
2016-09-19 00:44:05 -05:00
bors-servo
5457b80233 Auto merge of #13307 - bubbles231:code_refactor, r=Manishearth
Code refactoring

<!-- Please describe your changes on the following line: -->
The code was refactored to follow Rust naming conventions better.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes help fix #12379.

<!-- Either: -->
- [ ] There are tests for these changes OR
- [X] These changes do not require tests because logic was not changed.

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13307)
<!-- Reviewable:end -->
2016-09-18 22:57:59 -05:00
Taryn Hill
7d0ad1a705 Update string_cache to 0.2.29 2016-09-18 22:43:35 -05:00
bors-servo
157e3cc4e9 Auto merge of #13227 - jmr0:pipeline_visibility, r=jdm
Pipeline visibility logic change

<!-- Please describe your changes on the following line: -->

cc @paulrouget @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #13191 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13227)
<!-- Reviewable:end -->
2016-09-18 21:21:45 -05:00
Arthur Marble
5f961f9fd9 Fix my typo on commit. Rest of the fixes will be here soon. 2016-09-18 07:32:05 -05:00
Arthur Marble
b874e76455 Made fixes for PR. 2016-09-18 07:12:39 -05:00
Arthur Marble
7986423cd7 One last refactoring before fixing 2016-09-18 05:57:24 -05:00
Arthur Marble
883902bd97 Most of the code refactoring needed to be done is done with this commit. 2016-09-18 03:41:16 -05:00
Arthur Marble
dbec9d8454 More code refactoring (exampleVar to example_var) 2016-09-18 01:02:57 -05:00
Arthur Marble
5fa54177ca Refactored a bluetooth* related files from codeStyle to code_style. 2016-09-18 00:07:32 -05:00
Arthur Marble
55ff161ed5 Refactored a couple of files from codeStyle to code_style. 2016-09-17 20:31:46 -05:00
Arthur Marble
dd4907c985 Refactor isClosed_ to is_closed and relativeContentType to relative_content_type. 2016-09-17 20:31:46 -05:00
Arthur Marble
e7ffbf819a Replace typeString with type_string. 2016-09-17 20:31:46 -05:00
Arthur Marble
5ce3510a50 Refactored metaKey to meta_key where possible 2016-09-17 20:31:46 -05:00
Arthur Marble
bdbc04409d This commit refactors altKey to alt_key when possible. 2016-09-17 20:31:46 -05:00
Arthur Marble
fd0622a741 This commit refactors shiftKey to shift_key where possible. 2016-09-17 20:31:46 -05:00
Arthur Marble
77170a14bc This commit refactors ctrlKey to ctrl_key wherever possible. 2016-09-17 20:31:46 -05:00
bors-servo
83f687a7be Auto merge of #13292 - creativcoder:extendable, r=jdm
Implement ExtendableEvent as base type for ServiceWorker events

<!-- Please describe your changes on the following line: -->
r? @jdm

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [X] These changes do not require tests because refactor

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13292)
<!-- Reviewable:end -->
2016-09-17 10:33:03 -05:00
Rahul Sharma
8b10cca91f implement ExtendableEvent as base type for ServiceWorker events 2016-09-17 20:58:46 +05:30
jmr0
cf21ea5641 altering pipeline visibility change logic 2016-09-17 09:10:43 -04:00
bors-servo
6ac9dfdd34 Auto merge of #13304 - frewsxcv:ownership, r=jdm
Don't require `PathBuf` ownership if we don't need it.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/13304)
<!-- Reviewable:end -->
2016-09-16 23:14:14 -05:00
Corey Farwell
3aa2ec653a Don't require PathBuf ownership if we don't need it. 2016-09-16 23:11:04 -04:00
bors-servo
2fb4dd9ec3 Auto merge of #12703 - sjmelia:12343_test_activation, r=Manishearth
Fix Issue 12343: Add pref-gated methods and test for activatable element

<!-- Please describe your changes on the following line: -->
Add methods to activatable elements; gated by a preference, for use in servo-specific WPT tests.

I cargo-culted over the "redundant check" from #12322, I don't really understand the possible exploit.

Obvious flaw is the copypasta for each element. I understand that the webidl codegen will produce a trait for ActivatableElement, but I can't see how I can provide a default implementation for this? I guess otherwise could be an improvement to have each element just delegate to an Enter.../Exit... method on the Activatable trait?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #12343 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

…states

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/12703)
<!-- Reviewable:end -->
2016-09-16 20:34:25 -05:00