Manish Goregaokar
cfa81e8b79
Refactor column index advancing into its own method
2018-02-16 16:01:50 -08:00
Manish Goregaokar
b72a50d50a
Pass down full ComputedValues to TableCellStyleInfo; use for correct color computation
2018-02-16 16:01:49 -08:00
Manish Goregaokar
21140e7a0a
Make TableCellStyleIterator operate on immutable flows
2018-02-16 16:01:49 -08:00
Manish Goregaokar
265a2ab2cc
Allow for build_display_list to be called immutably
2018-02-16 16:01:48 -08:00
Manish Goregaokar
5cd15eeb54
Don't redraw backgrounds that we've already drawn
2018-02-16 16:01:47 -08:00
Manish Goregaokar
db6ec58e6b
Generate display lists for table cells during display list generation for their table parent
2018-02-16 16:01:46 -08:00
Manish Goregaokar
6232846699
Add stacking_relative_border_box_for_display_list
2018-02-16 16:01:46 -08:00
Manish Goregaokar
f7ac5d712f
Add build_display_list_for_background_if_applicable_with_background
2018-02-16 16:01:45 -08:00
Manish Goregaokar
f3531d1d35
Factor out BlockFlow::background_border_section()
2018-02-16 16:01:44 -08:00
Manish Goregaokar
836e59e5b6
Handle colspan in TableCellStyleIterator
2018-02-16 16:01:44 -08:00
Manish Goregaokar
6317c44ab4
Add Iterator impl for TableCellStyleIterator
2018-02-16 16:01:43 -08:00
Manish Goregaokar
1dd5bed031
Create TableCellStyleIterator
2018-02-16 16:01:42 -08:00
Manish Goregaokar
35be0c50f6
Add TableRowAndGroupIterator
2018-02-16 16:01:41 -08:00
Manish Goregaokar
b416bb3aa7
Add get_column_styles for getting column structure and styles for a table
2018-02-16 16:01:41 -08:00
bors-servo
d423e54d58
Auto merge of #20065 - emilio:note-stuff, r=nox
...
style: Cleanup GeckoElement::note_explicit_hints
What it's doing is not so complicated.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20065 )
<!-- Reviewable:end -->
2018-02-16 15:33:48 -05:00
bors-servo
d092c2e877
Auto merge of #20064 - emilio:cleanup-length-parsing, r=nox
...
style: Trivially cleanup length parsing.
Mostly formatting signatures properly, but also removing useless functions and
stuff.
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20064 )
<!-- Reviewable:end -->
2018-02-16 14:43:50 -05:00
bors-servo
e97693ee09
Auto merge of #20062 - servo:iamroot, r=emilio
...
Remove a single use of rooted_vec
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20062 )
<!-- Reviewable:end -->
2018-02-16 13:09:28 -05:00
Emilio Cobos Álvarez
2c03609dc1
style: Cleanup GeckoElement::note_explicit_hints.
...
What it's doing is not so complicated.
2018-02-16 19:00:21 +01:00
Emilio Cobos Álvarez
36e6d57aee
style: Inline maybe_restyle, since it only has one caller.
2018-02-16 19:00:21 +01:00
bors-servo
4454e81878
Auto merge of #20041 - paavininanda:mutflags, r=jdm
...
Added extra bool in Window object to know about its Mutation Observers
<!-- Please describe your changes on the following line: -->
- Added Cell<bool> type variable in Window object to know whether its mutation observers are present/absent
- Added get and set functions for this variable
- Added supporting test files to check for performance
---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #16936 .
<!-- Either: -->
- [x] There are tests for these changes, but these are manual tests for checking correctness of added code
<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->
<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20041 )
<!-- Reviewable:end -->
2018-02-16 12:16:55 -05:00
Nupur Baghel
a1fd6c39a2
Added extra bool in Window object to know about its Mutation Observers
2018-02-16 21:52:29 +05:30
Emilio Cobos Álvarez
fdc8405330
style: Trivially cleanup length parsing.
...
Mostly formatting signatures properly, but also removing useless functions and
stuff.
2018-02-16 16:04:19 +01:00
Emilio Cobos Álvarez
a6afaf2428
style: Update bindings.
2018-02-16 15:21:08 +01:00
Anthony Ramine
b6b6b46568
Remove a single use of rooted_vec
2018-02-16 14:02:05 +01:00
Emilio Cobos Álvarez
5e64cb3516
style: Make XBL / Shadow DOM use something more light-weight than a Stylist.
...
It's just a struct aggregating stylesheets + CascadeData, with a quirks_mode
parameter because XBL sucks so bad.
Bug: 1436059
Reviewed-by: xidorn
MozReview-Commit-ID: 7q99tSNXo0K
2018-02-16 13:42:36 +01:00
bors-servo
a6113af873
Auto merge of #20054 - ferjm:innertext.setter, r=emilio
...
Implement element.innerText setter
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #16107
- [X] There are tests for these changes
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20054 )
<!-- Reviewable:end -->
2018-02-16 05:38:38 -05:00
Fernando Jiménez Moreno
d64bf623f6
Implement element.innerText setter
2018-02-16 11:20:53 +01:00
bors-servo
ff58cb0a3f
Auto merge of #20056 - emilio:moz-user-input, r=bz
...
style: Remove -moz-user-input: enabled / disabled.
https://groups.google.com/d/msg/mozilla.dev.platform/E6tfP__wkwg/YVW6nPX9CQA
Bug: 1405087
Reviewed-by: bz
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20056 )
<!-- Reviewable:end -->
2018-02-15 14:57:52 -05:00
Anthony Ramine
d8c43ac855
Animate NonNegativeLength as its inner type
2018-02-15 12:03:02 +01:00
Anthony Ramine
52f0fcabad
Properly implement ToAnimatedZero for BorderSpacing
2018-02-15 12:03:01 +01:00
Anthony Ramine
b17fea1d7f
Make KeywordInfo generic
2018-02-15 12:03:00 +01:00
Anthony Ramine
aea66a9fb6
Move FontTag to the generic module
2018-02-15 12:03:00 +01:00
Emilio Cobos Álvarez
db689c85c2
style: Update bindings.
2018-02-15 11:50:50 +01:00
Emilio Cobos Álvarez
3378d29548
style: Also nix -moz-user-input: enabled.
...
It only has one use, has the same effect that "auto", and should have no effect
in <a> elements anyway (plus it's not overridden or used in that file at all
anyway), so we can remove its only use instead.
I can also change that use to "auto" if you want, but bug 760876 doesn't mention
-moz-user-input at all, so I think this is quite useless...
See the intent to unship for research on out of the tree usage:
https://groups.google.com/d/msg/mozilla.dev.platform/E6tfP__wkwg/YVW6nPX9CQAJ
Bug: 1405087
Reviewed-by: bz
MozReview-Commit-ID: 8EzQlzu9drE
2018-02-15 11:49:24 +01:00
Emilio Cobos Álvarez
5c19eb5998
style: Nix -moz-user-input: disabled.
...
It does nothing, and there's only one use of it anyway.
See the intent to unship for research on out of the tree usage:
https://groups.google.com/d/msg/mozilla.dev.platform/E6tfP__wkwg/YVW6nPX9CQAJ
Bug: 1405087
Reviewed-by: bz
MozReview-Commit-ID: 5XnsewYdvgQ
2018-02-15 11:49:00 +01:00
Emilio Cobos Álvarez
502b734a1a
style: Update a couple other spec links.
2018-02-14 20:29:40 +01:00
Emilio Cobos Álvarez
808102035e
style: Deindent and reuse some more code in single_value_to_css.
...
This method is a hack on its own, let's try to scope it a bit...
2018-02-14 20:29:11 +01:00
Emilio Cobos Álvarez
f3e38aca1b
style: Move the shorthand serialization code to its own function.
2018-02-14 20:29:10 +01:00
Emilio Cobos Álvarez
5c2ac8cf8b
style: Deindent a giant loop guarded by an !is_empty() condition.
2018-02-14 20:29:09 +01:00
Emilio Cobos Álvarez
ba7629a17e
style: Update a spec link.
2018-02-14 20:29:09 +01:00
Emilio Cobos Álvarez
1548520710
style: Move most of allowed_in to NonCustomPropertyId.
...
Also simplify the servo property id to gecko property id conversion to be faster
and less repetitive.
2018-02-14 19:10:28 +01:00
bors-servo
112bb55b92
Auto merge of #20040 - servo:derive-all-the-things, r=emilio
...
Change how some clamped types are animated
<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20040 )
<!-- Reviewable:end -->
2018-02-14 05:48:10 -05:00
Xidorn Quan
ea8a952d51
Remove initial values from font-face descriptors
...
They are not used anyway.
2018-02-14 17:35:57 +11:00
Xidorn Quan
6ffa888dd6
Integrate font-variation-settings descriptor with stylo
2018-02-14 11:15:58 +11:00
bors-servo
6cb78057bb
Auto merge of #20022 - Eijebong:syn, r=nox
...
Update syn, quote and synstructure
Right now they're duplicated because we need a new serde release (ping @dtolnay), a new cssparser release (ping @SimonSapin) and a new release of html5ever with https://github.com/servo/html5ever/pull/336
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/20022 )
<!-- Reviewable:end -->
2018-02-13 11:15:54 -05:00
Anthony Ramine
056abcbf5f
Change AnimatedValue for GreaterThanOrEqualToOneNumber to CSSFloat
2018-02-13 16:12:31 +01:00
Anthony Ramine
f89ebf7fe9
Change AnimatedValue for NonNegativeNumber to CSSFloat
2018-02-13 16:12:30 +01:00
Anthony Ramine
da5acc81d2
Change AnimatedValue for NonNegativeLengthOrPercentage to its inner type
2018-02-13 16:12:29 +01:00
Anthony Ramine
b79dc269f7
Change AnimatedValue for PositiveInteger to CSSInteger
2018-02-13 16:12:29 +01:00
bors-servo
b1d3d6f632
Auto merge of #19975 - paulrouget:killbhtml, r=mbrubeck,emilio
...
Kill browserhtml
Fixes https://github.com/servo/servo/issues/19971
<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg " height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/19975 )
<!-- Reviewable:end -->
2018-02-13 04:54:47 -05:00