mirror of
https://github.com/servo/servo.git
synced 2025-09-10 06:58:21 +01:00
52720 commits
| Author | SHA1 | Message | Date | |
|---|---|---|---|---|
Sebastian C
|
d3809c1024
|
fix: Store channel reference in CookieStore to prevent panic on unload (#39171)
CookieStore sets up a route with the resource threads to handle async communication and needs to later unregister itself when the page unloads. When attempting to do this in the `Drop` of CookieStore we panic attempting to retrieve the channel via `self.global().resource_threads()` because global is already null. This change stores a reference to the core resource thread in the object to send the unregister on `Drop`. Testing: manual testing for crash fix, behavior should be unchanged Signed-off-by: Sebastian C <sebsebmc@gmail.com> |
||
|
Sebastian C
|
7ce0bd8575
|
script: Remove CookieListItem fields that were removed in the spec (#39170)
The spec removed all fields from CookieListItem except for name and value Testing: WPT tests cover this already. Signed-off-by: Sebastian C <sebsebmc@gmail.com> |
||
Oriol Brufau
|
5b9a23ebdb
|
layout: Add method to retrieve only the first LayoutBoxBase of a box (#39165)
A LayoutBox typically has one LayoutBoxBase, or none in the case of `LayoutBox::DisplayContents`. However, `LayoutBox::InlineLevel` can contain multiple inline items, each one with its base. But since things like the style or the fragment flags should be the same for all of them, getting the first base is sometimes enough. Testing: not needed, no change in behavior. Signed-off-by: Oriol Brufau <obrufau@igalia.com> |
||
|
Oriol Brufau
|
0f9f507b46
|
layout: Fix scrollParent to skip ancestors with display: contents (#39153)
When encountering such an ancestor, we were returning null instead of skipping it. Testing: Adding new subtest for this. And while I'm at it, another one for the root element, unrelated to this fix. Signed-off-by: Oriol Brufau <obrufau@igalia.com> |
||
shanehandley
|
cf1f64e73f
|
script: remove wpt test added in #39079 (#39164)
Removes a test related to autoplay and sandboxing which will always fail. In https://github.com/servo/servo/pull/39079 I introduced a wpt to test autoplay functionality, but the test was flawed in its approach - shortly after merge, myself and @TimvdLippe found that this test would simulataneously require scripts to be enabled, as well as disabled for the test to pass. This slipped past me becuase we hadn't correctly implemented whether scripting was enabled yet in Servo. Testing: Removes a single WPT - this test has not been merged upstream. Signed-off-by: Shane Handley <shanehandley@fastmail.com> |
||
dependabot[bot]
|
0d58c2be76
|
build(deps): bump windows-sys from 0.59.0 to 0.61.0 (#39156)
Bumps [windows-sys](https://github.com/microsoft/windows-rs) from 0.59.0 to 0.61.0. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/microsoft/windows-rs/releases">windows-sys's releases</a>.</em></p> <blockquote> <h2>61</h2> <p>Major crate updates:</p> <ul> <li><code>windows</code> 0.59.0</li> <li><code>windows-core</code> 0.59.0 <ul> <li><code>windows-implement</code> 0.59.0</li> <li><code>windows-interface</code> 0.59.0</li> </ul> </li> <li><code>windows-targets</code> 0.53.0 <ul> <li><code>windows_i686_msvc</code> 0.53.0</li> <li><code>windows_x86_64_msvc</code> 0.53.0</li> <li><code>windows_aarch64_msvc</code> 0.53.0</li> <li><code>windows_i686_gnu</code> 0.53.0</li> <li><code>windows_x86_64_gnu</code> 0.53.0</li> <li><code>windows_i686_gnullvm</code> 0.53.0</li> <li><code>windows_x86_64_gnullvm</code> 0.53.0</li> <li><code>windows_aarch64_gnullvm</code> 0.53.0</li> </ul> </li> <li><code>windows-bindgen</code> 0.59.0</li> <li><code>windows-registry</code> 0.4.0</li> <li><code>windows-result</code> 0.3.0</li> <li><code>windows-strings</code> 0.3.0</li> <li><code>cppwinrt</code> 0.2.0</li> </ul> <p>Minor crate updates:</p> <ul> <li><code>windows-version</code> 0.1.2</li> </ul> <p>Excluded:</p> <ul> <li><code>windows-sys</code> 0.59.0</li> </ul> <p>Things to keep in mind:</p> <ul> <li> <p>The tag/release names no longer map directly to the crate versions, so to <a href="https://github.com/microsoft/windows-rs/tree/master/crates/samples">find samples</a> for a particular release requires looking at <a href="https://github.com/microsoft/windows-rs/releases">the releases</a> page and finding the release that most recently updated a particular crate.</p> </li> <li> <p>The <code>windows-bindgen</code> crate includes the major code generation overhaul that brings many improvements - be sure to check out the PR description for more information. The resulting code gen depends on the new version of <code>windows-core</code> and its dependencies, unless you include the <code>--sys</code> option. <a href="https://redirect.github.com/microsoft/windows-rs/issues/3359">#3359</a></p> </li> <li> <p>The <code>cppwinrt</code> crate constitutes a major update due to streamlining the error handling. <a href="https://redirect.github.com/microsoft/windows-rs/issues/3415">#3415</a></p> </li> <li> <p>The <code>windows-registry</code>, <code>windows-strings,</code> and <code>windows-result</code> crates are also major version updates since they include small breaking changes.</p> </li> <li> <p>The <code>windows-targets</code> crate finally receives a major version update, the first in over a year. This is due to <a href="https://redirect.github.com/microsoft/windows-rs/issues/3359">#3359</a> and <a href="https://redirect.github.com/microsoft/windows-rs/issues/3342">#3342</a> potentially introducing breaking changes. Although unlikely, these updates introduced sufficient changes that make it hard to ensure that the <code>windows-targets</code> libs don't break existing code. As we're updating <code>windows-targets</code> anyway, I took the liberty to bump the MSRV to 1.60 - to match the latest version of <code>windows-sys</code> - and remove the old but unused doc macro feature. Both remained for compatibility with very old dependents of the <code>windows-targets</code> crate.</p> </li> <li> <p>The <code>windows-version</code> crate receives a minor update to update its dependency on the <code>windows-targets</code> crate.</p> </li> <li> <p>Beyond these specifics, this update is the culmination of around 6 months worth of work on the <code>windows-rs</code> project. The biggest improvements comes from the new code generation engine, but many other improvements are now also available for production. This includes support for many new lints, warnings, and suggestions provided by the Rust toolchain; much smaller code gen thanks to deriving many more traits; more efficient code gen; major improvements to WinRT type system and implementation support; more robust and consistent error handling; stock collection and async support; improved support for class hierarchies; and much more!</p> </li> </ul> <p>In addition to "what's changed" below, check out what's changed for notes for <a href="https://github.com/microsoft/windows-rs/releases/tag/0.60.0">0.60.0</a> and <a href="https://github.com/microsoft/windows-rs/releases/tag/0.59.0">0.59.0</a> for additional changes that roll up to the crates published as part of this release.</p> <h2>What's Changed</h2> <ul> <li>Remove improper_ctypes workaround by <a href="https://github.com/ChrisDenton"><code>@ChrisDenton</code></a> in <a href="https://redirect.github.com/microsoft/windows-rs/pull/3296">microsoft/windows-rs#3296</a></li> </ul> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Narfinger
|
ed66e0b0ca
|
servoshell: Replace getopts with bpaf for argument parsing (#37194)
This includes some small refactoring and some small breaking changes as listed below. Other than these I tried to keep the functionality exactly the same but because in the old code the parsing and settings of preferences was intermingled it was difficult to figure out. Small Breaking: - Size and resources-path were unused but appeared in the help. - soft-fail and hard-fail: Soft-fail flag got removed because it is too difficult to keep both. The default is now soft-fail and hard-fail can be enabled. - The help strings are obviously formatted differently now. - -V does not work anymore but -v and --version. Ideally, we want to have the ServoShellPreferences and Preferences be directly the Argument structure but that needs a bit more discussion because it would break backwards compatibility with the commandline. This increases the binary size by ~280kb. Testing: The testcases are still working but they do not cover much. I added a unit test for the -p flag because it is the most difficult to parse in general. Fixes: This will fix a small number of various parsing misshaps. It will also show if we are removing an option via unused lint. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com> |
||
Kingsley Yung
|
b29eab0ffe
|
script: Re-implement evaluate_key_path_on_value in IndexedDB (#38847)
The current implementation of evaluate_key_path_on_value was translated from gecko, and it is incomplete. The unimplemented part occurs many crashes in WPT tests. This PR re-implements it according to the spec. It should eliminate many crashed WPT tests, and increase the code readability. Testing: Update WPT test expectation Fixes: #38817 partially, and #25325 --------- Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev> |
||
Euclid Ye
|
ebc1282c7a
|
webdriver: Update .ini to mark unstable subtests in accept_alert/accept.py, forward/forward.py, perform_actions/pointer_mouse.py, send_alert_text/send.py (#39159)
Few webdriver subtests are quite unstable. But it is an overkill to mark the entire test as intermittent, as the CI would permit buggy PRs that sabotage other stable subtests. This PR mark these subtests and closes the related intermittent issues. Fixes: #39158 Fixes: #39117 Fixes: #39121 Fixes: #39154 --------- Signed-off-by: Euclid Ye <euclid.ye@huawei.com> |
||
Tim van der Lippe
|
deb7f802df
|
Refactor loading methods to align with specification (#39146)
This is in preparation of being able to do mime sniffing on the response data. For that, we first need to introduce separate methods so that we can decouple them from process_response. In doing so, we introduce a NavigationParams which mimics what the spec intents. The spec stores different data (policy container instead of csp list and response instead of content-type), but it is similar enough. Part of #14024 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com> |
||
|
shanehandley
|
989c0d8994
|
script: Implement document's active sandboxing flag set (#39079)
Implements document's active sandboxing flags. These are currently populated only from CSP-derived sandboxing flags for a new document, when defined in the CSP. Testing: 1 new pass, and some new wpt's are added to test points in the spec where these flags influence behaviour. Signed-off-by: Shane Handley <shanehandley@fastmail.com> |
||
|
Kingsley Yung
|
f722419861
|
webcrypto: Reduce usage of standalone helper functions for JWK format (#39084)
Reduce the reliance on standalone helper functions for handling JWK format. Instead, those functionalities are now integrated into the `JsonWebKey` type generated by script_binding, via the local trait `JsonWebKeyExt`, for internal use. The `parse_jwk` function remains for now. It will be removed when once we refactor `SubtleCrypto::ImportKey` to support a more generic approach across different cryptographic algorithms. Testing: Refactoring. Existing WPT tests should suffice. --------- Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev> |
||
|
dependabot[bot]
|
ae5b40ebf9
|
build(deps): bump the egui-related group with 7 updates (#39155)
Bumps the egui-related group with 7 updates: | Package | From | To | | --- | --- | --- | | [egui](https://github.com/emilk/egui) | `0.32.1` | `0.32.2` | | [egui-winit](https://github.com/emilk/egui) | `0.32.1` | `0.32.2` | | [egui_glow](https://github.com/emilk/egui) | `0.32.1` | `0.32.2` | | [ecolor](https://github.com/emilk/egui) | `0.32.1` | `0.32.2` | | [emath](https://github.com/emilk/egui) | `0.32.1` | `0.32.2` | | [epaint](https://github.com/emilk/egui) | `0.32.1` | `0.32.2` | | [epaint_default_fonts](https://github.com/emilk/egui) | `0.32.1` | `0.32.2` | Updates `egui` from 0.32.1 to 0.32.2 <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/emilk/egui/releases">egui's releases</a>.</em></p> <blockquote> <h2>0.32.2 - Ui::place, Harness::mask and more bug fixes</h2> <p>egui is an easy-to-use immediate mode GUI for Rust that runs on both web and native.</p> <p>Try it now: <a href="https://www.egui.rs/">https://www.egui.rs/</a></p> <p>egui development is sponsored by <a href="https://www.rerun.io/">Rerun</a>, a startup building an SDK for visualizing streams of multimodal data.</p> <h3>Add <code>Ui::place</code></h3> <p><code>Ui::place</code> is similar to <code>Ui::put</code>, but it doesn't update the current <code>Ui</code>s cursor. This is very useful when using the new <code>Atom</code>s or making badge-like widgets. The following breaks with <code>Ui::put</code> but works just fine with <code>Ui::place</code>:</p> <!-- raw HTML omitted --> <!-- raw HTML omitted --> <h3>Add <code>Harness::mask</code></h3> <p><code>Harness::mask</code> allows for simple masking of <code>Rect</code>s you don't want to be visible in snapshot test images. The rect will be masked with a ugly color to make it obvious whats going on:</p> <!-- raw HTML omitted --> <h2>egui</h2> <ul> <li>Add <code>Ui::place</code>, to place widgets without changing the cursor <a href="https://redirect.github.com/emilk/egui/pull/7359">#7359</a> by <a href="https://github.com/lucasmerlin"><code>@lucasmerlin</code></a></li> <li>Fix: <code>SubMenu</code> should not display when ui is disabled <a href="https://redirect.github.com/emilk/egui/pull/7428">#7428</a> by <a href="https://github.com/ozwaldorf"><code>@ozwaldorf</code></a></li> <li>Remove line breaks when pasting into single line TextEdit <a href="https://redirect.github.com/emilk/egui/pull/7441">#7441</a> by <a href="https://github.com/YgorSouza"><code>@YgorSouza</code></a></li> <li>Panic mutexes that can't lock for 30 seconds, in debug builds <a href="https://redirect.github.com/emilk/egui/pull/7468">#7468</a> by <a href="https://github.com/emilk"><code>@emilk</code></a></li> <li>Fix: prevent calendar popup from closing on dropdown change <a href="https://redirect.github.com/emilk/egui/pull/7409">#7409</a> by <a href="https://github.com/AStrizh"><code>@AStrizh</code></a></li> </ul> <h2>egui_extras</h2> <ul> <li>Fix memory leak when <code>forget_image</code> is called while loading <a href="https://redirect.github.com/emilk/egui/pull/7380">#7380</a> by <a href="https://github.com/Vanadiae"><code>@Vanadiae</code></a></li> <li>Fix deadlock in <code>ImageLoader</code>, <code>FileLoader</code>, <code>EhttpLoader</code> <a href="https://redirect.github.com/emilk/egui/pull/7494">#7494</a> by <a href="https://github.com/lucasmerlin"><code>@lucasmerlin</code></a></li> </ul> <h2>egui_kittest</h2> <ul> <li>Allow masking widgets in kittest snapshots <a href="https://redirect.github.com/emilk/egui/pull/7467">#7467</a> by <a href="https://github.com/lucasmerlin"><code>@lucasmerlin</code></a></li> </ul> <h2>epaint</h2> <ul> <li>Panic mutexes that can't lock for 30 seconds, in debug builds <a href="https://redirect.github.com/emilk/egui/pull/7468">#7468</a> by <a href="https://github.com/emilk"><code>@emilk</code></a></li> <li>Skip zero-length layout job sections <a href="https://redirect.github.com/emilk/egui/pull/7430">#7430</a> by <a href="https://github.com/HactarCE"><code>@HactarCE</code></a></li> </ul> <h2>Unsorted commits</h2> <!-- raw HTML omitted --> </blockquote> <p>... (truncated)</p> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/emilk/egui/blob/0.32.2/CHANGELOG.md">egui's changelog</a>.</em></p> <blockquote> <h2>0.32.2 - 2025-09-04</h2> <ul> <li>Fix: <code>SubMenu</code> should not display when ui is disabled <a href="https://redirect.github.com/emilk/egui/pull/7428">#7428</a> by <a href="https://github.com/ozwaldorf"><code>@ozwaldorf</code></a></li> <li>Remove line breaks when pasting into single line TextEdit <a href="https://redirect.github.com/emilk/egui/pull/7441">#7441</a> by <a href="https://github.com/YgorSouza"><code>@YgorSouza</code></a></li> <li>Panic mutexes that can't lock for 30 seconds, in debug builds <a href="https://redirect.github.com/emilk/egui/pull/7468">#7468</a> by <a href="https://github.com/emilk"><code>@emilk</code></a></li> <li>Add <code>Ui::place</code>, to place widgets without changing the cursor <a href="https://redirect.github.com/emilk/egui/pull/7359">#7359</a> by <a href="https://github.com/lucasmerlin"><code>@lucasmerlin</code></a></li> <li>Fix: prevent calendar popup from closing on dropdown change <a href="https://redirect.github.com/emilk/egui/pull/7409">#7409</a> by <a href="https://github.com/AStrizh"><code>@AStrizh</code></a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Martin Robinson
|
e5fbb31452
|
script: Make get_property_jsval a safe function (#39137)
Accept the safe `JSContext` wraper to this function so that it can be safe. Some callers also become safe as well. Testing: This does not change behavior and is thus covered by existing tests. Fixes: #39129. Signed-off-by: Martin Robinson <mrobinson@igalia.com> |
||
|
Oriol Brufau
|
589a750cac
|
Upgrade Stylo to 2025-09-02 (#39150)
This continues #38429 Changelog: - Upstream: |
||
Shubham Gupta
|
40ced5bb61
|
Enable viewport <meta> tag support for mobile platforms only (#39133)
Enable viewport `<meta>` tag support for mobile platforms only. _Reference:_ [web_preferences.h](https://source.chromium.org/chromium/chromium/src/+/main:third_party/blink/public/common/web_preferences/web_preferences.h;l=158?) _Todo: Enable for when requested desktop site:_ [web_contents_impl.cc](https://source.chromium.org/chromium/chromium/src/+/main:content/browser/web_contents/web_contents_impl.cc;l=3752?) Testing: Tested Manually Fixes: #39002 Signed-off-by: Shubham Gupta <shubham13297@gmail.com> |
||
lumiscosity
|
c7ca281f44
|
script: implement setMatrixValue for DOMMatrix (#39148)
Even more progress on the geometry suite. Almost there! Testing: Covered by WPT (css/geometry). Signed-off-by: lumiscosity <averyrudelphe@gmail.com> |
||
|
dependabot[bot]
|
f3a8ad30f1
|
build(deps): bump cc from 1.2.34 to 1.2.35 (#39136)
Bumps [cc](https://github.com/rust-lang/cc-rs) from 1.2.34 to 1.2.35. <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rust-lang/cc-rs/blob/main/CHANGELOG.md">cc's changelog</a>.</em></p> <blockquote> <h2><a href="https://github.com/rust-lang/cc-rs/compare/cc-v1.2.34...cc-v1.2.35">1.2.35</a> - 2025-09-01</h2> <h3>Fixed</h3> <ul> <li>fix building for aarch64-apple-visionos-sim on nightly (<a href="https://redirect.github.com/rust-lang/cc-rs/pull/1534">#1534</a>)</li> <li>fix tests apple_sdkroot_wrong (<a href="https://redirect.github.com/rust-lang/cc-rs/pull/1530">#1530</a>)</li> </ul> <h3>Other</h3> <ul> <li>Regenerate target info (<a href="https://redirect.github.com/rust-lang/cc-rs/pull/1536">#1536</a>)</li> <li>Optimize Tool::to_command (<a href="https://redirect.github.com/rust-lang/cc-rs/pull/1535">#1535</a>)</li> <li>Extract find-msvc-tools (<a href="https://redirect.github.com/rust-lang/cc-rs/pull/1531">#1531</a>)</li> <li>Add prefer_clang_cl_over_msvc (<a href="https://redirect.github.com/rust-lang/cc-rs/pull/1516">#1516</a>)</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Kingsley Yung
|
925b7c5dad
|
script: Queue a microtask in wait_for_all of promise type (#39108)
In the wait-for-all algorithm of the IDL promise type, we need to queue a microtask to perform successSteps given « » if total is 0. This step was previously implemented in a workaround, which perform successSteps immediately. This patch properly queue the microtask, and remove the workaround. Testing: Refactoring only. Existing tests are enough. Fixes: #37259 --------- Signed-off-by: Kingsley Yung <kingsley@kkoyung.dev> |
||
|
dependabot[bot]
|
ae2d9674e8
|
build(deps): bump log from 0.4.27 to 0.4.28 (#39135)
Bumps [log](https://github.com/rust-lang/log) from 0.4.27 to 0.4.28. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/rust-lang/log/releases">log's releases</a>.</em></p> <blockquote> <h2>0.4.28</h2> <h2>What's Changed</h2> <ul> <li>ci: drop really old trick and ensure MSRV for all feature combo by <a href="https://github.com/tisonkun"><code>@tisonkun</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/676">rust-lang/log#676</a></li> <li>chore: fix some typos in comment by <a href="https://github.com/xixishidibei"><code>@xixishidibei</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/677">rust-lang/log#677</a></li> <li>Unhide <code>#[derive(Debug)]</code> in example by <a href="https://github.com/ZylosLumen"><code>@ZylosLumen</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/688">rust-lang/log#688</a></li> <li>Chore: delete compare_exchange method for AtomicUsize on platforms without atomics by <a href="https://github.com/HaoliangXu"><code>@HaoliangXu</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/690">rust-lang/log#690</a></li> <li>Add <code>increment_severity()</code> and <code>decrement_severity()</code> methods for <code>Level</code> and <code>LevelFilter</code> by <a href="https://github.com/nebkor"><code>@nebkor</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/692">rust-lang/log#692</a></li> <li>Prepare for 0.4.28 release by <a href="https://github.com/KodrAus"><code>@KodrAus</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/695">rust-lang/log#695</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/xixishidibei"><code>@xixishidibei</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/log/pull/677">rust-lang/log#677</a></li> <li><a href="https://github.com/ZylosLumen"><code>@ZylosLumen</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/log/pull/688">rust-lang/log#688</a></li> <li><a href="https://github.com/HaoliangXu"><code>@HaoliangXu</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/log/pull/690">rust-lang/log#690</a></li> <li><a href="https://github.com/nebkor"><code>@nebkor</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/log/pull/692">rust-lang/log#692</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/rust-lang/log/compare/0.4.27...0.4.28">https://github.com/rust-lang/log/compare/0.4.27...0.4.28</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/rust-lang/log/blob/master/CHANGELOG.md">log's changelog</a>.</em></p> <blockquote> <h2>[0.4.28] - 2025-09-02</h2> <h2>What's Changed</h2> <ul> <li>ci: drop really old trick and ensure MSRV for all feature combo by <a href="https://github.com/tisonkun"><code>@tisonkun</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/676">rust-lang/log#676</a></li> <li>Chore: delete compare_exchange method for AtomicUsize on platforms without atomics by <a href="https://github.com/HaoliangXu"><code>@HaoliangXu</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/690">rust-lang/log#690</a></li> <li>Add <code>increment_severity()</code> and <code>decrement_severity()</code> methods for <code>Level</code> and <code>LevelFilter</code> by <a href="https://github.com/nebkor"><code>@nebkor</code></a> in <a href="https://redirect.github.com/rust-lang/log/pull/692">rust-lang/log#692</a></li> </ul> <h2>New Contributors</h2> <ul> <li><a href="https://github.com/xixishidibei"><code>@xixishidibei</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/log/pull/677">rust-lang/log#677</a></li> <li><a href="https://github.com/ZylosLumen"><code>@ZylosLumen</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/log/pull/688">rust-lang/log#688</a></li> <li><a href="https://github.com/HaoliangXu"><code>@HaoliangXu</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/log/pull/690">rust-lang/log#690</a></li> <li><a href="https://github.com/nebkor"><code>@nebkor</code></a> made their first contribution in <a href="https://redirect.github.com/rust-lang/log/pull/692">rust-lang/log#692</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/rust-lang/log/compare/0.4.27...0.4.28">https://github.com/rust-lang/log/compare/0.4.27...0.4.28</a></p> <h3>Notable Changes</h3> <ul> <li>MSRV is bumped to 1.61.0 in <a href="https://redirect.github.com/rust-lang/log/pull/676">rust-lang/log#676</a></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
Martin Robinson
|
fa7d6d4004
|
script: Modify Element::determine_scroll_into_view_position to take a ScrollingBox (#39107)
There is no need to separate the two kinds of scrolling boxes into `Element` and `Viewport` more than once. This also eliminates a potentially panicking `unwrap()`. Testing: This doesn't change behavior and is thus covered by existing tests. Signed-off-by: Martin Robinson <mrobinson@igalia.com> |
||
|
Tim van der Lippe
|
dab195ca80
|
Hookup mime classifier to main document loader (#39109)
While we don't perform any sniffing yet, it does now check all relevant mime types. Before, we would only check specific versions of specific mime types. However, the specification is more elaborate, which MimeClassifier already handles. There are two new test failures, but they actually fail in the same way in other browsers. These tests are still being discussed what the correct behavior should be [1] Part of #14024 [1]: https://github.com/whatwg/mimesniff/issues/189#issuecomment-2081559661 --------- Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com> |
||
|
lumiscosity
|
a44b98c358
|
script: preserve 2D on DOMMatrix invert (#39113)
More small geometry fixes. Testing: Covered by WPT (css/geometry/DOMMatrix-invert-preserves-2d.html) --------- Signed-off-by: lumiscosity <averyrudelphe@gmail.com> |
||
|
Euclid Ye
|
ff8be71335
|
font: Remove unused FontTable constructor for Windows (#39130)
#39112 restricts accessibility for some font functions, exposing some functions that haven't been used for a long time. Now it is detected by Lint as dead code. Signed-off-by: Euclid Ye <euclid.ye@huawei.com> |
||
|
Tim van der Lippe
|
fc6bee8b81
|
Move Element::matches_environment to MediaList (#39034)
It more logically matches `MediaList`, and it allows us to call this method with a document. This is required when parsing Link headers, as they don't have an associated element, but they do have a document. Part of #35035 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com> |
||
Josh Matthews
|
aac6aa6c70
|
servoshell: Add button to toggle experimental web platform features. (#39125)
This makes it easier to experiment with the impact of experimental features when browsing around in servoshell. The toggle is global and causes all webviews to reload with the new preference values. Testing: Manually tested; no UI testing for servoshell. Not enabled: <img width="317" height="82" alt="Screenshot 2025-09-03 at 9 34 30 PM" src="https://github.com/user-attachments/assets/ca521ad5-ce1b-434e-a0c3-ea1b75d76d53" /> Enabled: <img width="320" height="82" alt="Screenshot 2025-09-03 at 9 34 36 PM" src="https://github.com/user-attachments/assets/7b6529b5-1055-4ae0-924a-96d57e115714" /> Signed-off-by: Josh Matthews <josh@joshmatthews.net> |
||
|
dependabot[bot]
|
912b83b58f
|
build(deps): bump uuid from 1.18.0 to 1.18.1 (#39116)
Bumps [uuid](https://github.com/uuid-rs/uuid) from 1.18.0 to 1.18.1. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/uuid-rs/uuid/releases">uuid's releases</a>.</em></p> <blockquote> <h2>v1.18.1</h2> <h2>What's Changed</h2> <ul> <li>Unsafe cleanup by <a href="https://github.com/KodrAus"><code>@KodrAus</code></a> in <a href="https://redirect.github.com/uuid-rs/uuid/pull/841">uuid-rs/uuid#841</a></li> <li>Prepare for 1.18.1 release by <a href="https://github.com/KodrAus"><code>@KodrAus</code></a> in <a href="https://redirect.github.com/uuid-rs/uuid/pull/842">uuid-rs/uuid#842</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/uuid-rs/uuid/compare/v1.18.0...v1.18.1">https://github.com/uuid-rs/uuid/compare/v1.18.0...v1.18.1</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
3ac81a994a
|
build(deps): bump deranged from 0.5.2 to 0.5.3 (#39120)
Bumps [deranged](https://github.com/jhpratt/deranged) from 0.5.2 to 0.5.3. <details> <summary>Commits</summary> <ul> <li>See full diff in <a href="https://github.com/jhpratt/deranged/commits">compare view</a></li> </ul> </details> <br /> [](https://docs.github.com/en/github/managing-security-vulnerabilities/about-dependabot-security-updates#about-compatibility-scores) Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting `@dependabot rebase`. [//]: # (dependabot-automerge-start) [//]: # (dependabot-automerge-end) --- <details> <summary>Dependabot commands and options</summary> <br /> You can trigger Dependabot actions by commenting on this PR: - `@dependabot rebase` will rebase this PR - `@dependabot recreate` will recreate this PR, overwriting any edits that have been made to it - `@dependabot merge` will merge this PR after your CI passes on it - `@dependabot squash and merge` will squash and merge this PR after your CI passes on it - `@dependabot cancel merge` will cancel a previously requested merge and block automerging - `@dependabot reopen` will reopen this PR if it is closed - `@dependabot close` will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually - `@dependabot show <dependency name> ignore conditions` will show all of the ignore conditions of the specified dependency - `@dependabot ignore this major version` will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this minor version` will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself) - `@dependabot ignore this dependency` will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself) </details> Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> |
||
|
dependabot[bot]
|
325feaf48e
|
build(deps): bump bitflags from 2.9.3 to 2.9.4 (#39119)
Bumps [bitflags](https://github.com/bitflags/bitflags) from 2.9.3 to 2.9.4. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/bitflags/bitflags/releases">bitflags's releases</a>.</em></p> <blockquote> <h2>2.9.4</h2> <h2>What's Changed</h2> <ul> <li>Add Cargo features to readme by <a href="https://github.com/KodrAus"><code>@KodrAus</code></a> in <a href="https://redirect.github.com/bitflags/bitflags/pull/460">bitflags/bitflags#460</a></li> <li>Prepare for 2.9.4 release by <a href="https://github.com/KodrAus"><code>@KodrAus</code></a> in <a href="https://redirect.github.com/bitflags/bitflags/pull/461">bitflags/bitflags#461</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/bitflags/bitflags/compare/2.9.3...2.9.4">https://github.com/bitflags/bitflags/compare/2.9.3...2.9.4</a></p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/bitflags/bitflags/blob/main/CHANGELOG.md">bitflags's changelog</a>.</em></p> <blockquote> <h1>2.9.4</h1> <h2>What's Changed</h2> <ul> <li>Add Cargo features to readme by <a href="https://github.com/KodrAus"><code>@KodrAus</code></a> in <a href="https://redirect.github.com/bitflags/bitflags/pull/460">bitflags/bitflags#460</a></li> </ul> <p><strong>Full Changelog</strong>: <a href="https://github.com/bitflags/bitflags/compare/2.9.3...2.9.4">https://github.com/bitflags/bitflags/compare/2.9.3...2.9.4</a></p> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Simon Wülker
|
73e39cf085
|
fonts: Reduce the public API surface (#39112)
This change marks all items that are not used by other crates as `pub(crate)` instead of `pub`. Additionally, I've removed all code that turned out to be unused. I think most of it was used only by `layout-2013`. Testing: The correctness of these changes is verified by the compiler, so no tests are needed. --------- Signed-off-by: Simon Wülker <simon.wuelker@arcor.de> |
||
|
dependabot[bot]
|
8993235e8f
|
build(deps): bump clap from 4.5.46 to 4.5.47 (#39118)
Bumps [clap](https://github.com/clap-rs/clap) from 4.5.46 to 4.5.47. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/clap-rs/clap/releases">clap's releases</a>.</em></p> <blockquote> <h2>v4.5.47</h2> <h2>[4.5.47] - 2025-09-02</h2> <h3>Features</h3> <ul> <li>Added <code>impl FromArgMatches for ()</code></li> <li>Added <code>impl Args for ()</code></li> <li>Added <code>impl Subcommand for ()</code></li> <li>Added <code>impl FromArgMatches for Infallible</code></li> <li>Added <code>impl Subcommand for Infallible</code></li> </ul> <h3>Fixes</h3> <ul> <li><em>(derive)</em> Update runtime error text to match <code>clap</code></li> </ul> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/clap-rs/clap/blob/master/CHANGELOG.md">clap's changelog</a>.</em></p> <blockquote> <h2>[4.5.47] - 2025-09-02</h2> <h3>Features</h3> <ul> <li>Added <code>impl FromArgMatches for ()</code></li> <li>Added <code>impl Args for ()</code></li> <li>Added <code>impl Subcommand for ()</code></li> <li>Added <code>impl FromArgMatches for Infallible</code></li> <li>Added <code>impl Subcommand for Infallible</code></li> </ul> <h3>Fixes</h3> <ul> <li><em>(derive)</em> Update runtime error text to match <code>clap</code></li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
|
dependabot[bot]
|
bdb33591d5
|
build(deps): bump time from 0.3.42 to 0.3.43 (#39115)
Bumps [time](https://github.com/time-rs/time) from 0.3.42 to 0.3.43. <details> <summary>Release notes</summary> <p><em>Sourced from <a href="https://github.com/time-rs/time/releases">time's releases</a>.</em></p> <blockquote> <h2>v0.3.43</h2> <p>See the <a href="https://github.com/time-rs/time/blob/main/CHANGELOG.md">changelog</a> for details.</p> </blockquote> </details> <details> <summary>Changelog</summary> <p><em>Sourced from <a href="https://github.com/time-rs/time/blob/main/CHANGELOG.md">time's changelog</a>.</em></p> <blockquote> <h2>0.3.43 [2025-09-02]</h2> <h3>Added</h3> <ul> <li>Support for <code>rand</code> 0.9</li> </ul> <h3>Fixed</h3> <ul> <li>In the <code>convert</code> module, any use of <code>per</code> with types that were not the same (such as <code>Nanosecond::per(Second)</code>) would not compile due to a bug. This has been fixed.</li> </ul> </blockquote> </details> <details> <summary>Commits</summary> <ul> <li><a href=" |
||
Andrei Volykhin
|
8a62984c2f
|
canvas: Use non rooted variant of HTMLCanvasElementOrOffscreenCanvas type (#38970)
Any RenderingContext/OffscreenRenderingContext type has readonly "canvas" attribute and associated native-code DOM context objects have reference to target DOM canvas objects. https://html.spec.whatwg.org/multipage/canvas.html#renderingcontext https://html.spec.whatwg.org/multipage/canvas.html#offscreenrenderingcontext And currently the reference to DOM canvas object is the rooting pointer on the stack, which leads to the circular reference problem. The SpiderMonkey's (SM) garbage collector will not be able to free the DOM canvas and context objects (unreacheble from JS) because of the rooting pointer on stack (see STACK_ROOTS). And these objects will be stored until the associated script runtime/thread will be terminated. SM -> JS Roots -> DOM Canvas* (on heap) -> DOM Context (on heap) SM -> Rust Roots -> Dom Canvas* (on stack) <- as "canvas" member field Let's replace the rooting pointer to the traceble pointer (DomRoot -> Dom) in the "canvas" member field of DOM context object, which allows to broke circular referencing problem. Testing: No changes in existed tests Signed-off-by: Andrei Volykhin <volykhin.andrei@huawei.com> Co-authored-by: Andrei Volykhin <volykhin.andrei@huawei.com> |
||
|
Martin Robinson
|
2c7866eb24
|
script/layout: Implement HTMLElement.scrollParent (#39110)
This new API allows getting the element which establishes an element's scroll container. This will be used to properly implement `scrollIntoView`. There is still work to do for this API and `offsetParent` to properly handle ancestors which are closed-shadow-hidden from the original query element. In addition, fix an issue where inline boxes were establishing scrolling containers (they shouldn't do that). Testing: There are tests for this change. Fixes: #39096. Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Oriol Brufau <obrufau@igalia.com> |
||
|
Narfinger
|
5c7ea4bdee
|
constellation: Use FnvHashMap for hashmaps that use ids as keys (#39106)
FNV is faster for hashing less than 16 bytes of data and the cryptographic properties of the default HashMap are not needed for the various ids. Testing: This does not change functionality. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com> |
||
|
Martin Robinson
|
0ae9ee28d5
|
script: More consistently use f32 and have scrolling methods follow the specification more closely (#39104)
This clarifies the units for scrolling: - `f32` is used for internal Servo scrolling APIs as that is the unit used in WebRender. - `f64` is used for the web-exposed scrolling APIs as that is what the WebIDL code generator gives us. Conversions are done consistently at the boundaries of the two APIs. In addition, web-exposed scrolling methods are refactored a bit to more closely follow the specification text. In addition, specification text is added to those methods so that it is clearer that we are following it. Testing: This should not change behavior and is thus covered by existing tests. Signed-off-by: Martin Robinson <mrobinson@igalia.com> |
||
|
Narfinger
|
b73c81630a
|
Change BrowingContextId from WebViewId explicitly (#39095)
There were still some accesses to the inner BrowsingContextId from the WebViewId. This changes it to completely rely on the From trait for these methods. This also means we can make the field private. For testing we add a way to create arbitrary WebViewIds. Testing: Does not change functionality. Signed-off-by: Narfinger <Narfinger@users.noreply.github.com> |
||
Ashwin Naren
|
4ea714e6d2
|
script: Calculate proper border box for resizeobserver (#38988)
Implements more of calculate_box_size, ensuring that the proper rectangle is returned when the border box is requested. Testing: WPT Fixes: Partially #38811 --------- Signed-off-by: Ashwin Naren <arihant2math@gmail.com> Co-authored-by: Jo Steven Novaryo <65610990+stevennovaryo@users.noreply.github.com> |
||
|
Josh Matthews
|
433a461044
|
indexeddb: Serialize all cloned values when storing data. (#39081)
We were performing a structured clone but throwing away any serializable DOM interfaces included in the result. We need to instead serialize the full structured clone result so we can deserialize the DOM interfaces when getting the data out of the object store. Testing: Existing WPT coverage is sufficient. Fixes: #38818 Fixed: #38842 Signed-off-by: Josh Matthews <josh@joshmatthews.net> |
||
|
Martin Robinson
|
6b208124dc
|
script: Always dirty nodes when changing node state (#39102)
With incremental layout adding a restyle to a node isn't enough to force its layout to update. We also need to explicitly mark the node as dirty so that its contents are updated when layout is run. This change makes this consistent for all node state changes. This might be a bit too conservative as all node state may not affect layout, but should catch issues in the future. Testing: This is very hard to test as it requires moving the mouse over the WebView, and the moving it away, and then testing the rendered contents. This kind of coordination would be difficult to manage with unit tests. Fixes: #38989. Signed-off-by: Martin Robinson <mrobinson@igalia.com> |
||
|
Ashwin Naren
|
4dcf4ef07a
|
Fix step ordering for MicrotaskQueue checkpoint (#39099)
The steps were incorrectly numbered, this PR fixes that and copies over the description of each step. Testing: None, just expanding on the comments/fixing the step numbering --------- Signed-off-by: Ashwin Naren <arihant2math@gmail.com> Co-authored-by: Jonathan Schwender <55576758+jschwe@users.noreply.github.com> |
||
Kenzie Raditya Tirtarahardja
|
9c840b05bc
|
CI: Enable webdriver classic on wpt workflow (#39087)
Since WebDriver is quite stable now, enable the `webdriver/classic` tests on wpt CI. --------- Signed-off-by: PotatoCP <Kenzie.Raditya.Tirtarahardja@huawei.com> |
||
|
Martin Robinson
|
2fc816d561
|
script: Make scrollIntoView more similar to the specification (#39094)
Rework the flow of code in `Element:scroll_into_view_with_options` to more closely follow the specification. This also simplifies the code a bit and adds some TODOs about future improvements. Testing: This should not change behavior and is thus covered by existing tests. Signed-off-by: Martin Robinson <mrobinson@igalia.com> Co-authored-by: Oriol Brufau <obrufau@igalia.com> |
||
|
Ashwin Naren
|
b0b70ec6b7
|
Throw SyntaxError from Location::SetHref (#39051)
It was originally throwing a TypeError, which was making WPT fail. Testing: Many happy WPT subtests Fixes: #39050 --------- Signed-off-by: Ashwin Naren <arihant2math@gmail.com> Co-authored-by: Sam <16504129+sagudev@users.noreply.github.com> |
||
|
Ashwin Naren
|
47551fc6fa
|
indexeddb: Finish implementation of key_type_to_jsval (#39008)
Uses clipped time to convert dates that are stored as `f64`s into JS values. Testing: WPT Fixes: #25327 --------- Signed-off-by: Ashwin Naren <arihant2math@gmail.com> |
||
|
Tim van der Lippe
|
a1f9e3e133
|
Move LinkProcessingOptions into separate file (#39033)
This makes future implementations easier where we will reuse most of this code to parse Link headers. Part of #35035 Signed-off-by: Tim van der Lippe <tvanderlippe@gmail.com> |
||
|
Martin Robinson
|
efe9ea2306
|
layout: Gracefully handle script queries on nodes with uninvertible transforms (#39075)
Instead of panicking when doing a geometry script query on a node with an uninvertible transform, return a zero-sized rectangle at the untransformed position. This is similar to what Gecko and Blink do (though it seems there are some differences in positioning this zero-sized rectangle). Mostly importantly, do not panic. Testing: This change adds a new WPT crash test. Fixes: #38848. Signed-off-by: Martin Robinson <mrobinson@igalia.com> |
||
Jerens Lensun
|
4de84b0ca5
|
script_bindings(python): Fix all the rest of type annotation in script_bindings codegen (#39070)
This will complete the type annotation on `codegen.py` so we can safely remove the ignore from `pyproject` configurataion --------- Signed-off-by: Jerens Lensun <jerensslensun@gmail.com> Signed-off-by: Mukilan Thiyagarajan <mukilan@igalia.com> Co-authored-by: Mukilan Thiyagarajan <mukilan@igalia.com> |
||
JoeDow
|
f8c0746c44
|
layout: Move hit testing for scrollable areas to display list construction (#39066)
Move the construction of hit test items for scroll nodes to the display list construction stage. This way they respect the `z-index` of their originating fragments and stacking context ordering in general. Testing: We currently do not have great testing for this as this tests the combination of hit testing of input events and scrolling at that point. The completion of WebDriver support should make this easier to test. Fixes: #38967 Signed-off-by: coding-joedow <ibluegalaxy_taoj@163.com> Co-authored-by: kongbai1996 <1782765876@qq.com> |
||
|
Euclid Ye
|
802fdd9068
|
webdriver: Focus browsing context when switch frame (#39086)
#38889 adds back the mechanism to focus the window when [switch to
window](https://w3c.github.io/webdriver/#switch-to-window). After that,
it causes many flaky TIMEOUT. Turns out the real reason is same as the
phenomenon which I thought was unrelated:
https://github.com/servo/servo/pull/38889#issuecomment-3217512339: we
need to focus the browsing context as well according to spec. This is
important for Servo because it relies on
|