Commit graph

36788 commits

Author SHA1 Message Date
bors-servo
d58ea974ba
Auto merge of #23285 - servo-wpt-sync:wpt_update_29-04-2019, r=servo-wpt-sync
Sync WPT with upstream (29-04-2019)

Automated downstream sync of changes from upstream as of 29-04-2019.
[no-wpt-sync]
2019-04-29 00:58:07 -04:00
WPT Sync Bot
c084436da7 Update web-platform-tests to revision 3b0853b41cdb88c713f2ac3636f5b69c14b31d49 2019-04-29 00:57:48 -04:00
bors-servo
c58f91ec1f
Auto merge of #23284 - servo-wpt-sync:wpt_update_28-04-2019, r=servo-wpt-sync
Sync WPT with upstream (28-04-2019)

Automated downstream sync of changes from upstream as of 28-04-2019.
[no-wpt-sync]
2019-04-28 01:39:42 -04:00
WPT Sync Bot
fc1d662be8 Update web-platform-tests to revision 301ce26e6c4fdc9c7b04dc86e009835662519c37 2019-04-28 01:39:16 -04:00
bors-servo
ffd9441a3d
Auto merge of #23279 - snarasi6:master, r=jdm
Implement deprecated setPosition and setOrientation methods for AudioListener #22898

<!-- Please describe your changes on the following line: -->
I have uncommented the two methods SetPosition and SetOrientation in AudioListener.webidl and have included the two methods in the AudioListener.rs file. I have some errors while handling the NotSupported error for the methods. Can you please review the code and help me out with the errors?

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #___ (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23279)
<!-- Reviewable:end -->
2019-04-27 20:47:11 -04:00
snarasi6
feeb89149d Implemented SetOrientation and SetPosition functions but still have errors in throwing NotSupported error message 2019-04-27 18:38:15 -04:00
bors-servo
10bee0db5d
Auto merge of #23259 - Akhilesh1996:master, r=Manishearth
Implement AudioParam.setValueCurveAtTime #22897

<!-- Please describe your changes on the following line: -->
Updated audioparam.rs to send the new UserAutomationEvent SetValueCurveAtTime to the audio engine and updated test results.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #22897 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23259)
<!-- Reviewable:end -->
2019-04-27 08:57:04 -04:00
bors-servo
7607f3c995
Auto merge of #23280 - servo-wpt-sync:wpt_update_27-04-2019, r=servo-wpt-sync
Sync WPT with upstream (27-04-2019)

Automated downstream sync of changes from upstream as of 27-04-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23280)
<!-- Reviewable:end -->
2019-04-27 05:25:48 -04:00
WPT Sync Bot
b30b1992ac Update web-platform-tests to revision 4accec3d14ccdc7b170017c0df299b954019f06f 2019-04-27 02:52:58 -04:00
bors-servo
6cf3ba9db2
Auto merge of #23276 - servo:jdm-patch-38, r=Manishearth
Install gcc-6 on TravisCI.

This is a followup for #23182.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23276)
<!-- Reviewable:end -->
2019-04-27 02:52:40 -04:00
Akhilesh V
b519a0b941 Implemented JS API for setValueCurveAtTime and updated tests 2019-04-26 23:17:24 -04:00
bors-servo
630cf2745b
Auto merge of #23275 - servo:jdm-patch-37, r=Manishearth
Use llvm's linker for x86 builds.

This is a follow up to #23256 and #23211.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23275)
<!-- Reviewable:end -->
2019-04-26 20:22:54 -04:00
Josh Matthews
5083451813
Install gcc-6 on TravisCI. 2019-04-26 16:53:56 -04:00
Josh Matthews
f723e150ec
Use llvm's linker for x86 builds. 2019-04-26 16:24:13 -04:00
bors-servo
94c1551c8f
Auto merge of #23182 - jdm:xenial, r=jdm
Switch to Xenial for Linux CI.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23182)
<!-- Reviewable:end -->
2019-04-26 12:51:09 -04:00
bors-servo
b4a2d60b25
Auto merge of #23211 - jdm:win-cross, r=SimonSapin
Add Windows x86 build job.

This will make it easier to start working on Hololens embedding work without having to deal with a broken build first.

---
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23211)
<!-- Reviewable:end -->
2019-04-26 08:55:28 -04:00
Josh Matthews
57d241fce5 Add Windows x86 build job. 2019-04-26 08:54:24 -04:00
bors-servo
56c2e85cab
Auto merge of #23270 - Manishearth:audioparam-validation, r=ferjm
Add input validation for AudioParam methods

Waiting on a build to make WPT updates

Spec requires us to validate inputs, we aren't doing this here.

We don't need to check for things being finite since we already get the arguments as `Finite` values

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23270)
<!-- Reviewable:end -->
2019-04-26 03:32:48 -04:00
bors-servo
9b20187793
Auto merge of #23273 - servo-wpt-sync:wpt_update_26-04-2019, r=servo-wpt-sync
Sync WPT with upstream (26-04-2019)

Automated downstream sync of changes from upstream as of 26-04-2019.
[no-wpt-sync]
2019-04-26 01:35:36 -04:00
WPT Sync Bot
efca990ffe Update web-platform-tests to revision d3cf77a7b8c20c678b725238eaa8a72eca3787ae 2019-04-26 01:35:21 -04:00
bors-servo
b73956cc37
Auto merge of #23090 - miller-time:nav-fetch-referrer, r=gterzian
Add referrer to navigation fetch request

<!-- Please describe your changes on the following line: -->
Implement step 13 of [following hyperlinks](https://html.spec.whatwg.org/#following-hyperlinks-2) and step 14.3 of [window open](https://html.spec.whatwg.org/#window-open-steps), as well as other referrer- and fetch-related updates.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #22890 (GitHub issue number if applicable)

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23090)
<!-- Reviewable:end -->
2019-04-25 20:21:23 -04:00
Manish Goregaokar
8a8a9f7135 Add input validation for AudioParam methods 2019-04-25 16:00:11 -07:00
bors-servo
880f3b8b7a
Auto merge of #23268 - asajeffrey:magicleap-package-fixes, r=jdm
Magicleap package fixes

<!-- Please describe your changes on the following line: -->

A couple of fixes for magicleap packaging...
* Move the setting of the debuggable flag into the `.package` file where it belongs,
* Allow compiling with v0.20.0 of the SDK.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it fixes the build

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23268)
<!-- Reviewable:end -->
2019-04-25 18:25:19 -04:00
bors-servo
36bb42525a
Auto merge of #23256 - jdm:clang-cl, r=asajeffrey
Use clang-cl for Windows builds

Depends on https://github.com/servo/mozjs/pull/178.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23256)
<!-- Reviewable:end -->
2019-04-25 14:35:59 -04:00
Alan Jeffrey
73a874f742 Work around deprecated API when packaging for magicleap 2019-04-25 13:02:56 -05:00
Alan Jeffrey
82fcab38a4 Move debuggable flag setting for magicleap package to package file 2019-04-25 12:56:37 -05:00
bors-servo
caac107ae8
Auto merge of #23262 - paulrouget:cursor-update, r=jdm
Update SetCursor behavior

We were initially sending a SetCursor message on every mouse move because of a winit bug, which is now fixed.

Also, we had a layout SetCursor message that was never used.

Fix #18599

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23262)
<!-- Reviewable:end -->
2019-04-25 12:28:08 -04:00
bors-servo
e877dc2759
Auto merge of #23263 - servo:rustup, r=jdm
Upgrade to rustc 1.36.0-nightly (e305df184 2019-04-24)

This includes a `size_of` regression for a few DOM types, due to https://github.com/rust-lang/rust/pull/58623 which replaces the implementation of `HashMap` in the standard library to Hashbrown.

Although `size_of<HashMap>` grows, it’s not obvious how total memory usage is going to be impacted: Hashbrown only has one `u8` instead of one `usize` of overhead per hash table bucket for storing (part of) a hash, and so might allocate less memory itself.

Hashbrown also typically has better run time performance: https://github.com/rust-lang/hashbrown#performance

Still, I’ve filed https://github.com/rust-lang/hashbrown/issues/69 about potentially reducing the `size_of<HashMap>` regression.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23263)
<!-- Reviewable:end -->
2019-04-25 10:58:23 -04:00
Josh Matthews
0136e5a2db Update mozjs. 2019-04-25 10:55:17 -04:00
Josh Matthews
c038ba4c7c Force the use of clang-cl.exe for Windows builds. 2019-04-25 10:55:16 -04:00
Simon Sapin
51d6b6350e Upgrade to rustc 1.36.0-nightly (e305df184 2019-04-24)
This includes a `size_of` regression for a few DOM types,
due to https://github.com/rust-lang/rust/pull/58623 which replaces the
implementation of `HashMap` in the standard library to Hashbrown.

Although `size_of<HashMap>` grows, it’s not obvious how total memory usage
is going to be impacted: Hashbrown only has one `u8` instead of one `usize`
of overhead per hash table bucket for storing (part of) a hash,
and so might allocate less memory itself.

Hashbrown also typically has better run time performance:
https://github.com/rust-lang/hashbrown#performance

Still, I’ve filed https://github.com/rust-lang/hashbrown/issues/69
about potentially reducing the `size_of<HashMap>` regression.
2019-04-25 13:52:09 +02:00
Paul Rouget
7858ede29f Update SetCursor behavior 2019-04-25 09:39:16 +02:00
bors-servo
07d1559141
Auto merge of #23250 - servo-wpt-sync:wpt_update_24-04-2019, r=servo-wpt-sync
Sync WPT with upstream (24-04-2019)

Automated downstream sync of changes from upstream as of 24-04-2019.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23250)
<!-- Reviewable:end -->
2019-04-24 20:25:39 -04:00
bors-servo
0b1a790683
Auto merge of #23252 - servo:jdm-patch-36, r=SimonSapin
Allow mac WPT jobs to run longer than 60 minutes

This should fix #23251 which has been hitting us lately as we run more tests.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23252)
<!-- Reviewable:end -->
2019-04-24 17:35:35 -04:00
Josh Matthews
817aa49dc7
Update cmake for MSVC builds. 2019-04-24 15:07:31 -04:00
Josh Matthews
facfa6a417
Allow mac WPT jobs to run longer than 60 minutes 2019-04-24 09:50:53 -04:00
WPT Sync Bot
d4dc41672a Update web-platform-tests to revision 7a7e16ad8d1a1b843340f47101c0a5c24c9bba57 2019-04-24 00:13:37 -04:00
bors-servo
ec680de063
Auto merge of #23248 - asajeffrey:liblzma-dev-dependency, r=jdm
Added liblzma-dev dependency on Debian

<!-- Please describe your changes on the following line: -->

This fixes a link error on Debian Linux
```
  = note: /usr/bin/ld.gold: error: cannot find -llzma
          collect2: error: ld returned 1 exit status
```

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes do not require tests because it's a README

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23248)
<!-- Reviewable:end -->
2019-04-23 21:52:59 -04:00
bors-servo
155fad62b3
Auto merge of #23246 - servo:jdm-patch-30, r=SimonSapin
Don't run full WPT testsuite twice.

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23246)
<!-- Reviewable:end -->
2019-04-23 18:26:28 -04:00
bors-servo
03b005c7b2
Auto merge of #23178 - tdelacour:ISSUE-21263, r=jdm
Add PerformanceResourceTiming: ResponseEnd

<!-- Please describe your changes on the following line: -->
1. Added `ResponseEnd` to `ResourceAttribute` enum in `net_traits` and added it to the `set_attribute` function on `ResourceFetchTiming`
2. Added `response_end` field to `performanceresourcetiming.rs`
3. In `http_loader.rs`, set ResponseEnd after response body read is complete, or before return due to network error.

I could use a little guidance on testing. After building and running `wpt` tests, I noticed that some tests now "Pass" when they were expected to "Fail". As per the wiki instructions, I've removed those expectations from the `metadata`.

I noticed that there are a handful of other "failing" test expectations associated with `responseEnd`, but those still do not pass. I looked through some similar PRs (`connectEnd`, `redirectStart`, etc) and saw that they also still have a few failing test expectations here and there. Does that mean this is OK for now? How can I better understand which tests we expect to resolve for a given issue? Thanks!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #21263 (GitHub issue number if applicable)

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because ___

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23178)
<!-- Reviewable:end -->
2019-04-23 16:49:12 -04:00
bors-servo
4c8d29f5a7
Auto merge of #23200 - krk:webidl-lint, r=jdm
Webidl lint

Parse webidl files and lint for inheritance correctness.

---

<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20461

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23200)
<!-- Reviewable:end -->
2019-04-23 15:24:33 -04:00
Alan Jeffrey
61f7f12f58 Updated bootstrap.py 2019-04-23 12:02:40 -05:00
Alan Jeffrey
3aa58eed16 Added liblzma-dev dependency on Debian 2019-04-23 11:42:38 -05:00
Thomas Delacour
fdbec9835c ISSUE-21263: implemented attribute setting in http loader 2019-04-23 12:33:28 -04:00
bors-servo
9a218e659a
Auto merge of #23247 - ferjm:rm.auto.media, r=jdm
Remove use of auto media backend. And update servo-media

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #23242

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23247)
<!-- Reviewable:end -->
2019-04-23 11:30:01 -04:00
Fernando Jiménez Moreno
74a48937f1 Remove use of auto media backend. And update servo-media 2019-04-23 16:24:33 +02:00
Josh Matthews
4e4fe97262
Don't run full WPT testsuite twice. 2019-04-23 09:29:58 -04:00
bors-servo
54f54d194d
Auto merge of #23186 - krk:enable-css-align-tests, r=jdm
Add css-align tests with failure expectations.

<!-- Please describe your changes on the following line: -->
Enabled `css-align` wpt tests.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `___` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #20576

<!-- Either: -->
- [X] There are tests for these changes

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23186)
<!-- Reviewable:end -->
2019-04-22 17:07:44 -04:00
bors-servo
abe13a99ed
Auto merge of #23237 - hundredeir:GetTimeouts, r=jdm
Adds webdriver command Get Timeouts

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

- [X] These changes do not require tests because webdriver tests already exists for it

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23237)
<!-- Reviewable:end -->
2019-04-22 15:07:02 -04:00
bors-servo
48ba809719
Auto merge of #23240 - servo-wpt-sync:wpt_update_22-04-2019, r=jdm
Sync WPT with upstream (22-04-2019)

Automated downstream sync of changes from upstream as of 22-04-2019.
[no-wpt-sync]

Fixes #22752.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/23240)
<!-- Reviewable:end -->
2019-04-22 13:27:33 -04:00