Commit graph

119 commits

Author SHA1 Message Date
Xidorn Quan
e22850dc85
style: Add check for non-Copy specified value to ensure specified_is_copy always returns the right result.
Differential Revision: https://phabricator.services.mozilla.com/D2931
2018-08-18 17:47:37 +02:00
Jonathan Watt
b05ace3e4a
style: Add a '-moz-menulist-button' value to '-moz-appearance'.
The '-moz-menulist-button' value currently behavies identically to the
'menulist-button' value.  This is not implemented as an alias because later
patches in this patch series will change the behavior of our pre-existing
'menulist-button' value to more closely match what Chrome does.

Bug: 1428676
Reviewed-by: emilio
2018-08-08 01:36:33 +02:00
Emilio Cobos Álvarez
0cab212052
style: Autogenerate StyleAppearance.
This builds on bug 1428676 and introduces StyleAppearance, which replaces the
NS_THEME_* constants.

Really sorry for the size of the patch.

There's a non-trivial change in the gtk theme, which I submitted separately as
bug 1478385.

Differential Revision: https://phabricator.services.mozilla.com/D2361
2018-08-08 01:35:08 +02:00
Emilio Cobos Álvarez
1716259a3a
style: Fix servo build. 2018-07-24 03:38:14 +02:00
Ting-Yu Lin
0c0ffef1a5
style: Convert NS_STYLE_COLUMN_SPAN_* to an enum class.
Bug: 1477533
Reviewed-by: heycam
MozReview-Commit-ID: F8M1DlpBop2
2018-07-24 03:31:53 +02:00
Ting-Yu Lin
23b1d4d640
style: Convert NS_STYLE_COLUMN_FILL_* to an enum class.
I put Balance as the first item in StyleColumnFill because it is the default
value.

Bug: 1477533
Reviewed-by: heycam
MozReview-Commit-ID: A4DVMLL6XBa
2018-07-24 03:31:41 +02:00
Xidorn Quan
d245f8b579
style: Introduce a concept of logical group.
Bug: 1473180
Reviewed-by: emilio
MozReview-Commit-ID: GXlf8JNML4N
2018-07-24 03:29:15 +02:00
Cameron McCormack
f526af7f01
style: Remove angle values from image-orientation.
Bug: 1473450
Reviewed-by: emilio
MozReview-Commit-ID: FB74ILJM6Fm
2018-07-16 19:42:12 +02:00
Emilio Cobos Álvarez
1c799dd296
style: Make writing-mode and direction non-animatable.
Per https://github.com/w3c/csswg-drafts/issues/2751

Bug: 1473779
Reviewed-by: heycam
MozReview-Commit-ID: GCG3vJWNPfC
2018-07-16 19:41:46 +02:00
Emilio Cobos Álvarez
4d005cb90e
style: Reformat most of inherited_box.mako.rs.
image-orientation is being changed as we speak, so I left it there to avoid
bitrot.

Bug: 1473779
Reviewed-by: heycam
MozReview-Commit-ID: IwpA5HEuVU
2018-07-16 19:41:28 +02:00
Philipp Klein
85af4145c3 style: Move clear CSS property outside mako
closes #21155
2018-07-10 09:18:33 +02:00
bors-servo
2bc70e738b
Auto merge of #21139 - kleinph:move-float-clear-outside-mako, r=emilio
style: Move `float` CSS property outside mako

Hi, I am fairly new to Rust and this is my first contribution to a Rust project.

- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [x] These changes fix #21130

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

I'm not sure if the approach with the two enums is good. Please let me know if this can be improved.
Regarding the tests I'm unsure: `tests/wpt/web-platform-tests/css/css-display/display-contents-float-001.html` seems to fail already before this PR, (and the cause is maybe not related to the style property definition).

Also I would like to add some docs, is it allowed to use the descriptions from MDN (https://developer.mozilla.org/en-US/docs/Web/CSS/float).

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/21139)
<!-- Reviewable:end -->
2018-07-09 22:00:25 -04:00
Philipp Klein
c7871811c8 style: Move float CSS property outside mako
closes #21130
2018-07-09 12:47:07 +02:00
Emilio Cobos Álvarez
9f8c80fb3a
style: Make writing-mode and direction non-animatable.
Per https://github.com/w3c/csswg-drafts/issues/2751

Bug: 1473779
Reviewed-by: heycam
2018-07-09 03:05:32 +02:00
Emilio Cobos Álvarez
a11dcefee7
style: Reformat most of inherited_box.mako.rs.
image-orientation is being changed as we speak, so I left it there to avoid
bitrot.

Bug: 1473779
Reviewed-by: heycam
2018-07-09 03:05:19 +02:00
Emilio Cobos Álvarez
c23dca874f
style: Reformat font.mako.rs.
To be consistent, use the block indentation the rest of the Rust code uses.

Differential Revision: https://phabricator.services.mozilla.com/D1906
Bug: 1472552
Reviewed-by: xidorn
2018-07-09 03:03:41 +02:00
Emilio Cobos Álvarez
06fa3406de
style: Put offset-* aliases behind a pref.
Bug: 1464782
Reviewed-by: xidorn
MozReview-Commit-ID: Hl6Muim3wVH
2018-07-01 00:08:20 +02:00
Emilio Cobos Álvarez
65953fb158
style: Rename offset-* logical properties to inset-*.
Bug: 1464782
Reviewed-by: xidorn
MozReview-Commit-ID: BW44sru99RF
2018-07-01 00:08:09 +02:00
Emilio Cobos Álvarez
0a95513368
style: Rename the properties directories from "shorthand" to "shorthands", "longhand" to "longhands".
Bug: 1468651
Reviewed-by: heycam
MozReview-Commit-ID: CY4THCC4zkX
2018-06-23 20:35:18 +02:00