Commit graph

2892 commits

Author SHA1 Message Date
Ravi Shankar
7099743bbf Cleanup grid mako 2017-02-20 14:29:46 +05:30
bors-servo
58aa6ce7ae Auto merge of #15629 - heycam:variables-leak, r=bholley,emilio
stylo: Destroy static Variables struct on shutdown.

Fix for https://bugzilla.mozilla.org/show_bug.cgi?id=1340457.

r? @emilio

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15629)
<!-- Reviewable:end -->
2017-02-19 21:12:57 -08:00
bors-servo
978a603190 Auto merge of #15516 - absoludity:fix-animation-serialization-15398, r=upsuper
Animation longhand serialization should be a list of each animation rather than a list of lists for each longhand.

Fixes part of #15398 -  serialization should be a list of each animation, rather than a list of lists for each longhand.

---
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes are prework for #15398

- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15516)
<!-- Reviewable:end -->
2017-02-19 19:41:19 -08:00
Huxley
06650f8428 fixed the wrong behavior of border-spacing 2017-02-19 22:59:51 +08:00
bors-servo
d88e275f1f Auto merge of #15646 - Manishearth:marker, r=heycam
Actually include file with marker shorthand

This wasn't being included so nothing was actually happening.

r? @heycam or @mbrubeck

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15646)
<!-- Reviewable:end -->
2017-02-19 00:07:40 -08:00
Manish Goregaokar
1541a2d154 Actually include file with marker shorthand 2017-02-18 23:20:39 -08:00
bors-servo
72b76458b7 Auto merge of #15606 - mbrubeck:align-items, r=Manishearth
stylo: Implement align-items and justify-items

Stylo-only patch to match Gecko property support. Part of #15001. r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15606)
<!-- Reviewable:end -->
2017-02-18 22:26:06 -08:00
Nazım Can Altınova
d7941d5e35 stylo: Support lang property 2017-02-18 20:37:07 -08:00
Manish Goregaokar
ade09844b7 stylo: Support quirksmode text-decoration color override 2017-02-18 20:37:05 -08:00
Manish Goregaokar
f27cd541b3 stylo: Support -x-span for <col span> 2017-02-18 20:37:04 -08:00
Manish Goregaokar
b85e1f5f0c stylo: Add helpers for converting Gecko keywords to Servo, use to support keyword pres attrs 2017-02-18 20:31:08 -08:00
Manish Goregaokar
afccbf4a8c stylo: Support font-family presentation attribute 2017-02-18 20:31:06 -08:00
Manish Goregaokar
5cc0fa5ec2 stylo: Support pixel and percent presentation attributes 2017-02-18 20:31:01 -08:00
Cameron McCormack
58fcd5155e stylo: Destroy static Variables struct on shutdown. 2017-02-19 09:24:48 +08:00
bors-servo
6e8d7b7d02 Auto merge of #15595 - deror1869107:use-bitflags, r=Wafflespeanut
Use bitflags for multikeyword properties

<!-- Please describe your changes on the following line: -->
Use bitflags for multikeyword properties

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15556

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15595)
<!-- Reviewable:end -->
2017-02-18 09:38:54 -08:00
deror1869107
2dec238d1c Use bitflags for multikeyword properties 2017-02-19 01:22:56 +08:00
Manish Goregaokar
66a28a4f5a stylo: Support marker shorthand; update boxing
MozReview-Commit-ID: 7B6h4IDZD67
2017-02-18 04:08:41 -08:00
Manish Goregaokar
895fcb222b stylo: Support nonstandard CSS_PROPERTY_NUMBERS_ARE_PIXELS behavior
MozReview-Commit-ID: 4QKKzJ1DVYP
2017-02-18 02:43:37 -08:00
Manish Goregaokar
ff08de8ad1 stylo: Support stroke-dasharray and stroke-dashoffset
MozReview-Commit-ID: 4QKKzJ1DVYP
2017-02-18 02:43:36 -08:00
Manish Goregaokar
4d33761596 stylo: Add paint-order bitfield
MozReview-Commit-ID: 4QKKzJ1DVYP
2017-02-18 02:43:34 -08:00
Manish Goregaokar
fa9881b829 stylo: Add mako template for URLOrNone, use for marker-* properties
MozReview-Commit-ID: 4QKKzJ1DVYP
2017-02-18 02:43:31 -08:00
Manish Goregaokar
3b0840d187 stylo: Add stroke-width property
MozReview-Commit-ID: 4QKKzJ1DVYP
2017-02-18 02:42:58 -08:00
Manish Goregaokar
51b03fbc7d stylo: Add Gecko bindings for <paint>, use for stroke/fill
MozReview-Commit-ID: 4QKKzJ1DVYP
2017-02-18 02:42:57 -08:00
Manish Goregaokar
c1d7941791 stylo: Support URL clip-paths
MozReview-Commit-ID: 4QKKzJ1DVYP
2017-02-18 02:42:54 -08:00
Manish Goregaokar
2942e3b2ea stylo: Support URL filters
MozReview-Commit-ID: 4QKKzJ1DVYP
2017-02-18 02:42:53 -08:00
Manish Goregaokar
e965b4e345 stylo: Add ServoBundledURI abstraction for use when setting css::URLValues
MozReview-Commit-ID: 4QKKzJ1DVYP
2017-02-18 02:42:47 -08:00
bors-servo
9cb3e31c1d Auto merge of #15617 - mbrubeck:border, r=upsuper
Fix -moz aliases for border-{start,end} properties

Fixes #15297. r? @upsuper or @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15617)
<!-- Reviewable:end -->
2017-02-17 13:58:05 -08:00
Matt Brubeck
9c2dbfe0d7 Fix -moz aliases for border-{start,end} properties
Fixes #15297.
2017-02-17 11:27:11 -08:00
bors-servo
3fa9ce16db Auto merge of #15594 - mbrubeck:align-content-fix, r=Manishearth
Fix initial value of align-content and justify-content

This fixes a trivial mistake in #15533, caused by me misreading the spec. r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15594)
<!-- Reviewable:end -->
2017-02-16 18:16:28 -08:00
Matt Brubeck
0a0dd11f50 stylo: Implement align-items and justify-items 2017-02-16 15:52:34 -08:00
Michael Nelson
75a993ce0c Fix serialization of animation. 2017-02-17 09:01:20 +11:00
bors-servo
11396b4dd3 Auto merge of #15576 - mbrubeck:align, r=Manishearth
stylo: Implement 'align-self' and 'justify-self'

Stylo-only patch to match Gecko property support. Part of #15001. r? @Manishearth

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15576)
<!-- Reviewable:end -->
2017-02-16 13:51:15 -08:00
Matt Brubeck
4de480ec9b style: Implement 'align-self' and 'justify-self' 2017-02-16 13:35:47 -08:00
Matt Brubeck
33338cab9d Update spec links for align-content and justify-content 2017-02-16 11:55:11 -08:00
Emilio Cobos Álvarez
30f944266b
Update nsstring.
This should fix bug 1334579
2017-02-16 20:17:04 +01:00
Matt Brubeck
4c27304541 Fix initial value of align-content and justify-content 2017-02-16 09:28:24 -08:00
bors-servo
715a164230 Auto merge of #15557 - bholley:opt_logging, r=emilio
stylo: various fixes to improve style logging in opt builds

This adds a traversal time entry to the style statistics, and switches to warn! as discussed in [1].

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=1339176

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15557)
<!-- Reviewable:end -->
2017-02-15 03:05:07 -08:00
bors-servo
f3bacf84f4 Auto merge of #15539 - AdmiralCoco:reject_outofrange_transition_values, r=emilio
Add rejection of out-of-range values for single-timing-functions

<!-- Please describe your changes on the following line: -->
This PR fixes #15344, checking for the `cubic-bezier p1x/p2x` and `steps` first value after parsing.

There are unit tests that check for parsing of invalid values - I was not sure if there was a more suitable place, so I created a file (name subject to change).

Q: I found this [test suite](https://github.com/servo/servo/blob/master/tests/unit/style/properties/serialization.rs#L592), and noticed that the `p2x` value is out of range, but the test does not fail - is this because there is no check when calling the function itself?

Thanks!

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15344

<!-- Either: -->
- [X] There are tests for these changes

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15539)
<!-- Reviewable:end -->
2017-02-14 19:25:49 -08:00
Bobby Holley
ae87b8a910 Switch from error! and println! to warn!, and set the default log level to warn on debug builds. 2017-02-14 17:19:01 -08:00
Dawing Cho
8f4282ef76 Add rejection of out-of-range values for single-timing-functions 2017-02-15 00:41:54 +00:00
bors-servo
357bf3b85a Auto merge of #15518 - emilio:color, r=SimonSapin
style: Unbox a bunch of color properties.

This builds on https://github.com/servo/rust-cssparser/pull/118.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15518)
<!-- Reviewable:end -->
2017-02-14 11:43:16 -08:00
Emilio Cobos Álvarez
0c102e2350
style: Unbox a bunch of color properties.
This builds on https://github.com/servo/rust-cssparser/pull/118.
2017-02-14 20:18:31 +01:00
bors-servo
2ea55ae1ad Auto merge of #15546 - eddiequan:15209_fix_quotes_serialization_transform_none, r=Wafflespeanut
fixes quote transform: none serialization

<!-- Please describe your changes on the following line: -->
Adds a unit test to reproduce faulty behaviour, and serializes "none" correctly when provided an empty list.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors
- [X] These changes fix #15209 (github issue number if applicable).

<!-- Either: -->
- [X] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15546)
<!-- Reviewable:end -->
2017-02-14 10:41:58 -08:00
Eddie Quan
bdd3ab1fe0 fixes quote transform: none serialization 2017-02-14 12:05:41 -05:00
Matt Brubeck
c70167d17c Stylo: Implement align-content and justify-content 2017-02-14 08:58:55 -08:00
bors-servo
aea6797a94 Auto merge of #15466 - hiei23:master, r=Wafflespeanut
-added parsing and serialization for grid-{row,column}-gap

<!-- Please describe your changes on the following line: -->
I have added an implementation for grid-{row,column}-gap based on the predefined type property suggestion in the description

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [x] `./mach build -d` does not report any errors
- [x] `./mach test-tidy` does not report any errors
- [ ] These changes fix #15310 (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15466)
<!-- Reviewable:end -->
2017-02-10 11:28:28 -08:00
hiei23
0701227906 -added parsing and serialization for grid-{row,column}-gap
updated missing products='gecko' in grid-row-gap and grip-column-gap
2017-02-10 13:10:16 -05:00
bors-servo
e985ad5422 Auto merge of #15463 - Manishearth:buncha-props, r=mbrubeck
stylo: Implement a bunch of properties

r? @mbrubeck or @heycam

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/15463)
<!-- Reviewable:end -->
2017-02-09 15:51:29 -08:00
Manish Goregaokar
779d936698 fixup! stylo: Implement scroll-snap-destination 2017-02-09 15:09:39 -08:00
Manish Goregaokar
78dc5f6aa9 stylo: Implement -moz-image-region
MozReview-Commit-ID: E6Iir2hWlbG
2017-02-09 15:09:37 -08:00