bors-servo
2c259f477c
auto merge of #4057 : jdm/servo/refcountdom, r=Ms2ger
...
This replaces the specialized TrustedXHRAddress and TrustedWorkerAddress code that was used for the same purpose. A non-zero refcount pins the given DOM object's reflector and prevents it from being GCed even when there are no other outstanding references visible to SpiderMonkey. This will enable us to implement asynchronous operations that refer to particular DOM objects (such as "queue a task to fire a simple event named load at the iframe element" from the spec) safely and conveniently, and paves the way for things like asynchronous network responses.
Some concerns about the resulting size of XHR progress messages have been expressed, but I believe optimizations to reduce that can be implemented in subsequent PRs.
r? @Ms2ger - note in particular the changes to the worker lifetime code. I couldn't figure out how to achieve an identical lifetime to the previous addref/release pairing, and I also was having trouble figuring out why the existing setup was safe. The new implementation now holds the main script task Worker object alive via the TrustedWorkerAddress field in the dedicated worker global scope, which is a significant difference.
2014-12-29 11:57:45 -07:00
Josh Matthews
9a7cd31134
Force all messages to worker tasks to send a TrustedWorkerAddress along with the ScriptMsg. This ensures that the main-thread Worker object is rooted for as long as there are events in flight or being processed.
2014-12-29 13:53:49 -05:00
Josh Matthews
2f059c15e7
Allow refcounting arbitrary DOM objects in concert with the GC to enable safe, asynchronous/cross-task references to pinned objects.
2014-12-29 13:53:48 -05:00
bors-servo
f76a460c53
auto merge of #4483 : brunoabinader/servo/named-deleter, r=Ms2ger
...
Closes #4469 .
2014-12-29 10:21:51 -07:00
Bruno de Oliveira Abinader
ab618dd9c7
Add support for named deleter
...
Closes #4469 .
2014-12-29 12:58:48 -04:00
bors-servo
1539051896
auto merge of #4501 : Ms2ger/servo/script_task, r=jdm
2014-12-29 09:54:45 -07:00
Simon Sapin
5e08e96e38
Fix typo in a cursor keyword. Thanks @nuss-justin!
2014-12-29 16:19:10 +01:00
Simon Sapin
2e35d4e987
Add a match_ignore_ascii_case! macro that does not allocate.
...
It should replace `match foo.to_ascii_lower().as_slice() { ...}`
@Manishearth I changed map.get to map.find in the lint to work around an ICE:
task 'rustc' panicked at 'couldn't find node id 0 in the AST map'
Does this look OK?
2014-12-29 16:19:10 +01:00
Simon Sapin
540d218885
Declare dependencies on text_writer.
...
Transitive dependencies being available is considered a bug:
https://github.com/rust-lang/cargo/issues/1037
2014-12-29 16:19:10 +01:00
Simon Sapin
b9a57531ea
Remove some tabs
...
@jdm, can you configure your editor to not insert them in the first
place?
2014-12-29 16:19:09 +01:00
Simon Sapin
8be85c5e6b
Implement ToCss for Cursor and de-duplicate variants and string values.
2014-12-29 16:19:09 +01:00
Simon Sapin
45a08c94a4
Implement ToCss for types in style::properties::common_values::specified
2014-12-29 16:19:09 +01:00
Simon Sapin
4a9d5b1130
Upgrade cssparser to a version with the new ToCss trait.
2014-12-29 16:19:09 +01:00
Ms2ger
a1d21d4c5e
Simplify some code in handle_click_event.
2014-12-29 09:51:01 +01:00
ProgramFOX
18d8ee6ce0
Added readonly flag for CSSStyleDeclaration
2014-12-28 17:39:07 +01:00
Ms2ger
767d0e11bf
Cleanup the transform_text tests.
2014-12-28 12:03:25 +01:00
bors-servo
56d1b16d1b
auto merge of #4173 : Manishearth/servo/a-more-dom-struct, r=kmcallister
...
Now `#[dom_struct]` also generates Reflectable impls, and there's another lint to ensure that a DOM struct only contains one bare DOM field (as the first field) or a Reflector.
A lot of this was generated by sed -- each autogenerated change has its own commit for easy review; these will be squashed later.
2014-12-27 22:12:45 -07:00
bors-servo
dbb1074782
auto merge of #4490 : Ms2ger/servo/transmutes, r=jdm
2014-12-27 12:27:46 -07:00
bors-servo
b139574cdc
auto merge of #4489 : Manishearth/servo/transmute-lint-fix, r=Ms2ger
2014-12-27 09:10:02 -07:00
Ms2ger
0031498e6b
Remove some transmute calls.
2014-12-27 17:07:32 +01:00
Manish Goregaokar
93c350e6e3
plugins: Fix transmute lint message
2014-12-27 21:35:49 +05:30
Ms2ger
aa18c84f0c
Re-enable two transform_text unit tests.
...
Note that I had to change some expectations to make them pass.
2014-12-27 16:14:32 +01:00
Manish Goregaokar
e0b88a9ca2
servo: to_string() -> into_string()
2014-12-27 14:48:36 +01:00
Manish Goregaokar
c7dfb1d24b
layout: to_string() -> into_string()
2014-12-27 14:48:36 +01:00
Manish Goregaokar
e9d1740e19
script: to_string() -> into_string()
2014-12-27 14:48:36 +01:00
Manish Goregaokar
475ff4dcb7
style: to_string() -> into_string()
2014-12-27 14:48:35 +01:00
Manish Goregaokar
e973213606
gfx: to_string() -> into_string()
2014-12-27 14:48:35 +01:00
Manish Goregaokar
50c246bdc5
Fix warnings post-upgrade
2014-12-27 03:28:35 +05:30
Manish Goregaokar
21a888341d
Ensure that Reflectors are the first field
2014-12-27 02:53:36 +05:30
Manish Goregaokar
d761877ef6
Add inheritance-checking lint
2014-12-27 02:53:35 +05:30
Manish Goregaokar
7d65673561
Remove extra spaces
...
Command: `find . -maxdepth 1 -type f -print0 | xargs -0 sed -z -i "s/}\\n\\n\\n/}\\n\\n/"`
2014-12-27 02:53:35 +05:30
Manish Goregaokar
552db382d6
Remove manual impls of Reflectors (autogen)
...
Obtained via:
`find . -maxdepth 1 -type f -print0 | xargs -0 sed -z -i "s/\\nimpl Reflectable for[^{]*{[^}]*}[^}]*}\\n//"`
`find . -maxdepth 1 -type f -print0 |xargs -0 grep -lZ dom_struct | xargs -0 grep -LZ "reflector()\\|Reflector::new" |xargs -0 sed -z -i "s/use dom::bindings::utils::{Reflectable, Reflector, reflect_dom_object};/use dom::bindings::utils::reflect_dom_object;/"`
followed by semi-automated removal of leftover imports
2014-12-27 02:52:33 +05:30
Manish Goregaokar
21607f066c
Add internal plugin for creating Reflectable implementations
2014-12-27 02:43:13 +05:30
Manish Goregaokar
dd8360fb10
Use inline(always) for trace()
2014-12-27 02:43:12 +05:30
Bruno de Oliveira Abinader
5afcf3ef65
Implement DOMTokenList.toggle
2014-12-26 14:55:27 -04:00
Bruno de Oliveira Abinader
2cfb4648ce
Implement DOMTokenList.remove
2014-12-26 14:55:27 -04:00
Bruno de Oliveira Abinader
aa29dc195d
Implement DOMTokenList.add
2014-12-26 14:55:27 -04:00
Bruno de Oliveira Abinader
08e7cf24cd
DOMTokenList::check_token_exceptions now returns an Atom
2014-12-26 14:55:26 -04:00
Bruno de Oliveira Abinader
51fac3d2cc
Added Element::get_tokenlist_attribute
2014-12-26 14:55:26 -04:00
Bruno de Oliveira Abinader
8859286a99
Added AttrValue::from_atomic_tokens & Element::set_atomic_tokenlist_attribute
2014-12-26 14:55:26 -04:00
Bruno de Oliveira Abinader
c5f7e553e4
Avoid duplicated tokens in AttrValue::from_serialized_tokenlist
2014-12-26 13:08:20 -04:00
Bruno de Oliveira Abinader
eb3678fa28
AttrValue's s/from_tokenlist/from_serialized_tokenlist/
2014-12-26 13:08:20 -04:00
bors-servo
0e6304dcf7
auto merge of #4467 : servo/servo/dataset, r=Ms2ger
2014-12-25 02:27:43 -07:00
Matt McCoy
bdb75c2146
This fixes #4166 . throw_dom_exception will take the GlobalRef by value, and all generated code will pass it by value.
2014-12-24 17:16:48 -05:00
bors-servo
070008b4c4
auto merge of #4478 : jdm/servo/hyperssl, r=larsbergstrom
...
This just updates rust-openssl and hyper to use cherry-picked commits that fix this particular issue. I think it's worth it because the experience of trying Servo for the first time right now is pretty terrible.
2014-12-24 11:15:45 -07:00
Josh Matthews
22c8d3df8d
Fix HTTPS fetches.
2014-12-24 12:41:38 -05:00
Ms2ger
919f2217f0
Implement dummy getOwnPropertyNames and enumerate traps.
2014-12-24 17:17:40 +01:00
thiagopnts
eacbe331c9
Replace bool attribute in Element::update_inline_style with a descriptive enum
2014-12-24 13:23:58 -02:00
bors-servo
194ce20969
auto merge of #4474 : thiagopnts/servo/generic-msgs, r=jdm
...
This refs #3735 . As discussed in the issue, I did it cloning when I couldn't dereference an attribute. The trait method should be on `&self` for object-safety reasons.
2014-12-24 03:45:44 -07:00
bors-servo
71b9f17b6b
auto merge of #4457 : jamougha/servo/master, r=jdm
...
Fixes #4411 .
I didn't find any tests for the text control functionality so I didn't write any for this, let me know if I should.
2014-12-23 23:45:45 -07:00