Commit graph

36788 commits

Author SHA1 Message Date
Boris Chiou
23f2e99e99
style: Fix the default behavior of scale:<number>{1}.
The current spec says: "If only the X value is given, the Y value
defaults to the same value.", so we should update the behavior.

Besides, we also update the serialization, so we serialization both
specified and computed value by servo. We enable the preference
for all the css-transforms, so some of them are passed now.

Differential Revision: https://phabricator.services.mozilla.com/D10638
2018-11-08 15:22:28 +01:00
Emilio Cobos Álvarez
264a679c50
style: followup post-review nit. 2018-11-08 15:22:27 +01:00
Cameron McCormack
de5584c1f6
style: Store the Rust QuotePair slice as the computed quotes value in Gecko style structs.
Depends on D10651

Differential Revision: https://phabricator.services.mozilla.com/D10652
2018-11-08 15:22:26 +01:00
Cameron McCormack
acf7b65f36
style: Make quotes property representation allocate less.
Differential Revision: https://phabricator.services.mozilla.com/D10650
2018-11-08 15:22:26 +01:00
Cameron McCormack
56fd3b786f
style: Serialize background-size: auto auto as "auto".
With this change, all of Chrome, Edge, Firefox, and Safari serialize
background-size by omitting the second "auto" if the value is "auto
auto".  Other keywords are still repeated.

Differential Revision: https://phabricator.services.mozilla.com/D10446
2018-11-08 15:22:25 +01:00
Ting-Yu Lin
68f4ad9557
style: Remove preference "layout.css.shape-outside.enabled".
shape-outside, shape-margin, shape-image-threshold have been shipped in Firefox
62. We can remove the preference.

The change in devtools/shared/css/generated/properties-db.js is generated by
"./mach devtools-css-db"

The actual shape-image CORS mode tests in file_shape_outside_CORS.html are
moved into test_shape_outside_CORS.html because we don't need the <iframe>
trick to enable the feature.

Differential Revision: https://phabricator.services.mozilla.com/D10804
2018-11-08 15:22:24 +01:00
bors-servo
dd5e5e9294
Auto merge of #22144 - Eijebong:hyperfix, r=jdm
Fix downloading huge files (broken since hyperup)

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22144)
<!-- Reviewable:end -->
2018-11-08 08:47:10 -05:00
bors-servo
0a11e10a0f
Auto merge of #22146 - servo-wpt-sync:wpt_update_07-11-2018, r=jdm
Sync WPT with upstream (07-11-2018)

Automated downstream sync of changes from upstream as of 07-11-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22146)
<!-- Reviewable:end -->
2018-11-08 07:22:18 -05:00
Bastien Orivel
85c6eff94a Use chunk.as_ref() instead of &chunk.into_bytes() 2018-11-08 12:37:50 +01:00
bors-servo
f220a63a0f
Auto merge of #22133 - servo:extern-crate, r=SimonSapin
Use 2018-edition idioms in crates that use that edition

The first commit is almost entirely mechanical, created by running `cargo fix --edition-idioms` and relevant crates. I undid the change of adding an anonymous lifetime parameter in types that have implicit lifetimes parameters, for example replacing `&mut Formatter` with `&mut Formatter<'_>`, because I don’t like it. The remaining changes are, in many places:

* Add `dyn` to trait object types, for example `Rc<gl::Gl>` to `Rc<dyn gl::Gl>`. This change also works in the 2015 edition.
* Remove `extern crate` where is it made unneeded by changes to the import/module system.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22133)
<!-- Reviewable:end -->
2018-11-08 05:11:11 -05:00
Simon Sapin
9f977c5287 Remove useless use crate_name; imports.
A `crate_name::foo` path always works in 2018
2018-11-08 09:29:52 +01:00
Simon Sapin
50c840fe42 Revert "Disable unused-extern-crates warnings for now"
This reverts commit 32462cd909a7c28d0d86664291bdcb0043c0bb45.
2018-11-08 09:28:00 +01:00
Simon Sapin
2012be4a8b cargo fix --edition-idioms 2018-11-08 09:28:00 +01:00
WPT Sync Bot
4443426308 Update web-platform-tests to revision cd44958a002b1ad494168e0290554644de84526e 2018-11-07 22:27:51 -05:00
bors-servo
b1fd6237d1
Auto merge of #22141 - pyfisch:add-note-fmt, r=SimonSapin
Hint ./mach fmt

Just thought that a note how to fix if rustfmt fails would be nice.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22141)
<!-- Reviewable:end -->
2018-11-07 20:57:56 -05:00
Bastien Orivel
dcbe7d36ae Continue decompressing chunks even after hyper is done downloading the body
If hyper reads compressed enough data, we were decompressing 32k by 32k
but we were throwing away the end of the body because we would end up
having lots of backed up data in the cursor when hyper was done.
2018-11-08 02:40:22 +01:00
Bastien Orivel
e30440c9cc Don't reset the buffers for each chunk we download
Sometimes hyper sends data that can't completely decompressed, resetting
the buffer means we're losing some data and thus breaking the body
2018-11-08 02:40:21 +01:00
bors-servo
44b75ed588
Auto merge of #22136 - pyfisch:fix-select-all, r=jdm
Correct select all

Fixes assertion failure.
Set selection direction forward on select all.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22136)
<!-- Reviewable:end -->
2018-11-07 19:40:18 -05:00
bors-servo
2ed23ce4c9
Auto merge of #22131 - servo-wpt-sync:wpt_update_06-11-2018, r=jdm
Sync WPT with upstream (06-11-2018)

Automated downstream sync of changes from upstream as of 06-11-2018.
[no-wpt-sync]

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22131)
<!-- Reviewable:end -->
2018-11-07 17:25:34 -05:00
bors-servo
741bd8e739
Auto merge of #22087 - Eijebong:rust_serialize, r=jdm
Remove rustc-serialize from the dependencies

Closes #12410.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22087)
<!-- Reviewable:end -->
2018-11-07 16:07:38 -05:00
Pyfisch
694991ad7e Hint ./mach fmt 2018-11-07 20:32:22 +01:00
Pyfisch
7db13e93b7 Correct select all
Fixes assertion failure.
Set selection direction forward on select all.
2018-11-07 18:58:51 +01:00
bors-servo
b93d4b2ac6
Auto merge of #22129 - ferjm:media.task.source, r=Manishearth
HTMLMediaElement - use media element instead of dom manipulation task…

… source

- [X] `./mach build -d` does not report any errors
- [X] `./mach test-tidy` does not report any errors

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22129)
<!-- Reviewable:end -->
2018-11-07 12:16:58 -05:00
Bastien Orivel
221199d277 Remove rustc-serialize from the dependencies 2018-11-07 17:33:23 +01:00
bors-servo
9c7efd9151
Auto merge of #22127 - Darkspirit:https_intermittent_tracker, r=jdm
Connect to intermittent trackers via https

This is the last part of #22088.
Each https url returns the same with curl as its previous http variant, so it should be a safe change.
And https has already been used at this place in the past: 38474f8671

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22127)
<!-- Reviewable:end -->
2018-11-07 10:13:36 -05:00
bors-servo
da2d9b2228
Auto merge of #22126 - pyfisch:autoformat, r=jdm
Enforce rustfmt on CI

<!-- Reviewable:start -->
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22126)
<!-- Reviewable:end -->
2018-11-07 08:47:57 -05:00
Pyfisch
1855c88d61 Fix test-tidy self test
Install rustup on first Travis job.
Only use rustfmt::skip as an outer attribute.
2018-11-07 09:37:55 +01:00
bors-servo
618a790050
Auto merge of #22074 - jdm:wrup, r=nox
Update webrender.

Fixes #22114.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22074)
<!-- Reviewable:end -->
2018-11-07 00:40:42 -05:00
WPT Sync Bot
0aa76d7524 Update web-platform-tests to revision 615bb572c95add74ca4fb9fed4af5269a49cf4ef 2018-11-06 22:43:16 -05:00
bors-servo
62d726369f
Auto merge of #22125 - Darkspirit:https_dl_buildbot_timings, r=jdm
Download buildbot metadata via https

https://build.servo.org/json works.

https://www.hardenize.com/report/build.servo.org#www_tls
Likely ECDHE-RSA-AES128-GCM-SHA256 will be used by any modern client to download the file.

-----
https://docs.python.org/2/library/urllib.html
> For Python versions earlier than 2.7.9, urllib does not attempt to validate the server certificates of HTTPS URIs. Use at your own risk!

python3 is used to run the script: 535ea9674f/etc/ci/buildbot_steps.yml (L170)

-----
https://docs.python.org/3.1/howto/urllib2.html
> Currently urllib.request does not support fetching of https locations through a proxy. However, this can be enabled by extending urllib.request as shown in the recipe [7].

I don't think this will be downloaded through a proxy.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22125)
<!-- Reviewable:end -->
2018-11-06 20:26:28 -05:00
bors-servo
8667cb327d
Auto merge of #22123 - Darkspirit:https_taskcluster_windows, r=jdm
Ensuring https for Windows Taskcluster

This should be a safe change as there're already some https downloads on Windows Taskcluster. Examples:
* with `$client.DownloadFile()`: 78327fcba5/etc/taskcluster/windows/bootstrap.ps1 (L43)
* with `Expand-ZIPFile`: e217672c1a/etc/taskcluster/windows/bootstrap.ps1 (L40)

Modern TLS is supported:
https://www.hardenize.com/report/download.tuxfamily.org#www_tls
https://www.hardenize.com/report/nssm.cc#www_tls

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22123)
<!-- Reviewable:end -->
2018-11-06 19:13:20 -05:00
bors-servo
b628b6ef8e
Auto merge of #22119 - atouchet:ua, r=paulrouget
Update Firefox version in user agent string

<!-- Please describe your changes on the following line: -->
GitHub is again limiting functionality in Servo due to using an outdated Firefox version in the user agent string. Updating this should get rid of the warning.

---
<!-- Thank you for contributing to Servo! Please replace each `[ ]` by `[X]` when the step is complete, and replace `__` with appropriate data: -->
- [ ] `./mach build -d` does not report any errors
- [ ] `./mach test-tidy` does not report any errors
- [ ] These changes fix #__ (github issue number if applicable).

<!-- Either: -->
- [ ] There are tests for these changes OR
- [ ] These changes do not require tests because _____

<!-- Also, please make sure that "Allow edits from maintainers" checkbox is checked, so that we can help you if you get stuck somewhere along the way.-->

<!-- Pull requests that do not address these steps are welcome, but they will require additional verification as part of the review process. -->

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22119)
<!-- Reviewable:end -->
2018-11-06 17:47:09 -05:00
Josh Matthews
1c5e4b3067 Update webrender to 790b76f1547453615262c3037e1fb04bda22fbc8. 2018-11-06 16:51:58 -05:00
Pyfisch
9e92eb205a Reorder imports 2018-11-06 22:35:07 +01:00
Pyfisch
4a947dd719 Remove import order check from test-tidy
Fix leaking file descriptor.
2018-11-06 22:30:31 +01:00
Pyfisch
095d446ccd Manually format remaining problems
Use line comments instead of block comments
as block comments contain trailing whitespace
after formatting with rustfmt.

Skip tests for malloc_size_of and script_plugins
with rustfmt as they have many block comments.
2018-11-06 22:30:31 +01:00
Pyfisch
cb07debcb6 Format remaining files 2018-11-06 22:30:31 +01:00
Pyfisch
bf47f90da6 Run rustfmt on test-tidy
Add ./mach fmt command.
Mach installs rustfmt if needed.
2018-11-06 22:28:29 +01:00
Fernando Jiménez Moreno
ebe6c3fac3 HTMLMediaElement - use media element instead of dom manipulation task source 2018-11-06 20:15:14 +01:00
bors-servo
6878dbbbea
Auto merge of #22086 - servo:2018-without-stylo, r=SimonSapin
Switch some crates to the 2018 edition

This is the subset of https://github.com/servo/servo/pull/22083 that doesn’t affect Gecko at all, so it isn’t blocked.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22086)
<!-- Reviewable:end -->
2018-11-06 13:38:52 -05:00
bors-servo
8df38f5e29
Auto merge of #22122 - Darkspirit:httpsdeps, r=jdm
Consistent servo-deps download URL

This PR ensures consistent https:// downloads for Servo dependencies.

It should be fine because
* https://servo-deps.s3.amazonaws.com is already used for MSVC deps:
e217672c1a/python/servo/bootstrap.py (L286)

* .travis.yml already downloads from [another https url](e217672c1a/.travis.yml (L28)) (https://sh.rustup.rs).
* In #22088 I saw the gstreamer dependency being download via https.

<!-- Reviewable:start -->
---
This change is [<img src="https://reviewable.io/review_button.svg" height="34" align="absmiddle" alt="Reviewable"/>](https://reviewable.io/reviews/servo/servo/22122)
<!-- Reviewable:end -->
2018-11-06 11:30:26 -05:00
Jan Andre Ikenmeyer
860422d1dc
Optional Windows Taskcluster dependency should be able to use TLS 1.2 2018-11-06 17:29:43 +01:00
Jan Andre Ikenmeyer
d1b5ece9aa
Connect to intermittent trackers via https 2018-11-06 17:02:41 +01:00
Keith Yeung
8757cf5bc0 Use question mark operator instead of try macro with a raw identifier
Co-Authored-By: SimonSapin <simon.sapin@exyr.org>
2018-11-06 16:12:04 +01:00
Simon Sapin
99cd7ba3d4 Disable unused-extern-crates warnings for now
There are *many* new ones in rust 2018!
2018-11-06 16:12:04 +01:00
Simon Sapin
9f9bf8f6bc Switch most crates to the 2018 edition 2018-11-06 16:12:04 +01:00
Simon Sapin
76e59a46d3 Sort use statements 2018-11-06 15:26:02 +01:00
Simon Sapin
45f7199eee cargo fix --edition 2018-11-06 15:26:02 +01:00
Simon Sapin
86f148fb97 Use 2018-style paths in code generated by proc-macro derives 2018-11-06 15:26:02 +01:00
Simon Sapin
acabd50f03 Use 2018-style paths in generated DOM bindings 2018-11-06 15:14:17 +01:00